[jira] [Commented] (HIVE-7283) CBO: plumb in HepPlanner and FieldTrimmer(ColumnPruner) into Optiq based planning

2014-06-28 Thread Gunther Hagleitner (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046792#comment-14046792
 ] 

Gunther Hagleitner commented on HIVE-7283:
--

LGTM. Committed to cbo branch.

 CBO: plumb in HepPlanner and FieldTrimmer(ColumnPruner) into Optiq based 
 planning
 -

 Key: HIVE-7283
 URL: https://issues.apache.org/jira/browse/HIVE-7283
 Project: Hive
  Issue Type: Sub-task
  Components: Query Processor
Reporter: Harish Butani
Assignee: Harish Butani
 Attachments: HIVE-7283.1.patch, HIVE-7283.2.patch


 1.
 HepPlanner initially used for:
 - Predicate Pushdown
 - Transitive Predicate inference
 - Partition Pruning
 2. Use Optiq's FieldTrimmer for ColumnPruner
 To begin with the rules are copies of Optiq base rules. Once Optiq is 
 refactored to work on Base RelNode classes, the copied rules will be removed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HIVE-7283) CBO: plumb in HepPlanner and FieldTrimmer(ColumnPruner) into Optiq based planning

2014-06-27 Thread Gunther Hagleitner (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046539#comment-14046539
 ] 

Gunther Hagleitner commented on HIVE-7283:
--

Tests pass without patch. Reverted change in cbo branch.

 CBO: plumb in HepPlanner and FieldTrimmer(ColumnPruner) into Optiq based 
 planning
 -

 Key: HIVE-7283
 URL: https://issues.apache.org/jira/browse/HIVE-7283
 Project: Hive
  Issue Type: Sub-task
  Components: Query Processor
Reporter: Harish Butani
Assignee: Harish Butani
 Attachments: HIVE-7283.1.patch


 1.
 HepPlanner initially used for:
 - Predicate Pushdown
 - Transitive Predicate inference
 - Partition Pruning
 2. Use Optiq's FieldTrimmer for ColumnPruner
 To begin with the rules are copies of Optiq base rules. Once Optiq is 
 refactored to work on Base RelNode classes, the copied rules will be removed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HIVE-7283) CBO: plumb in HepPlanner and FieldTrimmer(ColumnPruner) into Optiq based planning

2014-06-27 Thread Harish Butani (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046543#comment-14046543
 ] 

Harish Butani commented on HIVE-7283:
-

ok, sorry was running cbo_correctness.q w/o setting hive,enable.cbo=true on 
command line. 
I see the issue: for semiJoins joinType is set to Inner on JoinRelBase, so the 
assertion that num cols in Join = left + right fails in 
RelOptUtil.classifyFilters
For now going to bail  in HivePushFilterPastJoinRule for SemiJoins. Should have 
a patch soon.

 CBO: plumb in HepPlanner and FieldTrimmer(ColumnPruner) into Optiq based 
 planning
 -

 Key: HIVE-7283
 URL: https://issues.apache.org/jira/browse/HIVE-7283
 Project: Hive
  Issue Type: Sub-task
  Components: Query Processor
Reporter: Harish Butani
Assignee: Harish Butani
 Attachments: HIVE-7283.1.patch


 1.
 HepPlanner initially used for:
 - Predicate Pushdown
 - Transitive Predicate inference
 - Partition Pruning
 2. Use Optiq's FieldTrimmer for ColumnPruner
 To begin with the rules are copies of Optiq base rules. Once Optiq is 
 refactored to work on Base RelNode classes, the copied rules will be removed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HIVE-7283) CBO: plumb in HepPlanner and FieldTrimmer(ColumnPruner) into Optiq based planning

2014-06-27 Thread Harish Butani (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046718#comment-14046718
 ] 

Harish Butani commented on HIVE-7283:
-

For now have added checks to prevent PredicatePushdown and ColumnPruning for 
SemiJoins.
Test passes now.

 CBO: plumb in HepPlanner and FieldTrimmer(ColumnPruner) into Optiq based 
 planning
 -

 Key: HIVE-7283
 URL: https://issues.apache.org/jira/browse/HIVE-7283
 Project: Hive
  Issue Type: Sub-task
  Components: Query Processor
Reporter: Harish Butani
Assignee: Harish Butani
 Attachments: HIVE-7283.1.patch, HIVE-7283.2.patch


 1.
 HepPlanner initially used for:
 - Predicate Pushdown
 - Transitive Predicate inference
 - Partition Pruning
 2. Use Optiq's FieldTrimmer for ColumnPruner
 To begin with the rules are copies of Optiq base rules. Once Optiq is 
 refactored to work on Base RelNode classes, the copied rules will be removed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HIVE-7283) CBO: plumb in HepPlanner and FieldTrimmer(ColumnPruner) into Optiq based planning

2014-06-24 Thread Laljo John Pullokkaran (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042876#comment-14042876
 ] 

Laljo John Pullokkaran commented on HIVE-7283:
--

+1

 CBO: plumb in HepPlanner and FieldTrimmer(ColumnPruner) into Optiq based 
 planning
 -

 Key: HIVE-7283
 URL: https://issues.apache.org/jira/browse/HIVE-7283
 Project: Hive
  Issue Type: Sub-task
  Components: Query Processor
Reporter: Harish Butani
Assignee: Harish Butani
 Attachments: HIVE-7283.1.patch


 1.
 HepPlanner initially used for:
 - Predicate Pushdown
 - Transitive Predicate inference
 - Partition Pruning
 2. Use Optiq's FieldTrimmer for ColumnPruner
 To begin with the rules are copies of Optiq base rules. Once Optiq is 
 refactored to work on Base RelNode classes, the copied rules will be removed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)