[jira] [Commented] (HIVE-7497) Fix some default values in HiveConf
[
https://issues.apache.org/jira/browse/HIVE-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144086#comment-14144086
]
Lefty Leverenz commented on HIVE-7497:
--
Doc note: HIVE-8138 alters the behavior of
*hive.server2.global.init.file.location* (originally
*hive.global.init.file.location*), so use the description in that patch when
documenting the parameter in these two wikidocs:
* [Configuration Properties -- HiveServer2 |
https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-HiveServer2]
* [Setting Up HiveServer2 -- How to Configure |
https://cwiki.apache.org/confluence/display/Hive/Setting+Up+HiveServer2#SettingUpHiveServer2-HowtoConfigure]
> Fix some default values in HiveConf
> ---
>
> Key: HIVE-7497
> URL: https://issues.apache.org/jira/browse/HIVE-7497
> Project: Hive
> Issue Type: Task
>Reporter: Brock Noland
>Assignee: Dong Chen
> Labels: TODOC14
> Fix For: 0.14.0
>
> Attachments: HIVE-7497.1.patch, HIVE-7497.patch
>
>
> HIVE-5160 resolves an env variable at runtime via calling System.getenv(). As
> long as the variable is not defined when you run the build null is returned
> and the path is not placed in the hive-default,template. However if it is
> defined it will populate hive-default.template with a path which will be
> different based on the user running the build. We should use
> $\{system:HIVE_CONF_DIR\} instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-7497) Fix some default values in HiveConf
[
https://issues.apache.org/jira/browse/HIVE-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114902#comment-14114902
]
Dong Chen commented on HIVE-7497:
-
[~vgumashta] Thanks for taking care of it. I'm ok with it and please go ahead.
Thanks :)
> Fix some default values in HiveConf
> ---
>
> Key: HIVE-7497
> URL: https://issues.apache.org/jira/browse/HIVE-7497
> Project: Hive
> Issue Type: Task
>Reporter: Brock Noland
>Assignee: Dong Chen
> Labels: TODOC14
> Fix For: 0.14.0
>
> Attachments: HIVE-7497.1.patch, HIVE-7497.patch
>
>
> HIVE-5160 resolves an env variable at runtime via calling System.getenv(). As
> long as the variable is not defined when you run the build null is returned
> and the path is not placed in the hive-default,template. However if it is
> defined it will populate hive-default.template with a path which will be
> different based on the user running the build. We should use
> $\{system:HIVE_CONF_DIR\} instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-7497) Fix some default values in HiveConf
[
https://issues.apache.org/jira/browse/HIVE-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114242#comment-14114242
]
Vaibhav Gumashta commented on HIVE-7497:
[~brocknoland] Sure, that's what I intend to do.
> Fix some default values in HiveConf
> ---
>
> Key: HIVE-7497
> URL: https://issues.apache.org/jira/browse/HIVE-7497
> Project: Hive
> Issue Type: Task
>Reporter: Brock Noland
>Assignee: Dong Chen
> Labels: TODOC14
> Fix For: 0.14.0
>
> Attachments: HIVE-7497.1.patch, HIVE-7497.patch
>
>
> HIVE-5160 resolves an env variable at runtime via calling System.getenv(). As
> long as the variable is not defined when you run the build null is returned
> and the path is not placed in the hive-default,template. However if it is
> defined it will populate hive-default.template with a path which will be
> different based on the user running the build. We should use
> $\{system:HIVE_CONF_DIR\} instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-7497) Fix some default values in HiveConf
[
https://issues.apache.org/jira/browse/HIVE-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114189#comment-14114189
]
Brock Noland commented on HIVE-7497:
[~vaibhavgumashta] since this is commited any additional work would be done in
a follow on JIRA.
> Fix some default values in HiveConf
> ---
>
> Key: HIVE-7497
> URL: https://issues.apache.org/jira/browse/HIVE-7497
> Project: Hive
> Issue Type: Task
>Reporter: Brock Noland
>Assignee: Dong Chen
> Labels: TODOC14
> Fix For: 0.14.0
>
> Attachments: HIVE-7497.1.patch, HIVE-7497.patch
>
>
> HIVE-5160 resolves an env variable at runtime via calling System.getenv(). As
> long as the variable is not defined when you run the build null is returned
> and the path is not placed in the hive-default,template. However if it is
> defined it will populate hive-default.template with a path which will be
> different based on the user running the build. We should use
> $\{system:HIVE_CONF_DIR\} instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-7497) Fix some default values in HiveConf
[
https://issues.apache.org/jira/browse/HIVE-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114118#comment-14114118
]
Vaibhav Gumashta commented on HIVE-7497:
[~dongc] If you're ok with it, I can make the change in one of my patches I'm
working on.
> Fix some default values in HiveConf
> ---
>
> Key: HIVE-7497
> URL: https://issues.apache.org/jira/browse/HIVE-7497
> Project: Hive
> Issue Type: Task
>Reporter: Brock Noland
>Assignee: Dong Chen
> Labels: TODOC14
> Fix For: 0.14.0
>
> Attachments: HIVE-7497.1.patch, HIVE-7497.patch
>
>
> HIVE-5160 resolves an env variable at runtime via calling System.getenv(). As
> long as the variable is not defined when you run the build null is returned
> and the path is not placed in the hive-default,template. However if it is
> defined it will populate hive-default.template with a path which will be
> different based on the user running the build. We should use
> $\{system:HIVE_CONF_DIR\} instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-7497) Fix some default values in HiveConf
[
https://issues.apache.org/jira/browse/HIVE-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114116#comment-14114116
]
Vaibhav Gumashta commented on HIVE-7497:
[~dongc] I still have one issue with the patch (sorry for coming out so late on
this). We should change HIVE_GLOBAL_INIT_FILE_LOCATION to
HIVE_SERVER2_GLOBAL_INIT_FILE_LOCATION. This will be in sync with the
convention we've followed so far.
> Fix some default values in HiveConf
> ---
>
> Key: HIVE-7497
> URL: https://issues.apache.org/jira/browse/HIVE-7497
> Project: Hive
> Issue Type: Task
>Reporter: Brock Noland
>Assignee: Dong Chen
> Labels: TODOC14
> Fix For: 0.14.0
>
> Attachments: HIVE-7497.1.patch, HIVE-7497.patch
>
>
> HIVE-5160 resolves an env variable at runtime via calling System.getenv(). As
> long as the variable is not defined when you run the build null is returned
> and the path is not placed in the hive-default,template. However if it is
> defined it will populate hive-default.template with a path which will be
> different based on the user running the build. We should use
> $\{system:HIVE_CONF_DIR\} instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-7497) Fix some default values in HiveConf
[
https://issues.apache.org/jira/browse/HIVE-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078973#comment-14078973
]
Lefty Leverenz commented on HIVE-7497:
--
Good, that makes sense. Thanks [~dongc].
(I'd fix your env smiley but it's fun -- let the parenthesis remain open.)
> Fix some default values in HiveConf
> ---
>
> Key: HIVE-7497
> URL: https://issues.apache.org/jira/browse/HIVE-7497
> Project: Hive
> Issue Type: Task
>Reporter: Brock Noland
>Assignee: Dong Chen
> Labels: TODOC14
> Fix For: 0.14.0
>
> Attachments: HIVE-7497.1.patch, HIVE-7497.patch
>
>
> HIVE-5160 resolves an env variable at runtime via calling System.getenv(). As
> long as the variable is not defined when you run the build null is returned
> and the path is not placed in the hive-default,template. However if it is
> defined it will populate hive-default.template with a path which will be
> different based on the user running the build. We should use
> $\{system:HIVE_CONF_DIR\} instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-7497) Fix some default values in HiveConf
[
https://issues.apache.org/jira/browse/HIVE-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078948#comment-14078948
]
Dong Chen commented on HIVE-7497:
-
Thanks, Lefty.
Since the default value change of *hive.hwi.war.file* is only the prefix part
(from system: to env:) and the actual value is the same, I think user doc may
not need updates.
For *hive.server2.global.init.file.location*, $\{HIVE_CONF_DIR\} might be good
as the configuration parameter default value in user doc. (prefix env is not
neccessary in doc)
> Fix some default values in HiveConf
> ---
>
> Key: HIVE-7497
> URL: https://issues.apache.org/jira/browse/HIVE-7497
> Project: Hive
> Issue Type: Task
>Reporter: Brock Noland
>Assignee: Dong Chen
> Labels: TODOC14
> Fix For: 0.14.0
>
> Attachments: HIVE-7497.1.patch, HIVE-7497.patch
>
>
> HIVE-5160 resolves an env variable at runtime via calling System.getenv(). As
> long as the variable is not defined when you run the build null is returned
> and the path is not placed in the hive-default,template. However if it is
> defined it will populate hive-default.template with a path which will be
> different based on the user running the build. We should use
> $\{system:HIVE_CONF_DIR\} instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-7497) Fix some default values in HiveConf
[
https://issues.apache.org/jira/browse/HIVE-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077536#comment-14077536
]
Lefty Leverenz commented on HIVE-7497:
--
This renames configuration parameter *hive.global.init.file.location* (created
in HIVE-5160) to *hive.server2.global.init.file.location* and revises its
description, as well as changing its default from
System.getenv("HIVE_CONF_DIR") to "$\{env:HIVE_CONF_DIR\}" and changing the
default of configuration parameter *hive.hwi.war.file* from
"$\{system:HWI_WAR_FILE\}" to "$\{env:HWI_WAR_FILE\}".
*hive.server2.global.init.file.location* needs to be documented in two places,
with version information and a link to this JIRA ticket:
* [Hive Web Interface -- Configuration |
https://cwiki.apache.org/confluence/display/Hive/HiveWebInterface#HiveWebInterface-Configuration]
* [Configuration Properties -- Hive Web Interface (HWI) |
https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-HiveWebInterface(HWI)]
But it's not clear to me whether the default value changes need any user doc
updates -- do they?
> Fix some default values in HiveConf
> ---
>
> Key: HIVE-7497
> URL: https://issues.apache.org/jira/browse/HIVE-7497
> Project: Hive
> Issue Type: Task
>Reporter: Brock Noland
>Assignee: Dong Chen
> Labels: TODOC14
> Fix For: 0.14.0
>
> Attachments: HIVE-7497.1.patch, HIVE-7497.patch
>
>
> HIVE-5160 resolves an env variable at runtime via calling System.getenv(). As
> long as the variable is not defined when you run the build null is returned
> and the path is not placed in the hive-default,template. However if it is
> defined it will populate hive-default.template with a path which will be
> different based on the user running the build. We should use
> $\{system:HIVE_CONF_DIR\} instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-7497) Fix some default values in HiveConf
[
https://issues.apache.org/jira/browse/HIVE-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076408#comment-14076408
]
Hive QA commented on HIVE-7497:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12658111/HIVE-7497.1.patch
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 5770 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx
org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/78/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/78/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-78/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12658111
> Fix some default values in HiveConf
> ---
>
> Key: HIVE-7497
> URL: https://issues.apache.org/jira/browse/HIVE-7497
> Project: Hive
> Issue Type: Task
>Reporter: Brock Noland
>Assignee: Dong Chen
> Attachments: HIVE-7497.1.patch, HIVE-7497.patch
>
>
> HIVE-5160 resolves an env variable at runtime via calling System.getenv(). As
> long as the variable is not defined when you run the build null is returned
> and the path is not placed in the hive-default,template. However if it is
> defined it will populate hive-default.template with a path which will be
> different based on the user running the build. We should use
> $\{system:HIVE_CONF_DIR\} instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-7497) Fix some default values in HiveConf
[
https://issues.apache.org/jira/browse/HIVE-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076383#comment-14076383
]
Brock Noland commented on HIVE-7497:
+1 pending tests
Thank you!!
> Fix some default values in HiveConf
> ---
>
> Key: HIVE-7497
> URL: https://issues.apache.org/jira/browse/HIVE-7497
> Project: Hive
> Issue Type: Task
>Reporter: Brock Noland
>Assignee: Dong Chen
> Attachments: HIVE-7497.1.patch, HIVE-7497.patch
>
>
> HIVE-5160 resolves an env variable at runtime via calling System.getenv(). As
> long as the variable is not defined when you run the build null is returned
> and the path is not placed in the hive-default,template. However if it is
> defined it will populate hive-default.template with a path which will be
> different based on the user running the build. We should use
> $\{system:HIVE_CONF_DIR\} instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
