[jira] [Commented] (HIVE-7984) AccumuloOutputFormat Configuration items from StorageHandler not re-set in Configuration in Tez
[ https://issues.apache.org/jira/browse/HIVE-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138142#comment-14138142 ] Sushanth Sowmyan commented on HIVE-7984: Looks reasonable to me. +1. AccumuloOutputFormat Configuration items from StorageHandler not re-set in Configuration in Tez --- Key: HIVE-7984 URL: https://issues.apache.org/jira/browse/HIVE-7984 Project: Hive Issue Type: Bug Components: StorageHandler, Tez Reporter: Josh Elser Assignee: Josh Elser Fix For: 0.14.0 Attachments: HIVE-7984-1.diff, HIVE-7984-1.patch, HIVE-7984.1.patch Ran AccumuloStorageHandler queries with Tez and found that configuration elements that are pulled from the {{-hiveconf}} and passed to the inputJobProperties or outputJobProperties by the AccumuloStorageHandler aren't available inside of the Tez container. I'm guessing that there is a disconnect from the configuration that the StorageHandler creates and what the Tez container sees. The HBaseStorageHandler likely doesn't run into this because it expects to have hbase-site.xml available via tmpjars (and can extrapolate connection information from that file). Accumulo's site configuration file is not meant to be shared with consumers which means that this exact approach is not sufficient. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7984) AccumuloOutputFormat Configuration items from StorageHandler not re-set in Configuration in Tez
[ https://issues.apache.org/jira/browse/HIVE-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138143#comment-14138143 ] Sushanth Sowmyan commented on HIVE-7984: (And yes, confirming that the test failure is not related) AccumuloOutputFormat Configuration items from StorageHandler not re-set in Configuration in Tez --- Key: HIVE-7984 URL: https://issues.apache.org/jira/browse/HIVE-7984 Project: Hive Issue Type: Bug Components: StorageHandler, Tez Reporter: Josh Elser Assignee: Josh Elser Fix For: 0.14.0 Attachments: HIVE-7984-1.diff, HIVE-7984-1.patch, HIVE-7984.1.patch Ran AccumuloStorageHandler queries with Tez and found that configuration elements that are pulled from the {{-hiveconf}} and passed to the inputJobProperties or outputJobProperties by the AccumuloStorageHandler aren't available inside of the Tez container. I'm guessing that there is a disconnect from the configuration that the StorageHandler creates and what the Tez container sees. The HBaseStorageHandler likely doesn't run into this because it expects to have hbase-site.xml available via tmpjars (and can extrapolate connection information from that file). Accumulo's site configuration file is not meant to be shared with consumers which means that this exact approach is not sufficient. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7984) AccumuloOutputFormat Configuration items from StorageHandler not re-set in Configuration in Tez
[ https://issues.apache.org/jira/browse/HIVE-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138144#comment-14138144 ] Josh Elser commented on HIVE-7984: -- Thanks, Sushanth -- much appreciated. AccumuloOutputFormat Configuration items from StorageHandler not re-set in Configuration in Tez --- Key: HIVE-7984 URL: https://issues.apache.org/jira/browse/HIVE-7984 Project: Hive Issue Type: Bug Components: StorageHandler, Tez Reporter: Josh Elser Assignee: Josh Elser Fix For: 0.14.0 Attachments: HIVE-7984-1.diff, HIVE-7984-1.patch, HIVE-7984.1.patch Ran AccumuloStorageHandler queries with Tez and found that configuration elements that are pulled from the {{-hiveconf}} and passed to the inputJobProperties or outputJobProperties by the AccumuloStorageHandler aren't available inside of the Tez container. I'm guessing that there is a disconnect from the configuration that the StorageHandler creates and what the Tez container sees. The HBaseStorageHandler likely doesn't run into this because it expects to have hbase-site.xml available via tmpjars (and can extrapolate connection information from that file). Accumulo's site configuration file is not meant to be shared with consumers which means that this exact approach is not sufficient. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7984) AccumuloOutputFormat Configuration items from StorageHandler not re-set in Configuration in Tez
[ https://issues.apache.org/jira/browse/HIVE-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14136787#comment-14136787 ] Josh Elser commented on HIVE-7984: -- Test failure appears unrelated to me. Can anyone give this a review? It's a rather straightforward change. AccumuloOutputFormat Configuration items from StorageHandler not re-set in Configuration in Tez --- Key: HIVE-7984 URL: https://issues.apache.org/jira/browse/HIVE-7984 Project: Hive Issue Type: Bug Components: StorageHandler, Tez Reporter: Josh Elser Assignee: Josh Elser Fix For: 0.14.0 Attachments: HIVE-7984-1.diff, HIVE-7984-1.patch, HIVE-7984.1.patch Ran AccumuloStorageHandler queries with Tez and found that configuration elements that are pulled from the {{-hiveconf}} and passed to the inputJobProperties or outputJobProperties by the AccumuloStorageHandler aren't available inside of the Tez container. I'm guessing that there is a disconnect from the configuration that the StorageHandler creates and what the Tez container sees. The HBaseStorageHandler likely doesn't run into this because it expects to have hbase-site.xml available via tmpjars (and can extrapolate connection information from that file). Accumulo's site configuration file is not meant to be shared with consumers which means that this exact approach is not sufficient. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7984) AccumuloOutputFormat Configuration items from StorageHandler not re-set in Configuration in Tez
[ https://issues.apache.org/jira/browse/HIVE-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129598#comment-14129598 ] Hive QA commented on HIVE-7984: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12667841/HIVE-7984.1.patch {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 6195 tests executed *Failed tests:* {noformat} org.apache.hive.service.TestHS2ImpersonationWithRemoteMS.testImpersonation {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/733/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/733/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-733/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12667841 AccumuloOutputFormat Configuration items from StorageHandler not re-set in Configuration in Tez --- Key: HIVE-7984 URL: https://issues.apache.org/jira/browse/HIVE-7984 Project: Hive Issue Type: Bug Components: StorageHandler, Tez Reporter: Josh Elser Assignee: Josh Elser Fix For: 0.14.0 Attachments: HIVE-7984-1.diff, HIVE-7984-1.patch, HIVE-7984.1.patch Ran AccumuloStorageHandler queries with Tez and found that configuration elements that are pulled from the {{-hiveconf}} and passed to the inputJobProperties or outputJobProperties by the AccumuloStorageHandler aren't available inside of the Tez container. I'm guessing that there is a disconnect from the configuration that the StorageHandler creates and what the Tez container sees. The HBaseStorageHandler likely doesn't run into this because it expects to have hbase-site.xml available via tmpjars (and can extrapolate connection information from that file). Accumulo's site configuration file is not meant to be shared with consumers which means that this exact approach is not sufficient. -- This message was sent by Atlassian JIRA (v6.3.4#6332)