[jira] [Commented] (HIVE-9208) MetaStore DB schema inconsistent for MS SQL Server in use of varchar/nvarchar
[ https://issues.apache.org/jira/browse/HIVE-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288271#comment-14288271 ] Xiaobing Zhou commented on HIVE-9208: - I don't think we need to change length, right? MetaStore DB schema inconsistent for MS SQL Server in use of varchar/nvarchar - Key: HIVE-9208 URL: https://issues.apache.org/jira/browse/HIVE-9208 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.14.0 Reporter: Eugene Koifman Assignee: Xiaobing Zhou Attachments: HIVE-9208.1.patch, HIVE-9208.2.patch hive-schema-0.15.0.mssql.sql has PARTITIONS.PART_NAME as NVARCHAR but COMPLETED_TXN_COMPONENTS.CTC_PARTITON, COMPACTION_QUEUE.CQ_PARTITION, HIVE_LOCKS.HL_PARTITION, TXN_COMPONENTS.TC_PARTITION all use VARCHAR. This cannot be right since they all store the same value. the same is true of hive-schema-0.14.0.mssql.sql and the two corresponding hvie-txn-schema-... files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9208) MetaStore DB schema inconsistent for MS SQL Server in use of varchar/nvarchar
[ https://issues.apache.org/jira/browse/HIVE-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288275#comment-14288275 ] Xiaobing Zhou commented on HIVE-9208: - They are partition name with multi-bytes support. MetaStore DB schema inconsistent for MS SQL Server in use of varchar/nvarchar - Key: HIVE-9208 URL: https://issues.apache.org/jira/browse/HIVE-9208 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.14.0 Reporter: Eugene Koifman Assignee: Xiaobing Zhou Attachments: HIVE-9208.1.patch, HIVE-9208.2.patch hive-schema-0.15.0.mssql.sql has PARTITIONS.PART_NAME as NVARCHAR but COMPLETED_TXN_COMPONENTS.CTC_PARTITON, COMPACTION_QUEUE.CQ_PARTITION, HIVE_LOCKS.HL_PARTITION, TXN_COMPONENTS.TC_PARTITION all use VARCHAR. This cannot be right since they all store the same value. the same is true of hive-schema-0.14.0.mssql.sql and the two corresponding hvie-txn-schema-... files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9208) MetaStore DB schema inconsistent for MS SQL Server in use of varchar/nvarchar
[ https://issues.apache.org/jira/browse/HIVE-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288370#comment-14288370 ] Eugene Koifman commented on HIVE-9208: -- I was asking if you are sure those fields represent partition names. If yes, they should be nvarchar. As far as length, it seems odd that we store the same exact value in fields of different sizes... but perhaps this is beyond the scope of this bug. [~sushanth], could you look at this patch? do you know anything about the tables that seem to store partition values but the length of fields is not 767 as in most cases? MetaStore DB schema inconsistent for MS SQL Server in use of varchar/nvarchar - Key: HIVE-9208 URL: https://issues.apache.org/jira/browse/HIVE-9208 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.14.0 Reporter: Eugene Koifman Assignee: Xiaobing Zhou Attachments: HIVE-9208.1.patch, HIVE-9208.2.patch hive-schema-0.15.0.mssql.sql has PARTITIONS.PART_NAME as NVARCHAR but COMPLETED_TXN_COMPONENTS.CTC_PARTITON, COMPACTION_QUEUE.CQ_PARTITION, HIVE_LOCKS.HL_PARTITION, TXN_COMPONENTS.TC_PARTITION all use VARCHAR. This cannot be right since they all store the same value. the same is true of hive-schema-0.14.0.mssql.sql and the two corresponding hvie-txn-schema-... files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9208) MetaStore DB schema inconsistent for MS SQL Server in use of varchar/nvarchar
[ https://issues.apache.org/jira/browse/HIVE-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286066#comment-14286066 ] Eugene Koifman commented on HIVE-9208: -- Most of the diffs change varchar(767) to nvarchar(767), but in some cases the starting types are varchar(128) or varchar(4000). Are you sure these are partition keys? MetaStore DB schema inconsistent for MS SQL Server in use of varchar/nvarchar - Key: HIVE-9208 URL: https://issues.apache.org/jira/browse/HIVE-9208 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.14.0 Reporter: Eugene Koifman Assignee: Xiaobing Zhou Attachments: HIVE-9208.1.patch, HIVE-9208.2.patch hive-schema-0.15.0.mssql.sql has PARTITIONS.PART_NAME as NVARCHAR but COMPLETED_TXN_COMPONENTS.CTC_PARTITON, COMPACTION_QUEUE.CQ_PARTITION, HIVE_LOCKS.HL_PARTITION, TXN_COMPONENTS.TC_PARTITION all use VARCHAR. This cannot be right since they all store the same value. the same is true of hive-schema-0.14.0.mssql.sql and the two corresponding hvie-txn-schema-... files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9208) MetaStore DB schema inconsistent for MS SQL Server in use of varchar/nvarchar
[ https://issues.apache.org/jira/browse/HIVE-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14276063#comment-14276063 ] Eugene Koifman commented on HIVE-9208: -- I think there are other places in the schema that have the same issue. This needs to be made consistent for all tables. Unfortunately columns that seem to store partition name are named differently in different tables. some that look like potential candidates (but not an exhaustive list) part_col_stats.partition_name partition_events.partition_name partition_keys.pkey_name partition_params.param_value MetaStore DB schema inconsistent for MS SQL Server in use of varchar/nvarchar - Key: HIVE-9208 URL: https://issues.apache.org/jira/browse/HIVE-9208 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.14.0 Reporter: Eugene Koifman Assignee: Xiaobing Zhou Attachments: HIVE-9208.1.patch hive-schema-0.15.0.mssql.sql has PARTITIONS.PART_NAME as NVARCHAR but COMPLETED_TXN_COMPONENTS.CTC_PARTITON, COMPACTION_QUEUE.CQ_PARTITION, HIVE_LOCKS.HL_PARTITION, TXN_COMPONENTS.TC_PARTITION all use VARCHAR. This cannot be right since they all store the same value. the same is true of hive-schema-0.14.0.mssql.sql and the two corresponding hvie-txn-schema-... files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9208) MetaStore DB schema inconsistent for MS SQL Server in use of varchar/nvarchar
[ https://issues.apache.org/jira/browse/HIVE-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14276150#comment-14276150 ] Xiaobing Zhou commented on HIVE-9208: - Thanks [~ekoifman]! I'd take a look at them to get all partition name replications. MetaStore DB schema inconsistent for MS SQL Server in use of varchar/nvarchar - Key: HIVE-9208 URL: https://issues.apache.org/jira/browse/HIVE-9208 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.14.0 Reporter: Eugene Koifman Assignee: Xiaobing Zhou Attachments: HIVE-9208.1.patch hive-schema-0.15.0.mssql.sql has PARTITIONS.PART_NAME as NVARCHAR but COMPLETED_TXN_COMPONENTS.CTC_PARTITON, COMPACTION_QUEUE.CQ_PARTITION, HIVE_LOCKS.HL_PARTITION, TXN_COMPONENTS.TC_PARTITION all use VARCHAR. This cannot be right since they all store the same value. the same is true of hive-schema-0.14.0.mssql.sql and the two corresponding hvie-txn-schema-... files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
