[jira] [Commented] (HIVE-9290) Make some test results deterministic
[ https://issues.apache.org/jira/browse/HIVE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271116#comment-14271116 ] Xuefu Zhang commented on HIVE-9290: --- I was aware of this but knew Rui was immediately working on HIVE-9251 which depends on this issue. Yes, there will be a little time period where the tests would fail, but I think it's okay as long as we are aware. Make some test results deterministic Key: HIVE-9290 URL: https://issues.apache.org/jira/browse/HIVE-9290 Project: Hive Issue Type: Test Reporter: Rui Li Assignee: Rui Li Fix For: spark-branch, 0.15.0 Attachments: HIVE-9290-spark.patch, HIVE-9290.1.patch, HIVE-9290.1.patch {noformat} limit_pushdown.q optimize_nullscan.q ppd_gby_join.q vector_string_concat.q {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9290) Make some test results deterministic
[ https://issues.apache.org/jira/browse/HIVE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270835#comment-14270835 ] Hive QA commented on HIVE-9290: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12691076/HIVE-9290-spark.patch {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 7301 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_optimize_nullscan org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_windowing org.apache.hive.hcatalog.streaming.TestStreaming.testEndpointConnection {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-SPARK-Build/625/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-SPARK-Build/625/console Test logs: http://ec2-50-18-27-0.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-SPARK-Build-625/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12691076 - PreCommit-HIVE-SPARK-Build Make some test results deterministic Key: HIVE-9290 URL: https://issues.apache.org/jira/browse/HIVE-9290 Project: Hive Issue Type: Test Reporter: Rui Li Assignee: Rui Li Fix For: spark-branch, 0.15.0 Attachments: HIVE-9290-spark.patch, HIVE-9290.1.patch, HIVE-9290.1.patch {noformat} limit_pushdown.q optimize_nullscan.q ppd_gby_join.q vector_string_concat.q {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9290) Make some test results deterministic
[ https://issues.apache.org/jira/browse/HIVE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270742#comment-14270742 ] Rui Li commented on HIVE-9290: -- Hi [~szehon], sorry I didn't provide a patch for spark branch here. I was planning to update the golden files for these tests in HIVE-9251. Make some test results deterministic Key: HIVE-9290 URL: https://issues.apache.org/jira/browse/HIVE-9290 Project: Hive Issue Type: Test Reporter: Rui Li Assignee: Rui Li Fix For: spark-branch, 0.15.0 Attachments: HIVE-9290-spark.patch, HIVE-9290.1.patch, HIVE-9290.1.patch {noformat} limit_pushdown.q optimize_nullscan.q ppd_gby_join.q vector_string_concat.q {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9290) Make some test results deterministic
[ https://issues.apache.org/jira/browse/HIVE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270456#comment-14270456 ] Rui Li commented on HIVE-9290: -- The failed test is not related to the patch here. Make some test results deterministic Key: HIVE-9290 URL: https://issues.apache.org/jira/browse/HIVE-9290 Project: Hive Issue Type: Test Reporter: Rui Li Assignee: Rui Li Attachments: HIVE-9290.1.patch, HIVE-9290.1.patch {noformat} limit_pushdown.q optimize_nullscan.q ppd_gby_join.q vector_string_concat.q {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9290) Make some test results deterministic
[ https://issues.apache.org/jira/browse/HIVE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270450#comment-14270450 ] Hive QA commented on HIVE-9290: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12690996/HIVE-9290.1.patch {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 6739 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_optimize_nullscan {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2297/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2297/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2297/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12690996 - PreCommit-HIVE-TRUNK-Build Make some test results deterministic Key: HIVE-9290 URL: https://issues.apache.org/jira/browse/HIVE-9290 Project: Hive Issue Type: Test Reporter: Rui Li Assignee: Rui Li Attachments: HIVE-9290.1.patch, HIVE-9290.1.patch {noformat} limit_pushdown.q optimize_nullscan.q ppd_gby_join.q vector_string_concat.q {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9290) Make some test results deterministic
[ https://issues.apache.org/jira/browse/HIVE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269371#comment-14269371 ] Xuefu Zhang commented on HIVE-9290: --- +1 Make some test results deterministic Key: HIVE-9290 URL: https://issues.apache.org/jira/browse/HIVE-9290 Project: Hive Issue Type: Test Reporter: Rui Li Assignee: Rui Li Attachments: HIVE-9290.1.patch {noformat} limit_pushdown.q optimize_nullscan.q ppd_gby_join.q vector_string_concat.q {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9290) Make some test results deterministic
[ https://issues.apache.org/jira/browse/HIVE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268835#comment-14268835 ] Xuefu Zhang commented on HIVE-9290: --- It should be okay. Even though an extra stage is introduced, I see the limit is still pushed down in the second stage according to the plan. Make some test results deterministic Key: HIVE-9290 URL: https://issues.apache.org/jira/browse/HIVE-9290 Project: Hive Issue Type: Test Reporter: Rui Li Assignee: Rui Li Attachments: HIVE-9290.1.patch {noformat} limit_pushdown.q optimize_nullscan.q ppd_gby_join.q vector_string_concat.q {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9290) Make some test results deterministic
[ https://issues.apache.org/jira/browse/HIVE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268843#comment-14268843 ] Rui Li commented on HIVE-9290: -- Thanks [~xuefuz] for the explanation! Make some test results deterministic Key: HIVE-9290 URL: https://issues.apache.org/jira/browse/HIVE-9290 Project: Hive Issue Type: Test Reporter: Rui Li Assignee: Rui Li Attachments: HIVE-9290.1.patch {noformat} limit_pushdown.q optimize_nullscan.q ppd_gby_join.q vector_string_concat.q {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)