[jira] [Commented] (HIVE-9596) move standard getDisplayString impl to GenericUDF

2015-02-11 Thread Jason Dere (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317403#comment-14317403
 ] 

Jason Dere commented on HIVE-9596:
--

+1
What's the list of UDFs which you did not change in this patch? Just curious 
which UDFs have custom getDisplayString() formats.

 move standard getDisplayString impl to GenericUDF
 -

 Key: HIVE-9596
 URL: https://issues.apache.org/jira/browse/HIVE-9596
 Project: Hive
  Issue Type: Improvement
  Components: UDF
Reporter: Alexander Pivovarov
Assignee: Alexander Pivovarov
Priority: Minor
 Attachments: HIVE-9596.1.patch, HIVE-9596.2.patch, HIVE-9596.3.patch, 
 HIVE-9596.4.patch


 54 GenericUDF derived classes have very similar getDisplayString impl which 
 returns fname(child1, child2, childn)
 instr() and locate() have bugs in their implementation (no comma btw children)
 Instead of having 54 implementations of the same method it's better to move 
 standard implementation to the base class.
 affected UDF classes:
 {code}
 contrib/src/java/org/apache/hadoop/hive/contrib/genericudf/example/GenericUDFDBOutput.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEvaluateNPE.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestGetJavaBoolean.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestGetJavaString.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestTranslate.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDFEWAHBitmapBop.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDFReflect.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAbs.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFArray.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAssertTrue.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseTrim.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcat.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDecode.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEWAHBitmapEmpty.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFElt.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEncode.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFField.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFloorCeilBase.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGreatest.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFHash.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIf.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInitCap.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInstr.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLastDay.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLocate.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLower.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMacro.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapKeys.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapValues.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNamedStruct.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPower.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRound.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSentences.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSize.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSortArray.java

[jira] [Commented] (HIVE-9596) move standard getDisplayString impl to GenericUDF

2015-02-11 Thread Alexander Pivovarov (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317506#comment-14317506
 ] 

Alexander Pivovarov commented on HIVE-9596:
---

{code}
GenericUDFArrayContains // wraps children with 
GenericUDFBaseCompare
GenericUDFBaseNumeric
GenericUDFBetween
GenericUDFCase
GenericUDFIn
GenericUDFIndex
GenericUDFMap
GenericUDFNextDay // because added on Feb 9
GenericUDFNvl  // not sure it's correct.  returns if A is null returns B
GenericUDFOP*
GenericUDFTimestamp
GenericUDFTo*
GenericUDFUnion // looks like I missed it
GenericUDFWhen
{code}

 move standard getDisplayString impl to GenericUDF
 -

 Key: HIVE-9596
 URL: https://issues.apache.org/jira/browse/HIVE-9596
 Project: Hive
  Issue Type: Improvement
  Components: UDF
Reporter: Alexander Pivovarov
Assignee: Alexander Pivovarov
Priority: Minor
 Attachments: HIVE-9596.1.patch, HIVE-9596.2.patch, HIVE-9596.3.patch, 
 HIVE-9596.4.patch


 54 GenericUDF derived classes have very similar getDisplayString impl which 
 returns fname(child1, child2, childn)
 instr() and locate() have bugs in their implementation (no comma btw children)
 Instead of having 54 implementations of the same method it's better to move 
 standard implementation to the base class.
 affected UDF classes:
 {code}
 contrib/src/java/org/apache/hadoop/hive/contrib/genericudf/example/GenericUDFDBOutput.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEvaluateNPE.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestGetJavaBoolean.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestGetJavaString.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestTranslate.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDFEWAHBitmapBop.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDFReflect.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAbs.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFArray.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAssertTrue.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseTrim.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcat.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDecode.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEWAHBitmapEmpty.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFElt.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEncode.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFField.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFloorCeilBase.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGreatest.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFHash.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIf.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInitCap.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInstr.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLastDay.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLocate.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLower.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMacro.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapKeys.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapValues.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNamedStruct.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPower.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java

[jira] [Commented] (HIVE-9596) move standard getDisplayString impl to GenericUDF

2015-02-10 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14314362#comment-14314362
 ] 

Hive QA commented on HIVE-9596:
---



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12697623/HIVE-9596.4.patch

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 7540 tests executed
*Failed tests:*
{noformat}
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchAbort
org.apache.hive.spark.client.TestSparkClient.testSyncRpc
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2738/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2738/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2738/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12697623 - PreCommit-HIVE-TRUNK-Build

 move standard getDisplayString impl to GenericUDF
 -

 Key: HIVE-9596
 URL: https://issues.apache.org/jira/browse/HIVE-9596
 Project: Hive
  Issue Type: Improvement
  Components: UDF
Reporter: Alexander Pivovarov
Assignee: Alexander Pivovarov
Priority: Minor
 Attachments: HIVE-9596.1.patch, HIVE-9596.2.patch, HIVE-9596.3.patch, 
 HIVE-9596.4.patch


 54 GenericUDF derived classes have very similar getDisplayString impl which 
 returns fname(child1, child2, childn)
 instr() and locate() have bugs in their implementation (no comma btw children)
 Instead of having 54 implementations of the same method it's better to move 
 standard implementation to the base class.
 affected UDF classes:
 {code}
 contrib/src/java/org/apache/hadoop/hive/contrib/genericudf/example/GenericUDFDBOutput.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEvaluateNPE.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestGetJavaBoolean.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestGetJavaString.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestTranslate.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDFEWAHBitmapBop.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDFReflect.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAbs.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFArray.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAssertTrue.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseTrim.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcat.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDecode.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEWAHBitmapEmpty.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFElt.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEncode.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFField.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFloorCeilBase.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGreatest.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFHash.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIf.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInitCap.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInstr.java

[jira] [Commented] (HIVE-9596) move standard getDisplayString impl to GenericUDF

2015-02-07 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310694#comment-14310694
 ] 

Hive QA commented on HIVE-9596:
---



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12697094/HIVE-9596.2.patch

{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 7526 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udaf_percentile_approx_23
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_instr
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_locate
org.apache.hadoop.hive.thrift.TestHadoop20SAuthBridge.testMetastoreProxyUser
org.apache.hadoop.hive.thrift.TestHadoop20SAuthBridge.testSaslWithHiveMetaStore
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2697/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2697/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2697/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12697094 - PreCommit-HIVE-TRUNK-Build

 move standard getDisplayString impl to GenericUDF
 -

 Key: HIVE-9596
 URL: https://issues.apache.org/jira/browse/HIVE-9596
 Project: Hive
  Issue Type: Improvement
  Components: UDF
Reporter: Alexander Pivovarov
Assignee: Alexander Pivovarov
Priority: Minor
 Attachments: HIVE-9596.1.patch, HIVE-9596.2.patch


 54 GenericUDF derived classes have very similar getDisplayString impl which 
 returns fname(child1, child2, childn)
 instr() and locate() have bugs in their implementation (no comma btw child)
 Instead of having 54 implementations of the same method it's better to move 
 standard implementation to the base class.
 affected UDF classes:
 {code}
 contrib/src/java/org/apache/hadoop/hive/contrib/genericudf/example/GenericUDFDBOutput.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEvaluateNPE.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestGetJavaBoolean.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestGetJavaString.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestTranslate.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDFEWAHBitmapBop.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDFReflect.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAbs.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFArray.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAssertTrue.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseTrim.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcat.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDecode.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEWAHBitmapEmpty.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFElt.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEncode.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFField.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFloorCeilBase.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGreatest.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFHash.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIf.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java

[jira] [Commented] (HIVE-9596) move standard getDisplayString impl to GenericUDF

2015-02-07 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-9596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311066#comment-14311066
 ] 

Hive QA commented on HIVE-9596:
---



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12697286/HIVE-9596.3.patch

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 7526 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_index_auto_mult_tables_compact
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2704/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2704/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2704/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12697286 - PreCommit-HIVE-TRUNK-Build

 move standard getDisplayString impl to GenericUDF
 -

 Key: HIVE-9596
 URL: https://issues.apache.org/jira/browse/HIVE-9596
 Project: Hive
  Issue Type: Improvement
  Components: UDF
Reporter: Alexander Pivovarov
Assignee: Alexander Pivovarov
Priority: Minor
 Attachments: HIVE-9596.1.patch, HIVE-9596.2.patch, HIVE-9596.3.patch


 54 GenericUDF derived classes have very similar getDisplayString impl which 
 returns fname(child1, child2, childn)
 instr() and locate() have bugs in their implementation (no comma btw children)
 Instead of having 54 implementations of the same method it's better to move 
 standard implementation to the base class.
 affected UDF classes:
 {code}
 contrib/src/java/org/apache/hadoop/hive/contrib/genericudf/example/GenericUDFDBOutput.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEvaluateNPE.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestGetJavaBoolean.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestGetJavaString.java
 itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestTranslate.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDFEWAHBitmapBop.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDFReflect.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAbs.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFArray.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAssertTrue.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseTrim.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcat.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDecode.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEWAHBitmapEmpty.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFElt.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEncode.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFField.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFloorCeilBase.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGreatest.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFHash.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIf.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInitCap.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInstr.java
 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLastDay.java