[jira] [Updated] (HIVE-3381) Result of outer join is not valid
[
https://issues.apache.org/jira/browse/HIVE-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-3381:
--
Attachment: HIVE-3381.D5565.7.patch
navis updated the revision HIVE-3381 [jira] Result of outer join is not valid.
Rebased to trunk (HIVE-3980) added test (Thanks Vikram)
Reviewers: ashutoshc, JIRA
REVISION DETAIL
https://reviews.facebook.net/D5565
CHANGE SINCE LAST DIFF
https://reviews.facebook.net/D5565?vs=30351id=30495#toc
BRANCH
DPAL-1739
ARCANIST PROJECT
hive
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java
ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinObjectValue.java
ql/src/test/queries/clientpositive/mapjoin_test_outer.q
ql/src/test/results/clientpositive/auto_join21.q.out
ql/src/test/results/clientpositive/auto_join29.q.out
ql/src/test/results/clientpositive/auto_join7.q.out
ql/src/test/results/clientpositive/auto_join_filters.q.out
ql/src/test/results/clientpositive/join21.q.out
ql/src/test/results/clientpositive/join7.q.out
ql/src/test/results/clientpositive/join_1to1.q.out
ql/src/test/results/clientpositive/join_filters.q.out
ql/src/test/results/clientpositive/join_filters_overlap.q.out
ql/src/test/results/clientpositive/mapjoin1.q.out
ql/src/test/results/clientpositive/mapjoin_test_outer.q.out
To: JIRA, ashutoshc, navis
Cc: njain
Result of outer join is not valid
-
Key: HIVE-3381
URL: https://issues.apache.org/jira/browse/HIVE-3381
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.10.0
Reporter: Navis
Assignee: Navis
Priority: Critical
Attachments: HIVE-3381.D5565.3.patch, HIVE-3381.D5565.4.patch,
HIVE-3381.D5565.5.patch, HIVE-3381.D5565.6.patch, HIVE-3381.D5565.7.patch,
mapjoin_testOuter.q
Outer joins, especially full outer joins or outer join with filter on 'ON
clause' is not showing proper results. For example, query in test join_1to1.q
{code}
SELECT * FROM join_1to1_1 a full outer join join_1to1_2 b on a.key1 = b.key1
and a.value = 66 and b.value = 66 ORDER BY a.key1 ASC, a.key2 ASC, a.value
ASC, b.key1 ASC, b.key2 ASC, b.value ASC;
{code}
results
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULL66 NULLNULLNULL
NULL 10050 66 NULLNULLNULL
5 10005 66 5 10005 66
1510015 66 NULLNULLNULL
2010020 66 20 10020 66
2510025 88 NULLNULLNULL
3010030 66 NULLNULLNULL
3510035 88 NULLNULLNULL
4010040 66 NULLNULLNULL
4010040 66 40 10040 66
4010040 88 NULLNULLNULL
4010040 88 NULLNULLNULL
5010050 66 NULLNULLNULL
5010050 66 50 10050 66
5010050 66 50 10050 66
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
{code}
but it seemed not right. This should be
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL25 10025 66
NULL
[jira] [Updated] (HIVE-3381) Result of outer join is not valid
[
https://issues.apache.org/jira/browse/HIVE-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashutosh Chauhan updated HIVE-3381:
---
Resolution: Fixed
Fix Version/s: 0.11.0
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks, Navis!
Result of outer join is not valid
-
Key: HIVE-3381
URL: https://issues.apache.org/jira/browse/HIVE-3381
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.10.0
Reporter: Navis
Assignee: Navis
Priority: Critical
Fix For: 0.11.0
Attachments: HIVE-3381.D5565.3.patch, HIVE-3381.D5565.4.patch,
HIVE-3381.D5565.5.patch, HIVE-3381.D5565.6.patch, HIVE-3381.D5565.7.patch,
mapjoin_testOuter.q
Outer joins, especially full outer joins or outer join with filter on 'ON
clause' is not showing proper results. For example, query in test join_1to1.q
{code}
SELECT * FROM join_1to1_1 a full outer join join_1to1_2 b on a.key1 = b.key1
and a.value = 66 and b.value = 66 ORDER BY a.key1 ASC, a.key2 ASC, a.value
ASC, b.key1 ASC, b.key2 ASC, b.value ASC;
{code}
results
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULL66 NULLNULLNULL
NULL 10050 66 NULLNULLNULL
5 10005 66 5 10005 66
1510015 66 NULLNULLNULL
2010020 66 20 10020 66
2510025 88 NULLNULLNULL
3010030 66 NULLNULLNULL
3510035 88 NULLNULLNULL
4010040 66 NULLNULLNULL
4010040 66 40 10040 66
4010040 88 NULLNULLNULL
4010040 88 NULLNULLNULL
5010050 66 NULLNULLNULL
5010050 66 50 10050 66
5010050 66 50 10050 66
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
{code}
but it seemed not right. This should be
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL25 10025 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL80 10040 66
NULL NULLNULL80 10040 66
NULL NULL66 NULLNULLNULL
NULL 10050 66 NULLNULLNULL
5 10005 66 5 10005 66
1510015 66 NULLNULLNULL
2010020 66 20 10020 66
2510025 88 NULLNULLNULL
3010030 66 NULLNULLNULL
3510035 88 NULLNULLNULL
4010040 66 40 10040 66
4010040 88 NULLNULLNULL
5010050 66 50 10050 66
5010050 66 50 10050 66
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA
[jira] [Updated] (HIVE-3381) Result of outer join is not valid
[
https://issues.apache.org/jira/browse/HIVE-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-3381:
--
Attachment: HIVE-3381.D5565.6.patch
navis updated the revision HIVE-3381 [jira] Result of outer join is not valid.
Fixed test results passed all tests
Reviewers: JIRA
REVISION DETAIL
https://reviews.facebook.net/D5565
CHANGE SINCE LAST DIFF
https://reviews.facebook.net/D5565?vs=30225id=30351#toc
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java
ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinObjectValue.java
ql/src/test/results/clientpositive/auto_join21.q.out
ql/src/test/results/clientpositive/auto_join29.q.out
ql/src/test/results/clientpositive/auto_join7.q.out
ql/src/test/results/clientpositive/auto_join_filters.q.out
ql/src/test/results/clientpositive/join21.q.out
ql/src/test/results/clientpositive/join7.q.out
ql/src/test/results/clientpositive/join_1to1.q.out
ql/src/test/results/clientpositive/join_filters.q.out
ql/src/test/results/clientpositive/join_filters_overlap.q.out
ql/src/test/results/clientpositive/mapjoin1.q.out
To: JIRA, navis
Cc: njain
Result of outer join is not valid
-
Key: HIVE-3381
URL: https://issues.apache.org/jira/browse/HIVE-3381
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.10.0
Reporter: Navis
Assignee: Navis
Priority: Critical
Attachments: HIVE-3381.D5565.3.patch, HIVE-3381.D5565.4.patch,
HIVE-3381.D5565.5.patch, HIVE-3381.D5565.6.patch
Outer joins, especially full outer joins or outer join with filter on 'ON
clause' is not showing proper results. For example, query in test join_1to1.q
{code}
SELECT * FROM join_1to1_1 a full outer join join_1to1_2 b on a.key1 = b.key1
and a.value = 66 and b.value = 66 ORDER BY a.key1 ASC, a.key2 ASC, a.value
ASC, b.key1 ASC, b.key2 ASC, b.value ASC;
{code}
results
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULL66 NULLNULLNULL
NULL 10050 66 NULLNULLNULL
5 10005 66 5 10005 66
1510015 66 NULLNULLNULL
2010020 66 20 10020 66
2510025 88 NULLNULLNULL
3010030 66 NULLNULLNULL
3510035 88 NULLNULLNULL
4010040 66 NULLNULLNULL
4010040 66 40 10040 66
4010040 88 NULLNULLNULL
4010040 88 NULLNULLNULL
5010050 66 NULLNULLNULL
5010050 66 50 10050 66
5010050 66 50 10050 66
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
{code}
but it seemed not right. This should be
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL25 10025 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULL
[jira] [Updated] (HIVE-3381) Result of outer join is not valid
[
https://issues.apache.org/jira/browse/HIVE-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-3381:
--
Attachment: HIVE-3381.D5565.5.patch
navis updated the revision HIVE-3381 [jira] Result of outer join is not valid.
Rebased to trunk. running test
Reviewers: JIRA
REVISION DETAIL
https://reviews.facebook.net/D5565
CHANGE SINCE LAST DIFF
https://reviews.facebook.net/D5565?vs=22947id=30225#toc
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java
ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinObjectValue.java
ql/src/test/results/clientpositive/auto_join21.q.out
ql/src/test/results/clientpositive/auto_join29.q.out
ql/src/test/results/clientpositive/auto_join7.q.out
ql/src/test/results/clientpositive/auto_join_filters.q.out
ql/src/test/results/clientpositive/join21.q.out
ql/src/test/results/clientpositive/join7.q.out
ql/src/test/results/clientpositive/join_1to1.q.out
ql/src/test/results/clientpositive/join_filters.q.out
ql/src/test/results/clientpositive/join_filters_overlap.q.out
To: JIRA, navis
Cc: njain
Result of outer join is not valid
-
Key: HIVE-3381
URL: https://issues.apache.org/jira/browse/HIVE-3381
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.10.0
Reporter: Navis
Assignee: Navis
Priority: Critical
Attachments: HIVE-3381.D5565.3.patch, HIVE-3381.D5565.4.patch,
HIVE-3381.D5565.5.patch
Outer joins, especially full outer joins or outer join with filter on 'ON
clause' is not showing proper results. For example, query in test join_1to1.q
{code}
SELECT * FROM join_1to1_1 a full outer join join_1to1_2 b on a.key1 = b.key1
and a.value = 66 and b.value = 66 ORDER BY a.key1 ASC, a.key2 ASC, a.value
ASC, b.key1 ASC, b.key2 ASC, b.value ASC;
{code}
results
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULL66 NULLNULLNULL
NULL 10050 66 NULLNULLNULL
5 10005 66 5 10005 66
1510015 66 NULLNULLNULL
2010020 66 20 10020 66
2510025 88 NULLNULLNULL
3010030 66 NULLNULLNULL
3510035 88 NULLNULLNULL
4010040 66 NULLNULLNULL
4010040 66 40 10040 66
4010040 88 NULLNULLNULL
4010040 88 NULLNULLNULL
5010050 66 NULLNULLNULL
5010050 66 50 10050 66
5010050 66 50 10050 66
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
{code}
but it seemed not right. This should be
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL25 10025 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL80 10040 66
NULL NULLNULL80 10040 66
NULL NULL
[jira] [Updated] (HIVE-3381) Result of outer join is not valid
[
https://issues.apache.org/jira/browse/HIVE-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Navis updated HIVE-3381:
Status: Patch Available (was: Open)
Result of outer join is not valid
-
Key: HIVE-3381
URL: https://issues.apache.org/jira/browse/HIVE-3381
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.10.0
Reporter: Navis
Assignee: Navis
Priority: Critical
Attachments: HIVE-3381.D5565.3.patch, HIVE-3381.D5565.4.patch
Outer joins, especially full outer joins or outer join with filter on 'ON
clause' is not showing proper results. For example, query in test join_1to1.q
{code}
SELECT * FROM join_1to1_1 a full outer join join_1to1_2 b on a.key1 = b.key1
and a.value = 66 and b.value = 66 ORDER BY a.key1 ASC, a.key2 ASC, a.value
ASC, b.key1 ASC, b.key2 ASC, b.value ASC;
{code}
results
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULL66 NULLNULLNULL
NULL 10050 66 NULLNULLNULL
5 10005 66 5 10005 66
1510015 66 NULLNULLNULL
2010020 66 20 10020 66
2510025 88 NULLNULLNULL
3010030 66 NULLNULLNULL
3510035 88 NULLNULLNULL
4010040 66 NULLNULLNULL
4010040 66 40 10040 66
4010040 88 NULLNULLNULL
4010040 88 NULLNULLNULL
5010050 66 NULLNULLNULL
5010050 66 50 10050 66
5010050 66 50 10050 66
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
{code}
but it seemed not right. This should be
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL25 10025 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL80 10040 66
NULL NULLNULL80 10040 66
NULL NULL66 NULLNULLNULL
NULL 10050 66 NULLNULLNULL
5 10005 66 5 10005 66
1510015 66 NULLNULLNULL
2010020 66 20 10020 66
2510025 88 NULLNULLNULL
3010030 66 NULLNULLNULL
3510035 88 NULLNULLNULL
4010040 66 40 10040 66
4010040 88 NULLNULLNULL
5010050 66 50 10050 66
5010050 66 50 10050 66
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3381) Result of outer join is not valid
[
https://issues.apache.org/jira/browse/HIVE-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-3381:
--
Attachment: HIVE-3381.D5565.4.patch
navis updated the revision HIVE-3381 [jira] Result of outer join is not valid.
Reviewers: JIRA
1. Simplified code a little
2. Added comments including example
3. Rebased on trunk passed all tests
REVISION DETAIL
https://reviews.facebook.net/D5565
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java
ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinObjectValue.java
ql/src/test/results/clientpositive/auto_join21.q.out
ql/src/test/results/clientpositive/auto_join29.q.out
ql/src/test/results/clientpositive/auto_join7.q.out
ql/src/test/results/clientpositive/auto_join_filters.q.out
ql/src/test/results/clientpositive/join21.q.out
ql/src/test/results/clientpositive/join7.q.out
ql/src/test/results/clientpositive/join_1to1.q.out
ql/src/test/results/clientpositive/join_filters.q.out
ql/src/test/results/clientpositive/join_filters_overlap.q.out
To: JIRA, navis
Cc: njain
Result of outer join is not valid
-
Key: HIVE-3381
URL: https://issues.apache.org/jira/browse/HIVE-3381
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.10.0
Reporter: Navis
Assignee: Navis
Priority: Critical
Attachments: HIVE-3381.D5565.3.patch, HIVE-3381.D5565.4.patch
Outer joins, especially full outer joins or outer join with filter on 'ON
clause' is not showing proper results. For example, query in test join_1to1.q
{code}
SELECT * FROM join_1to1_1 a full outer join join_1to1_2 b on a.key1 = b.key1
and a.value = 66 and b.value = 66 ORDER BY a.key1 ASC, a.key2 ASC, a.value
ASC, b.key1 ASC, b.key2 ASC, b.value ASC;
{code}
results
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULL66 NULLNULLNULL
NULL 10050 66 NULLNULLNULL
5 10005 66 5 10005 66
1510015 66 NULLNULLNULL
2010020 66 20 10020 66
2510025 88 NULLNULLNULL
3010030 66 NULLNULLNULL
3510035 88 NULLNULLNULL
4010040 66 NULLNULLNULL
4010040 66 40 10040 66
4010040 88 NULLNULLNULL
4010040 88 NULLNULLNULL
5010050 66 NULLNULLNULL
5010050 66 50 10050 66
5010050 66 50 10050 66
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
{code}
but it seemed not right. This should be
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL25 10025 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL80 10040 66
NULL NULLNULL80 10040 66
NULL NULL66 NULLNULLNULL
[jira] [Updated] (HIVE-3381) Result of outer join is not valid
[
https://issues.apache.org/jira/browse/HIVE-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Navis updated HIVE-3381:
Status: Patch Available (was: Open)
Result of outer join is not valid
-
Key: HIVE-3381
URL: https://issues.apache.org/jira/browse/HIVE-3381
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.10.0
Reporter: Navis
Assignee: Navis
Priority: Critical
Outer joins, especially full outer joins or outer join with filter on 'ON
clause' is not showing proper results. For example, query in test join_1to1.q
{code}
SELECT * FROM join_1to1_1 a full outer join join_1to1_2 b on a.key1 = b.key1
and a.value = 66 and b.value = 66 ORDER BY a.key1 ASC, a.key2 ASC, a.value
ASC, b.key1 ASC, b.key2 ASC, b.value ASC;
{code}
results
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULL66 NULLNULLNULL
NULL 10050 66 NULLNULLNULL
5 10005 66 5 10005 66
1510015 66 NULLNULLNULL
2010020 66 20 10020 66
2510025 88 NULLNULLNULL
3010030 66 NULLNULLNULL
3510035 88 NULLNULLNULL
4010040 66 NULLNULLNULL
4010040 66 40 10040 66
4010040 88 NULLNULLNULL
4010040 88 NULLNULLNULL
5010050 66 NULLNULLNULL
5010050 66 50 10050 66
5010050 66 50 10050 66
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
{code}
but it seemed not right. This should be
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL25 10025 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL80 10040 66
NULL NULLNULL80 10040 66
NULL NULL66 NULLNULLNULL
NULL 10050 66 NULLNULLNULL
5 10005 66 5 10005 66
1510015 66 NULLNULLNULL
2010020 66 20 10020 66
2510025 88 NULLNULLNULL
3010030 66 NULLNULLNULL
3510035 88 NULLNULLNULL
4010040 66 40 10040 66
4010040 88 NULLNULLNULL
5010050 66 50 10050 66
5010050 66 50 10050 66
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3381) Result of outer join is not valid
[
https://issues.apache.org/jira/browse/HIVE-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Navis updated HIVE-3381:
Status: Open (was: Patch Available)
I found a bug with semi join.
Result of outer join is not valid
-
Key: HIVE-3381
URL: https://issues.apache.org/jira/browse/HIVE-3381
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.10.0
Reporter: Navis
Assignee: Navis
Priority: Critical
Outer joins, especially full outer joins or outer join with filter on 'ON
clause' is not showing proper results. For example, query in test join_1to1.q
{code}
SELECT * FROM join_1to1_1 a full outer join join_1to1_2 b on a.key1 = b.key1
and a.value = 66 and b.value = 66 ORDER BY a.key1 ASC, a.key2 ASC, a.value
ASC, b.key1 ASC, b.key2 ASC, b.value ASC;
{code}
results
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULL66 NULLNULLNULL
NULL 10050 66 NULLNULLNULL
5 10005 66 5 10005 66
1510015 66 NULLNULLNULL
2010020 66 20 10020 66
2510025 88 NULLNULLNULL
3010030 66 NULLNULLNULL
3510035 88 NULLNULLNULL
4010040 66 NULLNULLNULL
4010040 66 40 10040 66
4010040 88 NULLNULLNULL
4010040 88 NULLNULLNULL
5010050 66 NULLNULLNULL
5010050 66 50 10050 66
5010050 66 50 10050 66
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
{code}
but it seemed not right. This should be
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL25 10025 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL80 10040 66
NULL NULLNULL80 10040 66
NULL NULL66 NULLNULLNULL
NULL 10050 66 NULLNULLNULL
5 10005 66 5 10005 66
1510015 66 NULLNULLNULL
2010020 66 20 10020 66
2510025 88 NULLNULLNULL
3010030 66 NULLNULLNULL
3510035 88 NULLNULLNULL
4010040 66 40 10040 66
4010040 88 NULLNULLNULL
5010050 66 50 10050 66
5010050 66 50 10050 66
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3381) Result of outer join is not valid
[
https://issues.apache.org/jira/browse/HIVE-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Navis updated HIVE-3381:
Status: Patch Available (was: Open)
https://reviews.facebook.net/D5565
It was hard.
Result of outer join is not valid
-
Key: HIVE-3381
URL: https://issues.apache.org/jira/browse/HIVE-3381
Project: Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.10.0
Reporter: Navis
Assignee: Navis
Priority: Critical
Outer joins, especially full outer joins or outer join with filter on 'ON
clause' is not showing proper results. For example, query in test join_1to1.q
{code}
SELECT * FROM join_1to1_1 a full outer join join_1to1_2 b on a.key1 = b.key1
and a.value = 66 and b.value = 66 ORDER BY a.key1 ASC, a.key2 ASC, a.value
ASC, b.key1 ASC, b.key2 ASC, b.value ASC;
{code}
results
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULL66 NULLNULLNULL
NULL 10050 66 NULLNULLNULL
5 10005 66 5 10005 66
1510015 66 NULLNULLNULL
2010020 66 20 10020 66
2510025 88 NULLNULLNULL
3010030 66 NULLNULLNULL
3510035 88 NULLNULLNULL
4010040 66 NULLNULLNULL
4010040 66 40 10040 66
4010040 88 NULLNULLNULL
4010040 88 NULLNULLNULL
5010050 66 NULLNULLNULL
5010050 66 50 10050 66
5010050 66 50 10050 66
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
{code}
but it seemed not right. This should be
{code}
NULL NULLNULLNULLNULL66
NULL NULLNULLNULL10050 66
NULL NULLNULL10 10010 66
NULL NULLNULL25 10025 66
NULL NULLNULL30 10030 88
NULL NULLNULL35 10035 88
NULL NULLNULL40 10040 88
NULL NULLNULL50 10050 88
NULL NULLNULL70 10040 88
NULL NULLNULL70 10040 88
NULL NULLNULL80 10040 66
NULL NULLNULL80 10040 66
NULL NULL66 NULLNULLNULL
NULL 10050 66 NULLNULLNULL
5 10005 66 5 10005 66
1510015 66 NULLNULLNULL
2010020 66 20 10020 66
2510025 88 NULLNULLNULL
3010030 66 NULLNULLNULL
3510035 88 NULLNULLNULL
4010040 66 40 10040 66
4010040 88 NULLNULLNULL
5010050 66 50 10050 66
5010050 66 50 10050 66
5010050 88 NULLNULLNULL
5010050 88 NULLNULLNULL
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
6010040 66 60 10040 66
7010040 66 NULLNULLNULL
7010040 66 NULLNULLNULL
8010040 88 NULLNULLNULL
8010040 88 NULLNULLNULL
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
