[jira] [Updated] (HIVE-3876) call resetValid instead of ensureCapacity in the constructor of BytesRefArrayWritable

2013-01-13 Thread Ashutosh Chauhan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Chauhan updated HIVE-3876:
---

Status: Open  (was: Patch Available)

Turns out this results in tons of failures. 46 tests failed in CliDriver and 
there were failures in other drivers as well.

 call resetValid instead of ensureCapacity in the constructor of 
 BytesRefArrayWritable
 -

 Key: HIVE-3876
 URL: https://issues.apache.org/jira/browse/HIVE-3876
 Project: Hive
  Issue Type: Improvement
  Components: Serializers/Deserializers
Affects Versions: 0.10.0
Reporter: Yin Huai
Assignee: Yin Huai
Priority: Minor
 Attachments: HIVE-3876.1.patch.txt


 In the constructor of BytesRefArrayWritable, ensureCapacity(capacity) is 
 called, but valid has not been adjusted accordingly. After a new 
 BytesRefArrayWritable has been created with a initial capacity of x, if 
 resetValid() has not been called explicitly, the size returned is still 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-3876) call resetValid instead of ensureCapacity in the constructor of BytesRefArrayWritable

2013-01-11 Thread Yin Huai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yin Huai updated HIVE-3876:
---

Status: Patch Available  (was: Open)

 call resetValid instead of ensureCapacity in the constructor of 
 BytesRefArrayWritable
 -

 Key: HIVE-3876
 URL: https://issues.apache.org/jira/browse/HIVE-3876
 Project: Hive
  Issue Type: Improvement
  Components: Serializers/Deserializers
Affects Versions: 0.10.0
Reporter: Yin Huai
Assignee: Yin Huai
Priority: Minor
 Attachments: HIVE-3876.1.patch.txt


 In the constructor of BytesRefArrayWritable, ensureCapacity(capacity) is 
 called, but valid has not been adjusted accordingly. After a new 
 BytesRefArrayWritable has been created with a initial capacity of x, if 
 resetValid() has not been called explicitly, the size returned is still 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-3876) call resetValid instead of ensureCapacity in the constructor of BytesRefArrayWritable

2013-01-09 Thread Yin Huai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yin Huai updated HIVE-3876:
---

Attachment: HIVE-3876.1.patch.txt

is there any reason that we do not set valid to the capacity in the original 
constructor?

 call resetValid instead of ensureCapacity in the constructor of 
 BytesRefArrayWritable
 -

 Key: HIVE-3876
 URL: https://issues.apache.org/jira/browse/HIVE-3876
 Project: Hive
  Issue Type: Improvement
  Components: Serializers/Deserializers
Affects Versions: 0.10.0
Reporter: Yin Huai
Assignee: Yin Huai
Priority: Minor
 Attachments: HIVE-3876.1.patch.txt


 In the constructor of BytesRefArrayWritable, ensureCapacity(capacity) is 
 called, but valid has not been adjusted accordingly. After a new 
 BytesRefArrayWritable has been created with a initial capacity of x, if 
 resetValid() has not been called explicitly, the size returned is still 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira