[jira] [Updated] (HIVE-4534) IsNotNull and NotCol incorrectly handle nulls.

2013-05-22 Thread Owen O'Malley (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Owen O'Malley updated HIVE-4534:


   Resolution: Fixed
Fix Version/s: vectorization-branch
   Status: Resolved  (was: Patch Available)

I just committed this to the vectorization branch. Thanks, Jitendra!

> IsNotNull and NotCol incorrectly handle nulls.
> --
>
> Key: HIVE-4534
> URL: https://issues.apache.org/jira/browse/HIVE-4534
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Eric Hanson
>Assignee: Jitendra Nath Pandey
> Fix For: vectorization-branch
>
> Attachments: HIVE-4534.1.patch, HIVE-4534.2.patch
>
>
> See file IsNotNull.java in package 
> org.apache.hadoop.hive.ql.exec.vector.expressions
> It never looks at the noNulls flag on the input vector, but accesses the 
> isNull[] array anyway. This can yield incorrect results.
> isRepeating and noNulls are not set in the output, which can also cause wrong 
> results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-4534) IsNotNull and NotCol incorrectly handle nulls.

2013-05-20 Thread Jitendra Nath Pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jitendra Nath Pandey updated HIVE-4534:
---

Affects Version/s: (was: vectorization-branch)

> IsNotNull and NotCol incorrectly handle nulls.
> --
>
> Key: HIVE-4534
> URL: https://issues.apache.org/jira/browse/HIVE-4534
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Eric Hanson
>Assignee: Jitendra Nath Pandey
> Attachments: HIVE-4534.1.patch, HIVE-4534.2.patch
>
>
> See file IsNotNull.java in package 
> org.apache.hadoop.hive.ql.exec.vector.expressions
> It never looks at the noNulls flag on the input vector, but accesses the 
> isNull[] array anyway. This can yield incorrect results.
> isRepeating and noNulls are not set in the output, which can also cause wrong 
> results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-4534) IsNotNull and NotCol incorrectly handle nulls.

2013-05-20 Thread Jitendra Nath Pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jitendra Nath Pandey updated HIVE-4534:
---

Affects Version/s: vectorization-branch
   Status: Patch Available  (was: Open)

> IsNotNull and NotCol incorrectly handle nulls.
> --
>
> Key: HIVE-4534
> URL: https://issues.apache.org/jira/browse/HIVE-4534
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: vectorization-branch
>Reporter: Eric Hanson
>Assignee: Jitendra Nath Pandey
> Attachments: HIVE-4534.1.patch, HIVE-4534.2.patch
>
>
> See file IsNotNull.java in package 
> org.apache.hadoop.hive.ql.exec.vector.expressions
> It never looks at the noNulls flag on the input vector, but accesses the 
> isNull[] array anyway. This can yield incorrect results.
> isRepeating and noNulls are not set in the output, which can also cause wrong 
> results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-4534) IsNotNull and NotCol incorrectly handle nulls.

2013-05-20 Thread Jitendra Nath Pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jitendra Nath Pandey updated HIVE-4534:
---

Attachment: HIVE-4534.2.patch

Attached patch has additional unit tests, could not create review board entry 
because this patch is on top of HIVE-4472 patch.

> IsNotNull and NotCol incorrectly handle nulls.
> --
>
> Key: HIVE-4534
> URL: https://issues.apache.org/jira/browse/HIVE-4534
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Eric Hanson
>Assignee: Jitendra Nath Pandey
> Attachments: HIVE-4534.1.patch, HIVE-4534.2.patch
>
>
> See file IsNotNull.java in package 
> org.apache.hadoop.hive.ql.exec.vector.expressions
> It never looks at the noNulls flag on the input vector, but accesses the 
> isNull[] array anyway. This can yield incorrect results.
> isRepeating and noNulls are not set in the output, which can also cause wrong 
> results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-4534) IsNotNull and NotCol incorrectly handle nulls.

2013-05-14 Thread Jitendra Nath Pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jitendra Nath Pandey updated HIVE-4534:
---

Attachment: HIVE-4534.1.patch

Initial patch uploaded, I will upload another patch with unit tests.

> IsNotNull and NotCol incorrectly handle nulls.
> --
>
> Key: HIVE-4534
> URL: https://issues.apache.org/jira/browse/HIVE-4534
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Eric Hanson
>Assignee: Jitendra Nath Pandey
> Attachments: HIVE-4534.1.patch
>
>
> See file IsNotNull.java in package 
> org.apache.hadoop.hive.ql.exec.vector.expressions
> It never looks at the noNulls flag on the input vector, but accesses the 
> isNull[] array anyway. This can yield incorrect results.
> isRepeating and noNulls are not set in the output, which can also cause wrong 
> results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-4534) IsNotNull and NotCol incorrectly handle nulls.

2013-05-14 Thread Jitendra Nath Pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jitendra Nath Pandey updated HIVE-4534:
---

Summary: IsNotNull and NotCol incorrectly handle nulls.  (was: IsNotNull 
vectorized expression does not look at noNulls)

> IsNotNull and NotCol incorrectly handle nulls.
> --
>
> Key: HIVE-4534
> URL: https://issues.apache.org/jira/browse/HIVE-4534
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Eric Hanson
>Assignee: Jitendra Nath Pandey
>
> See file IsNotNull.java in package 
> org.apache.hadoop.hive.ql.exec.vector.expressions
> It never looks at the noNulls flag on the input vector, but accesses the 
> isNull[] array anyway. This can yield incorrect results.
> isRepeating and noNulls are not set in the output, which can also cause wrong 
> results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira