[jira] [Updated] (HIVE-5203) FunctionRegistry.getMethodInternal() should prefer method arguments with closer affinity to the original argument types
[ https://issues.apache.org/jira/browse/HIVE-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-5203: --- Resolution: Fixed Fix Version/s: 0.12.0 Status: Resolved (was: Patch Available) Committed to trunk. Thanks, Jason! FunctionRegistry.getMethodInternal() should prefer method arguments with closer affinity to the original argument types --- Key: HIVE-5203 URL: https://issues.apache.org/jira/browse/HIVE-5203 Project: Hive Issue Type: Bug Components: Types, UDF Reporter: Jason Dere Assignee: Jason Dere Fix For: 0.12.0 Attachments: HIVE-5203.1.patch, HIVE-5203.2.patch When the function registry is trying to determine the best version of UDF evaluate() to use based on a set of arguments passed in, it should prefer methods where the argument types are more related to the original types. For example if varchar is used with UDFFromUnixTime(), varchar is convertible to both the double and string versions of evaluate() for that UDF. In this case we would prefer that the function registry select the string version over the double version, since varchar and string are both string types. This doesn't really affect any of the existing types, but comes into play with the addition of the varchar type (HIVE-4844). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-5203) FunctionRegistry.getMethodInternal() should prefer method arguments with closer affinity to the original argument types
[ https://issues.apache.org/jira/browse/HIVE-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Dere updated HIVE-5203: - Attachment: HIVE-5203.2.patch Attaching HIVE-5203.2.patch. This breaks out the type affinity-based selection to a separate method for better testability, and adds tests. FunctionRegistry.getMethodInternal() should prefer method arguments with closer affinity to the original argument types --- Key: HIVE-5203 URL: https://issues.apache.org/jira/browse/HIVE-5203 Project: Hive Issue Type: Bug Components: Types, UDF Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-5203.1.patch, HIVE-5203.2.patch When the function registry is trying to determine the best version of UDF evaluate() to use based on a set of arguments passed in, it should prefer methods where the argument types are more related to the original types. For example if varchar is used with UDFFromUnixTime(), varchar is convertible to both the double and string versions of evaluate() for that UDF. In this case we would prefer that the function registry select the string version over the double version, since varchar and string are both string types. This doesn't really affect any of the existing types, but comes into play with the addition of the varchar type (HIVE-4844). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-5203) FunctionRegistry.getMethodInternal() should prefer method arguments with closer affinity to the original argument types
[ https://issues.apache.org/jira/browse/HIVE-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Dere updated HIVE-5203: - Attachment: HIVE-5203.1.patch Attaching HIVE-5203.1.patch FunctionRegistry.getMethodInternal() should prefer method arguments with closer affinity to the original argument types --- Key: HIVE-5203 URL: https://issues.apache.org/jira/browse/HIVE-5203 Project: Hive Issue Type: Bug Components: Types, UDF Reporter: Jason Dere Attachments: HIVE-5203.1.patch When the function registry is trying to determine the best version of UDF evaluate() to use based on a set of arguments passed in, it should prefer methods where the argument types are more related to the original types. For example if varchar is used with UDFFromUnixTime(), varchar is convertible to both the double and string versions of evaluate() for that UDF. In this case we would prefer that the function registry select the string version over the double version, since varchar and string are both string types. This doesn't really affect any of the existing types, but comes into play with the addition of the varchar type (HIVE-4844). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-5203) FunctionRegistry.getMethodInternal() should prefer method arguments with closer affinity to the original argument types
[ https://issues.apache.org/jira/browse/HIVE-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Dere updated HIVE-5203: - Assignee: Jason Dere FunctionRegistry.getMethodInternal() should prefer method arguments with closer affinity to the original argument types --- Key: HIVE-5203 URL: https://issues.apache.org/jira/browse/HIVE-5203 Project: Hive Issue Type: Bug Components: Types, UDF Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-5203.1.patch When the function registry is trying to determine the best version of UDF evaluate() to use based on a set of arguments passed in, it should prefer methods where the argument types are more related to the original types. For example if varchar is used with UDFFromUnixTime(), varchar is convertible to both the double and string versions of evaluate() for that UDF. In this case we would prefer that the function registry select the string version over the double version, since varchar and string are both string types. This doesn't really affect any of the existing types, but comes into play with the addition of the varchar type (HIVE-4844). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-5203) FunctionRegistry.getMethodInternal() should prefer method arguments with closer affinity to the original argument types
[ https://issues.apache.org/jira/browse/HIVE-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Dere updated HIVE-5203: - Status: Patch Available (was: Open) FunctionRegistry.getMethodInternal() should prefer method arguments with closer affinity to the original argument types --- Key: HIVE-5203 URL: https://issues.apache.org/jira/browse/HIVE-5203 Project: Hive Issue Type: Bug Components: Types, UDF Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-5203.1.patch When the function registry is trying to determine the best version of UDF evaluate() to use based on a set of arguments passed in, it should prefer methods where the argument types are more related to the original types. For example if varchar is used with UDFFromUnixTime(), varchar is convertible to both the double and string versions of evaluate() for that UDF. In this case we would prefer that the function registry select the string version over the double version, since varchar and string are both string types. This doesn't really affect any of the existing types, but comes into play with the addition of the varchar type (HIVE-4844). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
