[jira] [Updated] (HIVE-7305) Return value from in.read() is ignored in SerializationUtils#readLongLE()
[ https://issues.apache.org/jira/browse/HIVE-7305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] skrho updated HIVE-7305: Attachment: HIVE-7305_001.patch I added null check and size check logic.. Please review my patch~~ > Return value from in.read() is ignored in SerializationUtils#readLongLE() > - > > Key: HIVE-7305 > URL: https://issues.apache.org/jira/browse/HIVE-7305 > Project: Hive > Issue Type: Bug >Reporter: Ted Yu >Priority: Minor > Attachments: HIVE-7305_001.patch > > > {code} > long readLongLE(InputStream in) throws IOException { > in.read(readBuffer, 0, 8); > return (((readBuffer[0] & 0xff) << 0) > + ((readBuffer[1] & 0xff) << 8) > {code} > Return value from read() may indicate fewer than 8 bytes read. > The return value should be checked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-7305) Return value from in.read() is ignored in SerializationUtils#readLongLE()
[ https://issues.apache.org/jira/browse/HIVE-7305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] skrho updated HIVE-7305: Assignee: skrho Status: Patch Available (was: Open) > Return value from in.read() is ignored in SerializationUtils#readLongLE() > - > > Key: HIVE-7305 > URL: https://issues.apache.org/jira/browse/HIVE-7305 > Project: Hive > Issue Type: Bug >Reporter: Ted Yu >Assignee: skrho >Priority: Minor > Attachments: HIVE-7305_001.patch > > > {code} > long readLongLE(InputStream in) throws IOException { > in.read(readBuffer, 0, 8); > return (((readBuffer[0] & 0xff) << 0) > + ((readBuffer[1] & 0xff) << 8) > {code} > Return value from read() may indicate fewer than 8 bytes read. > The return value should be checked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)