[jira] [Updated] (HIVE-7862) close of InputStream in Utils#copyToZipStream() should be placed in finally block

[skrho (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HIVE-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

skrho updated HIVE-7862:

Attachment: HIVE-7862_001.txt

Here is patch.. 

I added try/catch/finally statement.. and  InputStream, ZipOutputStream object 
is closed in finally statement  

> close of InputStream in Utils#copyToZipStream() should be placed in finally 
> block
> -
>
> Key: HIVE-7862
> URL: https://issues.apache.org/jira/browse/HIVE-7862
> Project: Hive
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Attachments: HIVE-7862_001.txt
>
>
> In accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/Utils.java , 
> line 278 :
> {code}
>   private static void copyToZipStream(InputStream is, ZipEntry entry, 
> ZipOutputStream zos)
>   throws IOException {
> zos.putNextEntry(entry);
> byte[] arr = new byte[4096];
> int read = is.read(arr);
> while (read > -1) {
>   zos.write(arr, 0, read);
>   read = is.read(arr);
> }
> is.close();
> {code}
> If read() throws IOException, is would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HIVE-7862) close of InputStream in Utils#copyToZipStream() should be placed in finally block

[skrho (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HIVE-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

skrho updated HIVE-7862:

   Labels: patch  (was: )
Affects Version/s: 0.13.0
   Status: Patch Available  (was: Open)

> close of InputStream in Utils#copyToZipStream() should be placed in finally 
> block
> -
>
> Key: HIVE-7862
> URL: https://issues.apache.org/jira/browse/HIVE-7862
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Ted Yu
>Priority: Minor
>  Labels: patch
> Attachments: HIVE-7862_001.txt
>
>
> In accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/Utils.java , 
> line 278 :
> {code}
>   private static void copyToZipStream(InputStream is, ZipEntry entry, 
> ZipOutputStream zos)
>   throws IOException {
> zos.putNextEntry(entry);
> byte[] arr = new byte[4096];
> int read = is.read(arr);
> while (read > -1) {
>   zos.write(arr, 0, read);
>   read = is.read(arr);
> }
> is.close();
> {code}
> If read() throws IOException, is would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HIVE-7862) close of InputStream in Utils#copyToZipStream() should be placed in finally block

[Navis (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HIVE-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Navis updated HIVE-7862:

Assignee: skrho

> close of InputStream in Utils#copyToZipStream() should be placed in finally 
> block
> -
>
> Key: HIVE-7862
> URL: https://issues.apache.org/jira/browse/HIVE-7862
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Ted Yu
>Assignee: skrho
>Priority: Minor
>  Labels: patch
> Attachments: HIVE-7862_001.txt
>
>
> In accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/Utils.java , 
> line 278 :
> {code}
>   private static void copyToZipStream(InputStream is, ZipEntry entry, 
> ZipOutputStream zos)
>   throws IOException {
> zos.putNextEntry(entry);
> byte[] arr = new byte[4096];
> int read = is.read(arr);
> while (read > -1) {
>   zos.write(arr, 0, read);
>   read = is.read(arr);
> }
> is.close();
> {code}
> If read() throws IOException, is would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)