[jira] [Updated] (HIVE-9356) Fail to handle the case that a qfile contains a semicolon in the annotation

2015-01-14 Thread Dong Chen (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dong Chen updated HIVE-9356:

Attachment: HIVE-9356.2-encryption.patch

Right! I missed the HiveCommand only for testing. Thank your [~spena]
Update patch V2

 Fail to handle the case that a qfile contains a semicolon in the annotation
 ---

 Key: HIVE-9356
 URL: https://issues.apache.org/jira/browse/HIVE-9356
 Project: Hive
  Issue Type: Sub-task
Affects Versions: encryption-branch
Reporter: Ferdinand Xu
Assignee: Dong Chen
 Fix For: encryption-branch

 Attachments: HIVE-9356-encryption.patch, 
 HIVE-9356.1-encryption.patch, HIVE-9356.2-encryption.patch, HIVE-9356.patch


 Currently, we split the qfile by the semicolon. It should be able to handle 
 the comment statement in the qfile with a semicolon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HIVE-9356) Fail to handle the case that a qfile contains a semicolon in the annotation

2015-01-14 Thread Brock Noland (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brock Noland updated HIVE-9356:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Thank you Dong! Committed to branch!

 Fail to handle the case that a qfile contains a semicolon in the annotation
 ---

 Key: HIVE-9356
 URL: https://issues.apache.org/jira/browse/HIVE-9356
 Project: Hive
  Issue Type: Sub-task
Affects Versions: encryption-branch
Reporter: Ferdinand Xu
Assignee: Dong Chen
 Fix For: encryption-branch

 Attachments: HIVE-9356-encryption.patch, 
 HIVE-9356.1-encryption.patch, HIVE-9356.2-encryption.patch, HIVE-9356.patch


 Currently, we split the qfile by the semicolon. It should be able to handle 
 the comment statement in the qfile with a semicolon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HIVE-9356) Fail to handle the case that a qfile contains a semicolon in the annotation

2015-01-13 Thread Ferdinand Xu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ferdinand Xu updated HIVE-9356:
---
Summary: Fail to handle the case that a qfile contains a semicolon in the 
annotation  (was: Fail to handle the case that a qfile contains a semicolon)

 Fail to handle the case that a qfile contains a semicolon in the annotation
 ---

 Key: HIVE-9356
 URL: https://issues.apache.org/jira/browse/HIVE-9356
 Project: Hive
  Issue Type: Sub-task
Affects Versions: encryption-branch
Reporter: Ferdinand Xu
Assignee: Dong Chen
 Fix For: encryption-branch

 Attachments: HIVE-9356-encryption.patch, HIVE-9356.patch


 Currently, we split the qfile by the semicolon. It should be able to handle 
 the comment statement in the qfile with a semicolon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HIVE-9356) Fail to handle the case that a qfile contains a semicolon in the annotation

2015-01-13 Thread Dong Chen (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dong Chen updated HIVE-9356:

Attachment: HIVE-9356.1-encryption.patch

Thanks for your review! Sergio, Brock.

I found we have to handle below 2 difference cases of .q in current command 
parser implementation, so updated patch V1.
{quote}
--comment;
sql statement
{quote}
and 
{quote}
--comment;
HiveCommand
{quote}


 Fail to handle the case that a qfile contains a semicolon in the annotation
 ---

 Key: HIVE-9356
 URL: https://issues.apache.org/jira/browse/HIVE-9356
 Project: Hive
  Issue Type: Sub-task
Affects Versions: encryption-branch
Reporter: Ferdinand Xu
Assignee: Dong Chen
 Fix For: encryption-branch

 Attachments: HIVE-9356-encryption.patch, 
 HIVE-9356.1-encryption.patch, HIVE-9356.patch


 Currently, we split the qfile by the semicolon. It should be able to handle 
 the comment statement in the qfile with a semicolon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)