[jira] [Commented] (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053480#comment-13053480 ] Adam Kramer commented on HIVE-1731: --- Syed, can you also link the other task to finish the other messages here? I'll start posting my new complaints about error messages there now since this one's done. :) Here's one: hive select count(1), b.age from t1 a join t2 b ON a.key = b.key and a.ds='2011-06-10' AND b.ds='2011-06-10'; FAILED: Error in semantic analysis: Line 1:17 Expression not in GROUP BY key 'age' ...this should say, 'b.age' and not just 'age.' Why? Because it's different from this: hive select count(1), b.age from t1 a join t2 b ON a.key = b.key and a.ds='2011-06-10' AND b.ds='2011-06-10' GROUP BY age; FAILED: Error in semantic analysis: Line 1:17 Expression not in GROUP BY key 'age' ...which is many times more maddening than the first error message. Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Diagnosability, Query Processor Reporter: John Sichi Assignee: Syed S. Albiz Fix For: 0.7.1, 0.8.0 Attachments: 0001-Fixed-parse-error-line-number-issue.patch, 0001-Fixed-parse-error-line-number-issue.patch, 0002-update-test-cases-with-error-string-results.patch, HIVE-1731.1.patch, HIVE-1731.2.patch, HIVE-1731.3.patch, HIVE-1731.4.patch, HIVE-1731.5.patch, HIVE-1731.6.patch, HIVE-1731.7-0.7.patch, HIVE-1731.7.patch, HIVE-1731.8-0.7.patch This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13030422#comment-13030422 ] John Sichi commented on HIVE-1731: -- I've committed to trunk. Syed, can you give me a backport HIVE-1731.7-0.7.patch? Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Diagnosability, Query Processor Reporter: John Sichi Assignee: Syed S. Albiz Attachments: 0001-Fixed-parse-error-line-number-issue.patch, 0001-Fixed-parse-error-line-number-issue.patch, 0002-update-test-cases-with-error-string-results.patch, HIVE-1731.1.patch, HIVE-1731.2.patch, HIVE-1731.3.patch, HIVE-1731.4.patch, HIVE-1731.5.patch, HIVE-1731.6.patch, HIVE-1731.7.patch This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13030455#comment-13030455 ] Hudson commented on HIVE-1731: -- Integrated in Hive-trunk-h0.20 #715 (See [https://builds.apache.org/hudson/job/Hive-trunk-h0.20/715/]) HIVE-1731. Improve miscellaneous error messages (Syed Albiz via jvs) Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Diagnosability, Query Processor Reporter: John Sichi Assignee: Syed S. Albiz Attachments: 0001-Fixed-parse-error-line-number-issue.patch, 0001-Fixed-parse-error-line-number-issue.patch, 0002-update-test-cases-with-error-string-results.patch, HIVE-1731.1.patch, HIVE-1731.2.patch, HIVE-1731.3.patch, HIVE-1731.4.patch, HIVE-1731.5.patch, HIVE-1731.6.patch, HIVE-1731.7.patch This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13030070#comment-13030070 ] John Sichi commented on HIVE-1731: -- Syed, can you do the following: 1) Create a combined patch with the code changes plus the error messages; name it HIVE-1731.1.patch (our naming convention). In a fresh checkout of Hive source, in the directory corresponding to trunk, make sure that the command patch -p0 HIVE-1731.1.patch applies cleanly (I'm still getting prompts when I try it with your latest). 2) Upload it to review board per the instructions in HowToContribute. 3) Click Submit Patch again. 4) Print out this JIRA and check off the comments for the ones which are addressed by your patch; let me take a look at that while reviewing, and then we can create followups for the remaining ones. Thanks! Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Diagnosability, Query Processor Reporter: John Sichi Assignee: Syed S. Albiz Attachments: 0001-Fixed-parse-error-line-number-issue.patch, 0001-Fixed-parse-error-line-number-issue.patch, 0002-update-test-cases-with-error-string-results.patch This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13030181#comment-13030181 ] John Sichi commented on HIVE-1731: -- +1. Will commit when tests pass. Need to open followups for the unaddressed items. Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Diagnosability, Query Processor Reporter: John Sichi Assignee: Syed S. Albiz Attachments: 0001-Fixed-parse-error-line-number-issue.patch, 0001-Fixed-parse-error-line-number-issue.patch, 0002-update-test-cases-with-error-string-results.patch, HIVE-1731.1.patch, HIVE-1731.2.patch, HIVE-1731.3.patch, HIVE-1731.4.patch, HIVE-1731.5.patch This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13030192#comment-13030192 ] Carl Steinbach commented on HIVE-1731: -- @Syed: This is a great contribution, and it would be nice to include this in the 0.7.1 release. Do you think you have time to backport this to branch-0.7? Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Diagnosability, Query Processor Reporter: John Sichi Assignee: Syed S. Albiz Attachments: 0001-Fixed-parse-error-line-number-issue.patch, 0001-Fixed-parse-error-line-number-issue.patch, 0002-update-test-cases-with-error-string-results.patch, HIVE-1731.1.patch, HIVE-1731.2.patch, HIVE-1731.3.patch, HIVE-1731.4.patch, HIVE-1731.5.patch This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13027186#comment-13027186 ] Syed S. Albiz commented on HIVE-1731: - Will take a look Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Diagnosability, Query Processor Reporter: John Sichi This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13026033#comment-13026033 ] Thomas Lento commented on HIVE-1731: I ran this: [Wed Apr 27 14:58:42 tlento@dev1158] hive -e select _c17, count(1) from tmp_tl_foo group by _c17 I got this: FAILED: Parse Error: line 1:11 mismatched input ',' expecting CharSetLiteral in character string literal The problem, of course, is that I needed to run this: [Wed Apr 27 14:58:59 tlento@dev1158] hive -e select \`_c17\`, count(1) from tmp_tl_foo group by \`_c17\` Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Diagnosability, Query Processor Reporter: John Sichi This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13020040#comment-13020040 ] Adam Kramer commented on HIVE-1731: --- SELECT a.id, VAR(a.cnt) FROM mytable a FAILED: Error in semantic analysis: line 1:94 Expression Not In Group By Key a ...what this error message should say is Function VAR is either undefined or it is not an aggregation function. ...and even if this were a GOOD message, it means expression not in group by key a.cnt...just saying a is useless. Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Diagnosability, Query Processor Reporter: John Sichi This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13015646#comment-13015646 ] Adam Kramer commented on HIVE-1731: --- hive alter table my_table create partition(ds='2011-08-01'); FAILED: Parse Error: line 1:12 cannot recognize input 'my_table' in alter table statement ...what it should say is, I don't know what create partition means. If I change the word create to add, this works. Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Diagnosability, Query Processor Reporter: John Sichi This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004917#comment-13004917 ] Adam Kramer commented on HIVE-1731: --- FAILED - LOCKS ON THE UNDERLYING OBJECTS CANNOT BE ACQUIRED. RETRY AFTER SOME TIME should be FAILED - Somebody is currently running a query that will replace this table or partition. Retry after some time. or FAILED - Somebody is currently reading from a table or partition you are attempting to overwrite. Retry after some time. ...depending on whether the user is trying to read or write, respectively. Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Diagnosability, Query Processor Reporter: John Sichi This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12999479#comment-12999479 ] Adam Kramer commented on HIVE-1731: --- @John: Which of my messages are you talking about? Also, what's critical mass on this jira? Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: John Sichi This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12999584#comment-12999584 ] John Sichi commented on HIVE-1731: -- @Adam: I was referring to the kwRole spew. Critical mass: maybe we can bootcamp it :) Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: John Sichi This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-1731) Improve miscellaneous error messages
[
https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12990742#comment-12990742
]
Adam Kramer commented on HIVE-1731:
---
hive show partitios table_name_here ;
FAILED: Parse Error: line 1:5 rule kwRole failed predicate:
{input.LT(1).getText().equalsIgnoreCase(role)}? in show role grants
...this is a typo. I meant partitions. This error message did not help me
understand that at all and provides misleading information.
Should be
FAILED: Parse Error: line 1:5 predicate partitios not understood; failed rule
kwRole...
Improve miscellaneous error messages
Key: HIVE-1731
URL: https://issues.apache.org/jira/browse/HIVE-1731
Project: Hive
Issue Type: Improvement
Components: Query Processor
Reporter: John Sichi
Fix For: 0.7.0
This is a place for accumulating error message improvements so that we can
update a bunch in batch.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12990748#comment-12990748 ] John Sichi commented on HIVE-1731: -- @Adam: Hmmm, this seems to be some fallout from the ANTLR hack we used in HIVE-78 to avoid making ROLE into a keyword. Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: John Sichi Fix For: 0.7.0 This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982419#action_12982419 ] Adam Kramer commented on HIVE-1731: --- FAILED: Error in semantic analysis: AS clause has an invalid number of aliases ...this should provide the line number and column number on which the invalid AS clause begins and ends. Subqueries mean there could be more than one. Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: John Sichi Fix For: 0.7.0 This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1731) Improve miscellaneous error messages
[
https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12970972#action_12970972
]
Adam Kramer commented on HIVE-1731:
---
FAILED: Parse Error: line 0:-1 mismatched input 'EOF' expecting ) in subquery
source
No error that refers to lines 0:-1 is ever useful. Here is an example query:
INSERT OVERWRITE TABLE my_table
SELECT TRANSFORM(b.user1, b.user2, b.cnt)
USING '{tr}'
AS c1,c2,c3,c4
FROM (
SELECT b.user1, b.user2, b.cnt FROM (
SELECT user1, user2, COUNT(1) AS cnt
FROM sourcetable
WHERE ds '2010-12-01' AND ds = '2010-12-07'
GROUP BY user1, user2
DISTRIBUTE BY user1 SORT BY user1, cnt
) b;
...the problem here is that the inner query is not indented and lacks a ). This
error message should report the error as being at the ;, which is to say 12:4.
Since the message knows an rparen is missing, it should also provide the index
of the lparen. It should read like this:
FAILED: Parse Error: line 12:4 mismatched input 'EOF' expecting ) in subquery
source to close ( at line 5:6.
Improve miscellaneous error messages
Key: HIVE-1731
URL: https://issues.apache.org/jira/browse/HIVE-1731
Project: Hive
Issue Type: Improvement
Components: Query Processor
Reporter: John Sichi
Fix For: 0.7.0
This is a place for accumulating error message improvements so that we can
update a bunch in batch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1731) Improve miscellaneous error messages
[ https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12922379#action_12922379 ] John Sichi commented on HIVE-1731: -- From Andrew Ryan: Instead of FAILED: Error in semantic analysis: line 1:333 In strict mode, limit must be specified if ORDER BY is present make it FAILED: Error in semantic analysis: line 1:333 In strict mode, if ORDER BY is specified, LIMIT must also be specified Improve miscellaneous error messages Key: HIVE-1731 URL: https://issues.apache.org/jira/browse/HIVE-1731 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: John Sichi Fix For: 0.7.0 This is a place for accumulating error message improvements so that we can update a bunch in batch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
