[jira] Commented: (HIVE-1939) Fix test failure in TestContribCliDriver/url_hook.q
[ https://issues.apache.org/jira/browse/HIVE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003320#comment-13003320 ] Carl Steinbach commented on HIVE-1939: -- Review request: https://reviews.apache.org/r/469/ This patch moves the url_hook.q testcase from the contrib/positive directory to the contrib/negative directory. As I noted in my previous comment, this testcase should always have thrown an error, but until recently this fact was masked by another bug in the implementation of SHOW TABLES. That other bug was fixed in HIVE-1636, which consequently caused the error to start popping up in url_hook. I spent a lot of time trying to resolve the underlying problem (described in HIVE-2029), only to convince myself that this will require substantial changes to the HiveMetaStore class, which I think run the risk of destabilizing the branch. Consequently, I propose backporting this patch to the 0.7 branch in order to resolve the test failure, and then investigate and fix the real problem on trunk in HIVE-2029. Fix test failure in TestContribCliDriver/url_hook.q --- Key: HIVE-1939 URL: https://issues.apache.org/jira/browse/HIVE-1939 Project: Hive Issue Type: Bug Components: Metastore Reporter: Carl Steinbach Assignee: Carl Steinbach Priority: Blocker Fix For: 0.7.0 Attachments: HIVE-1939.1.patch.txt -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-1939) Fix test failure in TestContribCliDriver/url_hook.q
[ https://issues.apache.org/jira/browse/HIVE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003526#comment-13003526 ] John Sichi commented on HIVE-1939: -- +1. Will commit when tests pass. Fix test failure in TestContribCliDriver/url_hook.q --- Key: HIVE-1939 URL: https://issues.apache.org/jira/browse/HIVE-1939 Project: Hive Issue Type: Bug Components: Metastore Reporter: Carl Steinbach Assignee: Carl Steinbach Priority: Blocker Fix For: 0.7.0 Attachments: HIVE-1939.1.patch.txt -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-1939) Fix test failure in TestContribCliDriver/url_hook.q
[ https://issues.apache.org/jira/browse/HIVE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12990293#comment-12990293 ] John Sichi commented on HIVE-1939: -- I did some bisection on svn commits and found that the commit for HIVE-1636 seems to be the point where this broke. http://svn.apache.org/viewvc?view=revrev=1063549 Fix test failure in TestContribCliDriver/url_hook.q --- Key: HIVE-1939 URL: https://issues.apache.org/jira/browse/HIVE-1939 Project: Hive Issue Type: Bug Reporter: Carl Steinbach Assignee: Carl Steinbach Fix For: 0.7.0 -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-1939) Fix test failure in TestContribCliDriver/url_hook.q
[ https://issues.apache.org/jira/browse/HIVE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12990309#comment-12990309 ] Carl Steinbach commented on HIVE-1939: -- @John: Yup, you're right. The problem is that HIVE-1636 modified 'SHOW TABLES IN db' to throw an error when db doesn't exist. Previously in this situation the SHOW TABLES command just returned an empty result set. url_hook.q points the MetaStore to a new JDO URL and then runs 'SHOW TABLES'. In the past this caused the metastore to initialize a new metastore schema, but without creating the 'default' database. Since 'SHOW TABLES' wasn't checking for the existence of the default database the command succeeded with an empty result set. I think the correct fix for this problem is to make sure that the metastore creates the 'default' table if it does not already exist. Fix test failure in TestContribCliDriver/url_hook.q --- Key: HIVE-1939 URL: https://issues.apache.org/jira/browse/HIVE-1939 Project: Hive Issue Type: Bug Components: Metastore Reporter: Carl Steinbach Assignee: Carl Steinbach Fix For: 0.7.0 -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
