Re: Review Request: Add support for vectorized string concatenation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10868/#review1 --- ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatColCol.java https://reviews.apache.org/r/10868/#comment41236 Shouldn't this be string? - Timothy Chen On April 30, 2013, 9:35 p.m., Eric Hanson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10868/ --- (Updated April 30, 2013, 9:35 p.m.) Review request for hive. Description --- Add support for vectorized string concatenation This addresses bug HIVE-4431. https://issues.apache.org/jira/browse/HIVE-4431 Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java 246170d ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatColCol.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatColScalar.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatScalarCol.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorStringExpressions.java c0e71e5 Diff: https://reviews.apache.org/r/10868/diff/ Testing --- Thanks, Eric Hanson
Re: Review Request: Add support for vectorized string concatenation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10868/ --- (Updated May 1, 2013, 6 p.m.) Review request for hive. Changes --- Includes small fix recommended by Tim. Also merges in changes from HIVE-4458. I'll close 4458. Description --- Add support for vectorized string concatenation This addresses bug HIVE-4431. https://issues.apache.org/jira/browse/HIVE-4431 Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java 246170d ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatColCol.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatColScalar.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatScalarCol.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColAddDoubleColumn.java 71964c0 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColAddLongColumn.java e9f01db ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColDivideDoubleColumn.java d122e0f ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColDivideLongColumn.java c9f918e ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColMultiplyDoubleColumn.java 290cbed ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColMultiplyLongColumn.java 5b0d002 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColSubtractDoubleColumn.java aba47b3 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColSubtractLongColumn.java ede1602 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColAddDoubleColumn.java 49281a6 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColAddLongColumn.java 6981155 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColDivideDoubleColumn.java 127c681 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColDivideLongColumn.java adcd237 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColModuloLongColumn.java 10a0e2b ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColMultiplyDoubleColumn.java 53e4343 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColMultiplyLongColumn.java bea0e0c ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColSubtractDoubleColumn.java 07c0901 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColSubtractLongColumn.java 9e9ea00 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/ColumnArithmeticColumn.txt f76cb4b ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorArithmeticExpressions.java a918ad6 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorStringExpressions.java c0e71e5 Diff: https://reviews.apache.org/r/10868/diff/ Testing --- Thanks, Eric Hanson
Re: Review Request: Add support for vectorized string concatenation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10868/ --- (Updated May 2, 2013, 12:38 a.m.) Review request for hive. Description --- Add support for vectorized string concatenation This addresses bug HIVE-4431. https://issues.apache.org/jira/browse/HIVE-4431 Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java 2a45057 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatColCol.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatColScalar.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatScalarCol.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColAddDoubleColumn.java 71964c0 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColAddLongColumn.java e9f01db ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColDivideDoubleColumn.java d122e0f ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColDivideLongColumn.java c9f918e ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColMultiplyDoubleColumn.java 290cbed ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColMultiplyLongColumn.java 5b0d002 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColSubtractDoubleColumn.java aba47b3 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/DoubleColSubtractLongColumn.java ede1602 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColAddDoubleColumn.java 49281a6 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColAddLongColumn.java 6981155 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColDivideDoubleColumn.java 127c681 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColDivideLongColumn.java adcd237 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColModuloLongColumn.java 10a0e2b ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColMultiplyDoubleColumn.java 53e4343 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColMultiplyLongColumn.java bea0e0c ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColSubtractDoubleColumn.java 07c0901 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/LongColSubtractLongColumn.java 9e9ea00 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/ColumnArithmeticColumn.txt f76cb4b ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorArithmeticExpressions.java a918ad6 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorStringExpressions.java c0e71e5 Diff: https://reviews.apache.org/r/10868/diff/ Testing --- Thanks, Eric Hanson
