Re: Review Request 29763: HIVE-9292

2015-02-03 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29763/#review70777
---

Ship it!


Ship It!

- John Pullokkaran


On Feb. 3, 2015, 10:41 a.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29763/
> ---
> 
> (Updated Feb. 3, 2015, 10:41 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Bugs: HIVE-9292
> https://issues.apache.org/jira/browse/HIVE-9292
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> CBO (Calcite Return Path): Inline GroupBy, Properties
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java 
> 4d9d1da77394125cfcb9ac9ccf1c00528664b981 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java
>  3097385b92d4398ee57d3544354b383fe24719dd 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
>  69a5a4409164fc6cb725b315de08ec9d090b7f22 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
> 0cf2963cdd5fd78aedf5ec22f354b9bdfcfdb7f6 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 7b645b84c9e771239eba0c8980c1c58e0114f0ba 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
> e4ed51e9a40a926ce074a3e33119535b4e08a122 
> 
> Diff: https://reviews.apache.org/r/29763/diff/
> 
> 
> Testing
> ---
> 
> Existing tests.
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>

Re: Review Request 29763: HIVE-9292

2015-02-03 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29763/
---

(Updated Feb. 3, 2015, 10:41 a.m.)


Review request for hive and John Pullokkaran.


Changes
---

Updating patch taking into account John's comment.


Bugs: HIVE-9292
https://issues.apache.org/jira/browse/HIVE-9292


Repository: hive-git


Description
---

CBO (Calcite Return Path): Inline GroupBy, Properties


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java 
4d9d1da77394125cfcb9ac9ccf1c00528664b981 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java
 3097385b92d4398ee57d3544354b383fe24719dd 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
 69a5a4409164fc6cb725b315de08ec9d090b7f22 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
0cf2963cdd5fd78aedf5ec22f354b9bdfcfdb7f6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
7b645b84c9e771239eba0c8980c1c58e0114f0ba 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
e4ed51e9a40a926ce074a3e33119535b4e08a122 

Diff: https://reviews.apache.org/r/29763/diff/


Testing
---

Existing tests.


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 29763: HIVE-9292

2015-02-02 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29763/#review70631
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java


Could we add this to operatorUtil?
"Get first operator from some src op in the DAG"


- John Pullokkaran


On Jan. 28, 2015, 7:05 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29763/
> ---
> 
> (Updated Jan. 28, 2015, 7:05 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Bugs: HIVE-9292
> https://issues.apache.org/jira/browse/HIVE-9292
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> CBO (Calcite Return Path): Inline GroupBy, Properties
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java
>  3097385b92d4398ee57d3544354b383fe24719dd 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
>  69a5a4409164fc6cb725b315de08ec9d090b7f22 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
> dda4f75592209d88f25b5ca09ea9f32c77ea4ac6 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> c9a5ce53ffc3d5c791e0826be0cac771a4d20254 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
> 0116c85979f02ea0f88bbf8085a7590694eb2dfb 
> 
> Diff: https://reviews.apache.org/r/29763/diff/
> 
> 
> Testing
> ---
> 
> Existing tests.
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>

Re: Review Request 29763: HIVE-9292

2015-02-02 Thread Jesús Camacho Rodríguez 


> On Feb. 2, 2015, 7:31 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java,
> >  line 279
> > 
> >
> > This optimization is trying to get at the first GB after scan right?
> > i.e should we be traversing down stream or upstream?

First we get the top operator out of the query. Then we go down the tree till 
we find the last GroupBy operator i.e. the first one after the Scan. But in 
Hive operator tree, down the tree = upstream; that is why I call the getParents 
method.


- Jesús


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29763/#review70607
---


On Jan. 28, 2015, 7:05 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29763/
> ---
> 
> (Updated Jan. 28, 2015, 7:05 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Bugs: HIVE-9292
> https://issues.apache.org/jira/browse/HIVE-9292
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> CBO (Calcite Return Path): Inline GroupBy, Properties
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java
>  3097385b92d4398ee57d3544354b383fe24719dd 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
>  69a5a4409164fc6cb725b315de08ec9d090b7f22 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
> dda4f75592209d88f25b5ca09ea9f32c77ea4ac6 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> c9a5ce53ffc3d5c791e0826be0cac771a4d20254 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
> 0116c85979f02ea0f88bbf8085a7590694eb2dfb 
> 
> Diff: https://reviews.apache.org/r/29763/diff/
> 
> 
> Testing
> ---
> 
> Existing tests.
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>

Re: Review Request 29763: HIVE-9292

2015-02-02 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29763/#review70607
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java


This optimization is trying to get at the first GB after scan right?
i.e should we be traversing down stream or upstream?


- John Pullokkaran


On Jan. 28, 2015, 7:05 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29763/
> ---
> 
> (Updated Jan. 28, 2015, 7:05 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Bugs: HIVE-9292
> https://issues.apache.org/jira/browse/HIVE-9292
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> CBO (Calcite Return Path): Inline GroupBy, Properties
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java
>  3097385b92d4398ee57d3544354b383fe24719dd 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
>  69a5a4409164fc6cb725b315de08ec9d090b7f22 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
> dda4f75592209d88f25b5ca09ea9f32c77ea4ac6 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> c9a5ce53ffc3d5c791e0826be0cac771a4d20254 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
> 0116c85979f02ea0f88bbf8085a7590694eb2dfb 
> 
> Diff: https://reviews.apache.org/r/29763/diff/
> 
> 
> Testing
> ---
> 
> Existing tests.
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>

Re: Review Request 29763: HIVE-9292

2015-01-28 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29763/
---

(Updated Jan. 28, 2015, 7:05 p.m.)


Review request for hive and John Pullokkaran.


Bugs: HIVE-9292
https://issues.apache.org/jira/browse/HIVE-9292


Repository: hive-git


Description
---

CBO (Calcite Return Path): Inline GroupBy, Properties


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java
 3097385b92d4398ee57d3544354b383fe24719dd 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
 69a5a4409164fc6cb725b315de08ec9d090b7f22 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
dda4f75592209d88f25b5ca09ea9f32c77ea4ac6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
c9a5ce53ffc3d5c791e0826be0cac771a4d20254 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
0116c85979f02ea0f88bbf8085a7590694eb2dfb 

Diff: https://reviews.apache.org/r/29763/diff/


Testing
---

Existing tests.


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 29763: HIVE-9292

2015-01-28 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29763/
---

(Updated Jan. 28, 2015, 10:59 a.m.)


Review request for hive and John Pullokkaran.


Changes
---

New patch; addressed John's comments to remove the usage of ParseContext in 
RewriteQueryUsingAggregateIndexCtx after HIVE-9327 went in.


Bugs: HIVE-9292
https://issues.apache.org/jira/browse/HIVE-9292


Repository: hive-git


Description
---

CBO (Calcite Return Path): Inline GroupBy, Properties


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java
 3097385b92d4398ee57d3544354b383fe24719dd 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
 69a5a4409164fc6cb725b315de08ec9d090b7f22 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
dda4f75592209d88f25b5ca09ea9f32c77ea4ac6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
c9a5ce53ffc3d5c791e0826be0cac771a4d20254 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
0116c85979f02ea0f88bbf8085a7590694eb2dfb 

Diff: https://reviews.apache.org/r/29763/diff/


Testing
---

Existing tests.


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 29763: HIVE-9292

2015-01-14 Thread Jesús Camacho Rodríguez 


> On Jan. 13, 2015, 6:59 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java, line 96
> > 
> >
> > It seems like groupOpToInputTables is used only by 
> > RewriteQueryUsingAggregateIndexCtx. Couldn't we get rid of 
> > groupToInputTables from parse context by changing 
> > "RewriteQueryUsingAggregateIndexCtx"?
> 
> Jesús Camacho Rodríguez wrote:
> The method "replaceGroupByOperatorProcess" 1) creates a query in String 
> format, 2) uses "RewriteParseContextGenerator" to create an operator tree 
> from it, and 3) then takes the aggregator from the new operator tree and 
> replaces the old aggregation with it. It does not seem the most elegant way 
> to create the replacement aggregator.
> Do you think that I should rely on any other structure that is already in 
> ParseContext to retrieve the GroupByOperator so the process remains 
> unchanged, or rather you prefer that I rewrite it completely?
> 
> John Pullokkaran wrote:
> The optimization is trying to rewrite GB-TS as GB on IndexTable so as to 
> reduce the scan & aggregation cost. That may be the reason why it generates 
> query string first. You may not want to change this instead just change how 
> it gets hold of GB op (from tree as opposed to parsecontext).

The new patch addresses this issue.


- Jesús


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29763/#review67910
---


On Jan. 14, 2015, 11:26 a.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29763/
> ---
> 
> (Updated Jan. 14, 2015, 11:26 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Bugs: HIVE-9292
> https://issues.apache.org/jira/browse/HIVE-9292
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> CBO (Calcite Return Path): Inline GroupBy, Properties
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyCtx.java 
> b56b6085be2cb2a6c37dcba77a66ab0ce4476af3 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java
>  3097385b92d4398ee57d3544354b383fe24719dd 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
>  fe686d96b642572059ef13129951d01fce4fedce 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
> 8215c26f48f1611d3c64f6df5bcfac02069e3a67 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
> 23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
> 
> Diff: https://reviews.apache.org/r/29763/diff/
> 
> 
> Testing
> ---
> 
> Existing tests.
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>

Re: Review Request 29763: HIVE-9292

2015-01-14 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29763/
---

(Updated Jan. 14, 2015, 11:26 a.m.)


Review request for hive and John Pullokkaran.


Changes
---

Addressed John's comment.


Bugs: HIVE-9292
https://issues.apache.org/jira/browse/HIVE-9292


Repository: hive-git


Description
---

CBO (Calcite Return Path): Inline GroupBy, Properties


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyCtx.java 
b56b6085be2cb2a6c37dcba77a66ab0ce4476af3 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java
 3097385b92d4398ee57d3544354b383fe24719dd 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
 fe686d96b642572059ef13129951d01fce4fedce 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
8215c26f48f1611d3c64f6df5bcfac02069e3a67 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 

Diff: https://reviews.apache.org/r/29763/diff/


Testing
---

Existing tests.


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 29763: HIVE-9292

2015-01-13 Thread John Pullokkaran 


> On Jan. 13, 2015, 6:59 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java, line 96
> > 
> >
> > It seems like groupOpToInputTables is used only by 
> > RewriteQueryUsingAggregateIndexCtx. Couldn't we get rid of 
> > groupToInputTables from parse context by changing 
> > "RewriteQueryUsingAggregateIndexCtx"?
> 
> Jesús Camacho Rodríguez wrote:
> The method "replaceGroupByOperatorProcess" 1) creates a query in String 
> format, 2) uses "RewriteParseContextGenerator" to create an operator tree 
> from it, and 3) then takes the aggregator from the new operator tree and 
> replaces the old aggregation with it. It does not seem the most elegant way 
> to create the replacement aggregator.
> Do you think that I should rely on any other structure that is already in 
> ParseContext to retrieve the GroupByOperator so the process remains 
> unchanged, or rather you prefer that I rewrite it completely?

The optimization is trying to rewrite GB-TS as GB on IndexTable so as to reduce 
the scan & aggregation cost. That may be the reason why it generates query 
string first. You may not want to change this instead just change how it gets 
hold of GB op (from tree as opposed to parsecontext).


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29763/#review67910
---


On Jan. 13, 2015, 9:17 a.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29763/
> ---
> 
> (Updated Jan. 13, 2015, 9:17 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Bugs: HIVE-9292
> https://issues.apache.org/jira/browse/HIVE-9292
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> CBO (Calcite Return Path): Inline GroupBy, Properties
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
>  fe686d96b642572059ef13129951d01fce4fedce 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
> 8215c26f48f1611d3c64f6df5bcfac02069e3a67 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
> 23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 
> 7a0b0da5de5c1c7dc8dd099167e9d06e6b27eea2 
> 
> Diff: https://reviews.apache.org/r/29763/diff/
> 
> 
> Testing
> ---
> 
> Existing tests.
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>

Re: Review Request 29763: HIVE-9292

2015-01-13 Thread Jesús Camacho Rodríguez 


> On Jan. 13, 2015, 6:59 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java, line 96
> > 
> >
> > It seems like groupOpToInputTables is used only by 
> > RewriteQueryUsingAggregateIndexCtx. Couldn't we get rid of 
> > groupToInputTables from parse context by changing 
> > "RewriteQueryUsingAggregateIndexCtx"?

The method "replaceGroupByOperatorProcess" 1) creates a query in String format, 
2) uses "RewriteParseContextGenerator" to create an operator tree from it, and 
3) then takes the aggregator from the new operator tree and replaces the old 
aggregation with it. It does not seem the most elegant way to create the 
replacement aggregator.
Do you think that I should rely on any other structure that is already in 
ParseContext to retrieve the GroupByOperator so the process remains unchanged, 
or rather you prefer that I rewrite it completely?


- Jesús


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29763/#review67910
---


On Jan. 13, 2015, 9:17 a.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29763/
> ---
> 
> (Updated Jan. 13, 2015, 9:17 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Bugs: HIVE-9292
> https://issues.apache.org/jira/browse/HIVE-9292
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> CBO (Calcite Return Path): Inline GroupBy, Properties
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
>  fe686d96b642572059ef13129951d01fce4fedce 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
> 8215c26f48f1611d3c64f6df5bcfac02069e3a67 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
> 23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 
> 7a0b0da5de5c1c7dc8dd099167e9d06e6b27eea2 
> 
> Diff: https://reviews.apache.org/r/29763/diff/
> 
> 
> Testing
> ---
> 
> Existing tests.
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>

Re: Review Request 29763: HIVE-9292

2015-01-13 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29763/#review67910
---



ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java


It seems like groupOpToInputTables is used only by 
RewriteQueryUsingAggregateIndexCtx. Couldn't we get rid of groupToInputTables 
from parse context by changing "RewriteQueryUsingAggregateIndexCtx"?


- John Pullokkaran


On Jan. 13, 2015, 9:17 a.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29763/
> ---
> 
> (Updated Jan. 13, 2015, 9:17 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Bugs: HIVE-9292
> https://issues.apache.org/jira/browse/HIVE-9292
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> CBO (Calcite Return Path): Inline GroupBy, Properties
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
>  fe686d96b642572059ef13129951d01fce4fedce 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
> 8215c26f48f1611d3c64f6df5bcfac02069e3a67 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
> 23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 
> 7a0b0da5de5c1c7dc8dd099167e9d06e6b27eea2 
> 
> Diff: https://reviews.apache.org/r/29763/diff/
> 
> 
> Testing
> ---
> 
> Existing tests.
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>

Re: Review Request 29763: HIVE-9292

2015-01-13 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29763/
---

(Updated Jan. 13, 2015, 9:17 a.m.)


Review request for hive and John Pullokkaran.


Changes
---

Rebased patch after Spark merge.


Bugs: HIVE-9292
https://issues.apache.org/jira/browse/HIVE-9292


Repository: hive-git


Description
---

CBO (Calcite Return Path): Inline GroupBy, Properties


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
 fe686d96b642572059ef13129951d01fce4fedce 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
8215c26f48f1611d3c64f6df5bcfac02069e3a67 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 
7a0b0da5de5c1c7dc8dd099167e9d06e6b27eea2 

Diff: https://reviews.apache.org/r/29763/diff/


Testing
---

Existing tests.


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 29763: HIVE-9292

2015-01-12 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29763/
---

(Updated Jan. 12, 2015, 11:49 a.m.)


Review request for hive and John Pullokkaran.


Bugs: HIVE-9292
https://issues.apache.org/jira/browse/HIVE-9292


Repository: hive-git


Description
---

CBO (Calcite Return Path): Inline GroupBy, Properties


Diffs
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
 fe686d96b642572059ef13129951d01fce4fedce 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
8215c26f48f1611d3c64f6df5bcfac02069e3a67 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
971910a09d33fc2074b6a2d1c4e912b93254a3ca 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 
7a0b0da5de5c1c7dc8dd099167e9d06e6b27eea2 

Diff: https://reviews.apache.org/r/29763/diff/


Testing
---

Existing tests.


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 29763: HIVE-9292

2015-01-09 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29763/
---

(Updated Jan. 9, 2015, 12:29 p.m.)


Review request for hive.


Bugs: HIVE-9292
https://issues.apache.org/jira/browse/HIVE-9292


Repository: hive-git


Description
---

CBO (Calcite Return Path): Inline GroupBy, Properties


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java
 fe686d96b642572059ef13129951d01fce4fedce 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
8215c26f48f1611d3c64f6df5bcfac02069e3a67 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
971910a09d33fc2074b6a2d1c4e912b93254a3ca 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 
7a0b0da5de5c1c7dc8dd099167e9d06e6b27eea2 

Diff: https://reviews.apache.org/r/29763/diff/


Testing
---

Existing tests.


Thanks,

Jesús Camacho Rodríguez