Re: Review Request 38136: CBO: Calcite Operator To Hive Operator (Calcite Return Path): ctas after order by has problem

2015-09-08 Thread pengcheng xiong

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38136/
---

(Updated Sept. 8, 2015, 8:42 p.m.)


Review request for hive and John Pullokkaran.


Repository: hive-git


Description
---

with return path on, "create table b as select * from src order by key" will 
fail. Attached two test cases, one (cbo_rp_cross_product_check_2.q) is to test 
that "create table b as select * from src order by key" will not fail. The 
other(cbo_rp_auto_join17.q) is to correct current wrong table alias on master.


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/PlanModifierForReturnPath.java
 81cc474 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 73ae7c4 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java f6052e3 
  ql/src/test/queries/clientpositive/cbo_rp_auto_join17.q PRE-CREATION 
  ql/src/test/queries/clientpositive/cbo_rp_cross_product_check_2.q 
PRE-CREATION 
  ql/src/test/results/clientpositive/cbo_rp_auto_join17.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
PRE-CREATION 

Diff: https://reviews.apache.org/r/38136/diff/


Testing
---


Thanks,

pengcheng xiong



Re: Review Request 38136: CBO: Calcite Operator To Hive Operator (Calcite Return Path): ctas after order by has problem

2015-09-11 Thread John Pullokkaran

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38136/#review98718
---

Ship it!


Ship It!

- John Pullokkaran


On Sept. 8, 2015, 8:42 p.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38136/
> ---
> 
> (Updated Sept. 8, 2015, 8:42 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> with return path on, "create table b as select * from src order by key" will 
> fail. Attached two test cases, one (cbo_rp_cross_product_check_2.q) is to 
> test that "create table b as select * from src order by key" will not fail. 
> The other(cbo_rp_auto_join17.q) is to correct current wrong table alias on 
> master.
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/PlanModifierForReturnPath.java
>  81cc474 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 73ae7c4 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java f6052e3 
>   ql/src/test/queries/clientpositive/cbo_rp_auto_join17.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/cbo_rp_cross_product_check_2.q 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_auto_join17.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38136/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>