Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-21 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40865/#review111537
---

Ship it!


Ship It!

- John Pullokkaran


On Dec. 21, 2015, 5:44 p.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40865/
> ---
> 
> (Updated Dec. 21, 2015, 5:44 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11927
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
>  336745b 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
>  425514d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
>  631a4ca 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 87b18b7 
>   ql/src/test/queries/clientpositive/cbo_const.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/constantfolding.q PRE-CREATION 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out c4d59c8 
>   ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 277b0f7 
>   ql/src/test/results/clientpositive/cast1.q.out 0bdecba 
>   ql/src/test/results/clientpositive/cbo_const.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 13d8a50 
>   ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out 79f76bf 
>   ql/src/test/results/clientpositive/constantfolding.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cross_product_check_1.q.out d9143c8 
>   ql/src/test/results/clientpositive/cross_product_check_2.q.out 4e2b93e 
>   ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out 3153c7e 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 
>   ql/src/test/results/clientpositive/groupby_ppd.q.out 6164a26 
>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 
>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de 
>   ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e 
>   ql/src/test/results/clientpositive/input_part5.q.out f2d7335 
>   ql/src/test/results/clientpositive/input_part6.q.out fa51cdf 
>   ql/src/test/results/clientpositive/lineage2.q.out ec8b76b 
>   ql/src/test/results/clientpositive/lineage3.q.out 747dc9a 
>   ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 
> be77ba8 
>   ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 79348f3 
>   ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f6d8388 
>   ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out b322ef1 
>   ql/src/test/results/clientpositive/partition_multilevels.q.out c1c8778 
>   ql/src/test/results/clientpositive/perf/query31.q.out 52cbdf4 
>   ql/src/test/results/clientpositive/perf/query39.q.out a18cdaf 
>   ql/src/test/results/clientpositive/perf/query42.q.out 3954829 
>   ql/src/test/results/clientpositive/perf/query52.q.out 63f0bf6 
>   ql/src/test/results/clientpositive/perf/query64.q.out a63 
>   ql/src/test/results/clientpositive/perf/query66.q.out 22eaf61 
>   ql/src/test/results/clientpositive/perf/query75.q.out d54000b 
>   ql/src/test/results/clientpositive/pointlookup2.q.out a442425 
>   ql/src/test/results/clientpositive/quotedid_basic.q.out 519f647 
>   ql/src/test/results/clientpositive/quotedid_partition.q.out d34a005 
>   ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out b5e7846 
>   ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 
> 0656cd5 
>   ql/src/test/results/clientpositive/spark/cross_product_check_2.q.out 
> 2d6eb38 
>   ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out 9043fb1 
>   ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 239e803 
>   ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 
> 8370bbe 
>   ql/src/test/results/clientpositive/spark/union_remove_25.q.out b771fe9 
>   ql/src/test/results/clientpositive/spark/union_view.q.out cce7710 
>   ql/src/test/results/clientpositive/subquery_notin.q.out ed86079 
>   ql/src/test/results/clientpositive/subquery_notin_having.q.java1.7.out 
> d6c6edc 
>   ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out ad5f72b 
>   ql/src/test/results/clientpositive/tez/bucket_map_join_tez1.q.out 9582334 
>   ql/src/test/results/clientpositive/tez/cross_product_check_1.q.out ca44973 
>   ql/src/test/results/clientp

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-21 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40865/#review111536
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
 (line 320)


Remove this code; seems like not used.


- John Pullokkaran


On Dec. 21, 2015, 5:44 p.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40865/
> ---
> 
> (Updated Dec. 21, 2015, 5:44 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11927
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
>  336745b 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
>  425514d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
>  631a4ca 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 87b18b7 
>   ql/src/test/queries/clientpositive/cbo_const.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/constantfolding.q PRE-CREATION 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out c4d59c8 
>   ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 277b0f7 
>   ql/src/test/results/clientpositive/cast1.q.out 0bdecba 
>   ql/src/test/results/clientpositive/cbo_const.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 13d8a50 
>   ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out 79f76bf 
>   ql/src/test/results/clientpositive/constantfolding.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cross_product_check_1.q.out d9143c8 
>   ql/src/test/results/clientpositive/cross_product_check_2.q.out 4e2b93e 
>   ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out 3153c7e 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 
>   ql/src/test/results/clientpositive/groupby_ppd.q.out 6164a26 
>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 
>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de 
>   ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e 
>   ql/src/test/results/clientpositive/input_part5.q.out f2d7335 
>   ql/src/test/results/clientpositive/input_part6.q.out fa51cdf 
>   ql/src/test/results/clientpositive/lineage2.q.out ec8b76b 
>   ql/src/test/results/clientpositive/lineage3.q.out 747dc9a 
>   ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 
> be77ba8 
>   ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 79348f3 
>   ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f6d8388 
>   ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out b322ef1 
>   ql/src/test/results/clientpositive/partition_multilevels.q.out c1c8778 
>   ql/src/test/results/clientpositive/perf/query31.q.out 52cbdf4 
>   ql/src/test/results/clientpositive/perf/query39.q.out a18cdaf 
>   ql/src/test/results/clientpositive/perf/query42.q.out 3954829 
>   ql/src/test/results/clientpositive/perf/query52.q.out 63f0bf6 
>   ql/src/test/results/clientpositive/perf/query64.q.out a63 
>   ql/src/test/results/clientpositive/perf/query66.q.out 22eaf61 
>   ql/src/test/results/clientpositive/perf/query75.q.out d54000b 
>   ql/src/test/results/clientpositive/pointlookup2.q.out a442425 
>   ql/src/test/results/clientpositive/quotedid_basic.q.out 519f647 
>   ql/src/test/results/clientpositive/quotedid_partition.q.out d34a005 
>   ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out b5e7846 
>   ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 
> 0656cd5 
>   ql/src/test/results/clientpositive/spark/cross_product_check_2.q.out 
> 2d6eb38 
>   ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out 9043fb1 
>   ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 239e803 
>   ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 
> 8370bbe 
>   ql/src/test/results/clientpositive/spark/union_remove_25.q.out b771fe9 
>   ql/src/test/results/clientpositive/spark/union_view.q.out cce7710 
>   ql/src/test/results/clientpositive/subquery_notin.q.out ed86079 
>   ql/src/test/results/clientpositive/subquery_notin_having.q.java1.7.out 
> d6c6edc 
>   ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out ad5f72b 
>   ql

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-21 Thread pengcheng xiong 


> On Dec. 19, 2015, 2:44 a.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java,
> >  line 320
> > 
> >
> > Rename class?

CalcReduceExpression is not used in Hive right now. We can remove it or just 
keep it as a place holder.


- pengcheng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40865/#review111351
---


On Dec. 21, 2015, 5:44 p.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40865/
> ---
> 
> (Updated Dec. 21, 2015, 5:44 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11927
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
>  336745b 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
>  425514d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
>  631a4ca 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 87b18b7 
>   ql/src/test/queries/clientpositive/cbo_const.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/constantfolding.q PRE-CREATION 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out c4d59c8 
>   ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 277b0f7 
>   ql/src/test/results/clientpositive/cast1.q.out 0bdecba 
>   ql/src/test/results/clientpositive/cbo_const.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 13d8a50 
>   ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out 79f76bf 
>   ql/src/test/results/clientpositive/constantfolding.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cross_product_check_1.q.out d9143c8 
>   ql/src/test/results/clientpositive/cross_product_check_2.q.out 4e2b93e 
>   ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out 3153c7e 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 
>   ql/src/test/results/clientpositive/groupby_ppd.q.out 6164a26 
>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 
>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de 
>   ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e 
>   ql/src/test/results/clientpositive/input_part5.q.out f2d7335 
>   ql/src/test/results/clientpositive/input_part6.q.out fa51cdf 
>   ql/src/test/results/clientpositive/lineage2.q.out ec8b76b 
>   ql/src/test/results/clientpositive/lineage3.q.out 747dc9a 
>   ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 
> be77ba8 
>   ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 79348f3 
>   ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f6d8388 
>   ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out b322ef1 
>   ql/src/test/results/clientpositive/partition_multilevels.q.out c1c8778 
>   ql/src/test/results/clientpositive/perf/query31.q.out 52cbdf4 
>   ql/src/test/results/clientpositive/perf/query39.q.out a18cdaf 
>   ql/src/test/results/clientpositive/perf/query42.q.out 3954829 
>   ql/src/test/results/clientpositive/perf/query52.q.out 63f0bf6 
>   ql/src/test/results/clientpositive/perf/query64.q.out a63 
>   ql/src/test/results/clientpositive/perf/query66.q.out 22eaf61 
>   ql/src/test/results/clientpositive/perf/query75.q.out d54000b 
>   ql/src/test/results/clientpositive/pointlookup2.q.out a442425 
>   ql/src/test/results/clientpositive/quotedid_basic.q.out 519f647 
>   ql/src/test/results/clientpositive/quotedid_partition.q.out d34a005 
>   ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out b5e7846 
>   ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 
> 0656cd5 
>   ql/src/test/results/clientpositive/spark/cross_product_check_2.q.out 
> 2d6eb38 
>   ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out 9043fb1 
>   ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 239e803 
>   ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 
> 8370bbe 
>   ql/src/test/results/clientpositive/spark/union_remove_25.q.out b771fe9 
>   ql/src/test/results/clientpositive/spark/union_view.q.out cce7710 
>   ql/src/test/results/clientpositive/subquery_notin.q.out ed86079 
>

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-21 Thread pengcheng xiong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40865/
---

(Updated Dec. 21, 2015, 5:44 p.m.)


Review request for hive and John Pullokkaran.


Changes
---

address John's comments


Repository: hive-git


Description
---

HIVE-11927


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
 336745b 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
 425514d 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
 631a4ca 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 87b18b7 
  ql/src/test/queries/clientpositive/cbo_const.q PRE-CREATION 
  ql/src/test/queries/clientpositive/constantfolding.q PRE-CREATION 
  ql/src/test/results/clientpositive/annotate_stats_select.q.out c4d59c8 
  ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 277b0f7 
  ql/src/test/results/clientpositive/cast1.q.out 0bdecba 
  ql/src/test/results/clientpositive/cbo_const.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 13d8a50 
  ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out 79f76bf 
  ql/src/test/results/clientpositive/constantfolding.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cross_product_check_1.q.out d9143c8 
  ql/src/test/results/clientpositive/cross_product_check_2.q.out 4e2b93e 
  ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out 3153c7e 
  ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 
  ql/src/test/results/clientpositive/groupby_ppd.q.out 6164a26 
  ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 
  ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de 
  ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e 
  ql/src/test/results/clientpositive/input_part5.q.out f2d7335 
  ql/src/test/results/clientpositive/input_part6.q.out fa51cdf 
  ql/src/test/results/clientpositive/lineage2.q.out ec8b76b 
  ql/src/test/results/clientpositive/lineage3.q.out 747dc9a 
  ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out be77ba8 
  ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 79348f3 
  ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f6d8388 
  ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out b322ef1 
  ql/src/test/results/clientpositive/partition_multilevels.q.out c1c8778 
  ql/src/test/results/clientpositive/perf/query31.q.out 52cbdf4 
  ql/src/test/results/clientpositive/perf/query39.q.out a18cdaf 
  ql/src/test/results/clientpositive/perf/query42.q.out 3954829 
  ql/src/test/results/clientpositive/perf/query52.q.out 63f0bf6 
  ql/src/test/results/clientpositive/perf/query64.q.out a63 
  ql/src/test/results/clientpositive/perf/query66.q.out 22eaf61 
  ql/src/test/results/clientpositive/perf/query75.q.out d54000b 
  ql/src/test/results/clientpositive/pointlookup2.q.out a442425 
  ql/src/test/results/clientpositive/quotedid_basic.q.out 519f647 
  ql/src/test/results/clientpositive/quotedid_partition.q.out d34a005 
  ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out b5e7846 
  ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 0656cd5 
  ql/src/test/results/clientpositive/spark/cross_product_check_2.q.out 2d6eb38 
  ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out 9043fb1 
  ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 239e803 
  ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 8370bbe 
  ql/src/test/results/clientpositive/spark/union_remove_25.q.out b771fe9 
  ql/src/test/results/clientpositive/spark/union_view.q.out cce7710 
  ql/src/test/results/clientpositive/subquery_notin.q.out ed86079 
  ql/src/test/results/clientpositive/subquery_notin_having.q.java1.7.out 
d6c6edc 
  ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out ad5f72b 
  ql/src/test/results/clientpositive/tez/bucket_map_join_tez1.q.out 9582334 
  ql/src/test/results/clientpositive/tez/cross_product_check_1.q.out ca44973 
  ql/src/test/results/clientpositive/tez/cross_product_check_2.q.out ecd7f6b 
  ql/src/test/results/clientpositive/tez/dynpart_sort_optimization2.q.out 
346e52f 
  ql/src/test/results/clientpositive/tez/explainuser_1.q.out 78c68c3 
  ql/src/test/results/clientpositive/tez/vector_decimal_round.q.out 9a5d047 
  ql/src/test/results/clientpositive/udf1.q.out dffbccf 
  ql/src/test/results/clientpositive/udf_10_trims.q.out 2f79723 
  ql/src/test/results/clientpositive/udf_folder_constants.q.out 383

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-18 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40865/#review111351
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
 (line 320)


Rename class?


- John Pullokkaran


On Dec. 19, 2015, 12:28 a.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40865/
> ---
> 
> (Updated Dec. 19, 2015, 12:28 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11927
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
>  336745b 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
>  425514d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
>  3f2267d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
>  631a4ca 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
>  2825f77 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 7c5a43f 
>   ql/src/test/queries/clientpositive/cbo_const.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/constantfolding.q PRE-CREATION 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out c4d59c8 
>   ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 277b0f7 
>   ql/src/test/results/clientpositive/cast1.q.out 0bdecba 
>   ql/src/test/results/clientpositive/cbo_const.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b 
>   ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out b14caa8 
>   ql/src/test/results/clientpositive/constantfolding.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cross_product_check_1.q.out e7d6900 
>   ql/src/test/results/clientpositive/cross_product_check_2.q.out df438c9 
>   ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out b85d387 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 
>   ql/src/test/results/clientpositive/groupby_ppd.q.out 6164a26 
>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 
>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de 
>   ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e 
>   ql/src/test/results/clientpositive/input_part5.q.out f2d7335 
>   ql/src/test/results/clientpositive/input_part6.q.out fa51cdf 
>   ql/src/test/results/clientpositive/lineage2.q.out ec8b76b 
>   ql/src/test/results/clientpositive/lineage3.q.out 747dc9a 
>   ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 
> be77ba8 
>   ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 79348f3 
>   ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f6d8388 
>   ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out b322ef1 
>   ql/src/test/results/clientpositive/partition_multilevels.q.out c1c8778 
>   ql/src/test/results/clientpositive/perf/query31.q.out c479d91 
>   ql/src/test/results/clientpositive/perf/query39.q.out 0ad62cc 
>   ql/src/test/results/clientpositive/perf/query42.q.out a3264c7 
>   ql/src/test/results/clientpositive/perf/query52.q.out ac0c1e6 
>   ql/src/test/results/clientpositive/perf/query64.q.out 9735b45 
>   ql/src/test/results/clientpositive/perf/query66.q.out 42bcb83 
>   ql/src/test/results/clientpositive/perf/query75.q.out 70a1649 
>   ql/src/test/results/clientpositive/pointlookup2.q.out a442425 
>   ql/src/test/results/clientpositive/quotedid_basic.q.out 519f647 
>   ql/src/test/results/clientpositive/quotedid_partition.q.out d34a005 
>   ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out b5e7846 
>   ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 
> 5b03dcf 
>   ql/src/test/results/clientpositive/spark/cross_product_check_2.q.out 
> 93c502d 
>   ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out b597ebd 
>   ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 239e803 
>   ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 
> 8370bbe 
>   ql/src/test/results/clientpositive/spark/union_remove_25.q.out b771fe9 
>   ql/src/test/results/clientpositive/spark/union_view.q.out cce7710 
>   ql/src/test/results/clientpositive/subquery_notin.q.

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-18 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40865/#review111349
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
 (line 396)


Not sure about isInfinite.



ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 1210)


Could we add executor to previous hepPlan and check for null



ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 1267)


Could we add executor to previous hepPlan and check for null


- John Pullokkaran


On Dec. 19, 2015, 12:28 a.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40865/
> ---
> 
> (Updated Dec. 19, 2015, 12:28 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11927
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
>  336745b 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
>  425514d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
>  3f2267d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
>  631a4ca 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
>  2825f77 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 7c5a43f 
>   ql/src/test/queries/clientpositive/cbo_const.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/constantfolding.q PRE-CREATION 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out c4d59c8 
>   ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 277b0f7 
>   ql/src/test/results/clientpositive/cast1.q.out 0bdecba 
>   ql/src/test/results/clientpositive/cbo_const.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b 
>   ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out b14caa8 
>   ql/src/test/results/clientpositive/constantfolding.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cross_product_check_1.q.out e7d6900 
>   ql/src/test/results/clientpositive/cross_product_check_2.q.out df438c9 
>   ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out b85d387 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 
>   ql/src/test/results/clientpositive/groupby_ppd.q.out 6164a26 
>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 
>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de 
>   ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e 
>   ql/src/test/results/clientpositive/input_part5.q.out f2d7335 
>   ql/src/test/results/clientpositive/input_part6.q.out fa51cdf 
>   ql/src/test/results/clientpositive/lineage2.q.out ec8b76b 
>   ql/src/test/results/clientpositive/lineage3.q.out 747dc9a 
>   ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 
> be77ba8 
>   ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 79348f3 
>   ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f6d8388 
>   ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out b322ef1 
>   ql/src/test/results/clientpositive/partition_multilevels.q.out c1c8778 
>   ql/src/test/results/clientpositive/perf/query31.q.out c479d91 
>   ql/src/test/results/clientpositive/perf/query39.q.out 0ad62cc 
>   ql/src/test/results/clientpositive/perf/query42.q.out a3264c7 
>   ql/src/test/results/clientpositive/perf/query52.q.out ac0c1e6 
>   ql/src/test/results/clientpositive/perf/query64.q.out 9735b45 
>   ql/src/test/results/clientpositive/perf/query66.q.out 42bcb83 
>   ql/src/test/results/clientpositive/perf/query75.q.out 70a1649 
>   ql/src/test/results/clientpositive/pointlookup2.q.out a442425 
>   ql/src/test/results/clientpositive/quotedid_basic.q.out 519f647 
>   ql/src/test/results/clientpositive/quotedid_partition.q.out d34a005 
>   ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out b5e7846 
>   ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 
> 5b03dcf 
>   ql/src/test/results/clientpositive/spark/cross_product_check_2.q.out 
> 93c502d 
>   ql/src/test/results/clientpositive/spa

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-18 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40865/#review111348
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
 (line 334)


Hive's null literal has void type.
This is handled down in void switch.

So we might want to switch calcite null literal to void.


- John Pullokkaran


On Dec. 19, 2015, 12:28 a.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40865/
> ---
> 
> (Updated Dec. 19, 2015, 12:28 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11927
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
>  336745b 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
>  425514d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
>  3f2267d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
>  631a4ca 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
>  2825f77 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 7c5a43f 
>   ql/src/test/queries/clientpositive/cbo_const.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/constantfolding.q PRE-CREATION 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out c4d59c8 
>   ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 277b0f7 
>   ql/src/test/results/clientpositive/cast1.q.out 0bdecba 
>   ql/src/test/results/clientpositive/cbo_const.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b 
>   ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out b14caa8 
>   ql/src/test/results/clientpositive/constantfolding.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cross_product_check_1.q.out e7d6900 
>   ql/src/test/results/clientpositive/cross_product_check_2.q.out df438c9 
>   ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out b85d387 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 
>   ql/src/test/results/clientpositive/groupby_ppd.q.out 6164a26 
>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 
>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de 
>   ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e 
>   ql/src/test/results/clientpositive/input_part5.q.out f2d7335 
>   ql/src/test/results/clientpositive/input_part6.q.out fa51cdf 
>   ql/src/test/results/clientpositive/lineage2.q.out ec8b76b 
>   ql/src/test/results/clientpositive/lineage3.q.out 747dc9a 
>   ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 
> be77ba8 
>   ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 79348f3 
>   ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f6d8388 
>   ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out b322ef1 
>   ql/src/test/results/clientpositive/partition_multilevels.q.out c1c8778 
>   ql/src/test/results/clientpositive/perf/query31.q.out c479d91 
>   ql/src/test/results/clientpositive/perf/query39.q.out 0ad62cc 
>   ql/src/test/results/clientpositive/perf/query42.q.out a3264c7 
>   ql/src/test/results/clientpositive/perf/query52.q.out ac0c1e6 
>   ql/src/test/results/clientpositive/perf/query64.q.out 9735b45 
>   ql/src/test/results/clientpositive/perf/query66.q.out 42bcb83 
>   ql/src/test/results/clientpositive/perf/query75.q.out 70a1649 
>   ql/src/test/results/clientpositive/pointlookup2.q.out a442425 
>   ql/src/test/results/clientpositive/quotedid_basic.q.out 519f647 
>   ql/src/test/results/clientpositive/quotedid_partition.q.out d34a005 
>   ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out b5e7846 
>   ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 
> 5b03dcf 
>   ql/src/test/results/clientpositive/spark/cross_product_check_2.q.out 
> 93c502d 
>   ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out b597ebd 
>   ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 239e803 
>   ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 
> 8370bbe 
>   ql/src/test/results/clientpositive/spark/union_remove_25.q.out b771fe9 
>

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-18 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40865/#review111345
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
 (line 183)


Encoding binary as string literal wouldn't this result in lossy translation?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
 (line 249)


Why add milli seconds?


- John Pullokkaran


On Dec. 19, 2015, 12:28 a.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40865/
> ---
> 
> (Updated Dec. 19, 2015, 12:28 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11927
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
>  336745b 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
>  425514d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
>  3f2267d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
>  631a4ca 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
>  2825f77 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 7c5a43f 
>   ql/src/test/queries/clientpositive/cbo_const.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/constantfolding.q PRE-CREATION 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out c4d59c8 
>   ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 277b0f7 
>   ql/src/test/results/clientpositive/cast1.q.out 0bdecba 
>   ql/src/test/results/clientpositive/cbo_const.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b 
>   ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out b14caa8 
>   ql/src/test/results/clientpositive/constantfolding.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cross_product_check_1.q.out e7d6900 
>   ql/src/test/results/clientpositive/cross_product_check_2.q.out df438c9 
>   ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out b85d387 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 
>   ql/src/test/results/clientpositive/groupby_ppd.q.out 6164a26 
>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 
>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de 
>   ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e 
>   ql/src/test/results/clientpositive/input_part5.q.out f2d7335 
>   ql/src/test/results/clientpositive/input_part6.q.out fa51cdf 
>   ql/src/test/results/clientpositive/lineage2.q.out ec8b76b 
>   ql/src/test/results/clientpositive/lineage3.q.out 747dc9a 
>   ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 
> be77ba8 
>   ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 79348f3 
>   ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f6d8388 
>   ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out b322ef1 
>   ql/src/test/results/clientpositive/partition_multilevels.q.out c1c8778 
>   ql/src/test/results/clientpositive/perf/query31.q.out c479d91 
>   ql/src/test/results/clientpositive/perf/query39.q.out 0ad62cc 
>   ql/src/test/results/clientpositive/perf/query42.q.out a3264c7 
>   ql/src/test/results/clientpositive/perf/query52.q.out ac0c1e6 
>   ql/src/test/results/clientpositive/perf/query64.q.out 9735b45 
>   ql/src/test/results/clientpositive/perf/query66.q.out 42bcb83 
>   ql/src/test/results/clientpositive/perf/query75.q.out 70a1649 
>   ql/src/test/results/clientpositive/pointlookup2.q.out a442425 
>   ql/src/test/results/clientpositive/quotedid_basic.q.out 519f647 
>   ql/src/test/results/clientpositive/quotedid_partition.q.out d34a005 
>   ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out b5e7846 
>   ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 
> 5b03dcf 
>   ql/src/test/results/clientpositive/spark/cross_product_check_2.q.out 
> 93c502d 
>   ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out b597ebd 
>   ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 239e803 
>   ql/src/test/results/clientpositive/spark/groupby_sort_

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-18 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40865/#review111344
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
 (line 325)


This is a change in interface.
Instead of translating a type now we are translating a RexCall.



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
 (line 348)


Why are we looking at operands arguments?


- John Pullokkaran


On Dec. 19, 2015, 12:28 a.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40865/
> ---
> 
> (Updated Dec. 19, 2015, 12:28 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11927
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
>  336745b 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
>  425514d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
>  3f2267d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
>  631a4ca 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
>  2825f77 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 7c5a43f 
>   ql/src/test/queries/clientpositive/cbo_const.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/constantfolding.q PRE-CREATION 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out c4d59c8 
>   ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 277b0f7 
>   ql/src/test/results/clientpositive/cast1.q.out 0bdecba 
>   ql/src/test/results/clientpositive/cbo_const.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b 
>   ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out b14caa8 
>   ql/src/test/results/clientpositive/constantfolding.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cross_product_check_1.q.out e7d6900 
>   ql/src/test/results/clientpositive/cross_product_check_2.q.out df438c9 
>   ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out b85d387 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 
>   ql/src/test/results/clientpositive/groupby_ppd.q.out 6164a26 
>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 
>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de 
>   ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e 
>   ql/src/test/results/clientpositive/input_part5.q.out f2d7335 
>   ql/src/test/results/clientpositive/input_part6.q.out fa51cdf 
>   ql/src/test/results/clientpositive/lineage2.q.out ec8b76b 
>   ql/src/test/results/clientpositive/lineage3.q.out 747dc9a 
>   ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 
> be77ba8 
>   ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 79348f3 
>   ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f6d8388 
>   ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out b322ef1 
>   ql/src/test/results/clientpositive/partition_multilevels.q.out c1c8778 
>   ql/src/test/results/clientpositive/perf/query31.q.out c479d91 
>   ql/src/test/results/clientpositive/perf/query39.q.out 0ad62cc 
>   ql/src/test/results/clientpositive/perf/query42.q.out a3264c7 
>   ql/src/test/results/clientpositive/perf/query52.q.out ac0c1e6 
>   ql/src/test/results/clientpositive/perf/query64.q.out 9735b45 
>   ql/src/test/results/clientpositive/perf/query66.q.out 42bcb83 
>   ql/src/test/results/clientpositive/perf/query75.q.out 70a1649 
>   ql/src/test/results/clientpositive/pointlookup2.q.out a442425 
>   ql/src/test/results/clientpositive/quotedid_basic.q.out 519f647 
>   ql/src/test/results/clientpositive/quotedid_partition.q.out d34a005 
>   ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out b5e7846 
>   ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 
> 5b03dcf 
>   ql/src/test/results/clientpositive/spark/cross_product_check_2.q.out 
> 93c502d 
>   ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out b597ebd 
>   ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 239e803 
>   ql/src/

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-18 Thread pengcheng xiong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40865/
---

(Updated Dec. 19, 2015, 12:28 a.m.)


Review request for hive and John Pullokkaran.


Changes
---

address john's comments. rebase for relfactories.


Repository: hive-git


Description
---

HIVE-11927


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
 336745b 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
 425514d 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
 3f2267d 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
 631a4ca 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
 2825f77 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 7c5a43f 
  ql/src/test/queries/clientpositive/cbo_const.q PRE-CREATION 
  ql/src/test/queries/clientpositive/constantfolding.q PRE-CREATION 
  ql/src/test/results/clientpositive/annotate_stats_select.q.out c4d59c8 
  ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 277b0f7 
  ql/src/test/results/clientpositive/cast1.q.out 0bdecba 
  ql/src/test/results/clientpositive/cbo_const.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 62b611b 
  ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out b14caa8 
  ql/src/test/results/clientpositive/constantfolding.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cross_product_check_1.q.out e7d6900 
  ql/src/test/results/clientpositive/cross_product_check_2.q.out df438c9 
  ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out b85d387 
  ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 
  ql/src/test/results/clientpositive/groupby_ppd.q.out 6164a26 
  ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 
  ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de 
  ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e 
  ql/src/test/results/clientpositive/input_part5.q.out f2d7335 
  ql/src/test/results/clientpositive/input_part6.q.out fa51cdf 
  ql/src/test/results/clientpositive/lineage2.q.out ec8b76b 
  ql/src/test/results/clientpositive/lineage3.q.out 747dc9a 
  ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out be77ba8 
  ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 79348f3 
  ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f6d8388 
  ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out b322ef1 
  ql/src/test/results/clientpositive/partition_multilevels.q.out c1c8778 
  ql/src/test/results/clientpositive/perf/query31.q.out c479d91 
  ql/src/test/results/clientpositive/perf/query39.q.out 0ad62cc 
  ql/src/test/results/clientpositive/perf/query42.q.out a3264c7 
  ql/src/test/results/clientpositive/perf/query52.q.out ac0c1e6 
  ql/src/test/results/clientpositive/perf/query64.q.out 9735b45 
  ql/src/test/results/clientpositive/perf/query66.q.out 42bcb83 
  ql/src/test/results/clientpositive/perf/query75.q.out 70a1649 
  ql/src/test/results/clientpositive/pointlookup2.q.out a442425 
  ql/src/test/results/clientpositive/quotedid_basic.q.out 519f647 
  ql/src/test/results/clientpositive/quotedid_partition.q.out d34a005 
  ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out b5e7846 
  ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 5b03dcf 
  ql/src/test/results/clientpositive/spark/cross_product_check_2.q.out 93c502d 
  ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out b597ebd 
  ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 239e803 
  ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 8370bbe 
  ql/src/test/results/clientpositive/spark/union_remove_25.q.out b771fe9 
  ql/src/test/results/clientpositive/spark/union_view.q.out cce7710 
  ql/src/test/results/clientpositive/subquery_notin.q.out ed86079 
  ql/src/test/results/clientpositive/subquery_notin_having.q.java1.7.out 
7b7ccda 
  ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out 3241787 
  ql/src/test/results/clientpositive/tez/bucket_map_join_tez1.q.out 9582334 
  ql/src/test/results/clientpositive/tez/cross_product_check_1.q.out 0e7c681 
  ql/src/test/results/clientpositive/tez/cross_product_check_2.q.out efd8b5d 
  ql/src/test/results/clientpositive/tez/dynpart_sort_optimization2.q.out 
346e52f 
  ql/src/test/results/clientpositive/tez/explainuser_1.q.out c081309 
  ql/src/test/results/clientpositive/tez/v

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-16 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40865/#review110836
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
 (line 43)


Nit Pick: trailing space



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
 (line 63)


Why are we printing stack trace?
Log it instead



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
 (line 235)


Nit Pick: space


- John Pullokkaran


On Dec. 17, 2015, 1:26 a.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40865/
> ---
> 
> (Updated Dec. 17, 2015, 1:26 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11927
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
>  336745b 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelFactories.java 
> PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
>  425514d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
>  3f2267d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
>  631a4ca 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
>  2825f77 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 36a12bf 
>   ql/src/test/queries/clientpositive/cbo_const.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/constantfolding.q PRE-CREATION 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out c4d59c8 
>   ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 277b0f7 
>   ql/src/test/results/clientpositive/cast1.q.out 0bdecba 
>   ql/src/test/results/clientpositive/cbo_const.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b 
>   ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out b14caa8 
>   ql/src/test/results/clientpositive/constantfolding.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cross_product_check_1.q.out e7d6900 
>   ql/src/test/results/clientpositive/cross_product_check_2.q.out df438c9 
>   ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out b85d387 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 
>   ql/src/test/results/clientpositive/groupby_ppd.q.out 6164a26 
>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 
>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de 
>   ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e 
>   ql/src/test/results/clientpositive/input_part5.q.out f2d7335 
>   ql/src/test/results/clientpositive/input_part6.q.out fa51cdf 
>   ql/src/test/results/clientpositive/lineage2.q.out ec8b76b 
>   ql/src/test/results/clientpositive/lineage3.q.out 747dc9a 
>   ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 
> be77ba8 
>   ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 79348f3 
>   ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f6d8388 
>   ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out b322ef1 
>   ql/src/test/results/clientpositive/partition_multilevels.q.out c1c8778 
>   ql/src/test/results/clientpositive/perf/query31.q.out c479d91 
>   ql/src/test/results/clientpositive/perf/query39.q.out 0ad62cc 
>   ql/src/test/results/clientpositive/perf/query42.q.out a3264c7 
>   ql/src/test/results/clientpositive/perf/query52.q.out ac0c1e6 
>   ql/src/test/results/clientpositive/perf/query64.q.out 9735b45 
>   ql/src/test/results/clientpositive/perf/query66.q.out 42bcb83 
>   ql/src/test/results/clientpositive/perf/query75.q.out 70a1649 
>   ql/src/test/results/clientpositive/pointlookup2.q.out a442425 
>   ql/src/test/results/clientpositive/quotedid_basic.q.out 519f647 
>   ql/src/test/results/clientpositive/quotedid_partition.q.out d34a005 
>   ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out b5e7846 
>   ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 
> 5b03dcf 
>   ql/src/test/results/clientpositive/spark/cr

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-16 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40865/#review110835
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelFactories.java 
(line 41)


Remove trailing space.


- John Pullokkaran


On Dec. 17, 2015, 1:26 a.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40865/
> ---
> 
> (Updated Dec. 17, 2015, 1:26 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11927
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
>  336745b 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelFactories.java 
> PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
>  425514d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
>  3f2267d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
>  631a4ca 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
>  2825f77 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 36a12bf 
>   ql/src/test/queries/clientpositive/cbo_const.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/constantfolding.q PRE-CREATION 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out c4d59c8 
>   ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 277b0f7 
>   ql/src/test/results/clientpositive/cast1.q.out 0bdecba 
>   ql/src/test/results/clientpositive/cbo_const.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b 
>   ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out b14caa8 
>   ql/src/test/results/clientpositive/constantfolding.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cross_product_check_1.q.out e7d6900 
>   ql/src/test/results/clientpositive/cross_product_check_2.q.out df438c9 
>   ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out b85d387 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 
>   ql/src/test/results/clientpositive/groupby_ppd.q.out 6164a26 
>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 
>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de 
>   ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e 
>   ql/src/test/results/clientpositive/input_part5.q.out f2d7335 
>   ql/src/test/results/clientpositive/input_part6.q.out fa51cdf 
>   ql/src/test/results/clientpositive/lineage2.q.out ec8b76b 
>   ql/src/test/results/clientpositive/lineage3.q.out 747dc9a 
>   ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 
> be77ba8 
>   ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 79348f3 
>   ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f6d8388 
>   ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out b322ef1 
>   ql/src/test/results/clientpositive/partition_multilevels.q.out c1c8778 
>   ql/src/test/results/clientpositive/perf/query31.q.out c479d91 
>   ql/src/test/results/clientpositive/perf/query39.q.out 0ad62cc 
>   ql/src/test/results/clientpositive/perf/query42.q.out a3264c7 
>   ql/src/test/results/clientpositive/perf/query52.q.out ac0c1e6 
>   ql/src/test/results/clientpositive/perf/query64.q.out 9735b45 
>   ql/src/test/results/clientpositive/perf/query66.q.out 42bcb83 
>   ql/src/test/results/clientpositive/perf/query75.q.out 70a1649 
>   ql/src/test/results/clientpositive/pointlookup2.q.out a442425 
>   ql/src/test/results/clientpositive/quotedid_basic.q.out 519f647 
>   ql/src/test/results/clientpositive/quotedid_partition.q.out d34a005 
>   ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out b5e7846 
>   ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 
> 5b03dcf 
>   ql/src/test/results/clientpositive/spark/cross_product_check_2.q.out 
> 93c502d 
>   ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out b597ebd 
>   ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 239e803 
>   ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 
> 8370bbe 
>   ql/src/test/results/clientpositive/spark/union_remove_25.q.out b771fe9 
>   ql/src/test/results/clientposi

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-16 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40865/#review110834
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelFactories.java 
(line 49)


What about rest of the factories?


- John Pullokkaran


On Dec. 17, 2015, 1:26 a.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40865/
> ---
> 
> (Updated Dec. 17, 2015, 1:26 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11927
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
>  336745b 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelFactories.java 
> PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
>  425514d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
>  3f2267d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
>  631a4ca 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
>  2825f77 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 36a12bf 
>   ql/src/test/queries/clientpositive/cbo_const.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/constantfolding.q PRE-CREATION 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out c4d59c8 
>   ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 277b0f7 
>   ql/src/test/results/clientpositive/cast1.q.out 0bdecba 
>   ql/src/test/results/clientpositive/cbo_const.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b 
>   ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out b14caa8 
>   ql/src/test/results/clientpositive/constantfolding.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cross_product_check_1.q.out e7d6900 
>   ql/src/test/results/clientpositive/cross_product_check_2.q.out df438c9 
>   ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out b85d387 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 
>   ql/src/test/results/clientpositive/groupby_ppd.q.out 6164a26 
>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 
>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de 
>   ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e 
>   ql/src/test/results/clientpositive/input_part5.q.out f2d7335 
>   ql/src/test/results/clientpositive/input_part6.q.out fa51cdf 
>   ql/src/test/results/clientpositive/lineage2.q.out ec8b76b 
>   ql/src/test/results/clientpositive/lineage3.q.out 747dc9a 
>   ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 
> be77ba8 
>   ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 79348f3 
>   ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f6d8388 
>   ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out b322ef1 
>   ql/src/test/results/clientpositive/partition_multilevels.q.out c1c8778 
>   ql/src/test/results/clientpositive/perf/query31.q.out c479d91 
>   ql/src/test/results/clientpositive/perf/query39.q.out 0ad62cc 
>   ql/src/test/results/clientpositive/perf/query42.q.out a3264c7 
>   ql/src/test/results/clientpositive/perf/query52.q.out ac0c1e6 
>   ql/src/test/results/clientpositive/perf/query64.q.out 9735b45 
>   ql/src/test/results/clientpositive/perf/query66.q.out 42bcb83 
>   ql/src/test/results/clientpositive/perf/query75.q.out 70a1649 
>   ql/src/test/results/clientpositive/pointlookup2.q.out a442425 
>   ql/src/test/results/clientpositive/quotedid_basic.q.out 519f647 
>   ql/src/test/results/clientpositive/quotedid_partition.q.out d34a005 
>   ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out b5e7846 
>   ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 
> 5b03dcf 
>   ql/src/test/results/clientpositive/spark/cross_product_check_2.q.out 
> 93c502d 
>   ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out b597ebd 
>   ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 239e803 
>   ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 
> 8370bbe 
>   ql/src/test/results/clientpositive/spark/union_remove_25.q.out b771fe9 
>   ql/src/test/results

Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants

2015-12-16 Thread pengcheng xiong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40865/
---

(Updated Dec. 17, 2015, 1:26 a.m.)


Review request for hive and John Pullokkaran.


Repository: hive-git


Description
---

HIVE-11927


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
 336745b 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelFactories.java 
PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
 425514d 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
 3f2267d 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
 631a4ca 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
 2825f77 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 36a12bf 
  ql/src/test/queries/clientpositive/cbo_const.q PRE-CREATION 
  ql/src/test/queries/clientpositive/constantfolding.q PRE-CREATION 
  ql/src/test/results/clientpositive/annotate_stats_select.q.out c4d59c8 
  ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 277b0f7 
  ql/src/test/results/clientpositive/cast1.q.out 0bdecba 
  ql/src/test/results/clientpositive/cbo_const.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 62b611b 
  ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out b14caa8 
  ql/src/test/results/clientpositive/constantfolding.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cross_product_check_1.q.out e7d6900 
  ql/src/test/results/clientpositive/cross_product_check_2.q.out df438c9 
  ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out b85d387 
  ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 
  ql/src/test/results/clientpositive/groupby_ppd.q.out 6164a26 
  ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 
  ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de 
  ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e 
  ql/src/test/results/clientpositive/input_part5.q.out f2d7335 
  ql/src/test/results/clientpositive/input_part6.q.out fa51cdf 
  ql/src/test/results/clientpositive/lineage2.q.out ec8b76b 
  ql/src/test/results/clientpositive/lineage3.q.out 747dc9a 
  ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out be77ba8 
  ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 79348f3 
  ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f6d8388 
  ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out b322ef1 
  ql/src/test/results/clientpositive/partition_multilevels.q.out c1c8778 
  ql/src/test/results/clientpositive/perf/query31.q.out c479d91 
  ql/src/test/results/clientpositive/perf/query39.q.out 0ad62cc 
  ql/src/test/results/clientpositive/perf/query42.q.out a3264c7 
  ql/src/test/results/clientpositive/perf/query52.q.out ac0c1e6 
  ql/src/test/results/clientpositive/perf/query64.q.out 9735b45 
  ql/src/test/results/clientpositive/perf/query66.q.out 42bcb83 
  ql/src/test/results/clientpositive/perf/query75.q.out 70a1649 
  ql/src/test/results/clientpositive/pointlookup2.q.out a442425 
  ql/src/test/results/clientpositive/quotedid_basic.q.out 519f647 
  ql/src/test/results/clientpositive/quotedid_partition.q.out d34a005 
  ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out b5e7846 
  ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 5b03dcf 
  ql/src/test/results/clientpositive/spark/cross_product_check_2.q.out 93c502d 
  ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out b597ebd 
  ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 239e803 
  ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 8370bbe 
  ql/src/test/results/clientpositive/spark/union_remove_25.q.out b771fe9 
  ql/src/test/results/clientpositive/spark/union_view.q.out cce7710 
  ql/src/test/results/clientpositive/subquery_notin.q.out ed86079 
  ql/src/test/results/clientpositive/subquery_notin_having.q.java1.7.out 
7b7ccda 
  ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out 3241787 
  ql/src/test/results/clientpositive/tez/bucket_map_join_tez1.q.out 9582334 
  ql/src/test/results/clientpositive/tez/cross_product_check_1.q.out 0e7c681 
  ql/src/test/results/clientpositive/tez/cross_product_check_2.q.out efd8b5d 
  ql/src/test/results/clientpositive/tez/dynpart_sort_optimization2.q.out 
346e52f 
  ql/src/test/results/clientpositive/tez/explainuser_1.q.out c081309 
  ql/src/test/res