Re: Review Request: HIVE-1235: use Ivy for fetching HBase dependencies

2011-01-31 Thread John Sichi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/367/
---

(Updated 2011-01-31 11:13:20.501770)


Review request for hive.


Changes
---

This correspondes to HIVE-1235.3.patch; it adds a Collections.sort call to fix 
TestHBaseSerDe.


Summary
---

review request from JVS


This addresses bug HIVE-1235.
https://issues.apache.org/jira/browse/HIVE-1235


Diffs (updated)
-

  http://svn.apache.org/repos/asf/hive/trunk/build-common.xml 1065710 
  http://svn.apache.org/repos/asf/hive/trunk/build.xml 1065710 
  
http://svn.apache.org/repos/asf/hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
 1065710 
  
http://svn.apache.org/repos/asf/hive/trunk/hbase-handler/src/test/org/apache/hadoop/hive/hbase/HBaseTestSetup.java
 1065710 
  
http://svn.apache.org/repos/asf/hive/trunk/hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestHBaseSerDe.java
 1065710 
  
http://svn.apache.org/repos/asf/hive/trunk/hbase-handler/src/test/queries/hbase_bulk.m
 1065710 
  
http://svn.apache.org/repos/asf/hive/trunk/hbase-handler/src/test/results/hbase_bulk.m.out
 1065710 
  
http://svn.apache.org/repos/asf/hive/trunk/hbase-handler/src/test/results/hbase_stats.q.out
 1065710 
  http://svn.apache.org/repos/asf/hive/trunk/ivy/ivysettings.xml 1065710 
  http://svn.apache.org/repos/asf/hive/trunk/ivy/libraries.properties 1065710 
  http://svn.apache.org/repos/asf/hive/trunk/lib/hbase-0.20.3-test.jar UNKNOWN 
  http://svn.apache.org/repos/asf/hive/trunk/lib/hbase-0.20.3.jar UNKNOWN 
  http://svn.apache.org/repos/asf/hive/trunk/lib/zookeeper-3.2.2.jar UNKNOWN 
  http://svn.apache.org/repos/asf/hive/trunk/ql/build.xml 1065710 
  http://svn.apache.org/repos/asf/hive/trunk/ql/ivy.xml 1065710 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
 1065710 

Diff: https://reviews.apache.org/r/367/diff


Testing
---


Thanks,

John

Review Request: HIVE-1235: use Ivy for fetching HBase dependencies

2011-01-28 Thread John Sichi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/367/
---

Review request for hive.


Summary
---

review request from JVS


This addresses bug HIVE-1235.
https://issues.apache.org/jira/browse/HIVE-1235


Diffs
-

  http://svn.apache.org/repos/asf/hive/trunk/build-common.xml 1063501 
  http://svn.apache.org/repos/asf/hive/trunk/build.xml 1063501 
  
http://svn.apache.org/repos/asf/hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
 1063501 
  
http://svn.apache.org/repos/asf/hive/trunk/hbase-handler/src/test/org/apache/hadoop/hive/hbase/HBaseTestSetup.java
 1063501 
  
http://svn.apache.org/repos/asf/hive/trunk/hbase-handler/src/test/queries/hbase_bulk.m
 1063501 
  
http://svn.apache.org/repos/asf/hive/trunk/hbase-handler/src/test/results/hbase_bulk.m.out
 1063501 
  
http://svn.apache.org/repos/asf/hive/trunk/hbase-handler/src/test/results/hbase_stats.q.out
 1063501 
  http://svn.apache.org/repos/asf/hive/trunk/ivy/ivysettings.xml 1063501 
  http://svn.apache.org/repos/asf/hive/trunk/ivy/libraries.properties 1063501 
  http://svn.apache.org/repos/asf/hive/trunk/lib/hbase-0.20.3-test.jar UNKNOWN 
  http://svn.apache.org/repos/asf/hive/trunk/lib/hbase-0.20.3.jar UNKNOWN 
  http://svn.apache.org/repos/asf/hive/trunk/lib/zookeeper-3.2.2.jar UNKNOWN 
  http://svn.apache.org/repos/asf/hive/trunk/ql/build.xml 1063501 
  http://svn.apache.org/repos/asf/hive/trunk/ql/ivy.xml 1063501 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
 1063501 

Diff: https://reviews.apache.org/r/367/diff


Testing
---


Thanks,

John