Re: Review Request: HIVE-2503: create per-session HiveConf instance
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- (Updated 2012-01-04 05:08:24.994913) Review request for hive and Carl Steinbach. Changes --- Added missing ASF header. Summary --- We uses multiple HiveClient connected to single HiveServer. After configuring connections, we've found the environment variables are different from expected. Current hive server uses single instance of HiveConf and this seemed to make the problem. This addresses bug HIVE-2503. https://issues.apache.org/jira/browse/HIVE-2503 Diffs (updated) - service/src/java/org/apache/hadoop/hive/service/HiveServer.java 854cc99 service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java PRE-CREATION Diff: https://reviews.apache.org/r/2820/diff Testing --- If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. Thanks, Navis
Re: Review Request: HIVE-2503: create per-session HiveConf instance
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/#review3986 --- If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. Can you supply a version of this test so I can take a look. I'm curious to know why it doesn't work. Thanks. service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java https://reviews.apache.org/r/2820/#comment9025 Missing ASF header. - Carl On 2011-12-16 05:44:15, Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- (Updated 2011-12-16 05:44:15) Review request for hive and Carl Steinbach. Summary --- We uses multiple HiveClient connected to single HiveServer. After configuring connections, we've found the environment variables are different from expected. Current hive server uses single instance of HiveConf and this seemed to make the problem. This addresses bug HIVE-2503. https://issues.apache.org/jira/browse/HIVE-2503 Diffs - service/src/java/org/apache/hadoop/hive/service/HiveServer.java 854cc99 service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java PRE-CREATION Diff: https://reviews.apache.org/r/2820/diff Testing --- If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. Thanks, Navis
Re: Review Request: HIVE-2503: create per-session HiveConf instance
On 2011-12-19 22:35:46, Carl Steinbach wrote: If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. Can you supply a version of this test so I can take a look. I'm curious to know why it doesn't work. Thanks. I think it cannot be tested by making two instance of client, cause SessionState is a ThreadLocal thing.. Is it right? - Navis --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/#review3986 --- On 2011-12-16 05:44:15, Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- (Updated 2011-12-16 05:44:15) Review request for hive and Carl Steinbach. Summary --- We uses multiple HiveClient connected to single HiveServer. After configuring connections, we've found the environment variables are different from expected. Current hive server uses single instance of HiveConf and this seemed to make the problem. This addresses bug HIVE-2503. https://issues.apache.org/jira/browse/HIVE-2503 Diffs - service/src/java/org/apache/hadoop/hive/service/HiveServer.java 854cc99 service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java PRE-CREATION Diff: https://reviews.apache.org/r/2820/diff Testing --- If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. Thanks, Navis
Re: Review Request: HIVE-2503: create per-session HiveConf instance
On 2011-12-19 22:35:46, Carl Steinbach wrote: If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. Can you supply a version of this test so I can take a look. I'm curious to know why it doesn't work. Thanks. Navis Ryu wrote: I think it cannot be tested by making two instance of client, cause SessionState is a ThreadLocal thing.. Is it right? Yup, that makes sense. - Carl --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/#review3986 --- On 2011-12-16 05:44:15, Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- (Updated 2011-12-16 05:44:15) Review request for hive and Carl Steinbach. Summary --- We uses multiple HiveClient connected to single HiveServer. After configuring connections, we've found the environment variables are different from expected. Current hive server uses single instance of HiveConf and this seemed to make the problem. This addresses bug HIVE-2503. https://issues.apache.org/jira/browse/HIVE-2503 Diffs - service/src/java/org/apache/hadoop/hive/service/HiveServer.java 854cc99 service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java PRE-CREATION Diff: https://reviews.apache.org/r/2820/diff Testing --- If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. Thanks, Navis
Re: Review Request: HIVE-2503: create per-session HiveConf instance
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/#review3926 --- We should include a test case for regression purposes. You can achieve this by playing with test.service.standalone.server. If that doesn't work out, then you can always extend TestHiveServer and setup the test the way you want. - Ashutosh On 2011-11-14 08:54:00, Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- (Updated 2011-11-14 08:54:00) Review request for hive and Carl Steinbach. Summary --- We uses multiple HiveClient connected to single HiveServer. After configuring connections, we've found the environment variables are different from expected. Current hive server uses single instance of HiveConf and this seemed to make the problem. This addresses bug HIVE-2503. https://issues.apache.org/jira/browse/HIVE-2503 Diffs - service/src/java/org/apache/hadoop/hive/service/HiveServer.java a2d599f Diff: https://reviews.apache.org/r/2820/diff Testing --- If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. Thanks, Navis
Re: Review Request: HIVE-2503: create per-session HiveConf instance
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- (Updated 2011-12-16 05:44:15.242903) Review request for hive and Carl Steinbach. Changes --- I know the test code is very awkward, but that was what I've expected from HiveServer. Summary --- We uses multiple HiveClient connected to single HiveServer. After configuring connections, we've found the environment variables are different from expected. Current hive server uses single instance of HiveConf and this seemed to make the problem. This addresses bug HIVE-2503. https://issues.apache.org/jira/browse/HIVE-2503 Diffs (updated) - service/src/java/org/apache/hadoop/hive/service/HiveServer.java 854cc99 service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java PRE-CREATION Diff: https://reviews.apache.org/r/2820/diff Testing --- If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. Thanks, Navis
Review Request: HIVE-2503: create per-session HiveConf instance
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- Review request for hive and Carl Steinbach. Summary --- We uses multiple HiveClient connected to single HiveServer. After configuring connections, we've found the environment variables are different from expected. Current hive server uses single instance of HiveConf and this seemed to make the problem. This addresses bug HIVE-2503. https://issues.apache.org/jira/browse/HIVE-2503 Diffs - service/src/java/org/apache/hadoop/hive/service/HiveServer.java a2d599f Diff: https://reviews.apache.org/r/2820/diff Testing --- If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. Thanks, Navis
