Re: Review Request 15387: HIVE-5684 Serde support for char

2013-11-26 Thread Xuefu Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15387/#review29457
---

Ship it!


Ship It!

- Xuefu Zhang


On Nov. 10, 2013, 2:19 a.m., Jason Dere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15387/
> ---
> 
> (Updated Nov. 10, 2013, 2:19 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Prasanth_J.
> 
> 
> Bugs: HIVE-5684
> https://issues.apache.org/jira/browse/HIVE-5684
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> support for char type in orc file, serde tests.
> 
> 
> Diffs
> -
> 
>   ql/src/gen/protobuf/gen-java/org/apache/hadoop/hive/ql/io/orc/OrcProto.java 
> 9409b8f 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/ColumnStatisticsImpl.java 
> e257887 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcStruct.java a46ef53 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java e715eb8 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java 76b7cf3 
>   ql/src/protobuf/org/apache/hadoop/hive/ql/io/orc/orc_proto.proto 2f20793 
>   ql/src/test/queries/clientpositive/char_serde.q PRE-CREATION 
>   ql/src/test/results/clientpositive/char_serde.q.out PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java 6726973 
> 
> Diff: https://reviews.apache.org/r/15387/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Dere
> 
>



Review Request 15387: HIVE-5684 Serde support for char

2013-11-09 Thread Jason Dere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15387/
---

Review request for hive, Ashutosh Chauhan and Prasanth_J.


Bugs: HIVE-5684
https://issues.apache.org/jira/browse/HIVE-5684


Repository: hive-git


Description
---

support for char type in orc file, serde tests.


Diffs
-

  ql/src/gen/protobuf/gen-java/org/apache/hadoop/hive/ql/io/orc/OrcProto.java 
9409b8f 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/ColumnStatisticsImpl.java 
e257887 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcStruct.java a46ef53 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java e715eb8 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java 76b7cf3 
  ql/src/protobuf/org/apache/hadoop/hive/ql/io/orc/orc_proto.proto 2f20793 
  ql/src/test/queries/clientpositive/char_serde.q PRE-CREATION 
  ql/src/test/results/clientpositive/char_serde.q.out PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java 6726973 

Diff: https://reviews.apache.org/r/15387/diff/


Testing
---


Thanks,

Jason Dere