subject:"Review Request 18103\: Adds owner for DB."

Re: Review Request 18103: Adds owner for DB.

2014-02-14 Thread Thejas Nair


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18103/#review34553
---

Ship it!


Ship It!

- Thejas Nair


On Feb. 14, 2014, 10:41 p.m., Ashutosh Chauhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18103/
> ---
> 
> (Updated Feb. 14, 2014, 10:41 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6386
> https://issues.apache.org/jira/browse/HIVE-6386
> 
> 
> Repository: hive
> 
> 
> Description
> ---
> 
> Adds owner for DB.
> 
> 
> Diffs
> -
> 
>   
> trunk/itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
>  1568537 
>   trunk/metastore/if/hive_metastore.thrift 1568537 
>   trunk/metastore/scripts/upgrade/derby/016-HIVE-6386.derby.sql PRE-CREATION 
>   trunk/metastore/scripts/upgrade/mysql/016-HIVE-6386.mysql.sql PRE-CREATION 
>   trunk/metastore/scripts/upgrade/oracle/016-HIVE-6386.oracle.sql 
> PRE-CREATION 
>   trunk/metastore/scripts/upgrade/postgres/016-HIVE-6386.postgres.sql 
> PRE-CREATION 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1568537 
>   trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 1568537 
>   trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 1568537 
>   
> trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java
>  1568537 
>   trunk/metastore/src/gen/thrift/gen-php/metastore/Types.php 1568537 
>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 1568537 
>   trunk/metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 1568537 
>   
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
> 1568537 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> 1568537 
>   
> trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MDatabase.java
>  1568537 
>   trunk/metastore/src/model/package.jdo 1568537 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1568537 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
>  1568537 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java
>  1568537 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
>  1568537 
>   trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h 1568537 
>   trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp 1568537 
>   
> trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java
>  1568537 
>   
> trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
>  1568537 
>   
> trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
>  1568537 
>   trunk/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php 
> 1568537 
>   trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py 
> 1568537 
>   trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb 1568537 
> 
> Diff: https://reviews.apache.org/r/18103/diff/
> 
> 
> Testing
> ---
> 
> Added new test.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>

Re: Review Request 18103: Adds owner for DB.

2014-02-14 Thread Ashutosh Chauhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18103/
---

(Updated Feb. 14, 2014, 10:41 p.m.)


Review request for hive.


Changes
---

Some minor fixes.


Bugs: HIVE-6386
https://issues.apache.org/jira/browse/HIVE-6386


Repository: hive


Description
---

Adds owner for DB.


Diffs (updated)
-

  
trunk/itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
 1568537 
  trunk/metastore/if/hive_metastore.thrift 1568537 
  trunk/metastore/scripts/upgrade/derby/016-HIVE-6386.derby.sql PRE-CREATION 
  trunk/metastore/scripts/upgrade/mysql/016-HIVE-6386.mysql.sql PRE-CREATION 
  trunk/metastore/scripts/upgrade/oracle/016-HIVE-6386.oracle.sql PRE-CREATION 
  trunk/metastore/scripts/upgrade/postgres/016-HIVE-6386.postgres.sql 
PRE-CREATION 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1568537 
  trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 1568537 
  trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 1568537 
  
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java
 1568537 
  trunk/metastore/src/gen/thrift/gen-php/metastore/Types.php 1568537 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 1568537 
  trunk/metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 1568537 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
1568537 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
1568537 
  
trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MDatabase.java 
1568537 
  trunk/metastore/src/model/package.jdo 1568537 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1568537 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
 1568537 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java
 1568537 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
 1568537 
  trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h 1568537 
  trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp 1568537 
  
trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java
 1568537 
  
trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
 1568537 
  
trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
 1568537 
  trunk/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php 
1568537 
  trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py 
1568537 
  trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb 1568537 

Diff: https://reviews.apache.org/r/18103/diff/


Testing
---

Added new test.


Thanks,

Ashutosh Chauhan

Re: Review Request 18103: Adds owner for DB.

2014-02-14 Thread Ashutosh Chauhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18103/
---

(Updated Feb. 14, 2014, 10:18 p.m.)


Review request for hive.


Changes
---

Incorporated Thejas feedback.


Bugs: HIVE-6386
https://issues.apache.org/jira/browse/HIVE-6386


Repository: hive


Description
---

Adds owner for DB.


Diffs (updated)
-

  
trunk/itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
 1568535 
  trunk/metastore/if/hive_metastore.thrift 1568535 
  trunk/metastore/scripts/upgrade/derby/016-HIVE-6386.derby.sql PRE-CREATION 
  trunk/metastore/scripts/upgrade/mysql/016-HIVE-6386.mysql.sql PRE-CREATION 
  trunk/metastore/scripts/upgrade/oracle/016-HIVE-6386.oracle.sql PRE-CREATION 
  trunk/metastore/scripts/upgrade/postgres/016-HIVE-6386.postgres.sql 
PRE-CREATION 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1568535 
  trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 1568535 
  trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 1568535 
  
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java
 1568535 
  trunk/metastore/src/gen/thrift/gen-php/metastore/Types.php 1568535 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 1568535 
  trunk/metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 1568535 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
1568535 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
1568535 
  
trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MDatabase.java 
1568535 
  trunk/metastore/src/model/package.jdo 1568535 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1568535 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
 1568535 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java
 1568535 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
 1568535 
  trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h 1568535 
  trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp 1568535 
  
trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java
 1568535 
  
trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
 1568535 
  
trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
 1568535 
  trunk/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php 
1568535 
  trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py 
1568535 
  trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb 1568535 

Diff: https://reviews.apache.org/r/18103/diff/


Testing
---

Added new test.


Thanks,

Ashutosh Chauhan

Re: Review Request 18103: Adds owner for DB.

2014-02-14 Thread Thejas Nair


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18103/#review34499
---



trunk/metastore/if/hive_metastore.thrift


There is a PrincipalType which used in other metastore apis (see grant_role 
for example). I think it is better to be consistent and use that as the 
datatype for ownerType.

If we reuse PrincipalType, then we don't need to move HivePrincipal class 
to the common package.



- Thejas Nair


On Feb. 13, 2014, 11:24 p.m., Ashutosh Chauhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18103/
> ---
> 
> (Updated Feb. 13, 2014, 11:24 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6386
> https://issues.apache.org/jira/browse/HIVE-6386
> 
> 
> Repository: hive
> 
> 
> Description
> ---
> 
> Adds owner for DB.
> 
> 
> Diffs
> -
> 
>   trunk/common/src/java/org/apache/hive/common/HivePrincipal.java 
> PRE-CREATION 
>   
> trunk/itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
>  1568122 
>   trunk/metastore/if/hive_metastore.thrift 1568122 
>   trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 1568122 
>   trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 1568122 
>   
> trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java
>  1568122 
>   trunk/metastore/src/gen/thrift/gen-php/metastore/Types.php 1568122 
>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 1568122 
>   trunk/metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 1568122 
>   
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
> 1568122 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> 1568122 
>   
> trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MDatabase.java
>  1568122 
>   trunk/metastore/src/model/package.jdo 1568122 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1568122 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
>  1568122 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java
>  1568122 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
>  1568122 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java
>  1568122 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java
>  1568122 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java
>  1568122 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java
>  1568122 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrincipal.java
>  1568122 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeInfo.java
>  1568122 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/GrantPrivAuthUtils.java
>  1568122 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/RevokePrivAuthUtils.java
>  1568122 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java
>  1568122 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
>  1568122 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java
>  1568122 
>   trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h 1568122 
>   trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp 1568122 
>   
> trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java
>  1568122 
>   
> trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
>  1568122 
>   
> trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
>  1568122 
>   trunk/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php 
> 1568122 
>   trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py 
> 1568122 
>   trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb 1568122 
> 
> Diff: https://reviews.apache.org/r/18103/diff/
> 
> 
> Testing
> ---
> 
> Added new test.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>

Review Request 18103: Adds owner for DB.

2014-02-13 Thread Ashutosh Chauhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18103/
---

Review request for hive.


Bugs: HIVE-6386
https://issues.apache.org/jira/browse/HIVE-6386


Repository: hive


Description
---

Adds owner for DB.


Diffs
-

  trunk/common/src/java/org/apache/hive/common/HivePrincipal.java PRE-CREATION 
  
trunk/itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
 1568122 
  trunk/metastore/if/hive_metastore.thrift 1568122 
  trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 1568122 
  trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 1568122 
  
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java
 1568122 
  trunk/metastore/src/gen/thrift/gen-php/metastore/Types.php 1568122 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 1568122 
  trunk/metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 1568122 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
1568122 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
1568122 
  
trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MDatabase.java 
1568122 
  trunk/metastore/src/model/package.jdo 1568122 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1568122 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
 1568122 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java
 1568122 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
 1568122 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java
 1568122 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java
 1568122 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java
 1568122 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java
 1568122 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrincipal.java
 1568122 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeInfo.java
 1568122 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/GrantPrivAuthUtils.java
 1568122 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/RevokePrivAuthUtils.java
 1568122 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java
 1568122 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
 1568122 
  
trunk/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java
 1568122 
  trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h 1568122 
  trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp 1568122 
  
trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java
 1568122 
  
trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
 1568122 
  
trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
 1568122 
  trunk/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php 
1568122 
  trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py 
1568122 
  trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb 1568122 

Diff: https://reviews.apache.org/r/18103/diff/


Testing
---

Added new test.


Thanks,

Ashutosh Chauhan

Re: Review Request 18103: Adds owner for DB.

Re: Review Request 18103: Adds owner for DB.

Re: Review Request 18103: Adds owner for DB.

Re: Review Request 18103: Adds owner for DB.

Review Request 18103: Adds owner for DB.

5 matches

Site Navigation

Mail list logo

Footer information