Re: Review Request 20736: HIVE-4965 Add support so that PTFs can stream their output; Windowing PTF should do this

2014-04-25 Thread Harish Butani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20736/
---

(Updated April 25, 2014, 10:55 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
---

  


Bugs: HIVE-4965
https://issues.apache.org/jira/browse/HIVE-4965


Repository: hive-git


Description
---

There is no need to create an output PTF Partition for the last PTF in a chain. 
For the Windowing PTF this should give a perf. boost; we avoid creating 
temporary results for each UDAF; avoid populating an output Partition.


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java af25dc8 
  ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java ac052cd 
  ql/src/java/org/apache/hadoop/hive/ql/plan/PTFDeserializer.java 154f29a 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/TableFunctionEvaluator.java 
080fd44 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java 
110ef27 

Diff: https://reviews.apache.org/r/20736/diff/


Testing
---

ran existing tests


Thanks,

Harish Butani



Review Request 20736: HIVE-4965 Add support so that PTFs can stream their output; Windowing PTF should do this

2014-04-25 Thread Harish Butani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20736/
---

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-4965
https://issues.apache.org/jira/browse/HIVE-4965


Repository: hive-git


Description
---

There is no need to create an output PTF Partition for the last PTF in a chain. 
For the Windowing PTF this should give a perf. boost; we avoid creating 
temporary results for each UDAF; avoid populating an output Partition.


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java af25dc8 
  ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java ac052cd 
  ql/src/java/org/apache/hadoop/hive/ql/plan/PTFDeserializer.java 154f29a 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/TableFunctionEvaluator.java 
080fd44 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java 
110ef27 

Diff: https://reviews.apache.org/r/20736/diff/


Testing
---

ran existing tests


Thanks,

Harish Butani