Re: Review Request 24445: HIVE-7642, Set hive input format by configuration.

[chengxiang li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24445/
---

(Updated Aug. 12, 2014, 2:06 a.m.)


Review request for hive, Brock Noland and Szehon Ho.


Bugs: HIVE-7642
https://issues.apache.org/jira/browse/HIVE-7642


Repository: hive-git


Description
---

Currently hive input format is hard coded as HiveInputFormat, we should set 
this parameter from configuration.


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 
45eff67 

Diff: https://reviews.apache.org/r/24445/diff/


Testing
---


Thanks,

chengxiang li

Re: Review Request 24445: HIVE-7642, Set hive input format by configuration.

[Brock Noland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24445/#review50178
---


Thank you so much! We can commit this very, soon. Just two small "nits" below 
and then we'll commit this.


ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java


nit: Can the right hand side here can use StringUtils.isBlank so we can 
avoid the double negative?


https://commons.apache.org/proper/commons-lang/javadocs/api-2.6/org/apache/commons/lang/StringUtils.html#isBlank(java.lang.String)



ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java


nit: How about changing this to:

String msg = "Failed to load specified input format class:" + inpFormat;
LOG.error(msg, e);
throw new HiveException(msg, e);

which might provide better information to our users?


- Brock Noland


On Aug. 11, 2014, 7:45 a.m., chengxiang li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24445/
> ---
> 
> (Updated Aug. 11, 2014, 7:45 a.m.)
> 
> 
> Review request for hive, Brock Noland and Szehon Ho.
> 
> 
> Bugs: HIVE-7642
> https://issues.apache.org/jira/browse/HIVE-7642
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Currently hive input format is hard coded as HiveInputFormat, we should set 
> this parameter from configuration.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 
> 45eff67 
> 
> Diff: https://reviews.apache.org/r/24445/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> chengxiang li
> 
>

Re: Review Request 24445: HIVE-7642, Set hive input format by configuration.

[chengxiang li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24445/
---

(Updated Aug. 11, 2014, 7:45 a.m.)


Review request for hive, Brock Noland and Szehon Ho.


Bugs: HIVE-7642
https://issues.apache.org/jira/browse/HIVE-7642


Repository: hive-git


Description
---

Currently hive input format is hard coded as HiveInputFormat, we should set 
this parameter from configuration.


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 
45eff67 

Diff: https://reviews.apache.org/r/24445/diff/


Testing
---


Thanks,

chengxiang li

Re: Review Request 24445: HIVE-7642, Set hive input format by configuration.

[Brock Noland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24445/#review50144
---


Hi,

Thank you very much for taking this on! I have one question below.


ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java


If the configuration is incorrect, perhaps we should throw an error? 
Meaning re-throw the exception?


- Brock Noland


On Aug. 7, 2014, 7:30 a.m., chengxiang li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24445/
> ---
> 
> (Updated Aug. 7, 2014, 7:30 a.m.)
> 
> 
> Review request for hive, Brock Noland and Szehon Ho.
> 
> 
> Bugs: HIVE-7642
> https://issues.apache.org/jira/browse/HIVE-7642
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Currently hive input format is hard coded as HiveInputFormat, we should set 
> this parameter from configuration.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 
> 45eff67 
> 
> Diff: https://reviews.apache.org/r/24445/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> chengxiang li
> 
>

Review Request 24445: HIVE-7642, Set hive input format by configuration.

[chengxiang li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24445/
---

Review request for hive, Brock Noland and Szehon Ho.


Bugs: HIVE-7642
https://issues.apache.org/jira/browse/HIVE-7642


Repository: hive-git


Description
---

Currently hive input format is hard coded as HiveInputFormat, we should set 
this parameter from configuration.


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 
45eff67 

Diff: https://reviews.apache.org/r/24445/diff/


Testing
---


Thanks,

chengxiang li