Re: Review Request 26218: Add configuration for custom services in hiveserver2

2014-10-09 Thread Thejas Nair 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26218/#review56106
---



service/src/java/org/apache/hive/service/AbstractService.java
https://reviews.apache.org/r/26218/#comment96445

Lets mark this also explicitly with -   
@InterfaceStability.Evolving
@InterfaceStability.Unstable


- Thejas Nair


On Oct. 7, 2014, 6:04 a.m., Navis Ryu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/26218/
 ---
 
 (Updated Oct. 7, 2014, 6:04 a.m.)
 
 
 Review request for hive.
 
 
 Bugs: HIVE-8319
 https://issues.apache.org/jira/browse/HIVE-8319
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 NO PRECOMMIT TESTS
 
 Register services to hiveserver2, for example, 
 {noformat}
 property
   namehive.server2.service.classesname
   
 valuecom.nexr.hive.service.HiveStatus,com.nexr.hive.service.AzkabanServicevalue
 /property
 property
   nameazkaban.ssl.portname
   name...name
 /property
 {noformat}
 
 
 Diffs
 -
 
   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 51fc68f 
   
 hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/HCatInputFormat.java
  22e7091 
   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 155002a 
   ql/src/java/org/apache/hadoop/hive/ql/hooks/HookUtils.java 390ffd9 
   service/src/java/org/apache/hive/service/AbstractService.java c2a2b2d 
   service/src/java/org/apache/hive/service/BreakableService.java 9c44beb 
   service/src/java/org/apache/hive/service/CompositeService.java 8979118 
   service/src/java/org/apache/hive/service/FilterService.java 5a50874 
   service/src/java/org/apache/hive/service/Service.java 2111837 
   service/src/java/org/apache/hive/service/ServiceOperations.java 8946219 
   service/src/java/org/apache/hive/service/ServiceStateChangeListener.java 
 16ad9a9 
   service/src/java/org/apache/hive/service/server/HiveServer2.java c667533 
 
 Diff: https://reviews.apache.org/r/26218/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Navis Ryu

Review Request 26218: Add configuration for custom services in hiveserver2

2014-10-01 Thread Navis Ryu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26218/
---

Review request for hive.


Bugs: HIVE-8319
https://issues.apache.org/jira/browse/HIVE-8319


Repository: hive-git


Description
---

NO PRECOMMIT TESTS

Register services to hiveserver2, for example, 
{noformat}
property
  namehive.server2.service.classesname
  
valuecom.nexr.hive.service.HiveStatus,com.nexr.hive.service.AzkabanServicevalue
/property
property
  nameazkaban.ssl.portname
  name...name
/property
{noformat}


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b0cb98b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 155002a 
  ql/src/java/org/apache/hadoop/hive/ql/hooks/HookUtils.java 390ffd9 
  service/src/java/org/apache/hive/service/server/HiveServer2.java c667533 

Diff: https://reviews.apache.org/r/26218/diff/


Testing
---


Thanks,

Navis Ryu

Re: Review Request 26218: Add configuration for custom services in hiveserver2

2014-10-01 Thread Lefty Leverenz 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26218/#review55057
---



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
https://reviews.apache.org/r/26218/#comment95393

Maybe I'm just being dense, but does same lifecycle mean the same 
lifecycle as HS2?


- Lefty Leverenz


On Oct. 1, 2014, 7:24 a.m., Navis Ryu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/26218/
 ---
 
 (Updated Oct. 1, 2014, 7:24 a.m.)
 
 
 Review request for hive.
 
 
 Bugs: HIVE-8319
 https://issues.apache.org/jira/browse/HIVE-8319
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 NO PRECOMMIT TESTS
 
 Register services to hiveserver2, for example, 
 {noformat}
 property
   namehive.server2.service.classesname
   
 valuecom.nexr.hive.service.HiveStatus,com.nexr.hive.service.AzkabanServicevalue
 /property
 property
   nameazkaban.ssl.portname
   name...name
 /property
 {noformat}
 
 
 Diffs
 -
 
   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b0cb98b 
   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 155002a 
   ql/src/java/org/apache/hadoop/hive/ql/hooks/HookUtils.java 390ffd9 
   service/src/java/org/apache/hive/service/server/HiveServer2.java c667533 
 
 Diff: https://reviews.apache.org/r/26218/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Navis Ryu

Re: Review Request 26218: Add configuration for custom services in hiveserver2

2014-10-01 Thread Navis Ryu 


 On Oct. 1, 2014, 7:38 a.m., Lefty Leverenz wrote:
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 1492-1494
  https://reviews.apache.org/r/26218/diff/1/?file=710029#file710029line1492
 
  Maybe I'm just being dense, but does same lifecycle mean the same 
  lifecycle as HS2?

Yes. I should append of it to description.


- Navis


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26218/#review55057
---


On Oct. 1, 2014, 7:24 a.m., Navis Ryu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/26218/
 ---
 
 (Updated Oct. 1, 2014, 7:24 a.m.)
 
 
 Review request for hive.
 
 
 Bugs: HIVE-8319
 https://issues.apache.org/jira/browse/HIVE-8319
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 NO PRECOMMIT TESTS
 
 Register services to hiveserver2, for example, 
 {noformat}
 property
   namehive.server2.service.classesname
   
 valuecom.nexr.hive.service.HiveStatus,com.nexr.hive.service.AzkabanServicevalue
 /property
 property
   nameazkaban.ssl.portname
   name...name
 /property
 {noformat}
 
 
 Diffs
 -
 
   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b0cb98b 
   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 155002a 
   ql/src/java/org/apache/hadoop/hive/ql/hooks/HookUtils.java 390ffd9 
   service/src/java/org/apache/hive/service/server/HiveServer2.java c667533 
 
 Diff: https://reviews.apache.org/r/26218/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Navis Ryu

Re: Review Request 26218: Add configuration for custom services in hiveserver2

2014-10-01 Thread Lefty Leverenz 


 On Oct. 1, 2014, 7:38 a.m., Lefty Leverenz wrote:
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 1492-1494
  https://reviews.apache.org/r/26218/diff/1/?file=710029#file710029line1492
 
  Maybe I'm just being dense, but does same lifecycle mean the same 
  lifecycle as HS2?
 
 Navis Ryu wrote:
 Yes. I should append of it to description.

On second thought, it's fine the way it is.


- Lefty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26218/#review55057
---


On Oct. 1, 2014, 7:24 a.m., Navis Ryu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/26218/
 ---
 
 (Updated Oct. 1, 2014, 7:24 a.m.)
 
 
 Review request for hive.
 
 
 Bugs: HIVE-8319
 https://issues.apache.org/jira/browse/HIVE-8319
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 NO PRECOMMIT TESTS
 
 Register services to hiveserver2, for example, 
 {noformat}
 property
   namehive.server2.service.classesname
   
 valuecom.nexr.hive.service.HiveStatus,com.nexr.hive.service.AzkabanServicevalue
 /property
 property
   nameazkaban.ssl.portname
   name...name
 /property
 {noformat}
 
 
 Diffs
 -
 
   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b0cb98b 
   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 155002a 
   ql/src/java/org/apache/hadoop/hive/ql/hooks/HookUtils.java 390ffd9 
   service/src/java/org/apache/hive/service/server/HiveServer2.java c667533 
 
 Diff: https://reviews.apache.org/r/26218/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Navis Ryu