Re: Review Request 29037: Avoid creating serde for partitions if possible in FetchTask

2014-12-17 Thread Navis Ryu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29037/
---

(Updated Dec. 18, 2014, 7:04 a.m.)


Review request for hive.


Bugs: HIVE-7977
https://issues.apache.org/jira/browse/HIVE-7977


Repository: hive-git


Description
---

Currently, FetchTask creates SerDe instance thrice for each partition, which 
can be avoided if it's same with table SerDe.


Diffs (updated)
-

  data/files/datatypes.txt 0228a27 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1355230 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 6338c3c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/PartitionKeySampler.java 5d126a5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java ca65a8e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 29be691 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java 32d84ea 
  ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java 374e8b6 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/DelegatedListObjectInspector.java
 6a9215b 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/DelegatedMapObjectInspector.java
 975d5cd 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/DelegatedObjectInspectorFactory.java
 2db3819 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/DelegatedStructObjectInspector.java
 ef66e97 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/DelegatedUnionObjectInspector.java
 521fdd6 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
 8a42577 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
 49884b8 

Diff: https://reviews.apache.org/r/29037/diff/


Testing
---


Thanks,

Navis Ryu



Review Request 29037: Avoid creating serde for partitions if possible in FetchTask

2014-12-15 Thread Navis Ryu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29037/
---

Review request for hive.


Bugs: HIVE-7977
https://issues.apache.org/jira/browse/HIVE-7977


Repository: hive-git


Description
---

Currently, FetchTask creates SerDe instance thrice for each partition, which 
can be avoided if it's same with table SerDe.


Diffs
-

  data/files/datatypes.txt 0228a27 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 395a5f5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 6338c3c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java d2b5c05 
  ql/src/java/org/apache/hadoop/hive/ql/exec/PartitionKeySampler.java 5d126a5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java ca65a8e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 6c8624f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java 32d84ea 
  ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java 374e8b6 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/DelegatedListObjectInspector.java
 6a9215b 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/DelegatedMapObjectInspector.java
 975d5cd 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/DelegatedObjectInspectorFactory.java
 2db3819 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/DelegatedStructObjectInspector.java
 ef66e97 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/DelegatedUnionObjectInspector.java
 521fdd6 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
 8a42577 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
 49884b8 

Diff: https://reviews.apache.org/r/29037/diff/


Testing
---


Thanks,

Navis Ryu