Review Request 30779: hive.limit.query.max.table.partition makes queries fail on non-partitioned tables

[Navis Ryu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30779/
---

Review request for hive.


Repository: hive-git


Description
---

If you use hive.limit.query.max.table.partition to limit the amount of 
partitions that can be queried it makes queries on non-partitioned tables fail.

Example:
{noformat}
CREATE TABLE tmp(test INT);
SELECT COUNT(*) FROM TMP; -- works fine
SET hive.limit.query.max.table.partition=20;
SELECT COUNT(*) FROM TMP; -- generates NPE (FAILED: NullPointerException null)
SET hive.limit.query.max.table.partition=-1;
SELECT COUNT(*) FROM TMP; -- works fine again
{noformat}


Diffs
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
 d18e1a7 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 6c1ab07 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2466d78 

Diff: https://reviews.apache.org/r/30779/diff/


Testing
---


Thanks,

Navis Ryu

Re: Review Request 30779: hive.limit.query.max.table.partition makes queries fail on non-partitioned tables

[Ashutosh Chauhan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30779/#review72826
---



ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java


Didn't follow whats the bug here? Why the condition in if will ever be true?


- Ashutosh Chauhan


On Feb. 9, 2015, 1:58 a.m., Navis Ryu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30779/
> ---
> 
> (Updated Feb. 9, 2015, 1:58 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> If you use hive.limit.query.max.table.partition to limit the amount of 
> partitions that can be queried it makes queries on non-partitioned tables 
> fail.
> 
> Example:
> {noformat}
> CREATE TABLE tmp(test INT);
> SELECT COUNT(*) FROM TMP; -- works fine
> SET hive.limit.query.max.table.partition=20;
> SELECT COUNT(*) FROM TMP; -- generates NPE (FAILED: NullPointerException null)
> SET hive.limit.query.max.table.partition=-1;
> SELECT COUNT(*) FROM TMP; -- works fine again
> {noformat}
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
>  d18e1a7 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 6c1ab07 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2466d78 
> 
> Diff: https://reviews.apache.org/r/30779/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>