Re: Review Request 31222: HIVE-9738 create SOUNDEX udf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31222/#review74348 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSoundex.java https://reviews.apache.org/r/31222/#comment120919 Looks like Soundex.soundex() can return IllegalArgumentException for some unmapped characters - perhaps return null in this case to avoid aborting the entire query on this error. - Jason Dere On Feb. 20, 2015, 7:19 a.m., Alexander Pivovarov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31222/ --- (Updated Feb. 20, 2015, 7:19 a.m.) Review request for hive, Alan Gates and Jason Dere. Bugs: HIVE-9738 https://issues.apache.org/jira/browse/HIVE-9738 Repository: hive-git Description --- HIVE-9738 create SOUNDEX udf Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bfeb33c9edf79071bf106a3780e1c6bc21be3753 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSoundex.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSoundex.java PRE-CREATION ql/src/test/queries/clientpositive/udf_soundex.q PRE-CREATION ql/src/test/results/clientpositive/show_functions.q.out d4b06507f2356cc58ff7312ff78261406f3ceb4f ql/src/test/results/clientpositive/udf_soundex.q.out PRE-CREATION Diff: https://reviews.apache.org/r/31222/diff/ Testing --- Thanks, Alexander Pivovarov
Re: Review Request 31222: HIVE-9738 create SOUNDEX udf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31222/ --- (Updated Feb. 26, 2015, 9:50 p.m.) Review request for hive, Alan Gates and Jason Dere. Bugs: HIVE-9738 https://issues.apache.org/jira/browse/HIVE-9738 Repository: hive-git Description --- HIVE-9738 create SOUNDEX udf Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bfeb33c9edf79071bf106a3780e1c6bc21be3753 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSoundex.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSoundex.java PRE-CREATION ql/src/test/queries/clientpositive/udf_soundex.q PRE-CREATION ql/src/test/results/clientpositive/show_functions.q.out d4b06507f2356cc58ff7312ff78261406f3ceb4f ql/src/test/results/clientpositive/udf_soundex.q.out PRE-CREATION Diff: https://reviews.apache.org/r/31222/diff/ Testing --- Thanks, Alexander Pivovarov
Re: Review Request 31222: HIVE-9738 create SOUNDEX udf
On Feb. 26, 2015, 7:58 p.m., Jason Dere wrote: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSoundex.java, line 77 https://reviews.apache.org/r/31222/diff/1/?file=870136#file870136line77 Looks like Soundex.soundex() can return IllegalArgumentException for some unmapped characters - perhaps return null in this case to avoid aborting the entire query on this error. good catch. fixed and added unit test - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31222/#review74348 --- On Feb. 26, 2015, 9:50 p.m., Alexander Pivovarov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31222/ --- (Updated Feb. 26, 2015, 9:50 p.m.) Review request for hive, Alan Gates and Jason Dere. Bugs: HIVE-9738 https://issues.apache.org/jira/browse/HIVE-9738 Repository: hive-git Description --- HIVE-9738 create SOUNDEX udf Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bfeb33c9edf79071bf106a3780e1c6bc21be3753 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSoundex.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSoundex.java PRE-CREATION ql/src/test/queries/clientpositive/udf_soundex.q PRE-CREATION ql/src/test/results/clientpositive/show_functions.q.out d4b06507f2356cc58ff7312ff78261406f3ceb4f ql/src/test/results/clientpositive/udf_soundex.q.out PRE-CREATION Diff: https://reviews.apache.org/r/31222/diff/ Testing --- Thanks, Alexander Pivovarov
Re: Review Request 31222: HIVE-9738 create SOUNDEX udf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31222/#review74399 --- Ship it! Ship It! - Jason Dere On Feb. 26, 2015, 9:50 p.m., Alexander Pivovarov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31222/ --- (Updated Feb. 26, 2015, 9:50 p.m.) Review request for hive, Alan Gates and Jason Dere. Bugs: HIVE-9738 https://issues.apache.org/jira/browse/HIVE-9738 Repository: hive-git Description --- HIVE-9738 create SOUNDEX udf Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bfeb33c9edf79071bf106a3780e1c6bc21be3753 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSoundex.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSoundex.java PRE-CREATION ql/src/test/queries/clientpositive/udf_soundex.q PRE-CREATION ql/src/test/results/clientpositive/show_functions.q.out d4b06507f2356cc58ff7312ff78261406f3ceb4f ql/src/test/results/clientpositive/udf_soundex.q.out PRE-CREATION Diff: https://reviews.apache.org/r/31222/diff/ Testing --- Thanks, Alexander Pivovarov
Review Request 31222: HIVE-9738 create SOUNDEX udf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31222/ --- Review request for hive, Alan Gates and Jason Dere. Bugs: HIVE-9738 https://issues.apache.org/jira/browse/HIVE-9738 Repository: hive-git Description --- HIVE-9738 create SOUNDEX udf Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bfeb33c9edf79071bf106a3780e1c6bc21be3753 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSoundex.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSoundex.java PRE-CREATION ql/src/test/queries/clientpositive/udf_soundex.q PRE-CREATION ql/src/test/results/clientpositive/show_functions.q.out d4b06507f2356cc58ff7312ff78261406f3ceb4f ql/src/test/results/clientpositive/udf_soundex.q.out PRE-CREATION Diff: https://reviews.apache.org/r/31222/diff/ Testing --- Thanks, Alexander Pivovarov
