Review Request 32406: Add another level of explain for RDBMS audience

2015-03-23 Thread pengcheng xiong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32406/
---

Review request for hive.


Repository: hive-git


Description
---

Current Hive Explain (default) is targeted at MR Audience. We need a new level 
of explain plan to be targeted at RDBMS audience. The explain requires these:
1) The focus needs to be on what part of the query is being executed rather 
than internals of the engines
2) There needs to be a clearly readable tree of operations
3) Examples - Table scan should mention the table being scanned, the Sarg, the 
size of table and expected cardinality after the Sarg'ed read. The join should 
mention the table being joined with and the join condition. The aggregate 
should mention the columns in the group-by.


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f4d44ee 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 0b0c9b3 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 149f911 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Attr.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Connection.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Op.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Stage.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/TezJsonParser.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Vertex.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/hooks/ATSHook.java 53d169d 
  ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileWork.java e572338 
  ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanWork.java 
095afd4 
  
ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateWork.java
 092f627 
  ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTablePartMergeFilesDesc.java 
eaf3dc4 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java 
38b6d96 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java 476dfd1 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterDatabaseDesc.java e45bc26 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterIndexDesc.java db2cf7f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 24cf1da 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AppMasterEventDesc.java 264f959 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ArchiveWork.java 9fb5c8b 
  ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java 1737a34 
  ql/src/java/org/apache/hadoop/hive/ql/plan/BucketMapJoinContext.java f436bc0 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CollectDesc.java 588e14d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsDesc.java a44c8e8 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsUpdateWork.java d644155 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsWork.java 3cae727 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CommonMergeJoinDesc.java 2354139 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CopyWork.java 3353384 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateDatabaseDesc.java a6b52aa 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java dce5ece 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateMacroDesc.java 3c5a723 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 8cadb96 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 3dad4ab 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java dd76a82 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 79d9d16 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DemuxDesc.java 62de2e4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DependencyCollectionWork.java 
35180cd 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DescDatabaseDesc.java 3c0ed2a 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DescFunctionDesc.java 814ad73 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DescTableDesc.java eefd4d4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 66d8768 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropFunctionDesc.java e1f93a1 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropMacroDesc.java 3e2aefc 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropTableDesc.java c79710d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DummyStoreDesc.java 04e556d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicPruningEventDesc.java 
d6617b5 
  ql/src/java/org/apache/hadoop/hive/ql/plan/Explain.java a3408a0 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExplainWork.java f258d51 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExplosionDesc.java dc56ccd 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java ef5a655 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java 83ebfa3 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 22fd29e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/Forwa

Re: Review Request 32406: Add another level of explain for RDBMS audience

2015-03-25 Thread pengcheng xiong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32406/
---

(Updated March 25, 2015, 9:05 p.m.)


Review request for hive.


Repository: hive-git


Description
---

Current Hive Explain (default) is targeted at MR Audience. We need a new level 
of explain plan to be targeted at RDBMS audience. The explain requires these:
1) The focus needs to be on what part of the query is being executed rather 
than internals of the engines
2) There needs to be a clearly readable tree of operations
3) Examples - Table scan should mention the table being scanned, the Sarg, the 
size of table and expected cardinality after the Sarg'ed read. The join should 
mention the table being joined with and the join condition. The aggregate 
should mention the columns in the group-by.


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cf82e8b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 149f911 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Attr.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Connection.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Op.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Stage.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/TezJsonParser.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Vertex.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileWork.java e572338 
  
ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateWork.java
 092f627 
  ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTablePartMergeFilesDesc.java 
eaf3dc4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java 476dfd1 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterDatabaseDesc.java e45bc26 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterIndexDesc.java db2cf7f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 24cf1da 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ArchiveWork.java 9fb5c8b 
  ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java 1737a34 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CollectDesc.java 588e14d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsUpdateWork.java d644155 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsWork.java 3cae727 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CommonMergeJoinDesc.java 2354139 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CopyWork.java 3353384 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateDatabaseDesc.java a6b52aa 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java dce5ece 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateMacroDesc.java 3c5a723 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 8cadb96 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 3dad4ab 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java dd76a82 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 79d9d16 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DemuxDesc.java 62de2e4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DependencyCollectionWork.java 
35180cd 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DescDatabaseDesc.java 3c0ed2a 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DescFunctionDesc.java 814ad73 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DescTableDesc.java eefd4d4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 66d8768 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropFunctionDesc.java e1f93a1 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropMacroDesc.java 3e2aefc 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropTableDesc.java c79710d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DummyStoreDesc.java 04e556d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicPruningEventDesc.java 
d6617b5 
  ql/src/java/org/apache/hadoop/hive/ql/plan/Explain.java a3408a0 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExplainWork.java f258d51 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExplosionDesc.java dc56ccd 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java ef5a655 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java 83ebfa3 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 22fd29e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ForwardDesc.java b03fc06 
  ql/src/java/org/apache/hadoop/hive/ql/plan/GrantDesc.java f1cb323 
  ql/src/java/org/apache/hadoop/hive/ql/plan/GrantRevokeRoleDDL.java 65db04e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java d6aad9f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HashTableDummyDesc.java f15ce48 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HashTableSinkDesc.java 03ef704 
  ql/src/java/org/apache/hadoop/hive/ql/plan/JoinCondDesc.java 0c65196 
  ql/src/java/org/ap

Re: Review Request 32406: Add another level of explain for RDBMS audience

2015-03-26 Thread pengcheng xiong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32406/
---

(Updated March 26, 2015, 8:10 p.m.)


Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Changes
---

address the test failures in JIRA


Repository: hive-git


Description
---

Current Hive Explain (default) is targeted at MR Audience. We need a new level 
of explain plan to be targeted at RDBMS audience. The explain requires these:
1) The focus needs to be on what part of the query is being executed rather 
than internals of the engines
2) There needs to be a clearly readable tree of operations
3) Examples - Table scan should mention the table being scanned, the Sarg, the 
size of table and expected cardinality after the Sarg'ed read. The join should 
mention the table being joined with and the join condition. The aggregate 
should mention the columns in the group-by.


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cf82e8b 
  itests/src/test/resources/testconfiguration.properties 288270e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 149f911 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Attr.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Connection.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Op.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Stage.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/TezJsonParser.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Vertex.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileWork.java e572338 
  ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanWork.java 
095afd4 
  
ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateWork.java
 092f627 
  ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTablePartMergeFilesDesc.java 
eaf3dc4 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java 
38b6d96 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java 476dfd1 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterDatabaseDesc.java e45bc26 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterIndexDesc.java db2cf7f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 24cf1da 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ArchiveWork.java 9fb5c8b 
  ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java 1737a34 
  ql/src/java/org/apache/hadoop/hive/ql/plan/BucketMapJoinContext.java f436bc0 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CollectDesc.java 588e14d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsDesc.java a44c8e8 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsUpdateWork.java d644155 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsWork.java 3cae727 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CommonMergeJoinDesc.java 2354139 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CopyWork.java 3353384 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateDatabaseDesc.java a6b52aa 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java dce5ece 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateMacroDesc.java 3c5a723 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 8cadb96 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 3dad4ab 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java dd76a82 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 79d9d16 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DemuxDesc.java 62de2e4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DependencyCollectionWork.java 
35180cd 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DescDatabaseDesc.java 3c0ed2a 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DescFunctionDesc.java 814ad73 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DescTableDesc.java eefd4d4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 66d8768 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropFunctionDesc.java e1f93a1 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropMacroDesc.java 3e2aefc 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropTableDesc.java c79710d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DummyStoreDesc.java 04e556d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicPruningEventDesc.java 
d6617b5 
  ql/src/java/org/apache/hadoop/hive/ql/plan/Explain.java a3408a0 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExplainWork.java f258d51 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExplosionDesc.java dc56ccd 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java ef5a655 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java 83ebfa3 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 22fd29e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/Forwar

Re: Review Request 32406: Add another level of explain for RDBMS audience

2015-03-31 Thread Ashutosh Chauhan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32406/#review78298
---


Overall looks good. Few minor code level comments.


common/src/java/org/apache/hadoop/hive/conf/HiveConf.java


nit : whitespace



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Attr.java


Can be overridden from o.a.h.h.common.ObjectPair with overriding equals?

Also, consider placing this class in o.a.h.h.common package since ql/ 
package is distributed to cluster and we want to minimize its size.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Op.java


will be good to add comment for this.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Op.java


Better to name it: connections. We may use it for other purposes later.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Stage.java


Add comments for this boolean.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Stage.java


Seems like this boolean is used to keep state of printer while visiting 
over plan.
If so, better design IMO is to keep this state with printer. This class 
should be state free.
Just a thought, you may know better.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Vertex.java


Can you add comments about this and next boolean.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Vertex.java


Similar comment about state being with printer.


- Ashutosh Chauhan


On March 26, 2015, 8:10 p.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32406/
> ---
> 
> (Updated March 26, 2015, 8:10 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Current Hive Explain (default) is targeted at MR Audience. We need a new 
> level of explain plan to be targeted at RDBMS audience. The explain requires 
> these:
> 1) The focus needs to be on what part of the query is being executed rather 
> than internals of the engines
> 2) There needs to be a clearly readable tree of operations
> 3) Examples - Table scan should mention the table being scanned, the Sarg, 
> the size of table and expected cardinality after the Sarg'ed read. The join 
> should mention the table being joined with and the join condition. The 
> aggregate should mention the columns in the group-by.
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cf82e8b 
>   itests/src/test/resources/testconfiguration.properties 288270e 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 149f911 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Attr.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Connection.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Op.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Stage.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/TezJsonParser.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/explain/Vertex.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileWork.java e572338 
>   ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanWork.java 
> 095afd4 
>   
> ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateWork.java
>  092f627 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTablePartMergeFilesDesc.java 
> eaf3dc4 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java 
> 38b6d96 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java 
> 476dfd1 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterDatabaseDesc.java e45bc26 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterIndexDesc.java db2cf7f 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 24cf1da 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ArchiveWork.java 9fb5c8b 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java 1737a34 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/BucketMapJoinContext.java 
> f436bc0 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CollectDesc.java 588e14d 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsDesc.java a44c8e8 
>

Re: Review Request 32406: Add another level of explain for RDBMS audience

2015-04-02 Thread pengcheng xiong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32406/
---

(Updated April 2, 2015, 8:07 p.m.)


Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Changes
---

address Ashutosh's comments, take into consideration of Mostafa's feedback, 
make the JSONParser easy to extend


Repository: hive-git


Description
---

Current Hive Explain (default) is targeted at MR Audience. We need a new level 
of explain plan to be targeted at RDBMS audience. The explain requires these:
1) The focus needs to be on what part of the query is being executed rather 
than internals of the engines
2) There needs to be a clearly readable tree of operations
3) Examples - Table scan should mention the table being scanned, the Sarg, the 
size of table and expected cardinality after the Sarg'ed read. The join should 
mention the table being joined with and the join condition. The aggregate 
should mention the columns in the group-by.


Diffs (updated)
-

  common/pom.xml 5b0e78c 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/JsonParser.java 
PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/jsonexplain/JsonParserFactory.java
 PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Attr.java 
PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Connection.java 
PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Op.java 
PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Stage.java 
PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParser.java
 PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Vertex.java 
PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1631e2d 
  itests/src/test/resources/testconfiguration.properties 288270e 
  ql/src/java/org/apache/hadoop/hive/ql/Context.java 0f7da53 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 149f911 
  ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileWork.java e572338 
  ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanWork.java 
095afd4 
  
ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateWork.java
 092f627 
  ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTablePartMergeFilesDesc.java 
eaf3dc4 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java c8bf7dc 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java 
38b6d96 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java 9834fc8 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterDatabaseDesc.java e45bc26 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterIndexDesc.java db2cf7f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 24cf1da 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ArchiveWork.java 9fb5c8b 
  ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java 6ab75a7 
  ql/src/java/org/apache/hadoop/hive/ql/plan/BucketMapJoinContext.java f436bc0 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CollectDesc.java 588e14d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsDesc.java a44c8e8 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsUpdateWork.java d644155 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsWork.java 3cae727 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CommonMergeJoinDesc.java 2354139 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CopyWork.java 3353384 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateDatabaseDesc.java a6b52aa 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java dce5ece 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateMacroDesc.java 3c5a723 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 8cadb96 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 3dad4ab 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java dd76a82 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 79d9d16 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DemuxDesc.java 62de2e4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DependencyCollectionWork.java 
35180cd 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DescDatabaseDesc.java 3c0ed2a 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DescFunctionDesc.java 814ad73 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DescTableDesc.java eefd4d4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 66d8768 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropFunctionDesc.java e1f93a1 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropMacroDesc.java 3e2aefc 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DropTableDesc.java c79710d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DummyStoreDesc.java 04e556d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicPruningEventDesc.java 
d6617b5

Re: Review Request 32406: Add another level of explain for RDBMS audience

2015-04-06 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32406/#review78955
---



ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java


You can not just use message because:
1. Message is too verbose in most cases
2. Many places its not because of missing feature

A solution is to introduce a global variable that captures the missing 
feature and set that to correct value in places where we are throwing the 
CalciteException


- John Pullokkaran


On April 2, 2015, 8:07 p.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32406/
> ---
> 
> (Updated April 2, 2015, 8:07 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Current Hive Explain (default) is targeted at MR Audience. We need a new 
> level of explain plan to be targeted at RDBMS audience. The explain requires 
> these:
> 1) The focus needs to be on what part of the query is being executed rather 
> than internals of the engines
> 2) There needs to be a clearly readable tree of operations
> 3) Examples - Table scan should mention the table being scanned, the Sarg, 
> the size of table and expected cardinality after the Sarg'ed read. The join 
> should mention the table being joined with and the join condition. The 
> aggregate should mention the columns in the group-by.
> 
> 
> Diffs
> -
> 
>   common/pom.xml 5b0e78c 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/JsonParser.java 
> PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/jsonexplain/JsonParserFactory.java
>  PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Attr.java 
> PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Connection.java 
> PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Op.java 
> PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Stage.java 
> PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParser.java
>  PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Vertex.java 
> PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1631e2d 
>   itests/src/test/resources/testconfiguration.properties 288270e 
>   ql/src/java/org/apache/hadoop/hive/ql/Context.java 0f7da53 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 149f911 
>   ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileWork.java e572338 
>   ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanWork.java 
> 095afd4 
>   
> ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateWork.java
>  092f627 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTablePartMergeFilesDesc.java 
> eaf3dc4 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java c8bf7dc 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java 
> 38b6d96 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java 
> 9834fc8 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterDatabaseDesc.java e45bc26 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterIndexDesc.java db2cf7f 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 24cf1da 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ArchiveWork.java 9fb5c8b 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java 6ab75a7 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/BucketMapJoinContext.java 
> f436bc0 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CollectDesc.java 588e14d 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsDesc.java a44c8e8 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsUpdateWork.java 
> d644155 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsWork.java 3cae727 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CommonMergeJoinDesc.java 2354139 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CopyWork.java 3353384 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateDatabaseDesc.java a6b52aa 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java dce5ece 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateMacroDesc.java 3c5a723 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 8cadb96 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 3dad4ab 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java dd76a82 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 79d9d16 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/

Re: Review Request 32406: Add another level of explain for RDBMS audience

2015-04-06 Thread pengcheng xiong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32406/
---

(Updated April 7, 2015, 12:42 a.m.)


Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Changes
---

address John's comments.


Repository: hive-git


Description
---

Current Hive Explain (default) is targeted at MR Audience. We need a new level 
of explain plan to be targeted at RDBMS audience. The explain requires these:
1) The focus needs to be on what part of the query is being executed rather 
than internals of the engines
2) There needs to be a clearly readable tree of operations
3) Examples - Table scan should mention the table being scanned, the Sarg, the 
size of table and expected cardinality after the Sarg'ed read. The join should 
mention the table being joined with and the join condition. The aggregate 
should mention the columns in the group-by.


Diffs (updated)
-

  common/pom.xml 5b0e78c 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/JsonParser.java 
PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/jsonexplain/JsonParserFactory.java
 PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Attr.java 
PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Connection.java 
PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Op.java 
PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Stage.java 
PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParser.java
 PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Vertex.java 
PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cc16c38 
  itests/src/test/resources/testconfiguration.properties 288270e 
  ql/src/java/org/apache/hadoop/hive/ql/Context.java 0f7da53 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 149f911 
  ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileWork.java e572338 
  ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanWork.java 
095afd4 
  
ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateWork.java
 092f627 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
 a71cd35 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
 6c215c9 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
 29134a4 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java
 5c0616e 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
 8c3587e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTablePartMergeFilesDesc.java 
eaf3dc4 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java c8bf7dc 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java 
38b6d96 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1f6d53d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java 9834fc8 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterDatabaseDesc.java e45bc26 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterIndexDesc.java db2cf7f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 24cf1da 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ArchiveWork.java 9fb5c8b 
  ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java 6ab75a7 
  ql/src/java/org/apache/hadoop/hive/ql/plan/BucketMapJoinContext.java f436bc0 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CollectDesc.java 588e14d 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsDesc.java a44c8e8 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsUpdateWork.java d644155 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsWork.java 3cae727 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CommonMergeJoinDesc.java 2354139 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CopyWork.java 3353384 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateDatabaseDesc.java a6b52aa 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java dce5ece 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateMacroDesc.java 3c5a723 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 8cadb96 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 3dad4ab 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java dd76a82 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 79d9d16 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DemuxDesc.java 62de2e4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DependencyCollectionWork.java 
35180cd 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DescDatabaseDesc.java 3c0ed2a 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DescFunctionDesc.java 814ad73 
  ql/src/java/org/apache/hadoop

Re: Review Request 32406: Add another level of explain for RDBMS audience

2015-04-07 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32406/#review79199
---

Ship it!


Ship It!

- John Pullokkaran


On April 7, 2015, 12:42 a.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32406/
> ---
> 
> (Updated April 7, 2015, 12:42 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Current Hive Explain (default) is targeted at MR Audience. We need a new 
> level of explain plan to be targeted at RDBMS audience. The explain requires 
> these:
> 1) The focus needs to be on what part of the query is being executed rather 
> than internals of the engines
> 2) There needs to be a clearly readable tree of operations
> 3) Examples - Table scan should mention the table being scanned, the Sarg, 
> the size of table and expected cardinality after the Sarg'ed read. The join 
> should mention the table being joined with and the join condition. The 
> aggregate should mention the columns in the group-by.
> 
> 
> Diffs
> -
> 
>   common/pom.xml 5b0e78c 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/JsonParser.java 
> PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/jsonexplain/JsonParserFactory.java
>  PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Attr.java 
> PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Connection.java 
> PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Op.java 
> PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Stage.java 
> PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParser.java
>  PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Vertex.java 
> PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cc16c38 
>   itests/src/test/resources/testconfiguration.properties 288270e 
>   ql/src/java/org/apache/hadoop/hive/ql/Context.java 0f7da53 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 149f911 
>   ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileWork.java e572338 
>   ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanWork.java 
> 095afd4 
>   
> ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateWork.java
>  092f627 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
>  a71cd35 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
>  6c215c9 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
>  29134a4 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java
>  5c0616e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
>  8c3587e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTablePartMergeFilesDesc.java 
> eaf3dc4 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java c8bf7dc 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java 
> 38b6d96 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1f6d53d 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java 
> 9834fc8 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterDatabaseDesc.java e45bc26 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterIndexDesc.java db2cf7f 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 24cf1da 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ArchiveWork.java 9fb5c8b 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java 6ab75a7 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/BucketMapJoinContext.java 
> f436bc0 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CollectDesc.java 588e14d 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsDesc.java a44c8e8 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsUpdateWork.java 
> d644155 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsWork.java 3cae727 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CommonMergeJoinDesc.java 2354139 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CopyWork.java 3353384 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateDatabaseDesc.java a6b52aa 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java dce5ece 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateMacroDesc.java 3c5a723 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 8cadb96 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.jav