Re: Review Request 37917: HIVE-11689 minor flow changes to ORC split generation

2015-08-31 Thread Sergey Shelukhin


> On Aug. 30, 2015, 6:24 a.m., Swarnim Kulkarni wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java, line 1428
> > 
> >
> > Worth logging a JIRA for this? :)

this is an old comment that may be affected due to code move or something


- Sergey


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37917/#review97011
---


On Aug. 29, 2015, 1:47 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37917/
> ---
> 
> (Updated Aug. 29, 2015, 1:47 a.m.)
> 
> 
> Review request for hive, Gopal V and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see JIRA
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 8c138b9 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
> ce86cd8 
> 
> Diff: https://reviews.apache.org/r/37917/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>



Re: Review Request 37917: HIVE-11689 minor flow changes to ORC split generation

2015-08-31 Thread Sergey Shelukhin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37917/
---

(Updated Aug. 31, 2015, 10:49 p.m.)


Review request for hive, Gopal V and Prasanth_J.


Repository: hive-git


Description
---

see JIRA


Diffs (updated)
-

  data/conf/tez/hive-site.xml 2f9415a 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 8c138b9 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
ce86cd8 

Diff: https://reviews.apache.org/r/37917/diff/


Testing
---


Thanks,

Sergey Shelukhin



Re: Review Request 37917: HIVE-11689 minor flow changes to ORC split generation

2015-08-30 Thread j . prasanth . j

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37917/#review97032
---

Ship it!


Ship It!

- Prasanth_J


On Aug. 29, 2015, 1:47 a.m., Sergey Shelukhin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37917/
 ---
 
 (Updated Aug. 29, 2015, 1:47 a.m.)
 
 
 Review request for hive, Gopal V and Prasanth_J.
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 see JIRA
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 8c138b9 
   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
 ce86cd8 
 
 Diff: https://reviews.apache.org/r/37917/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Sergey Shelukhin
 




Review Request 37917: HIVE-11689 minor flow changes to ORC split generation

2015-08-28 Thread Sergey Shelukhin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37917/
---

Review request for hive, Gopal V and Prasanth_J.


Repository: hive-git


Description
---

see JIRA


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 8c138b9 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
ce86cd8 

Diff: https://reviews.apache.org/r/37917/diff/


Testing
---


Thanks,

Sergey Shelukhin