Re: Review Request 38838: HIVE-11913 : Verify existence of tests for new changes in HiveQA
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38838/#review101360 --- Ship it! The patch looks good. I just saw many lines that were not changed are shown with green/yellow lines. Could it be because spaces? - Sergio Pena On Sept. 29, 2015, 2:17 a.m., Szehon Ho wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38838/ > --- > > (Updated Sept. 29, 2015, 2:17 a.m.) > > > Review request for hive, Brock Noland and Sergio Pena. > > > Bugs: HIVE-11913 > https://issues.apache.org/jira/browse/HIVE-11913 > > > Repository: hive-git > > > Description > --- > > Make HiveQA give -1 if there are no tests added or modified (Test.*.java or > .*.q) in the git patch. Basic idea is to add a new test phase > "TestCheckPhase" to read the git patch and parse for newly added tests, and > channel this information to the JIRA reporting service. > > There are some changes as I also did auto-cleanup the JIRAService class to > meet the coding guidelines. > > > Diffs > - > > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java > c7be572 > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java > 7217ef9 > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/TestCheckPhase.java > PRE-CREATION > > testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestTestCheckPhase.java > PRE-CREATION > testutils/ptest2/src/test/resources/HIVE-10761.6.patch PRE-CREATION > testutils/ptest2/src/test/resources/HIVE-11271.4.patch PRE-CREATION > testutils/ptest2/src/test/resources/HIVE-9377.1.patch PRE-CREATION > testutils/ptest2/src/test/resources/remove-test.patch PRE-CREATION > > Diff: https://reviews.apache.org/r/38838/diff/ > > > Testing > --- > > Added unit tests. Will need to see in production. > > > Thanks, > > Szehon Ho > >
Re: Review Request 38838: HIVE-11913 : Verify existence of tests for new changes in HiveQA
> On Oct. 2, 2015, 7:44 p.m., Sergio Pena wrote: > > The patch looks good. > > I just saw many lines that were not changed are shown with green/yellow > > lines. Could it be because spaces? Hi yea, as I mentioned, I used the codestyle. Yes they are spaces. At first it wasn't intentional, but anyway the fixes are conforming to the code standard, so I left it. - Szehon --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38838/#review101360 --- On Sept. 29, 2015, 2:17 a.m., Szehon Ho wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38838/ > --- > > (Updated Sept. 29, 2015, 2:17 a.m.) > > > Review request for hive, Brock Noland and Sergio Pena. > > > Bugs: HIVE-11913 > https://issues.apache.org/jira/browse/HIVE-11913 > > > Repository: hive-git > > > Description > --- > > Make HiveQA give -1 if there are no tests added or modified (Test.*.java or > .*.q) in the git patch. Basic idea is to add a new test phase > "TestCheckPhase" to read the git patch and parse for newly added tests, and > channel this information to the JIRA reporting service. > > There are some changes as I also did auto-cleanup the JIRAService class to > meet the coding guidelines. > > > Diffs > - > > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java > c7be572 > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java > 7217ef9 > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/TestCheckPhase.java > PRE-CREATION > > testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestTestCheckPhase.java > PRE-CREATION > testutils/ptest2/src/test/resources/HIVE-10761.6.patch PRE-CREATION > testutils/ptest2/src/test/resources/HIVE-11271.4.patch PRE-CREATION > testutils/ptest2/src/test/resources/HIVE-9377.1.patch PRE-CREATION > testutils/ptest2/src/test/resources/remove-test.patch PRE-CREATION > > Diff: https://reviews.apache.org/r/38838/diff/ > > > Testing > --- > > Added unit tests. Will need to see in production. > > > Thanks, > > Szehon Ho > >
Review Request 38838: HIVE-11913 : Verify existence of tests for new changes in HiveQA
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38838/ --- Review request for hive, Brock Noland and Sergio Pena. Bugs: HIVE-11913 https://issues.apache.org/jira/browse/HIVE-11913 Repository: hive-git Description --- Make HiveQA give -1 if there are no tests added or modified (Test.*.java or .*.q) in the git patch. Basic idea is to add a new test phase "TestCheckPhase" to read the git patch and parse for newly added tests, and channel this information to the JIRA reporting service. There are some changes as I also did auto-cleanup the JIRAService class to meet the coding guidelines. Diffs - testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java c7be572 testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 7217ef9 testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/TestCheckPhase.java PRE-CREATION testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestTestCheckPhase.java PRE-CREATION testutils/ptest2/src/test/resources/HIVE-10761.6.patch PRE-CREATION testutils/ptest2/src/test/resources/HIVE-11271.4.patch PRE-CREATION testutils/ptest2/src/test/resources/HIVE-9377.1.patch PRE-CREATION testutils/ptest2/src/test/resources/remove-test.patch PRE-CREATION Diff: https://reviews.apache.org/r/38838/diff/ Testing --- Added unit tests. Will need to see in production. Thanks, Szehon Ho
