Re: Review Request 39522: HIVE-12220 LLAP: Usability issues with hive.llap.io.cache.orc.size

2015-10-22 Thread Sergey Shelukhin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39522/
---

(Updated Oct. 22, 2015, 10:33 p.m.)


Review request for hive and Gopal V.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6c7adbd 
  llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java 
ae64d20 
  
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java
 4a256ee 
  
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java
 f551edb 
  llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 
05fecc7 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 
6f75001 
  
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java
 86a56ab 
  
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java 
d4d4bb2 
  
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java
 a423eeb 

Diff: https://reviews.apache.org/r/39522/diff/


Testing
---


Thanks,

Sergey Shelukhin



Re: Review Request 39522: HIVE-12220 LLAP: Usability issues with hive.llap.io.cache.orc.size

2015-10-22 Thread Sergey Shelukhin


> On Oct. 21, 2015, 8:11 p.m., Gopal V wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 2291
> > 
> >
> > Remove the .ll.?

it stands for low-level


- Sergey


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39522/#review103461
---


On Oct. 21, 2015, 8:04 p.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39522/
> ---
> 
> (Updated Oct. 21, 2015, 8:04 p.m.)
> 
> 
> Review request for hive and Gopal V.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6c7adbd 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java 
> ae64d20 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java
>  4a256ee 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java
>  f551edb 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 
> 05fecc7 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 
> 6f75001 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java
>  86a56ab 
>   
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java
>  d4d4bb2 
>   
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java
>  a423eeb 
> 
> Diff: https://reviews.apache.org/r/39522/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>



Re: Review Request 39522: HIVE-12220 LLAP: Usability issues with hive.llap.io.cache.orc.size

2015-10-21 Thread Gopal V

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39522/#review103461
---



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2291)


Remove the .ll.?


- Gopal V


On Oct. 21, 2015, 8:04 p.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39522/
> ---
> 
> (Updated Oct. 21, 2015, 8:04 p.m.)
> 
> 
> Review request for hive and Gopal V.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6c7adbd 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java 
> ae64d20 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java
>  4a256ee 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java
>  f551edb 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 
> 05fecc7 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 
> 6f75001 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java
>  86a56ab 
>   
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java
>  d4d4bb2 
>   
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java
>  a423eeb 
> 
> Diff: https://reviews.apache.org/r/39522/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>



Review Request 39522: HIVE-12220 LLAP: Usability issues with hive.llap.io.cache.orc.size

2015-10-21 Thread Sergey Shelukhin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39522/
---

Review request for hive and Gopal V.


Repository: hive-git


Description
---

see jira


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6c7adbd 
  llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java 
ae64d20 
  
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java
 4a256ee 
  
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java
 f551edb 
  llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 
05fecc7 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 
6f75001 
  
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java
 86a56ab 
  
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java 
d4d4bb2 
  
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java
 a423eeb 

Diff: https://reviews.apache.org/r/39522/diff/


Testing
---


Thanks,

Sergey Shelukhin