Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-03-08 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/
---

(Updated March 9, 2016, 2:07 a.m.)


Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5098851 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileFormatProxy.java 
ec0be2b 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 
bd4e188 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
0e8a157 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
9048d45 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
62677d1 
  
metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java
 1b388aa 
  orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 9bf9377 
  ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/LocalCache.java PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetastoreExternalCachesByConf.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java ef76723 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 0ebcd2a 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java fdc7956 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
4fafe8c 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java 
7a93b54 
  storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
dc71db4 
  
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 
be5e67b 

Diff: https://reviews.apache.org/r/40415/diff/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-03-07 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/#review122384
---


Ship it!




Ship It!

- Prasanth_J


On March 7, 2016, 9:36 p.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40415/
> ---
> 
> (Updated March 7, 2016, 9:36 p.m.)
> 
> 
> Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5098851 
>   metastore/src/java/org/apache/hadoop/hive/metastore/FileFormatProxy.java 
> ec0be2b 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 
> bd4e188 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
> b5c4d1d 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
> cb092d1 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java
>  1b388aa 
>   orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 
>   ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 9bf9377 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/LocalCache.java PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetastoreExternalCachesByConf.java
>  PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java 
> ef76723 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 0ebcd2a 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ad17096 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
> 4fafe8c 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java 
> 7a93b54 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
> dc71db4 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
>  be5e67b 
> 
> Diff: https://reviews.apache.org/r/40415/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-03-07 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/
---

(Updated March 7, 2016, 9:36 p.m.)


Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5098851 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileFormatProxy.java 
ec0be2b 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 
bd4e188 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
b5c4d1d 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
cb092d1 
  
metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java
 1b388aa 
  orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 9bf9377 
  ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/LocalCache.java PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetastoreExternalCachesByConf.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java ef76723 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 0ebcd2a 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ad17096 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
4fafe8c 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java 
7a93b54 
  storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
dc71db4 
  
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 
be5e67b 

Diff: https://reviews.apache.org/r/40415/diff/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-03-07 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/
---

(Updated March 7, 2016, 9:32 p.m.)


Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5098851 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileFormatProxy.java 
ec0be2b 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 
bd4e188 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
b5c4d1d 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
cb092d1 
  
metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java
 1b388aa 
  orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 9bf9377 
  ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/LocalCache.java PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetastoreExternalCachesByConf.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java ef76723 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 0ebcd2a 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ad17096 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
4fafe8c 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java 
7a93b54 
  storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
dc71db4 
  
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 
be5e67b 

Diff: https://reviews.apache.org/r/40415/diff/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-03-07 Thread Sergey Shelukhin 


> On March 7, 2016, 7:27 a.m., Prasanth_J wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java,
> >  line 2223
> > 
> >
> > use ThreadLocal?

Not sure that helps. Also, it's a threadlocal... Remembering the result for 
some time could be a good solution in a follow-up, but we assume by default 
that if the user enables it they know what they are doing, or pay a small perf 
penalty


- Sergey


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/#review122261
---


On March 2, 2016, 2:30 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40415/
> ---
> 
> (Updated March 2, 2016, 2:30 a.m.)
> 
> 
> Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2723dad 
>   metastore/src/java/org/apache/hadoop/hive/metastore/FileFormatProxy.java 
> ec0be2b 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 
> bd4e188 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
> b5c4d1d 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
> cb092d1 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java
>  1b388aa 
>   orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 
>   ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 9bf9377 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/LocalCache.java PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetastoreExternalCachesByConf.java
>  PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java 
> ef76723 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 0ebcd2a 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java fdc7956 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
> 4fafe8c 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java 
> 7a93b54 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
> dc71db4 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
>  be5e67b 
> 
> Diff: https://reviews.apache.org/r/40415/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-03-06 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/#review122261
---




metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
(line )


use ThreadLocal?



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
(line 2251)


Can this be set here or provide a separate API for not getting footer? We 
would otherwise transfer more data through wire.



orc/src/java/org/apache/orc/impl/InStream.java 


nit: Unrelated changes.


- Prasanth_J


On March 2, 2016, 2:30 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40415/
> ---
> 
> (Updated March 2, 2016, 2:30 a.m.)
> 
> 
> Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2723dad 
>   metastore/src/java/org/apache/hadoop/hive/metastore/FileFormatProxy.java 
> ec0be2b 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 
> bd4e188 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
> b5c4d1d 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
> cb092d1 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java
>  1b388aa 
>   orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 
>   ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 9bf9377 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/LocalCache.java PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetastoreExternalCachesByConf.java
>  PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java 
> ef76723 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 0ebcd2a 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java fdc7956 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
> 4fafe8c 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java 
> 7a93b54 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
> dc71db4 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
>  be5e67b 
> 
> Diff: https://reviews.apache.org/r/40415/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-03-01 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/
---

(Updated March 2, 2016, 2:30 a.m.)


Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2723dad 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileFormatProxy.java 
ec0be2b 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 
bd4e188 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
b5c4d1d 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
cb092d1 
  
metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java
 1b388aa 
  orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 9bf9377 
  ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/LocalCache.java PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetastoreExternalCachesByConf.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java ef76723 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 0ebcd2a 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java fdc7956 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
4fafe8c 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java 
7a93b54 
  storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
dc71db4 
  
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 
be5e67b 

Diff: https://reviews.apache.org/r/40415/diff/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-02-26 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/
---

(Updated Feb. 26, 2016, 8:12 p.m.)


Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java e868500 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileFormatProxy.java 
ec0be2b 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 
bd4e188 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
b5c4d1d 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
cb092d1 
  
metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java
 1b388aa 
  orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 520ae74 
  ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/LocalCache.java PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetastoreExternalCachesByConf.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java ef76723 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java d175d2d 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java aa1c925 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
6f84708 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java 
7a93b54 
  storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
dc71db4 
  
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 
be5e67b 

Diff: https://reviews.apache.org/r/40415/diff/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-02-26 Thread Sergey Shelukhin 


> On Feb. 16, 2016, 7:38 p.m., Prasanth_J wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java, 
> > line 1523
> > 
> >
> > Then why provide this interface? Is it client's responsibility as to 
> > when to use this interface?

Yes :)


> On Feb. 16, 2016, 7:38 p.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java, line 484
> > 
> >
> > Is it intentional? Stacktrace will be lost.

Yeah, this exception is not very useful, it's usually just the fact that the FS 
doesn't support file IDs.


> On Feb. 16, 2016, 7:38 p.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java, line 
> > 41
> > 
> >
> > what is the byteBuffer arg contain? What is the return type? It's 
> > unclear from the function signature. I think it will be better to do the 
> > conversion from SplitInfo to ByteBuffer just right before we send it across 
> > the wire. SplitInfo can be generic across file formats.

changed the return type; the arg is file metadata, documented on the interface, 
I renamed it for clarity


> On Feb. 16, 2016, 7:38 p.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java, line 625
> > 
> >
> > nit. are there multiple caches?

yes, by conf. Usually there would only be one. Renamed for clarity.


> On Feb. 16, 2016, 7:38 p.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java, line 1002
> > 
> >
> > same as above. is it required to drop the stacktrace and just print the 
> > message?

Yes, stacktrace is annoying and pointless :) In case if there's some FS issue, 
the other (non-ID) API will probably also fail and produce a proper stack trace


- Sergey


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/#review119116
---


On Feb. 26, 2016, 5:04 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40415/
> ---
> 
> (Updated Feb. 26, 2016, 5:04 a.m.)
> 
> 
> Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java e868500 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 
> bd4e188 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
> b5c4d1d 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
> cb092d1 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java
>  1b388aa 
>   orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 
>   ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 520ae74 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java 
> ef76723 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java d175d2d 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java aa1c925 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
> 6f84708 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java 
> 7a93b54 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
> dc71db4 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
>  be5e67b 
> 
> Diff: https://reviews.apache.org/r/40415/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-02-25 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/
---

(Updated Feb. 26, 2016, 5:04 a.m.)


Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java e868500 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 
bd4e188 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
b5c4d1d 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
cb092d1 
  
metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java
 1b388aa 
  orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 520ae74 
  ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java ef76723 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java d175d2d 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java aa1c925 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
6f84708 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java 
7a93b54 
  storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
dc71db4 
  
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 
be5e67b 

Diff: https://reviews.apache.org/r/40415/diff/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-02-16 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/#review119116
---




metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
(line 2230)


nit: use single arg ctor instead?



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
(line 2255)


nit: same as above. use 2 arg ctor instead?



metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java (line 
1523)


Then why provide this interface? Is it client's responsibility as to when 
to use this interface?



ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java (line 484)


Is it intentional? Stacktrace will be lost.



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java (line 41)


what is the byteBuffer arg contain? What is the return type? It's unclear 
from the function signature. I think it will be better to do the conversion 
from SplitInfo to ByteBuffer just right before we send it across the wire. 
SplitInfo can be generic across file formats.



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 625)


nit. are there multiple caches?



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 998)


same as above. is it required to drop the stacktrace and just print the 
message?



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 2002)


OrcInputFormat is becoming the next SemanticAnalyzer. Too many inner 
classes/interfaces. :)



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 2312)


In general, ORC PPD is controlled by hive.optimizer.index.filter config. If 
this config is disabled, we should disable metastore footer cache ppd as well.


- Prasanth_J


On Feb. 12, 2016, 2:58 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40415/
> ---
> 
> (Updated Feb. 12, 2016, 2:58 a.m.)
> 
> 
> Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cd17a84 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 
> bd4e188 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
> 564fca4 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
> 07c20bf 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java
>  1b388aa 
>   orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 
>   ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 520ae74 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java 
> ef76723 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java f36f707 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java a92c002 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
> 9b1d7ae 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java 
> 7a93b54 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
> dc71db4 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
>  be5e67b 
> 
> Diff: https://reviews.apache.org/r/40415/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-02-11 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/
---

(Updated Feb. 12, 2016, 2:58 a.m.)


Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cd17a84 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 
bd4e188 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
564fca4 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
07c20bf 
  
metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java
 1b388aa 
  orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 520ae74 
  ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java ef76723 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java f36f707 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java a92c002 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
9b1d7ae 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java 
7a93b54 
  storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
dc71db4 
  
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 
be5e67b 

Diff: https://reviews.apache.org/r/40415/diff/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-01-28 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/#review116818
---




ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 675)


There's already an in-out parameter for results, so I feel it will make it 
unobvious if these are inconsistent


- Sergey Shelukhin


On Nov. 18, 2015, 12:23 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40415/
> ---
> 
> (Updated Nov. 18, 2015, 12:23 a.m.)
> 
> 
> Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 953e52c 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
> c5e7a5f 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
> aa96f77 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 46862da 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 488d923 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
> ec90481 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
> dc71db4 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java 
> d70b3b0 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
>  eeff131 
> 
> Diff: https://reviews.apache.org/r/40415/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-01-28 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/#review116839
---




ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1102)


I actaully initially created PairOfLong and then renamed the fields for 
clarity. I looked at it; it is immutable and a pain to use for just having a 
pair of long.



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1964)


Added a comment. Basically, in the PPD case, we don't parse the footers, so 
we don't care. Also having PPD implies that footers are correct, otherwise PPD 
wouldn't be able to work.



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 2055)


Will try that



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 2061)


This is after modification



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 2116)


not really, it's owned by one thread. I just want to get the bytes out w/o 
copy.


- Sergey Shelukhin


On Nov. 18, 2015, 12:23 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40415/
> ---
> 
> (Updated Nov. 18, 2015, 12:23 a.m.)
> 
> 
> Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 953e52c 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
> c5e7a5f 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
> aa96f77 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 46862da 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 488d923 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
> ec90481 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
> dc71db4 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java 
> d70b3b0 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
>  eeff131 
> 
> Diff: https://reviews.apache.org/r/40415/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2016-01-28 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/
---

(Updated Jan. 29, 2016, 12:26 a.m.)


Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java bfd88f8 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
09a6aea 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
4284d54 
  orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java f36f707 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 0bab769 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
873cf2b 
  storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
dc71db4 
  
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 
be5e67b 

Diff: https://reviews.apache.org/r/40415/diff/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2015-11-24 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/#review107860
---



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 675)


Can you make ppdResults are return value and not inOut parameter?



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1083)


Can this ever get large than 64MB? If so setSizeLimit should be increased 
in CodedInputStream.



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1102)


Can you make use of Guava's Range instead?



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1123)


Looks like current is being populated inside this method. Can this method 
be made to return Range instead?



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1826)


Return ppdResult instead?



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1917)


Can you reuse Utilities' threadlocal kryo object here?



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1964)


I don't clearly understand this. Why do we populate corruptIds list if ppd 
is disabled?



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 2055)


You can use the deserialized sarg as cloned object here. 
Utilities.clonePlan() does that. Alternatively, you can try use kryo.copy() for 
deep copying object. There is a slight difference though, serializing and 
deserializing for deep copy does not copy transient fields but kryo.copy() will 
copy transient fields as well. HIVE-12424 for more info.



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 2061)


Reading this back should get you cloned object.



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 2116)


All ByteArrayOutputStream methods are synchronized. Should this be as well?



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 3384)


unused variable: conf



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 3393)


same here



ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java (line 
1035)


Will it be easy to add unit tests for this patch? Or qfile test.



storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 
(line 173)


This is still not deep copy. literal and literalList can be refs. I think 
we should use kryo instead. This will also be fragile when we add fields to 
this class.


- Prasanth_J


On Nov. 18, 2015, 12:23 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40415/
> ---
> 
> (Updated Nov. 18, 2015, 12:23 a.m.)
> 
> 
> Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 953e52c 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
> c5e7a5f 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
> aa96f77 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 46862da 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 488d923 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
> ec90481 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
> dc71db4 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java 
> d70b3b0 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
>  eeff131 
> 
> Diff: https://reviews.apache.org/r/40415/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy

2015-11-17 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/
---

Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.


Repository: hive-git


Description
---

see jira


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 953e52c 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
c5e7a5f 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
aa96f77 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 46862da 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 488d923 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
ec90481 
  storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java 
dc71db4 
  storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java 
d70b3b0 
  
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 
eeff131 

Diff: https://reviews.apache.org/r/40415/diff/


Testing
---


Thanks,

Sergey Shelukhin