Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez 


> On Dec. 18, 2015, 8:09 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java, line 492
> > 
> >
> > This is fragile; i.e reusing the flag whether to run CBO or not for 
> > whether CBO was actually run successfully.
> > 
> > We already keep state in parsecontext about this.
> 
> Jesús Camacho Rodríguez wrote:
> I did not create the variable, I just created an access method i.e. the 
> variable was already there. It is only checked at SemanticAnalyzer to know 
> whether it should introduce isnotnull filters below Join or not.

In addition, I meant to say that variable is set to false if CBO fails (line 
330 in CalcitePlanner: runCBO = false;)


- Jesús


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/#review111254
---


On Dec. 18, 2015, 10:19 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41457/
> ---
> 
> (Updated Dec. 18, 2015, 10:19 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Bugs: HIVE-11865
> https://issues.apache.org/jira/browse/HIVE-11865
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Disable Hive PPD optimizer when CBO has optimized the plan
> 
> 
> Diffs
> -
> 
>   hbase-handler/src/test/results/positive/hbase_queries.q.out 
> 3907bc946679c0ce2492692dcb7e2cf252c6e188 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
> 8f48e7df4b9c081528b82545d445f75f67f93bfc 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
>  142812ca703d5e667bd532a711d29594123bde50 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
>  8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
>  7e484b90deed2dfb120faa2699eb9b9b7a4e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
>  c8de1d89a1df083cd125ae8c11bf854b09915680 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> 7c5a43ff4060c9a4d9c4c5523d851ef959da3932 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 27549dceac8b5913b1fb1604bde213ae26b243bf 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 
> ccc4bb454e61e3c39b1f90f29de5e754f8d886bf 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 
> 1702628447d38b09c9b7d0dcf38218a9037a2c64 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java 
> accfb3b9f5631f25220c88b759dba6c5299b4044 
>   ql/src/test/results/clientpositive/auto_join12.q.out 
> 6f08aa8f043113f0a99acd10c848f60a122a3f0b 
>   ql/src/test/results/clientpositive/auto_join13.q.out 
> d29818cf438449a6a1413edd7d474c4ab35f2148 
>   ql/src/test/results/clientpositive/auto_join16.q.out 
> 38738ede2b4cd49aa24490eafb81dec1de78bea5 
>   ql/src/test/results/clientpositive/auto_join2.q.out 
> ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
>   ql/src/test/results/clientpositive/auto_join33.q.out 
> 8b13bd0cb7fd869c58c9d092b2e8710391c96503 
>   ql/src/test/results/clientpositive/auto_join_filters.q.out 
> e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
>   ql/src/test/results/clientpositive/auto_join_nulls.q.out 
> 954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
>   ql/src/test/results/clientpositive/auto_join_stats.q.out 
> feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
>   ql/src/test/results/clientpositive/auto_join_stats2.q.out 
> e0d0146dd6b86e9f69a467dcde0c020c31af499d 
>   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
> c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
>   ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
> 096f5d445bc7e61381775270bef04e911eac5bb6 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
> 30853c42a52e1def5a913352580e0b5391ac2050 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
> 3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 
> e6c2832003a1bb804f99125866bff6117e4dab73 
>   ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out 
> 326e4d67f00158929f4aaa0a2ec53cedabe3e92c 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b1e43fed3326c8c43e3266ad281c86a054 
>   ql/src/test/resu

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/
---

(Updated Dec. 18, 2015, 10:19 p.m.)


Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Bugs: HIVE-11865
https://issues.apache.org/jira/browse/HIVE-11865


Repository: hive-git


Description
---

Disable Hive PPD optimizer when CBO has optimized the plan


Diffs (updated)
-

  hbase-handler/src/test/results/positive/hbase_queries.q.out 
3907bc946679c0ce2492692dcb7e2cf252c6e188 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
8f48e7df4b9c081528b82545d445f75f67f93bfc 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
 142812ca703d5e667bd532a711d29594123bde50 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
 8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
 7e484b90deed2dfb120faa2699eb9b9b7a4e 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
 c8de1d89a1df083cd125ae8c11bf854b09915680 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
7c5a43ff4060c9a4d9c4c5523d851ef959da3932 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
27549dceac8b5913b1fb1604bde213ae26b243bf 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 
ccc4bb454e61e3c39b1f90f29de5e754f8d886bf 
  ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 
1702628447d38b09c9b7d0dcf38218a9037a2c64 
  ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java 
accfb3b9f5631f25220c88b759dba6c5299b4044 
  ql/src/test/results/clientpositive/auto_join12.q.out 
6f08aa8f043113f0a99acd10c848f60a122a3f0b 
  ql/src/test/results/clientpositive/auto_join13.q.out 
d29818cf438449a6a1413edd7d474c4ab35f2148 
  ql/src/test/results/clientpositive/auto_join16.q.out 
38738ede2b4cd49aa24490eafb81dec1de78bea5 
  ql/src/test/results/clientpositive/auto_join2.q.out 
ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
  ql/src/test/results/clientpositive/auto_join33.q.out 
8b13bd0cb7fd869c58c9d092b2e8710391c96503 
  ql/src/test/results/clientpositive/auto_join_filters.q.out 
e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
  ql/src/test/results/clientpositive/auto_join_nulls.q.out 
954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
  ql/src/test/results/clientpositive/auto_join_stats.q.out 
feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
  ql/src/test/results/clientpositive/auto_join_stats2.q.out 
e0d0146dd6b86e9f69a467dcde0c020c31af499d 
  ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
  ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
096f5d445bc7e61381775270bef04e911eac5bb6 
  ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
30853c42a52e1def5a913352580e0b5391ac2050 
  ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
  ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 
e6c2832003a1bb804f99125866bff6117e4dab73 
  ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out 
326e4d67f00158929f4aaa0a2ec53cedabe3e92c 
  ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
62b611b1e43fed3326c8c43e3266ad281c86a054 
  ql/src/test/results/clientpositive/cbo_rp_join0.q.out 
3c6bb7319fd7605a62f082b989f723d5aab6c3fe 
  ql/src/test/results/clientpositive/cbo_rp_join1.q.out 
e77002866174f85168859c4145e7016c9d829bb6 
  ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out 
b14caa80b3346036f9ec835fe4e2294f47eb7ee5 
  ql/src/test/results/clientpositive/cbo_rp_outer_join_ppr.q.java1.7.out 
263053705347793513a44d49968dedd4fdffecfe 
  ql/src/test/results/clientpositive/correlationoptimizer10.q.out 
860452ef9bbf38df7aaeb00eb2636f53730ae923 
  ql/src/test/results/clientpositive/correlationoptimizer13.q.out 
82304d8ff96e14bf18cde3f0867b25c6757d40d6 
  ql/src/test/results/clientpositive/correlationoptimizer9.q.out 
d32003dead268bd435713751d5e5956bdd4f5f74 
  ql/src/test/results/clientpositive/cross_join.q.out 
f36496e8503fedc67d6c9555b6e0dd5b0c9bd6ed 
  ql/src/test/results/clientpositive/cross_product_check_1.q.out 
e7d6900d64851fa21f976ca20b5d7d753aa5d28f 
  ql/src/test/results/clientpositive/cross_product_check_2.q.out 
df438c9ae7c95033383eae28bf8bada55c08b5c4 
  ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out 
b85d387f3910598a3300df9adc34dce952715a2e 
  
ql/src/test/results/clientpositive/encrypted/encryption_join_unencrypted_tbl.q.out
 8903860b7c3f906bc1d755a85150f078bd11735f

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez 


> On Dec. 18, 2015, 8:09 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java, line 492
> > 
> >
> > This is fragile; i.e reusing the flag whether to run CBO or not for 
> > whether CBO was actually run successfully.
> > 
> > We already keep state in parsecontext about this.

I did not create the variable, I just created an access method i.e. the 
variable was already there. It is only checked at SemanticAnalyzer to know 
whether it should introduce isnotnull filters below Join or not.


- Jesús


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/#review111254
---


On Dec. 18, 2015, 5:28 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41457/
> ---
> 
> (Updated Dec. 18, 2015, 5:28 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Bugs: HIVE-11865
> https://issues.apache.org/jira/browse/HIVE-11865
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Disable Hive PPD optimizer when CBO has optimized the plan
> 
> 
> Diffs
> -
> 
>   hbase-handler/src/test/results/positive/hbase_queries.q.out 
> 3907bc946679c0ce2492692dcb7e2cf252c6e188 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
> 8f48e7df4b9c081528b82545d445f75f67f93bfc 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
>  142812ca703d5e667bd532a711d29594123bde50 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
>  8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
>  7e484b90deed2dfb120faa2699eb9b9b7a4e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
>  c8de1d89a1df083cd125ae8c11bf854b09915680 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
>  efde6652ca270d8e8d8f682fc0ff260702f46d5a 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
>  feec3c25929cac0bb3b6f50d074557a3c2745889 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> 7c5a43ff4060c9a4d9c4c5523d851ef959da3932 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 27549dceac8b5913b1fb1604bde213ae26b243bf 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 
> ccc4bb454e61e3c39b1f90f29de5e754f8d886bf 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 
> 1702628447d38b09c9b7d0dcf38218a9037a2c64 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java 
> accfb3b9f5631f25220c88b759dba6c5299b4044 
>   ql/src/test/results/clientpositive/auto_join12.q.out 
> 6f08aa8f043113f0a99acd10c848f60a122a3f0b 
>   ql/src/test/results/clientpositive/auto_join13.q.out 
> d29818cf438449a6a1413edd7d474c4ab35f2148 
>   ql/src/test/results/clientpositive/auto_join16.q.out 
> 38738ede2b4cd49aa24490eafb81dec1de78bea5 
>   ql/src/test/results/clientpositive/auto_join2.q.out 
> ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
>   ql/src/test/results/clientpositive/auto_join33.q.out 
> 8b13bd0cb7fd869c58c9d092b2e8710391c96503 
>   ql/src/test/results/clientpositive/auto_join_filters.q.out 
> e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
>   ql/src/test/results/clientpositive/auto_join_nulls.q.out 
> 954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
>   ql/src/test/results/clientpositive/auto_join_stats.q.out 
> feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
>   ql/src/test/results/clientpositive/auto_join_stats2.q.out 
> e0d0146dd6b86e9f69a467dcde0c020c31af499d 
>   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
> c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
>   ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
> 096f5d445bc7e61381775270bef04e911eac5bb6 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
> 30853c42a52e1def5a913352580e0b5391ac2050 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
> 3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 
> e6c2832003a1bb804f99125866bff6117e4dab73 
>   ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out 
> 326e4d67f00158929f4aaa0a2ec53cedabe3e92c 
>   ql/src/test/resu

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez 


> On Dec. 18, 2015, 7:59 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java,
> >  line 1
> > 
> >
> > These seems cosmetic, do we need these?

These are all cosmetic, I changed them by mistake. They will not be changed in 
the final version.


- Jesús


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/#review111248
---


On Dec. 18, 2015, 5:28 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41457/
> ---
> 
> (Updated Dec. 18, 2015, 5:28 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Bugs: HIVE-11865
> https://issues.apache.org/jira/browse/HIVE-11865
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Disable Hive PPD optimizer when CBO has optimized the plan
> 
> 
> Diffs
> -
> 
>   hbase-handler/src/test/results/positive/hbase_queries.q.out 
> 3907bc946679c0ce2492692dcb7e2cf252c6e188 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
> 8f48e7df4b9c081528b82545d445f75f67f93bfc 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
>  142812ca703d5e667bd532a711d29594123bde50 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
>  8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
>  7e484b90deed2dfb120faa2699eb9b9b7a4e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
>  c8de1d89a1df083cd125ae8c11bf854b09915680 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
>  efde6652ca270d8e8d8f682fc0ff260702f46d5a 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
>  feec3c25929cac0bb3b6f50d074557a3c2745889 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> 7c5a43ff4060c9a4d9c4c5523d851ef959da3932 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 27549dceac8b5913b1fb1604bde213ae26b243bf 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 
> ccc4bb454e61e3c39b1f90f29de5e754f8d886bf 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 
> 1702628447d38b09c9b7d0dcf38218a9037a2c64 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java 
> accfb3b9f5631f25220c88b759dba6c5299b4044 
>   ql/src/test/results/clientpositive/auto_join12.q.out 
> 6f08aa8f043113f0a99acd10c848f60a122a3f0b 
>   ql/src/test/results/clientpositive/auto_join13.q.out 
> d29818cf438449a6a1413edd7d474c4ab35f2148 
>   ql/src/test/results/clientpositive/auto_join16.q.out 
> 38738ede2b4cd49aa24490eafb81dec1de78bea5 
>   ql/src/test/results/clientpositive/auto_join2.q.out 
> ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
>   ql/src/test/results/clientpositive/auto_join33.q.out 
> 8b13bd0cb7fd869c58c9d092b2e8710391c96503 
>   ql/src/test/results/clientpositive/auto_join_filters.q.out 
> e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
>   ql/src/test/results/clientpositive/auto_join_nulls.q.out 
> 954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
>   ql/src/test/results/clientpositive/auto_join_stats.q.out 
> feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
>   ql/src/test/results/clientpositive/auto_join_stats2.q.out 
> e0d0146dd6b86e9f69a467dcde0c020c31af499d 
>   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
> c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
>   ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
> 096f5d445bc7e61381775270bef04e911eac5bb6 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
> 30853c42a52e1def5a913352580e0b5391ac2050 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
> 3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 
> e6c2832003a1bb804f99125866bff6117e4dab73 
>   ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out 
> 326e4d67f00158929f4aaa0a2ec53cedabe3e92c 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b1e43fed3326c8c43e3266ad281c86a054 
>   ql/src/test/results/clientpositive/cbo_rp_join0.q.out 
> 3c6bb7319fd7605a62f082b989f723d5aab6c3fe 
>   ql/src/test/results/clientposi

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez 


> On Dec. 18, 2015, 7:52 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java, line 112
> > 
> >
> > In the CBO Success path the additional const prop seems unnecessary. 
> > All we have done between two const prop is is synthetic join predicates 
> > (not null predicates) && Simple predicate push down.

You are right; the latest version of the patch addresses this issue.


- Jesús


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/#review111247
---


On Dec. 18, 2015, 5:28 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41457/
> ---
> 
> (Updated Dec. 18, 2015, 5:28 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Bugs: HIVE-11865
> https://issues.apache.org/jira/browse/HIVE-11865
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Disable Hive PPD optimizer when CBO has optimized the plan
> 
> 
> Diffs
> -
> 
>   hbase-handler/src/test/results/positive/hbase_queries.q.out 
> 3907bc946679c0ce2492692dcb7e2cf252c6e188 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
> 8f48e7df4b9c081528b82545d445f75f67f93bfc 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
>  142812ca703d5e667bd532a711d29594123bde50 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
>  8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
>  7e484b90deed2dfb120faa2699eb9b9b7a4e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
>  c8de1d89a1df083cd125ae8c11bf854b09915680 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
>  efde6652ca270d8e8d8f682fc0ff260702f46d5a 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
>  feec3c25929cac0bb3b6f50d074557a3c2745889 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> 7c5a43ff4060c9a4d9c4c5523d851ef959da3932 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 27549dceac8b5913b1fb1604bde213ae26b243bf 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 
> ccc4bb454e61e3c39b1f90f29de5e754f8d886bf 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 
> 1702628447d38b09c9b7d0dcf38218a9037a2c64 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java 
> accfb3b9f5631f25220c88b759dba6c5299b4044 
>   ql/src/test/results/clientpositive/auto_join12.q.out 
> 6f08aa8f043113f0a99acd10c848f60a122a3f0b 
>   ql/src/test/results/clientpositive/auto_join13.q.out 
> d29818cf438449a6a1413edd7d474c4ab35f2148 
>   ql/src/test/results/clientpositive/auto_join16.q.out 
> 38738ede2b4cd49aa24490eafb81dec1de78bea5 
>   ql/src/test/results/clientpositive/auto_join2.q.out 
> ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
>   ql/src/test/results/clientpositive/auto_join33.q.out 
> 8b13bd0cb7fd869c58c9d092b2e8710391c96503 
>   ql/src/test/results/clientpositive/auto_join_filters.q.out 
> e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
>   ql/src/test/results/clientpositive/auto_join_nulls.q.out 
> 954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
>   ql/src/test/results/clientpositive/auto_join_stats.q.out 
> feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
>   ql/src/test/results/clientpositive/auto_join_stats2.q.out 
> e0d0146dd6b86e9f69a467dcde0c020c31af499d 
>   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
> c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
>   ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
> 096f5d445bc7e61381775270bef04e911eac5bb6 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
> 30853c42a52e1def5a913352580e0b5391ac2050 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
> 3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 
> e6c2832003a1bb804f99125866bff6117e4dab73 
>   ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out 
> 326e4d67f00158929f4aaa0a2ec53cedabe3e92c 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b1e43fed3326c8c43e3266ad281c86a054 
>   ql/src/test/results/cl

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/#review111288
---



ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 491)


I did not create the variable, I just created an access method i.e. the 
variable was already there. It is only checked at SemanticAnalyzer to know 
whether it should introduce isnotnull filters below Join or not.


- Jesús Camacho Rodríguez


On Dec. 18, 2015, 5:28 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41457/
> ---
> 
> (Updated Dec. 18, 2015, 5:28 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Bugs: HIVE-11865
> https://issues.apache.org/jira/browse/HIVE-11865
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Disable Hive PPD optimizer when CBO has optimized the plan
> 
> 
> Diffs
> -
> 
>   hbase-handler/src/test/results/positive/hbase_queries.q.out 
> 3907bc946679c0ce2492692dcb7e2cf252c6e188 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
> 8f48e7df4b9c081528b82545d445f75f67f93bfc 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
>  142812ca703d5e667bd532a711d29594123bde50 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
>  8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
>  7e484b90deed2dfb120faa2699eb9b9b7a4e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
>  c8de1d89a1df083cd125ae8c11bf854b09915680 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
>  efde6652ca270d8e8d8f682fc0ff260702f46d5a 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
>  feec3c25929cac0bb3b6f50d074557a3c2745889 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> 7c5a43ff4060c9a4d9c4c5523d851ef959da3932 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 27549dceac8b5913b1fb1604bde213ae26b243bf 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 
> ccc4bb454e61e3c39b1f90f29de5e754f8d886bf 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 
> 1702628447d38b09c9b7d0dcf38218a9037a2c64 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java 
> accfb3b9f5631f25220c88b759dba6c5299b4044 
>   ql/src/test/results/clientpositive/auto_join12.q.out 
> 6f08aa8f043113f0a99acd10c848f60a122a3f0b 
>   ql/src/test/results/clientpositive/auto_join13.q.out 
> d29818cf438449a6a1413edd7d474c4ab35f2148 
>   ql/src/test/results/clientpositive/auto_join16.q.out 
> 38738ede2b4cd49aa24490eafb81dec1de78bea5 
>   ql/src/test/results/clientpositive/auto_join2.q.out 
> ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
>   ql/src/test/results/clientpositive/auto_join33.q.out 
> 8b13bd0cb7fd869c58c9d092b2e8710391c96503 
>   ql/src/test/results/clientpositive/auto_join_filters.q.out 
> e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
>   ql/src/test/results/clientpositive/auto_join_nulls.q.out 
> 954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
>   ql/src/test/results/clientpositive/auto_join_stats.q.out 
> feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
>   ql/src/test/results/clientpositive/auto_join_stats2.q.out 
> e0d0146dd6b86e9f69a467dcde0c020c31af499d 
>   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
> c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
>   ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
> 096f5d445bc7e61381775270bef04e911eac5bb6 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
> 30853c42a52e1def5a913352580e0b5391ac2050 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
> 3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 
> e6c2832003a1bb804f99125866bff6117e4dab73 
>   ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out 
> 326e4d67f00158929f4aaa0a2ec53cedabe3e92c 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b1e43fed3326c8c43e3266ad281c86a054 
>   ql/src/test/results/clientpositive/cbo_rp_join0.q.out 
> 3c6bb7319fd7605a62f082b989f723d5aab6c3fe 
>   ql/src/test/results/clientpositive/cbo_rp_join1.q.out

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez 


> On Dec. 18, 2015, 8:12 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java, line 167
> > 
> >
> > This is fragile.
> > State will have to be maintained; i.e unset if a filter merge happened.

This is already taken care of, as new Filter is created and the property is set 
to false by default.


- Jesús


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/#review111255
---


On Dec. 18, 2015, 5:28 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41457/
> ---
> 
> (Updated Dec. 18, 2015, 5:28 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Bugs: HIVE-11865
> https://issues.apache.org/jira/browse/HIVE-11865
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Disable Hive PPD optimizer when CBO has optimized the plan
> 
> 
> Diffs
> -
> 
>   hbase-handler/src/test/results/positive/hbase_queries.q.out 
> 3907bc946679c0ce2492692dcb7e2cf252c6e188 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
> 8f48e7df4b9c081528b82545d445f75f67f93bfc 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
>  142812ca703d5e667bd532a711d29594123bde50 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
>  8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
>  7e484b90deed2dfb120faa2699eb9b9b7a4e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
>  c8de1d89a1df083cd125ae8c11bf854b09915680 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
>  efde6652ca270d8e8d8f682fc0ff260702f46d5a 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
>  feec3c25929cac0bb3b6f50d074557a3c2745889 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> 7c5a43ff4060c9a4d9c4c5523d851ef959da3932 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 27549dceac8b5913b1fb1604bde213ae26b243bf 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 
> ccc4bb454e61e3c39b1f90f29de5e754f8d886bf 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 
> 1702628447d38b09c9b7d0dcf38218a9037a2c64 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java 
> accfb3b9f5631f25220c88b759dba6c5299b4044 
>   ql/src/test/results/clientpositive/auto_join12.q.out 
> 6f08aa8f043113f0a99acd10c848f60a122a3f0b 
>   ql/src/test/results/clientpositive/auto_join13.q.out 
> d29818cf438449a6a1413edd7d474c4ab35f2148 
>   ql/src/test/results/clientpositive/auto_join16.q.out 
> 38738ede2b4cd49aa24490eafb81dec1de78bea5 
>   ql/src/test/results/clientpositive/auto_join2.q.out 
> ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
>   ql/src/test/results/clientpositive/auto_join33.q.out 
> 8b13bd0cb7fd869c58c9d092b2e8710391c96503 
>   ql/src/test/results/clientpositive/auto_join_filters.q.out 
> e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
>   ql/src/test/results/clientpositive/auto_join_nulls.q.out 
> 954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
>   ql/src/test/results/clientpositive/auto_join_stats.q.out 
> feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
>   ql/src/test/results/clientpositive/auto_join_stats2.q.out 
> e0d0146dd6b86e9f69a467dcde0c020c31af499d 
>   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
> c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
>   ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
> 096f5d445bc7e61381775270bef04e911eac5bb6 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
> 30853c42a52e1def5a913352580e0b5391ac2050 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
> 3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 
> e6c2832003a1bb804f99125866bff6117e4dab73 
>   ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out 
> 326e4d67f00158929f4aaa0a2ec53cedabe3e92c 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b1e43fed3326c8c43e3266ad281c86a054 
>   ql/src/test/results/clientpositive/cbo_rp_join0.q.out 
> 3c6bb7319fd7605a62f082b989f723d5aab6c3fe 
>

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/#review111255
---



ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java (line 167)


This is fragile.
State will have to be maintained; i.e unset if a filter merge happened.


- John Pullokkaran


On Dec. 18, 2015, 5:28 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41457/
> ---
> 
> (Updated Dec. 18, 2015, 5:28 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Bugs: HIVE-11865
> https://issues.apache.org/jira/browse/HIVE-11865
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Disable Hive PPD optimizer when CBO has optimized the plan
> 
> 
> Diffs
> -
> 
>   hbase-handler/src/test/results/positive/hbase_queries.q.out 
> 3907bc946679c0ce2492692dcb7e2cf252c6e188 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
> 8f48e7df4b9c081528b82545d445f75f67f93bfc 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
>  142812ca703d5e667bd532a711d29594123bde50 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
>  8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
>  7e484b90deed2dfb120faa2699eb9b9b7a4e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
>  c8de1d89a1df083cd125ae8c11bf854b09915680 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
>  efde6652ca270d8e8d8f682fc0ff260702f46d5a 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
>  feec3c25929cac0bb3b6f50d074557a3c2745889 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> 7c5a43ff4060c9a4d9c4c5523d851ef959da3932 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 27549dceac8b5913b1fb1604bde213ae26b243bf 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 
> ccc4bb454e61e3c39b1f90f29de5e754f8d886bf 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 
> 1702628447d38b09c9b7d0dcf38218a9037a2c64 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java 
> accfb3b9f5631f25220c88b759dba6c5299b4044 
>   ql/src/test/results/clientpositive/auto_join12.q.out 
> 6f08aa8f043113f0a99acd10c848f60a122a3f0b 
>   ql/src/test/results/clientpositive/auto_join13.q.out 
> d29818cf438449a6a1413edd7d474c4ab35f2148 
>   ql/src/test/results/clientpositive/auto_join16.q.out 
> 38738ede2b4cd49aa24490eafb81dec1de78bea5 
>   ql/src/test/results/clientpositive/auto_join2.q.out 
> ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
>   ql/src/test/results/clientpositive/auto_join33.q.out 
> 8b13bd0cb7fd869c58c9d092b2e8710391c96503 
>   ql/src/test/results/clientpositive/auto_join_filters.q.out 
> e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
>   ql/src/test/results/clientpositive/auto_join_nulls.q.out 
> 954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
>   ql/src/test/results/clientpositive/auto_join_stats.q.out 
> feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
>   ql/src/test/results/clientpositive/auto_join_stats2.q.out 
> e0d0146dd6b86e9f69a467dcde0c020c31af499d 
>   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
> c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
>   ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
> 096f5d445bc7e61381775270bef04e911eac5bb6 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
> 30853c42a52e1def5a913352580e0b5391ac2050 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
> 3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 
> e6c2832003a1bb804f99125866bff6117e4dab73 
>   ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out 
> 326e4d67f00158929f4aaa0a2ec53cedabe3e92c 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b1e43fed3326c8c43e3266ad281c86a054 
>   ql/src/test/results/clientpositive/cbo_rp_join0.q.out 
> 3c6bb7319fd7605a62f082b989f723d5aab6c3fe 
>   ql/src/test/results/clientpositive/cbo_rp_join1.q.out 
> e77002866174f85168859c4145e7016c9d829bb6 
>   ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out 
> b14caa80b3346036f9ec835f

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/#review111254
---



ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 491)


This is fragile; i.e reusing the flag whether to run CBO or not for whether 
CBO was actually run successfully.

We already keep state in parsecontext about this.


- John Pullokkaran


On Dec. 18, 2015, 5:28 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41457/
> ---
> 
> (Updated Dec. 18, 2015, 5:28 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Bugs: HIVE-11865
> https://issues.apache.org/jira/browse/HIVE-11865
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Disable Hive PPD optimizer when CBO has optimized the plan
> 
> 
> Diffs
> -
> 
>   hbase-handler/src/test/results/positive/hbase_queries.q.out 
> 3907bc946679c0ce2492692dcb7e2cf252c6e188 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
> 8f48e7df4b9c081528b82545d445f75f67f93bfc 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
>  142812ca703d5e667bd532a711d29594123bde50 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
>  8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
>  7e484b90deed2dfb120faa2699eb9b9b7a4e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
>  c8de1d89a1df083cd125ae8c11bf854b09915680 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
>  efde6652ca270d8e8d8f682fc0ff260702f46d5a 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
>  feec3c25929cac0bb3b6f50d074557a3c2745889 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> 7c5a43ff4060c9a4d9c4c5523d851ef959da3932 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 27549dceac8b5913b1fb1604bde213ae26b243bf 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 
> ccc4bb454e61e3c39b1f90f29de5e754f8d886bf 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 
> 1702628447d38b09c9b7d0dcf38218a9037a2c64 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java 
> accfb3b9f5631f25220c88b759dba6c5299b4044 
>   ql/src/test/results/clientpositive/auto_join12.q.out 
> 6f08aa8f043113f0a99acd10c848f60a122a3f0b 
>   ql/src/test/results/clientpositive/auto_join13.q.out 
> d29818cf438449a6a1413edd7d474c4ab35f2148 
>   ql/src/test/results/clientpositive/auto_join16.q.out 
> 38738ede2b4cd49aa24490eafb81dec1de78bea5 
>   ql/src/test/results/clientpositive/auto_join2.q.out 
> ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
>   ql/src/test/results/clientpositive/auto_join33.q.out 
> 8b13bd0cb7fd869c58c9d092b2e8710391c96503 
>   ql/src/test/results/clientpositive/auto_join_filters.q.out 
> e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
>   ql/src/test/results/clientpositive/auto_join_nulls.q.out 
> 954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
>   ql/src/test/results/clientpositive/auto_join_stats.q.out 
> feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
>   ql/src/test/results/clientpositive/auto_join_stats2.q.out 
> e0d0146dd6b86e9f69a467dcde0c020c31af499d 
>   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
> c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
>   ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
> 096f5d445bc7e61381775270bef04e911eac5bb6 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
> 30853c42a52e1def5a913352580e0b5391ac2050 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
> 3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 
> e6c2832003a1bb804f99125866bff6117e4dab73 
>   ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out 
> 326e4d67f00158929f4aaa0a2ec53cedabe3e92c 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b1e43fed3326c8c43e3266ad281c86a054 
>   ql/src/test/results/clientpositive/cbo_rp_join0.q.out 
> 3c6bb7319fd7605a62f082b989f723d5aab6c3fe 
>   ql/src/test/results/clientpositive/cbo_rp_join1.q.out 
> e77002866174f85168859c4145e7016c9d829bb6 
>   q

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/#review111248
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
 (line 1)


These seems cosmetic, do we need these?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
 (line 10)


These seems cosmetic, do we need these?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
 (line 1)


These seems cosmetic, do we need these?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
 (line 10)


These seems cosmetic, do we need these?


- John Pullokkaran


On Dec. 18, 2015, 5:28 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41457/
> ---
> 
> (Updated Dec. 18, 2015, 5:28 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Bugs: HIVE-11865
> https://issues.apache.org/jira/browse/HIVE-11865
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Disable Hive PPD optimizer when CBO has optimized the plan
> 
> 
> Diffs
> -
> 
>   hbase-handler/src/test/results/positive/hbase_queries.q.out 
> 3907bc946679c0ce2492692dcb7e2cf252c6e188 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
> 8f48e7df4b9c081528b82545d445f75f67f93bfc 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
>  142812ca703d5e667bd532a711d29594123bde50 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
>  8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
>  7e484b90deed2dfb120faa2699eb9b9b7a4e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
>  c8de1d89a1df083cd125ae8c11bf854b09915680 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
>  efde6652ca270d8e8d8f682fc0ff260702f46d5a 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
>  feec3c25929cac0bb3b6f50d074557a3c2745889 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> 7c5a43ff4060c9a4d9c4c5523d851ef959da3932 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 27549dceac8b5913b1fb1604bde213ae26b243bf 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 
> ccc4bb454e61e3c39b1f90f29de5e754f8d886bf 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 
> 1702628447d38b09c9b7d0dcf38218a9037a2c64 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java 
> accfb3b9f5631f25220c88b759dba6c5299b4044 
>   ql/src/test/results/clientpositive/auto_join12.q.out 
> 6f08aa8f043113f0a99acd10c848f60a122a3f0b 
>   ql/src/test/results/clientpositive/auto_join13.q.out 
> d29818cf438449a6a1413edd7d474c4ab35f2148 
>   ql/src/test/results/clientpositive/auto_join16.q.out 
> 38738ede2b4cd49aa24490eafb81dec1de78bea5 
>   ql/src/test/results/clientpositive/auto_join2.q.out 
> ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
>   ql/src/test/results/clientpositive/auto_join33.q.out 
> 8b13bd0cb7fd869c58c9d092b2e8710391c96503 
>   ql/src/test/results/clientpositive/auto_join_filters.q.out 
> e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
>   ql/src/test/results/clientpositive/auto_join_nulls.q.out 
> 954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
>   ql/src/test/results/clientpositive/auto_join_stats.q.out 
> feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
>   ql/src/test/results/clientpositive/auto_join_stats2.q.out 
> e0d0146dd6b86e9f69a467dcde0c020c31af499d 
>   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
> c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
>   ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
> 096f5d445bc7e61381775270bef04e911eac5bb6 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
> 30853c42a52e1def5a913352580e0b5391ac2050 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
> 3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_9.q

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/#review111247
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java (line 110)


In the CBO Success path the additional const prop seems unnecessary. All we 
have done between two const prop is is synthetic join predicates (not null 
predicates) && Simple predicate push down.


- John Pullokkaran


On Dec. 18, 2015, 5:28 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41457/
> ---
> 
> (Updated Dec. 18, 2015, 5:28 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Bugs: HIVE-11865
> https://issues.apache.org/jira/browse/HIVE-11865
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Disable Hive PPD optimizer when CBO has optimized the plan
> 
> 
> Diffs
> -
> 
>   hbase-handler/src/test/results/positive/hbase_queries.q.out 
> 3907bc946679c0ce2492692dcb7e2cf252c6e188 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
> 8f48e7df4b9c081528b82545d445f75f67f93bfc 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
>  142812ca703d5e667bd532a711d29594123bde50 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
>  8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
>  7e484b90deed2dfb120faa2699eb9b9b7a4e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
>  c8de1d89a1df083cd125ae8c11bf854b09915680 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
>  efde6652ca270d8e8d8f682fc0ff260702f46d5a 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
>  feec3c25929cac0bb3b6f50d074557a3c2745889 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> 7c5a43ff4060c9a4d9c4c5523d851ef959da3932 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 27549dceac8b5913b1fb1604bde213ae26b243bf 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 
> ccc4bb454e61e3c39b1f90f29de5e754f8d886bf 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 
> 1702628447d38b09c9b7d0dcf38218a9037a2c64 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java 
> accfb3b9f5631f25220c88b759dba6c5299b4044 
>   ql/src/test/results/clientpositive/auto_join12.q.out 
> 6f08aa8f043113f0a99acd10c848f60a122a3f0b 
>   ql/src/test/results/clientpositive/auto_join13.q.out 
> d29818cf438449a6a1413edd7d474c4ab35f2148 
>   ql/src/test/results/clientpositive/auto_join16.q.out 
> 38738ede2b4cd49aa24490eafb81dec1de78bea5 
>   ql/src/test/results/clientpositive/auto_join2.q.out 
> ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
>   ql/src/test/results/clientpositive/auto_join33.q.out 
> 8b13bd0cb7fd869c58c9d092b2e8710391c96503 
>   ql/src/test/results/clientpositive/auto_join_filters.q.out 
> e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
>   ql/src/test/results/clientpositive/auto_join_nulls.q.out 
> 954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
>   ql/src/test/results/clientpositive/auto_join_stats.q.out 
> feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
>   ql/src/test/results/clientpositive/auto_join_stats2.q.out 
> e0d0146dd6b86e9f69a467dcde0c020c31af499d 
>   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
> c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
>   ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
> 096f5d445bc7e61381775270bef04e911eac5bb6 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
> 30853c42a52e1def5a913352580e0b5391ac2050 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
> 3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 
> e6c2832003a1bb804f99125866bff6117e4dab73 
>   ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out 
> 326e4d67f00158929f4aaa0a2ec53cedabe3e92c 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
> 62b611b1e43fed3326c8c43e3266ad281c86a054 
>   ql/src/test/results/clientpositive/cbo_rp_join0.q.out 
> 3c6bb7319fd7605a62f082b989f723d5aab6c3fe 
>   ql/src/test/results/clientpositive/cbo_rp_join1.q.out 
> e77002866174f85168859c4

Re: Review Request 41457: HIVE-11865

2015-12-18 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/
---

(Updated Dec. 18, 2015, 5:28 p.m.)


Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Bugs: HIVE-11865
https://issues.apache.org/jira/browse/HIVE-11865


Repository: hive-git


Description
---

Disable Hive PPD optimizer when CBO has optimized the plan


Diffs (updated)
-

  hbase-handler/src/test/results/positive/hbase_queries.q.out 
3907bc946679c0ce2492692dcb7e2cf252c6e188 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
8f48e7df4b9c081528b82545d445f75f67f93bfc 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
 142812ca703d5e667bd532a711d29594123bde50 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
 8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
 7e484b90deed2dfb120faa2699eb9b9b7a4e 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
 c8de1d89a1df083cd125ae8c11bf854b09915680 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
 efde6652ca270d8e8d8f682fc0ff260702f46d5a 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
 feec3c25929cac0bb3b6f50d074557a3c2745889 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
7c5a43ff4060c9a4d9c4c5523d851ef959da3932 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
27549dceac8b5913b1fb1604bde213ae26b243bf 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 
ccc4bb454e61e3c39b1f90f29de5e754f8d886bf 
  ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 
1702628447d38b09c9b7d0dcf38218a9037a2c64 
  ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java 
accfb3b9f5631f25220c88b759dba6c5299b4044 
  ql/src/test/results/clientpositive/auto_join12.q.out 
6f08aa8f043113f0a99acd10c848f60a122a3f0b 
  ql/src/test/results/clientpositive/auto_join13.q.out 
d29818cf438449a6a1413edd7d474c4ab35f2148 
  ql/src/test/results/clientpositive/auto_join16.q.out 
38738ede2b4cd49aa24490eafb81dec1de78bea5 
  ql/src/test/results/clientpositive/auto_join2.q.out 
ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
  ql/src/test/results/clientpositive/auto_join33.q.out 
8b13bd0cb7fd869c58c9d092b2e8710391c96503 
  ql/src/test/results/clientpositive/auto_join_filters.q.out 
e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
  ql/src/test/results/clientpositive/auto_join_nulls.q.out 
954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
  ql/src/test/results/clientpositive/auto_join_stats.q.out 
feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
  ql/src/test/results/clientpositive/auto_join_stats2.q.out 
e0d0146dd6b86e9f69a467dcde0c020c31af499d 
  ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
  ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
096f5d445bc7e61381775270bef04e911eac5bb6 
  ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
30853c42a52e1def5a913352580e0b5391ac2050 
  ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
  ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 
e6c2832003a1bb804f99125866bff6117e4dab73 
  ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out 
326e4d67f00158929f4aaa0a2ec53cedabe3e92c 
  ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
62b611b1e43fed3326c8c43e3266ad281c86a054 
  ql/src/test/results/clientpositive/cbo_rp_join0.q.out 
3c6bb7319fd7605a62f082b989f723d5aab6c3fe 
  ql/src/test/results/clientpositive/cbo_rp_join1.q.out 
e77002866174f85168859c4145e7016c9d829bb6 
  ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out 
b14caa80b3346036f9ec835fe4e2294f47eb7ee5 
  ql/src/test/results/clientpositive/cbo_rp_outer_join_ppr.q.java1.7.out 
263053705347793513a44d49968dedd4fdffecfe 
  ql/src/test/results/clientpositive/correlationoptimizer10.q.out 
860452ef9bbf38df7aaeb00eb2636f53730ae923 
  ql/src/test/results/clientpositive/correlationoptimizer13.q.out 
82304d8ff96e14bf18cde3f0867b25c6757d40d6 
  ql/src/test/results/clientpositive/correlationoptimizer9.q.out 
d32003dead268bd435713751d5e5956bdd4f5f74 
  ql/src/test/results/clientpositive/cross_join.q.out 
f36496e8503fedc67d6c9555b6e0dd5b0c9bd6ed 
  ql/src/test/results/clientpositive/cross_product_check_1.q.out 
e7d6900d64851fa21f976ca20b5d7d753aa5d28f 
  ql/src/test/results/clientpositive/cross_product_check_2.q.out 
d

Re: Review Request 41457: HIVE-11865

2015-12-17 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/
---

(Updated Dec. 17, 2015, 3:21 p.m.)


Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Bugs: HIVE-11865
https://issues.apache.org/jira/browse/HIVE-11865


Repository: hive-git


Description
---

Disable Hive PPD optimizer when CBO has optimized the plan


Diffs (updated)
-

  hbase-handler/src/test/results/positive/hbase_queries.q.out 
3907bc946679c0ce2492692dcb7e2cf252c6e188 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
8f48e7df4b9c081528b82545d445f75f67f93bfc 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
 db625c1c3d47b5ee2744950db2fb71804945cbec 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
 8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
 7e484b90deed2dfb120faa2699eb9b9b7a4e 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
 2a415d5abd9c054956f46cd26f9df2257d67ecf4 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
 efde6652ca270d8e8d8f682fc0ff260702f46d5a 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
 feec3c25929cac0bb3b6f50d074557a3c2745889 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
36a12bf6b2c3ef7233eda7c949725e02c880d7f7 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
27549dceac8b5913b1fb1604bde213ae26b243bf 
  ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
PRE-CREATION 
  ql/src/test/results/clientpositive/auto_join12.q.out 
6f08aa8f043113f0a99acd10c848f60a122a3f0b 
  ql/src/test/results/clientpositive/auto_join13.q.out 
d29818cf438449a6a1413edd7d474c4ab35f2148 
  ql/src/test/results/clientpositive/auto_join16.q.out 
38738ede2b4cd49aa24490eafb81dec1de78bea5 
  ql/src/test/results/clientpositive/auto_join2.q.out 
ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
  ql/src/test/results/clientpositive/auto_join33.q.out 
8b13bd0cb7fd869c58c9d092b2e8710391c96503 
  ql/src/test/results/clientpositive/auto_join_filters.q.out 
e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
  ql/src/test/results/clientpositive/auto_join_nulls.q.out 
954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
  ql/src/test/results/clientpositive/auto_join_stats.q.out 
feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
  ql/src/test/results/clientpositive/auto_join_stats2.q.out 
e0d0146dd6b86e9f69a467dcde0c020c31af499d 
  ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
  ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
096f5d445bc7e61381775270bef04e911eac5bb6 
  ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
30853c42a52e1def5a913352580e0b5391ac2050 
  ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
  ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 
e6c2832003a1bb804f99125866bff6117e4dab73 
  ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out 
326e4d67f00158929f4aaa0a2ec53cedabe3e92c 
  ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 
62b611b1e43fed3326c8c43e3266ad281c86a054 
  ql/src/test/results/clientpositive/cbo_rp_join0.q.out 
3c6bb7319fd7605a62f082b989f723d5aab6c3fe 
  ql/src/test/results/clientpositive/cbo_rp_join1.q.out 
e77002866174f85168859c4145e7016c9d829bb6 
  ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out 
b14caa80b3346036f9ec835fe4e2294f47eb7ee5 
  ql/src/test/results/clientpositive/cbo_rp_outer_join_ppr.q.java1.7.out 
263053705347793513a44d49968dedd4fdffecfe 
  ql/src/test/results/clientpositive/correlationoptimizer10.q.out 
860452ef9bbf38df7aaeb00eb2636f53730ae923 
  ql/src/test/results/clientpositive/correlationoptimizer13.q.out 
82304d8ff96e14bf18cde3f0867b25c6757d40d6 
  ql/src/test/results/clientpositive/correlationoptimizer9.q.out 
d32003dead268bd435713751d5e5956bdd4f5f74 
  ql/src/test/results/clientpositive/cross_join.q.out 
f36496e8503fedc67d6c9555b6e0dd5b0c9bd6ed 
  ql/src/test/results/clientpositive/cross_product_check_1.q.out 
e7d6900d64851fa21f976ca20b5d7d753aa5d28f 
  ql/src/test/results/clientpositive/cross_product_check_2.q.out 
df438c9ae7c95033383eae28bf8bada55c08b5c4 
  ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out 
b85d387f3910598a3300df9adc34dce952715a2e 
  
ql/src/test/results/clientpositive/encrypted/encryption_join_unencrypted_tbl.q.out
 8903860b7c3f906bc1d755a85150f078bd11735f 
  ql/src/test/results/clientpositive/explain_logica

Re: Review Request 41457: HIVE-11865

2015-12-17 Thread Jesús Camacho Rodríguez 


> On Dec. 17, 2015, 1:45 a.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java, line 106
> > 
> >
> > What about const propagation?

I had been doing tests adding/removing the different rules and I had forgotten 
to add that one back, thanks. The effect of not running constant propagation 
there could be seen in multiple tests e.g. fold_eq_with_case_when.q. New patch 
addresses this.


- Jesús


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/#review110839
---


On Dec. 16, 2015, 7:14 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41457/
> ---
> 
> (Updated Dec. 16, 2015, 7:14 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Bugs: HIVE-11865
> https://issues.apache.org/jira/browse/HIVE-11865
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Disable Hive PPD optimizer when CBO has optimized the plan
> 
> 
> Diffs
> -
> 
>   hbase-handler/src/test/results/positive/hbase_pushdown.q.out 
> be96eecc8642f85a493ae6c72964bc4e30c4db57 
>   hbase-handler/src/test/results/positive/hbase_queries.q.out 
> 3907bc946679c0ce2492692dcb7e2cf252c6e188 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
> 8f48e7df4b9c081528b82545d445f75f67f93bfc 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
>  db625c1c3d47b5ee2744950db2fb71804945cbec 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
>  8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
>  7e484b90deed2dfb120faa2699eb9b9b7a4e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
>  2a415d5abd9c054956f46cd26f9df2257d67ecf4 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
>  efde6652ca270d8e8d8f682fc0ff260702f46d5a 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
>  feec3c25929cac0bb3b6f50d074557a3c2745889 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> 36a12bf6b2c3ef7233eda7c949725e02c880d7f7 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 27549dceac8b5913b1fb1604bde213ae26b243bf 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/auto_join12.q.out 
> 6f08aa8f043113f0a99acd10c848f60a122a3f0b 
>   ql/src/test/results/clientpositive/auto_join13.q.out 
> d29818cf438449a6a1413edd7d474c4ab35f2148 
>   ql/src/test/results/clientpositive/auto_join16.q.out 
> 38738ede2b4cd49aa24490eafb81dec1de78bea5 
>   ql/src/test/results/clientpositive/auto_join2.q.out 
> ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
>   ql/src/test/results/clientpositive/auto_join33.q.out 
> 8b13bd0cb7fd869c58c9d092b2e8710391c96503 
>   ql/src/test/results/clientpositive/auto_join8.q.out 
> 80dd575c58add873ae34967b1d255ee5b63a9b07 
>   ql/src/test/results/clientpositive/auto_join_filters.q.out 
> e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
>   ql/src/test/results/clientpositive/auto_join_nulls.q.out 
> 954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
>   ql/src/test/results/clientpositive/auto_join_stats.q.out 
> feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
>   ql/src/test/results/clientpositive/auto_join_stats2.q.out 
> e0d0146dd6b86e9f69a467dcde0c020c31af499d 
>   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
> c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
>   ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
> 096f5d445bc7e61381775270bef04e911eac5bb6 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
> 30853c42a52e1def5a913352580e0b5391ac2050 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
> 3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 
> e6c2832003a1bb804f99125866bff6117e4dab73 
>   ql/src/test/results/clientpositive/cbo_rp_auto_join1.q.out 
> 5c09fe0ad2d30c6c597abdad27b309fd8d00f678 
>   ql/src/test/results/clientpositive/cbo_rp_join0.q.out 
> 3c6bb7319fd7605a62f082b989f723d5aab6c3fe 
>   ql/src/test/results/clientpositive/cbo_rp_join1.q.out 
> e77002866174f85168859c4145e7016c9d829bb6 
>   ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out 
>

Re: Review Request 41457: HIVE-11865

2015-12-16 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/#review110839
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java (line 104)


What about const propagation?


- John Pullokkaran


On Dec. 16, 2015, 7:14 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41457/
> ---
> 
> (Updated Dec. 16, 2015, 7:14 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Bugs: HIVE-11865
> https://issues.apache.org/jira/browse/HIVE-11865
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Disable Hive PPD optimizer when CBO has optimized the plan
> 
> 
> Diffs
> -
> 
>   hbase-handler/src/test/results/positive/hbase_pushdown.q.out 
> be96eecc8642f85a493ae6c72964bc4e30c4db57 
>   hbase-handler/src/test/results/positive/hbase_queries.q.out 
> 3907bc946679c0ce2492692dcb7e2cf252c6e188 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
> 8f48e7df4b9c081528b82545d445f75f67f93bfc 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
>  db625c1c3d47b5ee2744950db2fb71804945cbec 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
>  8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
>  7e484b90deed2dfb120faa2699eb9b9b7a4e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
>  2a415d5abd9c054956f46cd26f9df2257d67ecf4 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
>  efde6652ca270d8e8d8f682fc0ff260702f46d5a 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
>  feec3c25929cac0bb3b6f50d074557a3c2745889 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> 36a12bf6b2c3ef7233eda7c949725e02c880d7f7 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 27549dceac8b5913b1fb1604bde213ae26b243bf 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/auto_join12.q.out 
> 6f08aa8f043113f0a99acd10c848f60a122a3f0b 
>   ql/src/test/results/clientpositive/auto_join13.q.out 
> d29818cf438449a6a1413edd7d474c4ab35f2148 
>   ql/src/test/results/clientpositive/auto_join16.q.out 
> 38738ede2b4cd49aa24490eafb81dec1de78bea5 
>   ql/src/test/results/clientpositive/auto_join2.q.out 
> ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
>   ql/src/test/results/clientpositive/auto_join33.q.out 
> 8b13bd0cb7fd869c58c9d092b2e8710391c96503 
>   ql/src/test/results/clientpositive/auto_join8.q.out 
> 80dd575c58add873ae34967b1d255ee5b63a9b07 
>   ql/src/test/results/clientpositive/auto_join_filters.q.out 
> e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
>   ql/src/test/results/clientpositive/auto_join_nulls.q.out 
> 954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
>   ql/src/test/results/clientpositive/auto_join_stats.q.out 
> feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
>   ql/src/test/results/clientpositive/auto_join_stats2.q.out 
> e0d0146dd6b86e9f69a467dcde0c020c31af499d 
>   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
> c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
>   ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
> 096f5d445bc7e61381775270bef04e911eac5bb6 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
> 30853c42a52e1def5a913352580e0b5391ac2050 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
> 3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 
> e6c2832003a1bb804f99125866bff6117e4dab73 
>   ql/src/test/results/clientpositive/cbo_rp_auto_join1.q.out 
> 5c09fe0ad2d30c6c597abdad27b309fd8d00f678 
>   ql/src/test/results/clientpositive/cbo_rp_join0.q.out 
> 3c6bb7319fd7605a62f082b989f723d5aab6c3fe 
>   ql/src/test/results/clientpositive/cbo_rp_join1.q.out 
> e77002866174f85168859c4145e7016c9d829bb6 
>   ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out 
> b14caa80b3346036f9ec835fe4e2294f47eb7ee5 
>   ql/src/test/results/clientpositive/cbo_rp_outer_join_ppr.q.java1.7.out 
> 263053705347793513a44d49968dedd4fdffecfe 
>   ql/src/test/results/clientpositive/constprog_partitioner.q.out 
> 08c0aebafe1644a5adbec6a56879b39617bfbf69 
>   ql/src/test/results/clientpositive/cross_join.q.out 
> f3649

Review Request 41457: HIVE-11865

2015-12-16 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41457/
---

Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Bugs: HIVE-11865
https://issues.apache.org/jira/browse/HIVE-11865


Repository: hive-git


Description
---

Disable Hive PPD optimizer when CBO has optimized the plan


Diffs
-

  hbase-handler/src/test/results/positive/hbase_pushdown.q.out 
be96eecc8642f85a493ae6c72964bc4e30c4db57 
  hbase-handler/src/test/results/positive/hbase_queries.q.out 
3907bc946679c0ce2492692dcb7e2cf252c6e188 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 
8f48e7df4b9c081528b82545d445f75f67f93bfc 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
 db625c1c3d47b5ee2744950db2fb71804945cbec 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTSTransposeRule.java
 8321504774c5ec5c7c9de3aecdf78dcd8408c4cf 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
 7e484b90deed2dfb120faa2699eb9b9b7a4e 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortTransposeRule.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
 2a415d5abd9c054956f46cd26f9df2257d67ecf4 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
 efde6652ca270d8e8d8f682fc0ff260702f46d5a 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java
 feec3c25929cac0bb3b6f50d074557a3c2745889 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
36a12bf6b2c3ef7233eda7c949725e02c880d7f7 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
27549dceac8b5913b1fb1604bde213ae26b243bf 
  ql/src/java/org/apache/hadoop/hive/ql/ppd/SimplePredicatePushDown.java 
PRE-CREATION 
  ql/src/test/results/clientpositive/auto_join12.q.out 
6f08aa8f043113f0a99acd10c848f60a122a3f0b 
  ql/src/test/results/clientpositive/auto_join13.q.out 
d29818cf438449a6a1413edd7d474c4ab35f2148 
  ql/src/test/results/clientpositive/auto_join16.q.out 
38738ede2b4cd49aa24490eafb81dec1de78bea5 
  ql/src/test/results/clientpositive/auto_join2.q.out 
ce40ff30cb9cc2ab734ee37c0f3dc0ae85bbd202 
  ql/src/test/results/clientpositive/auto_join33.q.out 
8b13bd0cb7fd869c58c9d092b2e8710391c96503 
  ql/src/test/results/clientpositive/auto_join8.q.out 
80dd575c58add873ae34967b1d255ee5b63a9b07 
  ql/src/test/results/clientpositive/auto_join_filters.q.out 
e0ed3737f9b25d45bdb365b13aeed3a40c50135f 
  ql/src/test/results/clientpositive/auto_join_nulls.q.out 
954bf069760c6f0d7e5420c7e9a3b9756d5aa4df 
  ql/src/test/results/clientpositive/auto_join_stats.q.out 
feb818679df7d9f63f2d2d7a7c9afb2d0f5874d8 
  ql/src/test/results/clientpositive/auto_join_stats2.q.out 
e0d0146dd6b86e9f69a467dcde0c020c31af499d 
  ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 
c63016d0a3610eaa6cd82a4adc5d1bf6f0925cce 
  ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 
096f5d445bc7e61381775270bef04e911eac5bb6 
  ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 
30853c42a52e1def5a913352580e0b5391ac2050 
  ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out 
3e8dbcfd5bcc66ccd83b01c08c7745b02f05328f 
  ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 
e6c2832003a1bb804f99125866bff6117e4dab73 
  ql/src/test/results/clientpositive/cbo_rp_auto_join1.q.out 
5c09fe0ad2d30c6c597abdad27b309fd8d00f678 
  ql/src/test/results/clientpositive/cbo_rp_join0.q.out 
3c6bb7319fd7605a62f082b989f723d5aab6c3fe 
  ql/src/test/results/clientpositive/cbo_rp_join1.q.out 
e77002866174f85168859c4145e7016c9d829bb6 
  ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out 
b14caa80b3346036f9ec835fe4e2294f47eb7ee5 
  ql/src/test/results/clientpositive/cbo_rp_outer_join_ppr.q.java1.7.out 
263053705347793513a44d49968dedd4fdffecfe 
  ql/src/test/results/clientpositive/constprog_partitioner.q.out 
08c0aebafe1644a5adbec6a56879b39617bfbf69 
  ql/src/test/results/clientpositive/cross_join.q.out 
f36496e8503fedc67d6c9555b6e0dd5b0c9bd6ed 
  ql/src/test/results/clientpositive/cross_product_check_1.q.out 
e7d6900d64851fa21f976ca20b5d7d753aa5d28f 
  ql/src/test/results/clientpositive/cross_product_check_2.q.out 
df438c9ae7c95033383eae28bf8bada55c08b5c4 
  ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out 
b85d387f3910598a3300df9adc34dce952715a2e 
  ql/src/test/results/clientpositive/explain_logical.q.out 
d302918ceddd0fe10ea16d1fb32379bc823a158d 
  ql/src/test/results/clientpositive/filter_cond_pushdown.q.out 
b1cfb25a8fba4e5d3941d1615418ae68e8eaa6bf 
  ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out 
231d98f0faaa1ff5a8368648ea62e7632301c391 
  ql/src/test/results/clientpositive/fouter_join_