Re: Review Request 41924: HIVE - 11485 : Session close should not close async SQL operations

2016-01-11 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41924/#review113729
---



ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 


If drop is not happening here, when will it happen?


- Amareshwari Sriramadasu


On Jan. 5, 2016, 10:23 a.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41924/
> ---
> 
> (Updated Jan. 5, 2016, 10:23 a.m.)
> 
> 
> Review request for hive and Amareshwari Sriramadasu.
> 
> 
> Bugs: HIVE-11485
> https://issues.apache.org/jira/browse/HIVE-11485
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Removed 3 actions on closing of a hive session  :
> 1. Closing of operations running on the session.
> 2. Dropping of the session paths.
> 3. FileSystem.closeAllForUGI() for the session.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 5f15557 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 50c912e 
>   
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
>  441db7c 
> 
> Diff: https://reviews.apache.org/r/41924/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Review Request 41924: HIVE - 11485 : Session close should not close async SQL operations

2016-01-05 Thread Deepak Barr 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41924/
---

Review request for hive and Amareshwari Sriramadasu.


Bugs: HIVE-11485
https://issues.apache.org/jira/browse/HIVE-11485


Repository: hive-git


Description
---

Removed 3 actions on closing of a hive session  :
1. Closing of operations running on the session.
2. Dropping of the session paths.
3. FileSystem.closeAllForUGI() for the session.


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 5f15557 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
50c912e 
  
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
 441db7c 

Diff: https://reviews.apache.org/r/41924/diff/


Testing
---


Thanks,

Deepak Barr

Re: Review Request 41924: HIVE - 11485 : Session close should not close async SQL operations

2016-01-05 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41924/#review113013
---


Please include a unit test.

- Amareshwari Sriramadasu


On Jan. 5, 2016, 10:23 a.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41924/
> ---
> 
> (Updated Jan. 5, 2016, 10:23 a.m.)
> 
> 
> Review request for hive and Amareshwari Sriramadasu.
> 
> 
> Bugs: HIVE-11485
> https://issues.apache.org/jira/browse/HIVE-11485
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Removed 3 actions on closing of a hive session  :
> 1. Closing of operations running on the session.
> 2. Dropping of the session paths.
> 3. FileSystem.closeAllForUGI() for the session.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 5f15557 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> 50c912e 
>   
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
>  441db7c 
> 
> Diff: https://reviews.apache.org/r/41924/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>