Re: Review Request 45137: HiveServer2: Make ZK config publishing configurable

[Vaibhav Gumashta]

> On March 28, 2016, 5:59 p.m., Thejas Nair wrote:
> > service/src/java/org/apache/hive/service/server/HiveServer2.java, line 456
> > 
> >
> > Looks like addServerInstanceToZooKeeper would get called twice on start 
> > of HS2 from commandline.
> > Should we remove that from startHiveServer2 method ?

addServerInstanceToZooKeeper is called only from start. Towards the end of the 
diff you'll the the part where the call to addServerInstanceToZooKeeper from 
within startHiveServer2 has been removed.


- Vaibhav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45137/#review125688
---


On March 28, 2016, 11:47 a.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45137/
> ---
> 
> (Updated March 28, 2016, 11:47 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-13326
> https://issues.apache.org/jira/browse/HIVE-13326
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-13326
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b8870f2 
>   itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java 
> 751d8ea 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithLocalClusterSpark.java
>  f649fc2 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java 
> bcd65a9 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestMultiSessionsHS2WithLocalClusterSpark.java
>  0c3479d 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestServiceDiscoveryWithMiniHS2.java
>  PRE-CREATION 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestHS2AuthzContext.java
>  0bb3c0a 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestJdbcMetadataApiAuth.java
>  19b311d 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestJdbcWithSQLAuthorization.java
>  dacde45 
>   jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 1ca77a1 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java ab834b9 
> 
> Diff: https://reviews.apache.org/r/45137/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Re: Review Request 45137: HiveServer2: Make ZK config publishing configurable

[Thejas Nair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45137/#review125688
---




service/src/java/org/apache/hive/service/server/HiveServer2.java (line 455)


Looks like addServerInstanceToZooKeeper would get called twice on start of 
HS2 from commandline.
Should we remove that from startHiveServer2 method ?


- Thejas Nair


On March 28, 2016, 11:47 a.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45137/
> ---
> 
> (Updated March 28, 2016, 11:47 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-13326
> https://issues.apache.org/jira/browse/HIVE-13326
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-13326
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b8870f2 
>   itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java 
> 751d8ea 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithLocalClusterSpark.java
>  f649fc2 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java 
> bcd65a9 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestMultiSessionsHS2WithLocalClusterSpark.java
>  0c3479d 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestServiceDiscoveryWithMiniHS2.java
>  PRE-CREATION 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestHS2AuthzContext.java
>  0bb3c0a 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestJdbcMetadataApiAuth.java
>  19b311d 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestJdbcWithSQLAuthorization.java
>  dacde45 
>   jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 1ca77a1 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java ab834b9 
> 
> Diff: https://reviews.apache.org/r/45137/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Re: Review Request 45137: HiveServer2: Make ZK config publishing configurable

[Vaibhav Gumashta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45137/
---

(Updated March 28, 2016, 11:47 a.m.)


Review request for hive and Thejas Nair.


Bugs: HIVE-13326
https://issues.apache.org/jira/browse/HIVE-13326


Repository: hive-git


Description
---

https://issues.apache.org/jira/browse/HIVE-13326


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b8870f2 
  itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java 
751d8ea 
  
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithLocalClusterSpark.java
 f649fc2 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java 
bcd65a9 
  
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestMultiSessionsHS2WithLocalClusterSpark.java
 0c3479d 
  
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestServiceDiscoveryWithMiniHS2.java
 PRE-CREATION 
  
itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestHS2AuthzContext.java
 0bb3c0a 
  
itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestJdbcMetadataApiAuth.java
 19b311d 
  
itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestJdbcWithSQLAuthorization.java
 dacde45 
  jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 1ca77a1 
  service/src/java/org/apache/hive/service/server/HiveServer2.java ab834b9 

Diff: https://reviews.apache.org/r/45137/diff/


Testing
---


Thanks,

Vaibhav Gumashta

Re: Review Request 45137: HiveServer2: Make ZK config publishing configurable

[Vaibhav Gumashta]

> On March 22, 2016, 6:24 a.m., Thejas Nair wrote:
> > service/src/java/org/apache/hive/service/server/HiveServer2.java, line 257
> > 
> >
> > better to avoid these cosmetic changes that don't seem to improve style 
> > compliance

I have the hive compliant style set on my editor and selected the method I 
changed and applied the formatting. I'll revert that and limit to specific code 
changes.


- Vaibhav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45137/#review124741
---


On March 22, 2016, 12:36 a.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45137/
> ---
> 
> (Updated March 22, 2016, 12:36 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-13326
> https://issues.apache.org/jira/browse/HIVE-13326
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-13326
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0f8d67f 
>   jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 1ca77a1 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java ab834b9 
> 
> Diff: https://reviews.apache.org/r/45137/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Re: Review Request 45137: HiveServer2: Make ZK config publishing configurable

[Thejas Nair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45137/#review124741
---




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2020)


It would be good to be more obvious in the description, by using 
HiveServer2 instead of server.



jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java (line 51)


it would be good to avoid unrelated changes, specially when both before and 
after state look OK. It keeps git-blame more useful!



jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java (line 84)


Can you also print dataStr here ?



service/src/java/org/apache/hive/service/server/HiveServer2.java (line 257)


better to avoid these cosmetic changes that don't seem to improve style 
compliance


- Thejas Nair


On March 22, 2016, 12:36 a.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45137/
> ---
> 
> (Updated March 22, 2016, 12:36 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-13326
> https://issues.apache.org/jira/browse/HIVE-13326
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-13326
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0f8d67f 
>   jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 1ca77a1 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java ab834b9 
> 
> Diff: https://reviews.apache.org/r/45137/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Review Request 45137: HiveServer2: Make ZK config publishing configurable

[Vaibhav Gumashta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45137/
---

Review request for hive and Thejas Nair.


Bugs: HIVE-13326
https://issues.apache.org/jira/browse/HIVE-13326


Repository: hive-git


Description
---

https://issues.apache.org/jira/browse/HIVE-13326


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0f8d67f 
  jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 1ca77a1 
  service/src/java/org/apache/hive/service/server/HiveServer2.java ab834b9 

Diff: https://reviews.apache.org/r/45137/diff/


Testing
---


Thanks,

Vaibhav Gumashta