Re: Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-11 Thread Thejas Nair 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/#review128303
---


Ship it!




Ship It!

- Thejas Nair


On April 12, 2016, 12:15 a.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45836/
> ---
> 
> (Updated April 12, 2016, 12:15 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6535
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Diffs
> -
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 
> 4eaff10 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
>  8868ec1 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java
>  35b6c52 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
>  8db2e62 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java
>  d6f6280 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
>  a09b39a 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java
>  740b851 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
>  2a0fec2 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> b7d6549 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 9ce6055 
> 
> Diff: https://reviews.apache.org/r/45836/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Re: Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-11 Thread Vaibhav Gumashta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/
---

(Updated April 12, 2016, 12:15 a.m.)


Review request for hive and Thejas Nair.


Bugs: HIVE-6535
https://issues.apache.org/jira/browse/HIVE-6535


Repository: hive-git


Description
---

https://issues.apache.org/jira/browse/HIVE-6535


Diffs (updated)
-

  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 
4eaff10 
  jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
  jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
  
service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
 8868ec1 
  
service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 
35b6c52 
  
service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
 8db2e62 
  
service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java 
d6f6280 
  
service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
 a09b39a 
  
service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 
740b851 
  
service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
 2a0fec2 
  service/src/java/org/apache/hive/service/cli/operation/Operation.java b7d6549 
  service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
9ce6055 

Diff: https://reviews.apache.org/r/45836/diff/


Testing
---


Thanks,

Vaibhav Gumashta

Re: Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-11 Thread Thejas Nair 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/#review128227
---




itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java (line 
2620)


add a check for number of rows returned as well ?



itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java (line 
2672)


verify number of rows returned as well ?



jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java (line 262)


s/Uers/Users/


- Thejas Nair


On April 11, 2016, 6 p.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45836/
> ---
> 
> (Updated April 11, 2016, 6 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6535
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Diffs
> -
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 
> 4eaff10 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
>  8868ec1 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java
>  35b6c52 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
>  8db2e62 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java
>  d6f6280 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
>  a09b39a 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java
>  740b851 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
>  2a0fec2 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> b7d6549 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 9ce6055 
> 
> Diff: https://reviews.apache.org/r/45836/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Re: Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-11 Thread Thejas Nair 


> On April 9, 2016, 4:43 a.m., Thejas Nair wrote:
> > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java, line 260
> > 
> >
> > mark as @limitedprivate and @evolving ?
> 
> Vaibhav Gumashta wrote:
> Adding these 2 annotations will add a dependency on 
> org.apache.hadoop.classification.InterfaceStability. Don't think we should do 
> that in JDBC.

org.apache.hadoop.hive.common.classification also has this.


- Thejas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/#review127953
---


On April 11, 2016, 6 p.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45836/
> ---
> 
> (Updated April 11, 2016, 6 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6535
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Diffs
> -
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 
> 4eaff10 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
>  8868ec1 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java
>  35b6c52 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
>  8db2e62 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java
>  d6f6280 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
>  a09b39a 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java
>  740b851 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
>  2a0fec2 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> b7d6549 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 9ce6055 
> 
> Diff: https://reviews.apache.org/r/45836/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Re: Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-11 Thread Vaibhav Gumashta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/
---

(Updated April 11, 2016, 6 p.m.)


Review request for hive and Thejas Nair.


Bugs: HIVE-6535
https://issues.apache.org/jira/browse/HIVE-6535


Repository: hive-git


Description
---

https://issues.apache.org/jira/browse/HIVE-6535


Diffs (updated)
-

  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 
4eaff10 
  jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
  jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
  
service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
 8868ec1 
  
service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 
35b6c52 
  
service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
 8db2e62 
  
service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java 
d6f6280 
  
service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
 a09b39a 
  
service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 
740b851 
  
service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
 2a0fec2 
  service/src/java/org/apache/hive/service/cli/operation/Operation.java b7d6549 
  service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
9ce6055 

Diff: https://reviews.apache.org/r/45836/diff/


Testing
---


Thanks,

Vaibhav Gumashta

Re: Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-11 Thread Vaibhav Gumashta 


> On April 11, 2016, 10:54 a.m., Vaibhav Gumashta wrote:
> > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java, line 225
> > 
> >
> > I think you saw the difference between diff 1 and diff 2. You won't see 
> > this in a diff between original and patch 2.
> 
> Thejas Nair wrote:
> The patch 1 had a resultset.close added in Statement.close() . Shouldn't 
> that change be retained ?

Sorry missed that. Updated the patch.


- Vaibhav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/#review128093
---


On April 11, 2016, 12:05 p.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45836/
> ---
> 
> (Updated April 11, 2016, 12:05 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6535
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Diffs
> -
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 
> 4eaff10 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
>  8868ec1 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java
>  35b6c52 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
>  8db2e62 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java
>  d6f6280 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
>  a09b39a 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java
>  740b851 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
>  2a0fec2 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> b7d6549 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 9ce6055 
> 
> Diff: https://reviews.apache.org/r/45836/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Re: Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-11 Thread Thejas Nair 


> On April 11, 2016, 10:54 a.m., Vaibhav Gumashta wrote:
> > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java, line 225
> > 
> >
> > I think you saw the difference between diff 1 and diff 2. You won't see 
> > this in a diff between original and patch 2.

The patch 1 had a resultset.close added in Statement.close() . Shouldn't that 
change be retained ?


- Thejas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/#review128093
---


On April 11, 2016, 12:05 p.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45836/
> ---
> 
> (Updated April 11, 2016, 12:05 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6535
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Diffs
> -
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 
> 4eaff10 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
>  8868ec1 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java
>  35b6c52 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
>  8db2e62 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java
>  d6f6280 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
>  a09b39a 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java
>  740b851 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
>  2a0fec2 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> b7d6549 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 9ce6055 
> 
> Diff: https://reviews.apache.org/r/45836/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Re: Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-11 Thread Vaibhav Gumashta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/
---

(Updated April 11, 2016, 12:05 p.m.)


Review request for hive and Thejas Nair.


Bugs: HIVE-6535
https://issues.apache.org/jira/browse/HIVE-6535


Repository: hive-git


Description
---

https://issues.apache.org/jira/browse/HIVE-6535


Diffs (updated)
-

  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 
4eaff10 
  jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
  jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
  
service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
 8868ec1 
  
service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 
35b6c52 
  
service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
 8db2e62 
  
service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java 
d6f6280 
  
service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
 a09b39a 
  
service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 
740b851 
  
service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
 2a0fec2 
  service/src/java/org/apache/hive/service/cli/operation/Operation.java b7d6549 
  service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
9ce6055 

Diff: https://reviews.apache.org/r/45836/diff/


Testing
---


Thanks,

Vaibhav Gumashta

Re: Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-11 Thread Vaibhav Gumashta 


> On April 9, 2016, 4:43 a.m., Thejas Nair wrote:
> > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java, line 260
> > 
> >
> > mark as @limitedprivate and @evolving ?

Adding these 2 annotations will add a dependency on 
org.apache.hadoop.classification.InterfaceStability. Don't think we should do 
that in JDBC.


- Vaibhav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/#review127953
---


On April 9, 2016, 12:37 a.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45836/
> ---
> 
> (Updated April 9, 2016, 12:37 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6535
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Diffs
> -
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
>  8868ec1 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java
>  35b6c52 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
>  8db2e62 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java
>  d6f6280 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
>  a09b39a 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java
>  740b851 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
>  2a0fec2 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> d9a273b 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 04d816a 
> 
> Diff: https://reviews.apache.org/r/45836/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Re: Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-11 Thread Vaibhav Gumashta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/#review128093
---




jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 


I think you saw the difference between diff 1 and diff 2. You won't see 
this in a diff between original and patch 2.


- Vaibhav Gumashta


On April 9, 2016, 12:37 a.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45836/
> ---
> 
> (Updated April 9, 2016, 12:37 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6535
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Diffs
> -
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
>  8868ec1 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java
>  35b6c52 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
>  8db2e62 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java
>  d6f6280 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
>  a09b39a 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java
>  740b851 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
>  2a0fec2 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> d9a273b 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 04d816a 
> 
> Diff: https://reviews.apache.org/r/45836/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Re: Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-08 Thread Thejas Nair 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/#review127953
---




jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 


shouldn't resultset be closed here ?



jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java (line 257)


mark as @limitedprivate and @evolving ?



jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java (line 259)


add a note that - users should call those getUpdateCount or ResultSet.next 
(depending on whether query returns results) to ensure that query completes 
successfully.
Calling another execute* method, or close before query completion would 
result in the async query getting killed if it is not already finished.



jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java (line 312)


getUpdateCount or ResultSet.next() would result in another RPC call. 
Can we call keep track of the Statement complete status as a Statement 
member to avoid that ?



service/src/java/org/apache/hive/service/cli/operation/Operation.java (line 208)


just use the condition directly here ?

- if( !states.contains(state) ) {
... 
}


- Thejas Nair


On April 9, 2016, 12:37 a.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45836/
> ---
> 
> (Updated April 9, 2016, 12:37 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6535
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Diffs
> -
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
>  8868ec1 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java
>  35b6c52 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
>  8db2e62 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java
>  d6f6280 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
>  a09b39a 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java
>  740b851 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
>  2a0fec2 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> d9a273b 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 04d816a 
> 
> Diff: https://reviews.apache.org/r/45836/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Re: Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-08 Thread Vaibhav Gumashta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/
---

(Updated April 9, 2016, 12:37 a.m.)


Review request for hive and Thejas Nair.


Bugs: HIVE-6535
https://issues.apache.org/jira/browse/HIVE-6535


Repository: hive-git


Description
---

https://issues.apache.org/jira/browse/HIVE-6535


Diffs (updated)
-

  jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
  jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
  
service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
 8868ec1 
  
service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 
35b6c52 
  
service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
 8db2e62 
  
service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java 
d6f6280 
  
service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
 a09b39a 
  
service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 
740b851 
  
service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
 2a0fec2 
  service/src/java/org/apache/hive/service/cli/operation/Operation.java d9a273b 
  service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
04d816a 

Diff: https://reviews.apache.org/r/45836/diff/


Testing
---


Thanks,

Vaibhav Gumashta

Re: Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-06 Thread Thejas Nair 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/#review127559
---




jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 


these comments look still applicable and useful for someone new to the 
codebase. retain them ?



jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java (line 824)


why is this waitfor.. needed here ?



service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
 (line 71)


For MetadataOperation such as GetCatalogsOperation, in the blocking call 
the state moves to FINISHED, as there is no async execution for it. So I this 
should assert for FINISHED state.



service/src/java/org/apache/hive/service/cli/operation/Operation.java (line 205)


states.contains(state) ?


- Thejas Nair


On April 6, 2016, 8:53 p.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45836/
> ---
> 
> (Updated April 6, 2016, 8:53 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6535
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Diffs
> -
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
>  8868ec1 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java
>  35b6c52 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
>  8db2e62 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java
>  d6f6280 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
>  a09b39a 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java
>  740b851 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
>  2a0fec2 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> d9a273b 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 04d816a 
> 
> Diff: https://reviews.apache.org/r/45836/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Re: Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-06 Thread Thejas Nair 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/#review127558
---




jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java (line 103)


See beeline Commands.java loop for collecting logs. It will stop collecting 
when this boolean is false. So initing to false doesn't work with that logic.

Commands.java has - 
while (hiveStatement.hasMoreLogs()) {


- Thejas Nair


On April 6, 2016, 8:53 p.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45836/
> ---
> 
> (Updated April 6, 2016, 8:53 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6535
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Diffs
> -
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
>  8868ec1 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java
>  35b6c52 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
>  8db2e62 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java
>  d6f6280 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
>  a09b39a 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java
>  740b851 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
>  2a0fec2 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> d9a273b 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 04d816a 
> 
> Diff: https://reviews.apache.org/r/45836/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Re: Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-06 Thread Thejas Nair 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/#review127557
---




jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java (line 272)


logs are being generated for queries that don't have results as well.  
insert queries for example, and even ddl queries.


- Thejas Nair


On April 6, 2016, 8:53 p.m., Vaibhav Gumashta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45836/
> ---
> 
> (Updated April 6, 2016, 8:53 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6535
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-6535
> 
> 
> Diffs
> -
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
>  8868ec1 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java
>  35b6c52 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
>  8db2e62 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java
>  d6f6280 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
>  a09b39a 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java
>  740b851 
>   
> service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
>  2a0fec2 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 
> d9a273b 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
> 04d816a 
> 
> Diff: https://reviews.apache.org/r/45836/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>

Review Request 45836: JDBC: async wait should happen during fetch for results

2016-04-06 Thread Vaibhav Gumashta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45836/
---

Review request for hive and Thejas Nair.


Bugs: HIVE-6535
https://issues.apache.org/jira/browse/HIVE-6535


Repository: hive-git


Description
---

https://issues.apache.org/jira/browse/HIVE-6535


Diffs
-

  jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 8f67209 
  jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java b4dba44 
  
service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
 8868ec1 
  
service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 
35b6c52 
  
service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
 8db2e62 
  
service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java 
d6f6280 
  
service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
 a09b39a 
  
service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 
740b851 
  
service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
 2a0fec2 
  service/src/java/org/apache/hive/service/cli/operation/Operation.java d9a273b 
  service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
04d816a 

Diff: https://reviews.apache.org/r/45836/diff/


Testing
---


Thanks,

Vaibhav Gumashta