Re: Review Request 49410: HIVE-13945 Decimal value is displayed as rounded when selecting where clause with that decimal value - no out files

2016-06-29 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49410/#review140074
---




ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java (line 576)


spurious



ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java (line 
295)


spurious



serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/DecimalTypeInfo.java 
(line 34)


spurious


- Sergey Shelukhin


On June 29, 2016, 11:56 p.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49410/
> ---
> 
> (Updated June 29, 2016, 11:56 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see JIRA
> 
> 
> Diffs
> -
> 
>   contrib/src/test/queries/clientpositive/udf_example_format.q 38069dc 
>   orc/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java 9e5f5cc 
>   orc/src/java/org/apache/orc/impl/RecordReaderImpl.java 36a802e 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java e154d13 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 
> 9de1833 
>   
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToLong.java
>  045f0ab 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 227a051 
>   ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java 
> 1fa94b9 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java
>  6952ffb 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
>  2e1384a 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> 5b32f56 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 67d8b86 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g a1909a7 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java a9e503d 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 20d9649 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 
> 239cc61 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java fc6540e 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java 3d85abd 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java 24533d6 
>   
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileApprox.java
>  795013a 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java 
> 351b593 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java 
> 89e69be 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java 
> e52e431 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java 
> b89c14e 
>   
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 
> 6fa3b3f 
>   ql/src/test/queries/clientnegative/compare_double_bigint.q 8ee4b27 
>   ql/src/test/queries/clientpositive/decimal_divide.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/implicit_decimal.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/input_lazyserde.q 74d7a2a 
>   ql/src/test/queries/clientpositive/udf_java_method.q c0598cd 
>   ql/src/test/queries/clientpositive/udf_reflect.q 97fa817 
>   ql/src/test/queries/clientpositive/vector_struct_in.q 0e3a4ca 
>   
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
>  6415bf8 
>   serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/DecimalTypeInfo.java 
> d00f77d 
>   storage-api/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 
> 1c6be91 
> 
> Diff: https://reviews.apache.org/r/49410/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Review Request 49410: HIVE-13945 Decimal value is displayed as rounded when selecting where clause with that decimal value - no out files

2016-06-29 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49410/
---

Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
---

see JIRA


Diffs
-

  contrib/src/test/queries/clientpositive/udf_example_format.q 38069dc 
  orc/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java 9e5f5cc 
  orc/src/java/org/apache/orc/impl/RecordReaderImpl.java 36a802e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java e154d13 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 
9de1833 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToLong.java
 045f0ab 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 227a051 
  ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java 
1fa94b9 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java
 6952ffb 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
 2e1384a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 5b32f56 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 67d8b86 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g a1909a7 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java a9e503d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 20d9649 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 239cc61 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java fc6540e 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java 3d85abd 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java 24533d6 
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileApprox.java
 795013a 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java 
351b593 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java 
89e69be 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java 
e52e431 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java 
b89c14e 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 
6fa3b3f 
  ql/src/test/queries/clientnegative/compare_double_bigint.q 8ee4b27 
  ql/src/test/queries/clientpositive/decimal_divide.q PRE-CREATION 
  ql/src/test/queries/clientpositive/implicit_decimal.q PRE-CREATION 
  ql/src/test/queries/clientpositive/input_lazyserde.q 74d7a2a 
  ql/src/test/queries/clientpositive/udf_java_method.q c0598cd 
  ql/src/test/queries/clientpositive/udf_reflect.q 97fa817 
  ql/src/test/queries/clientpositive/vector_struct_in.q 0e3a4ca 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
 6415bf8 
  serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/DecimalTypeInfo.java 
d00f77d 
  storage-api/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 
1c6be91 

Diff: https://reviews.apache.org/r/49410/diff/


Testing
---


Thanks,

Sergey Shelukhin