Re: Review Request 59610: Support numeric as same as decimal

2017-05-30 Thread Ashutosh Chauhan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59610/#review176358
---




ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
Line 137 (original), 137 (patched)


This will make Numeric reserved keyword, which is ok, but we need to note 
that in Release Notes field of jira and mark incompatible change flag in jira.


- Ashutosh Chauhan


On May 26, 2017, 5:43 p.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59610/
> ---
> 
> (Updated May 26, 2017, 5:43 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-16764
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 393df65cd9 
>   ql/src/test/queries/clientpositive/perf/query1.q d40f66aa1d 
>   ql/src/test/queries/clientpositive/perf/query10.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query12.q 7ef6cb89eb 
>   ql/src/test/queries/clientpositive/perf/query13.q 6f43d4738f 
>   ql/src/test/queries/clientpositive/perf/query14.q e075f4f4a8 
>   ql/src/test/queries/clientpositive/perf/query15.q 9f75410fbe 
>   ql/src/test/queries/clientpositive/perf/query16.q 0243bf3fbe 
>   ql/src/test/queries/clientpositive/perf/query17.q bb8a33b8de 
>   ql/src/test/queries/clientpositive/perf/query18.q e6061f5579 
>   ql/src/test/queries/clientpositive/perf/query19.q cfb62185d0 
>   ql/src/test/queries/clientpositive/perf/query2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query20.q d4ea10dc18 
>   ql/src/test/queries/clientpositive/perf/query21.q 4c68df9a9e 
>   ql/src/test/queries/clientpositive/perf/query22.q adb509dab0 
>   ql/src/test/queries/clientpositive/perf/query23.q 4939416e73 
>   ql/src/test/queries/clientpositive/perf/query24.q b9b747f4ab 
>   ql/src/test/queries/clientpositive/perf/query25.q 80185ab00c 
>   ql/src/test/queries/clientpositive/perf/query26.q 0e81120214 
>   ql/src/test/queries/clientpositive/perf/query27.q 0cbb3ae5a9 
>   ql/src/test/queries/clientpositive/perf/query28.q 2a5f0922d4 
>   ql/src/test/queries/clientpositive/perf/query29.q 1634b1f6ae 
>   ql/src/test/queries/clientpositive/perf/query3.q 47dfac57c9 
>   ql/src/test/queries/clientpositive/perf/query30.q 25c9e07d11 
>   ql/src/test/queries/clientpositive/perf/query31.q d448dc3894 
>   ql/src/test/queries/clientpositive/perf/query32.q ceb2ddb03c 
>   ql/src/test/queries/clientpositive/perf/query33.q 06628bd1af 
>   ql/src/test/queries/clientpositive/perf/query34.q 5c3efe1719 
>   ql/src/test/queries/clientpositive/perf/query35.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query36.q 6c3a945a8f 
>   ql/src/test/queries/clientpositive/perf/query37.q c71ec56f8f 
>   ql/src/test/queries/clientpositive/perf/query38.q 2e8517e3b3 
>   ql/src/test/queries/clientpositive/perf/query39.q c9f8f2b96e 
>   ql/src/test/queries/clientpositive/perf/query40.q 155fa084c5 
>   ql/src/test/queries/clientpositive/perf/query42.q c4b115b236 
>   ql/src/test/queries/clientpositive/perf/query43.q f1c22e86d6 
>   ql/src/test/queries/clientpositive/perf/query44.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query45.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query46.q 3e8711f9a1 
>   ql/src/test/queries/clientpositive/perf/query48.q a02f6302ed 
>   ql/src/test/queries/clientpositive/perf/query49.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query5.q a877c4cd88 
>   ql/src/test/queries/clientpositive/perf/query50.q e4bdf0ab6f 
>   ql/src/test/queries/clientpositive/perf/query51.q b7688cfefc 
>   ql/src/test/queries/clientpositive/perf/query52.q 24d0ac3231 
>   ql/src/test/queries/clientpositive/perf/query53.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query54.q b1a3e832a8 
>   ql/src/test/queries/clientpositive/perf/query55.q 644ba1afd5 
>   ql/src/test/queries/clientpositive/perf/query56.q 63e53ea9fe 
>   ql/src/test/queries/clientpositive/perf/query58.q d392ded7d8 
>   ql/src/test/queries/clientpositive/perf/query59.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query6.q 8e4a7d375e 
>   ql/src/test/queries/clientpositive/perf/query60.q efa86d1079 
>   ql/src/test/queries/clientpositive/perf/query61.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query63.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/perf/query64.q 13ebf4ab76 
>   ql/src/test/queries/clientpositive/perf/query65.q bd4475d8ff 
>   ql/src/test/queries/clientpositive/perf/query66.q 9224680411 
>   ql/src/test/queries/clientpositive/perf/query67.q ca2fc61fb0 
>   ql/src/test/queries/clientpositive/perf/query68.q

Review Request 59610: Support numeric as same as decimal

2017-05-26 Thread pengcheng xiong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59610/
---

Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
---

HIVE-16764


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 393df65cd9 
  ql/src/test/queries/clientpositive/perf/query1.q d40f66aa1d 
  ql/src/test/queries/clientpositive/perf/query10.q PRE-CREATION 
  ql/src/test/queries/clientpositive/perf/query12.q 7ef6cb89eb 
  ql/src/test/queries/clientpositive/perf/query13.q 6f43d4738f 
  ql/src/test/queries/clientpositive/perf/query14.q e075f4f4a8 
  ql/src/test/queries/clientpositive/perf/query15.q 9f75410fbe 
  ql/src/test/queries/clientpositive/perf/query16.q 0243bf3fbe 
  ql/src/test/queries/clientpositive/perf/query17.q bb8a33b8de 
  ql/src/test/queries/clientpositive/perf/query18.q e6061f5579 
  ql/src/test/queries/clientpositive/perf/query19.q cfb62185d0 
  ql/src/test/queries/clientpositive/perf/query2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/perf/query20.q d4ea10dc18 
  ql/src/test/queries/clientpositive/perf/query21.q 4c68df9a9e 
  ql/src/test/queries/clientpositive/perf/query22.q adb509dab0 
  ql/src/test/queries/clientpositive/perf/query23.q 4939416e73 
  ql/src/test/queries/clientpositive/perf/query24.q b9b747f4ab 
  ql/src/test/queries/clientpositive/perf/query25.q 80185ab00c 
  ql/src/test/queries/clientpositive/perf/query26.q 0e81120214 
  ql/src/test/queries/clientpositive/perf/query27.q 0cbb3ae5a9 
  ql/src/test/queries/clientpositive/perf/query28.q 2a5f0922d4 
  ql/src/test/queries/clientpositive/perf/query29.q 1634b1f6ae 
  ql/src/test/queries/clientpositive/perf/query3.q 47dfac57c9 
  ql/src/test/queries/clientpositive/perf/query30.q 25c9e07d11 
  ql/src/test/queries/clientpositive/perf/query31.q d448dc3894 
  ql/src/test/queries/clientpositive/perf/query32.q ceb2ddb03c 
  ql/src/test/queries/clientpositive/perf/query33.q 06628bd1af 
  ql/src/test/queries/clientpositive/perf/query34.q 5c3efe1719 
  ql/src/test/queries/clientpositive/perf/query35.q PRE-CREATION 
  ql/src/test/queries/clientpositive/perf/query36.q 6c3a945a8f 
  ql/src/test/queries/clientpositive/perf/query37.q c71ec56f8f 
  ql/src/test/queries/clientpositive/perf/query38.q 2e8517e3b3 
  ql/src/test/queries/clientpositive/perf/query39.q c9f8f2b96e 
  ql/src/test/queries/clientpositive/perf/query40.q 155fa084c5 
  ql/src/test/queries/clientpositive/perf/query42.q c4b115b236 
  ql/src/test/queries/clientpositive/perf/query43.q f1c22e86d6 
  ql/src/test/queries/clientpositive/perf/query44.q PRE-CREATION 
  ql/src/test/queries/clientpositive/perf/query45.q PRE-CREATION 
  ql/src/test/queries/clientpositive/perf/query46.q 3e8711f9a1 
  ql/src/test/queries/clientpositive/perf/query48.q a02f6302ed 
  ql/src/test/queries/clientpositive/perf/query49.q PRE-CREATION 
  ql/src/test/queries/clientpositive/perf/query5.q a877c4cd88 
  ql/src/test/queries/clientpositive/perf/query50.q e4bdf0ab6f 
  ql/src/test/queries/clientpositive/perf/query51.q b7688cfefc 
  ql/src/test/queries/clientpositive/perf/query52.q 24d0ac3231 
  ql/src/test/queries/clientpositive/perf/query53.q PRE-CREATION 
  ql/src/test/queries/clientpositive/perf/query54.q b1a3e832a8 
  ql/src/test/queries/clientpositive/perf/query55.q 644ba1afd5 
  ql/src/test/queries/clientpositive/perf/query56.q 63e53ea9fe 
  ql/src/test/queries/clientpositive/perf/query58.q d392ded7d8 
  ql/src/test/queries/clientpositive/perf/query59.q PRE-CREATION 
  ql/src/test/queries/clientpositive/perf/query6.q 8e4a7d375e 
  ql/src/test/queries/clientpositive/perf/query60.q efa86d1079 
  ql/src/test/queries/clientpositive/perf/query61.q PRE-CREATION 
  ql/src/test/queries/clientpositive/perf/query63.q PRE-CREATION 
  ql/src/test/queries/clientpositive/perf/query64.q 13ebf4ab76 
  ql/src/test/queries/clientpositive/perf/query65.q bd4475d8ff 
  ql/src/test/queries/clientpositive/perf/query66.q 9224680411 
  ql/src/test/queries/clientpositive/perf/query67.q ca2fc61fb0 
  ql/src/test/queries/clientpositive/perf/query68.q 34f87c2cdd 
  ql/src/test/queries/clientpositive/perf/query69.q d9528ae18a 
  ql/src/test/queries/clientpositive/perf/query7.q 39c4383a8c 
  ql/src/test/queries/clientpositive/perf/query70.q 80f8c234d6 
  ql/src/test/queries/clientpositive/perf/query71.q d0601d283e 
  ql/src/test/queries/clientpositive/perf/query72.q 6c076d6afe 
  ql/src/test/queries/clientpositive/perf/query73.q 95c4695eed 
  ql/src/test/queries/clientpositive/perf/query75.q a815c9e0af 
  ql/src/test/queries/clientpositive/perf/query76.q 1894cf4088 
  ql/src/test/queries/clientpositive/perf/query77.q PRE-CREATION 
  ql/src/test/queries/clientpositive/perf/query78.q PRE-CREATION 
  ql/src/test/queries/clientpositive/perf/query79.q d1046022f1 
  ql/src/test/queries/clientpositive/perf/query8.q bb77f55933 
  ql/src/test/queries/clientposi