Review Request 64326: HIVE-18208

2017-12-04 Thread Deepak Jaiswal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64326/
---

Review request for hive and Jason Dere.


Repository: hive-git


Description
---

SMB Join : Fix the unit tests to run SMB Joins.
Updated tests and result files.


Diffs
-

  ql/src/test/queries/clientpositive/auto_sortmerge_join_1.q a1d5249448 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_10.q e65344dd6d 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_11.q 11499f8eab 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_12.q b512cc5c74 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_13.q 1c868dcd15 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_14.q dd59c74fc0 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_15.q 1480b15488 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_16.q 12ab1fa1d1 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_2.q e77d937991 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_3.q 183f03335a 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_4.q 21f273a17b 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_7.q cf12331e13 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_8.q 5ec4e26d4b 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_9.q f95631f429 
  ql/src/test/queries/clientpositive/bucketsortoptimize_insert_2.q 4a14587857 
  ql/src/test/queries/clientpositive/bucketsortoptimize_insert_6.q ec0c2dc254 
  ql/src/test/queries/clientpositive/bucketsortoptimize_insert_7.q 45635c1209 
  ql/src/test/queries/clientpositive/quotedid_smb.q 25d1f0eee7 
  ql/src/test/queries/clientpositive/smb_cache.q e415e51053 
  ql/src/test/results/clientpositive/auto_sortmerge_join_10.q.out 22ac2a201a 
  ql/src/test/results/clientpositive/auto_sortmerge_join_11.q.out 243a49b45f 
  ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 3d0559a47c 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_1.q.out 
36bfac3f4c 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_10.q.out 
b8f10fec67 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_11.q.out 
37d97d2252 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out 
655573650b 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_13.q.out 
a6d73097e0 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_14.q.out 
2d03e8cb72 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_15.q.out 
ce41569f49 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_16.q.out 
cb8564fd78 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_2.q.out 
90d362e981 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_3.q.out 
365f63c0ad 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_4.q.out 
8ee44b3493 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_7.q.out 
83d5a968b7 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_8.q.out 
0e0428481b 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_9.q.out 
8bd3d126c1 
  ql/src/test/results/clientpositive/llap/bucketsortoptimize_insert_2.q.out 
b907c2dbd8 
  ql/src/test/results/clientpositive/llap/bucketsortoptimize_insert_6.q.out 
f5f5f91e82 
  ql/src/test/results/clientpositive/llap/bucketsortoptimize_insert_7.q.out 
7b380562ac 
  ql/src/test/results/clientpositive/llap/quotedid_smb.q.out 8e850f50ce 
  ql/src/test/results/clientpositive/llap/smb_cache.q.out 60d4ff0ba0 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_1.q.out 
e6038b857d 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_12.q.out 
ff9a0f4fa4 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_14.q.out 
8c0d506b26 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_15.q.out 
b005bda331 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_16.q.out 
cb8564fd78 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_2.q.out 
025d0d29c5 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_3.q.out 
3ad950a107 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_4.q.out 
60437ec56d 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_7.q.out 
16ecabe05d 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_8.q.out 
e180471dcb 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_9.q.out 
4d0476f9ee 
  ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_2.q.out 
814553d81a 
  ql/src/test/results/clientpositive/spark/quotedid_smb.q.out 7b8777f9d6 


Diff: https://reviews.apache.org/r/64326/diff/1/


Testing
---


Thanks,

Deepak Jaiswal

Re: Review Request 64326: HIVE-18208

2017-12-07 Thread Jason Dere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64326/#review192957
---




ql/src/test/queries/clientpositive/auto_sortmerge_join_1.q
Lines 29 (patched)


Please add comment stating that the point of this setting is to disable 
hashjoins from being chosen in the query plan. As well as in the other qfiles.



ql/src/test/queries/clientpositive/bucketsortoptimize_insert_2.q
Lines 36 (patched)


Is this config needed for all of the bucketsort tests?



ql/src/test/results/clientpositive/llap/auto_sortmerge_join_11.q.out
Line 113 (original), 113 (patched)


Looks like MapJoin is replaced by a reduce-side mergejoin, is this correct?



ql/src/test/results/clientpositive/llap/auto_sortmerge_join_11.q.out
Line 403 (original), 412 (patched)


Looks like MapJoin is replaced by a reduce-side mergejoin, is this correct?



ql/src/test/results/clientpositive/llap/auto_sortmerge_join_11.q.out
Line 693 (original), 711 (patched)


Looks like MapJoin is replaced by a reduce-side mergejoin, is this correct?



ql/src/test/results/clientpositive/llap/auto_sortmerge_join_11.q.out
Line 975 (original), 1002 (patched)


Looks like MapJoin is replaced by a reduce-side mergejoin, is this correct?



ql/src/test/results/clientpositive/llap/auto_sortmerge_join_16.q.out
Lines 263 (patched)


Is this one supposed to be a smb join? The mergejoin is in the Reducer.



ql/src/test/results/clientpositive/llap/auto_sortmerge_join_9.q.out
Line 1204 (original), 1154 (patched)


Looks like MapJoin is replaced by a reduce-side mergejoin, is this correct?



ql/src/test/results/clientpositive/llap/smb_cache.q.out
Line 206 (original), 212 (patched)


Are these supposed to be smb joins? Looks like reducer-side mergejoin here.


- Jason Dere


On Dec. 5, 2017, 4:43 a.m., Deepak Jaiswal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64326/
> ---
> 
> (Updated Dec. 5, 2017, 4:43 a.m.)
> 
> 
> Review request for hive and Jason Dere.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> SMB Join : Fix the unit tests to run SMB Joins.
> Updated tests and result files.
> 
> 
> Diffs
> -
> 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_1.q a1d5249448 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_10.q e65344dd6d 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_11.q 11499f8eab 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_12.q b512cc5c74 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_13.q 1c868dcd15 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_14.q dd59c74fc0 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_15.q 1480b15488 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_16.q 12ab1fa1d1 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_2.q e77d937991 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_3.q 183f03335a 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_4.q 21f273a17b 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_7.q cf12331e13 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_8.q 5ec4e26d4b 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_9.q f95631f429 
>   ql/src/test/queries/clientpositive/bucketsortoptimize_insert_2.q 4a14587857 
>   ql/src/test/queries/clientpositive/bucketsortoptimize_insert_6.q ec0c2dc254 
>   ql/src/test/queries/clientpositive/bucketsortoptimize_insert_7.q 45635c1209 
>   ql/src/test/queries/clientpositive/quotedid_smb.q 25d1f0eee7 
>   ql/src/test/queries/clientpositive/smb_cache.q e415e51053 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_10.q.out 22ac2a201a 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_11.q.out 243a49b45f 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 3d0559a47c 
>   ql/src/test/results/clientpositive/llap/auto_sortmerge_join_1.q.out 
> 36bfac3f4c 
>   ql/src/test/results/clientpositive/llap/auto_sortmerge_join_10.q.out 
> b8f10fec67 
>   ql/src/test/results/clientpositive/llap/auto_sortmerge_join_11.q.out 
> 37d97d2252 
>   ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out 
> 655573650b 
>   ql/src/test/results/clientpositive/llap/auto_sortmerg

Re: Review Request 64326: HIVE-18208

2017-12-07 Thread Deepak Jaiswal 


> On Dec. 8, 2017, 12:59 a.m., Jason Dere wrote:
> > ql/src/test/queries/clientpositive/auto_sortmerge_join_1.q
> > Lines 29 (patched)
> > 
> >
> > Please add comment stating that the point of this setting is to disable 
> > hashjoins from being chosen in the query plan. As well as in the other 
> > qfiles.

Adding comment on all the tests. Thanks


> On Dec. 8, 2017, 12:59 a.m., Jason Dere wrote:
> > ql/src/test/queries/clientpositive/bucketsortoptimize_insert_2.q
> > Lines 36 (patched)
> > 
> >
> > Is this config needed for all of the bucketsort tests?

Thanks for the catch. I added it there for testing some other stuff. Will take 
it out.


> On Dec. 8, 2017, 12:59 a.m., Jason Dere wrote:
> > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_11.q.out
> > Line 113 (original), 113 (patched)
> > 
> >
> > Looks like MapJoin is replaced by a reduce-side mergejoin, is this 
> > correct?

Fix coming in updated patch. Applies to all such queries in the test file.


> On Dec. 8, 2017, 12:59 a.m., Jason Dere wrote:
> > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_16.q.out
> > Lines 263 (patched)
> > 
> >
> > Is this one supposed to be a smb join? The mergejoin is in the Reducer.

Found the issue earlier today, updated the results.


> On Dec. 8, 2017, 12:59 a.m., Jason Dere wrote:
> > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_9.q.out
> > Line 1204 (original), 1154 (patched)
> > 
> >
> > Looks like MapJoin is replaced by a reduce-side mergejoin, is this 
> > correct?

Yes. Since the noconditionaltasksize virtually disables hash joins, the chance 
of getting mapside join other than SMB is low.
For this query, SMB does not apply, thus it falls back to reduce side join.


> On Dec. 8, 2017, 12:59 a.m., Jason Dere wrote:
> > ql/src/test/results/clientpositive/llap/smb_cache.q.out
> > Line 206 (original), 212 (patched)
> > 
> >
> > Are these supposed to be smb joins? Looks like reducer-side mergejoin 
> > here.

Thanks for pointing out. I must have missed it. Looking into it.


- Deepak


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64326/#review192957
---


On Dec. 5, 2017, 4:43 a.m., Deepak Jaiswal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64326/
> ---
> 
> (Updated Dec. 5, 2017, 4:43 a.m.)
> 
> 
> Review request for hive and Jason Dere.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> SMB Join : Fix the unit tests to run SMB Joins.
> Updated tests and result files.
> 
> 
> Diffs
> -
> 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_1.q a1d5249448 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_10.q e65344dd6d 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_11.q 11499f8eab 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_12.q b512cc5c74 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_13.q 1c868dcd15 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_14.q dd59c74fc0 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_15.q 1480b15488 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_16.q 12ab1fa1d1 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_2.q e77d937991 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_3.q 183f03335a 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_4.q 21f273a17b 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_7.q cf12331e13 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_8.q 5ec4e26d4b 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_9.q f95631f429 
>   ql/src/test/queries/clientpositive/bucketsortoptimize_insert_2.q 4a14587857 
>   ql/src/test/queries/clientpositive/bucketsortoptimize_insert_6.q ec0c2dc254 
>   ql/src/test/queries/clientpositive/bucketsortoptimize_insert_7.q 45635c1209 
>   ql/src/test/queries/clientpositive/quotedid_smb.q 25d1f0eee7 
>   ql/src/test/queries/clientpositive/smb_cache.q e415e51053 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_10.q.out 22ac2a201a 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_11.q.out 243a49b45f 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 3d0559a47c 
>   ql/src/test/results/clien

Re: Review Request 64326: HIVE-18208

2017-12-08 Thread Deepak Jaiswal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64326/
---

(Updated Dec. 8, 2017, 8:08 a.m.)


Review request for hive and Jason Dere.


Changes
---

Updated the patch with comments from review.
Rolled back changes to auto_sortmerge_join_16.q and its result files as the 
test is giving wrong results for which a separate JIRA is opened.


Repository: hive-git


Description
---

SMB Join : Fix the unit tests to run SMB Joins.
Updated tests and result files.


Diffs (updated)
-

  ql/src/test/queries/clientpositive/auto_sortmerge_join_1.q a1d5249448 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_10.q e65344dd6d 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_11.q 11499f8eab 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_12.q b512cc5c74 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_13.q 1c868dcd15 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_14.q dd59c74fc0 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_15.q 1480b15488 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_2.q e77d937991 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_3.q 183f03335a 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_4.q 21f273a17b 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_7.q cf12331e13 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_8.q 5ec4e26d4b 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_9.q f95631f429 
  ql/src/test/queries/clientpositive/bucketsortoptimize_insert_2.q 4a14587857 
  ql/src/test/queries/clientpositive/bucketsortoptimize_insert_6.q ec0c2dc254 
  ql/src/test/queries/clientpositive/bucketsortoptimize_insert_7.q 45635c1209 
  ql/src/test/queries/clientpositive/quotedid_smb.q 25d1f0eee7 
  ql/src/test/queries/clientpositive/smb_cache.q e415e51053 
  ql/src/test/results/clientpositive/auto_sortmerge_join_10.q.out 22ac2a201a 
  ql/src/test/results/clientpositive/auto_sortmerge_join_11.q.out 243a49b45f 
  ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 3d0559a47c 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_1.q.out 
36bfac3f4c 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_10.q.out 
b8f10fec67 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_11.q.out 
37d97d2252 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out 
655573650b 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_13.q.out 
a6d73097e0 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_14.q.out 
2d03e8cb72 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_15.q.out 
ce41569f49 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_2.q.out 
90d362e981 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_3.q.out 
365f63c0ad 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_4.q.out 
8ee44b3493 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_7.q.out 
83d5a968b7 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_8.q.out 
0e0428481b 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_9.q.out 
8bd3d126c1 
  ql/src/test/results/clientpositive/llap/bucketsortoptimize_insert_2.q.out 
b907c2dbd8 
  ql/src/test/results/clientpositive/llap/bucketsortoptimize_insert_6.q.out 
f5f5f91e82 
  ql/src/test/results/clientpositive/llap/bucketsortoptimize_insert_7.q.out 
7b380562ac 
  ql/src/test/results/clientpositive/llap/quotedid_smb.q.out 8e850f50ce 
  ql/src/test/results/clientpositive/llap/smb_cache.q.out 60d4ff0ba0 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_1.q.out 
e6038b857d 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_12.q.out 
ff9a0f4fa4 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_14.q.out 
8c0d506b26 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_15.q.out 
b005bda331 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_2.q.out 
025d0d29c5 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_3.q.out 
3ad950a107 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_4.q.out 
60437ec56d 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_7.q.out 
16ecabe05d 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_8.q.out 
e180471dcb 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_9.q.out 
4d0476f9ee 
  ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_2.q.out 
814553d81a 
  ql/src/test/results/clientpositive/spark/quotedid_smb.q.out 7b8777f9d6 


Diff: https://reviews.apache.org/r/64326/diff/2/

Changes: https://reviews.apache.org/r/64326/diff/1-2/


Testing
---


Thanks,

Deepak Jaiswal

Re: Review Request 64326: HIVE-18208

2017-12-12 Thread Deepak Jaiswal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64326/
---

(Updated Dec. 12, 2017, 7:37 p.m.)


Review request for hive and Jason Dere.


Changes
---

Rebased the patch


Repository: hive-git


Description
---

SMB Join : Fix the unit tests to run SMB Joins.
Updated tests and result files.


Diffs (updated)
-

  ql/src/test/queries/clientpositive/auto_sortmerge_join_1.q a1d5249448 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_10.q e65344dd6d 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_11.q 11499f8eab 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_12.q b512cc5c74 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_13.q b5706be3d5 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_14.q dd59c74fc0 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_15.q 1480b15488 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_2.q e77d937991 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_3.q 183f03335a 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_4.q 21f273a17b 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_7.q cf12331e13 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_8.q 5ec4e26d4b 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_9.q f95631f429 
  ql/src/test/queries/clientpositive/bucketsortoptimize_insert_2.q 4a14587857 
  ql/src/test/queries/clientpositive/bucketsortoptimize_insert_6.q ec0c2dc254 
  ql/src/test/queries/clientpositive/bucketsortoptimize_insert_7.q 45635c1209 
  ql/src/test/queries/clientpositive/quotedid_smb.q 25d1f0eee7 
  ql/src/test/queries/clientpositive/smb_cache.q e415e51053 
  ql/src/test/results/clientpositive/auto_sortmerge_join_10.q.out 22ac2a201a 
  ql/src/test/results/clientpositive/auto_sortmerge_join_11.q.out 243a49b45f 
  ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 3d0559a47c 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_1.q.out 
36bfac3f4c 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_10.q.out 
c1459d53ef 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_11.q.out 
37d97d2252 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out 
655573650b 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_13.q.out 
b78a517a74 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_14.q.out 
72d2c62e5b 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_15.q.out 
91b1d8ea67 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_2.q.out 
90d362e981 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_3.q.out 
365f63c0ad 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_4.q.out 
8ee44b3493 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_7.q.out 
83d5a968b7 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_8.q.out 
0e0428481b 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_9.q.out 
37c07afbf1 
  ql/src/test/results/clientpositive/llap/bucketsortoptimize_insert_2.q.out 
ce248323ce 
  ql/src/test/results/clientpositive/llap/bucketsortoptimize_insert_6.q.out 
3ba8a65772 
  ql/src/test/results/clientpositive/llap/bucketsortoptimize_insert_7.q.out 
0af21e0e26 
  ql/src/test/results/clientpositive/llap/quotedid_smb.q.out 8e850f50ce 
  ql/src/test/results/clientpositive/llap/smb_cache.q.out defade5c08 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_1.q.out 
e6038b857d 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_12.q.out 
ff9a0f4fa4 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_14.q.out 
8c0d506b26 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_15.q.out 
b005bda331 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_2.q.out 
025d0d29c5 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_3.q.out 
3ad950a107 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_4.q.out 
60437ec56d 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_7.q.out 
16ecabe05d 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_8.q.out 
e180471dcb 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_9.q.out 
4d0476f9ee 
  ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_2.q.out 
814553d81a 
  ql/src/test/results/clientpositive/spark/quotedid_smb.q.out 7b8777f9d6 


Diff: https://reviews.apache.org/r/64326/diff/3/

Changes: https://reviews.apache.org/r/64326/diff/2-3/


Testing
---


Thanks,

Deepak Jaiswal