Re: Review Request 68365: HIVE-19253: HMS ignores tableType property for external tables

2018-08-15 Thread Andrew Sherman via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68365/#review207383
---


Ship it!




Ship It!

- Andrew Sherman


On Aug. 15, 2018, 11:13 p.m., Alexander Kolbasov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68365/
> ---
> 
> (Updated Aug. 15, 2018, 11:13 p.m.)
> 
> 
> Review request for hive, Andrew Sherman, Peter Vary, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-19253
> https://issues.apache.org/jira/browse/HIVE-19253
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-19253: HMS ignores tableType property for external tables
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  8e2f94eb691a72cc4e6410aa76b176032d4af673 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
>  5233bee59220244e89f05b6c4dbf86a2cc6dc9fe 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java
>  b74c3048fa2e18adc7f0d7cc813a180d4466fa36 
> 
> 
> Diff: https://reviews.apache.org/r/68365/diff/2/
> 
> 
> Testing
> ---
> 
> Added unit test to verify the expected behavior.
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>

Re: Review Request 68365: HIVE-19253: HMS ignores tableType property for external tables

2018-08-15 Thread Alexander Kolbasov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68365/
---

(Updated Aug. 15, 2018, 11:13 p.m.)


Review request for hive, Andrew Sherman, Peter Vary, and Vihang Karajgaonkar.


Changes
---

Added extre check in MetastoreUtils to check for external table.


Bugs: HIVE-19253
https://issues.apache.org/jira/browse/HIVE-19253


Repository: hive-git


Description
---

HIVE-19253: HMS ignores tableType property for external tables


Diffs (updated)
-

  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 8e2f94eb691a72cc4e6410aa76b176032d4af673 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe 
  
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java
 b74c3048fa2e18adc7f0d7cc813a180d4466fa36 


Diff: https://reviews.apache.org/r/68365/diff/2/

Changes: https://reviews.apache.org/r/68365/diff/1-2/


Testing
---

Added unit test to verify the expected behavior.


Thanks,

Alexander Kolbasov

Re: Review Request 68365: HIVE-19253: HMS ignores tableType property for external tables

2018-08-15 Thread Alexander Kolbasov 


> On Aug. 15, 2018, 8:59 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java
> > Lines 839 (patched)
> > 
> >
> > It seems weird that there isn't a constant for "EXTERNAL", but I can't 
> > find one.

Will add a constant as well.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68365/#review207354
---


On Aug. 15, 2018, 8:18 p.m., Alexander Kolbasov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68365/
> ---
> 
> (Updated Aug. 15, 2018, 8:18 p.m.)
> 
> 
> Review request for hive, Andrew Sherman, Peter Vary, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-19253
> https://issues.apache.org/jira/browse/HIVE-19253
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-19253: HMS ignores tableType property for external tables
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  8e2f94eb691a72cc4e6410aa76b176032d4af673 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java
>  b74c3048fa2e18adc7f0d7cc813a180d4466fa36 
> 
> 
> Diff: https://reviews.apache.org/r/68365/diff/1/
> 
> 
> Testing
> ---
> 
> Added unit test to verify the expected behavior.
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>

Re: Review Request 68365: HIVE-19253: HMS ignores tableType property for external tables

2018-08-15 Thread Alexander Kolbasov 


> On Aug. 15, 2018, 8:59 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java
> > Lines 854 (patched)
> > 
> >
> > So you test 
> > params(EXTERNAL=true),TableType.MANAGED_TABLE
> > params(EXTERNAL=false),TableType.EXTERNAL_TABLE
> > having done all the work you may as well test
> > params(EXTERNAL=false),TableType.MANAGED_TABLE
> > params(EXTERNAL=true),TableType.EXTERNAL_TABLE
> > as well?

Will add tests.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68365/#review207354
---


On Aug. 15, 2018, 8:18 p.m., Alexander Kolbasov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68365/
> ---
> 
> (Updated Aug. 15, 2018, 8:18 p.m.)
> 
> 
> Review request for hive, Andrew Sherman, Peter Vary, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-19253
> https://issues.apache.org/jira/browse/HIVE-19253
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-19253: HMS ignores tableType property for external tables
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  8e2f94eb691a72cc4e6410aa76b176032d4af673 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java
>  b74c3048fa2e18adc7f0d7cc813a180d4466fa36 
> 
> 
> Diff: https://reviews.apache.org/r/68365/diff/1/
> 
> 
> Testing
> ---
> 
> Added unit test to verify the expected behavior.
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>

Re: Review Request 68365: HIVE-19253: HMS ignores tableType property for external tables

2018-08-15 Thread Andrew Sherman via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68365/#review207354
---




standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java
Lines 839 (patched)


It seems weird that there isn't a constant for "EXTERNAL", but I can't find 
one.



standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java
Lines 854 (patched)


So you test 
params(EXTERNAL=true),TableType.MANAGED_TABLE
params(EXTERNAL=false),TableType.EXTERNAL_TABLE
having done all the work you may as well test
params(EXTERNAL=false),TableType.MANAGED_TABLE
params(EXTERNAL=true),TableType.EXTERNAL_TABLE
as well?


- Andrew Sherman


On Aug. 15, 2018, 8:18 p.m., Alexander Kolbasov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68365/
> ---
> 
> (Updated Aug. 15, 2018, 8:18 p.m.)
> 
> 
> Review request for hive, Andrew Sherman, Peter Vary, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-19253
> https://issues.apache.org/jira/browse/HIVE-19253
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-19253: HMS ignores tableType property for external tables
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  8e2f94eb691a72cc4e6410aa76b176032d4af673 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java
>  b74c3048fa2e18adc7f0d7cc813a180d4466fa36 
> 
> 
> Diff: https://reviews.apache.org/r/68365/diff/1/
> 
> 
> Testing
> ---
> 
> Added unit test to verify the expected behavior.
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>

Review Request 68365: HIVE-19253: HMS ignores tableType property for external tables

2018-08-15 Thread Alexander Kolbasov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68365/
---

Review request for hive, Andrew Sherman, Peter Vary, and Vihang Karajgaonkar.


Bugs: HIVE-19253
https://issues.apache.org/jira/browse/HIVE-19253


Repository: hive-git


Description
---

HIVE-19253: HMS ignores tableType property for external tables


Diffs
-

  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 8e2f94eb691a72cc4e6410aa76b176032d4af673 
  
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java
 b74c3048fa2e18adc7f0d7cc813a180d4466fa36 


Diff: https://reviews.apache.org/r/68365/diff/1/


Testing
---

Added unit test to verify the expected behavior.


Thanks,

Alexander Kolbasov