Re: Review Request 71888: HIVE-22568: Process compaction candidates in parallel by the Initiator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71888/#review219251 --- Ship it! Ship It! - Peter Vary On dec. 6, 2019, 12:54 du, Denys Kuzmenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71888/ > --- > > (Updated dec. 6, 2019, 12:54 du) > > > Review request for hive, Laszlo Pinter and Peter Vary. > > > Bugs: HIVE-22568 > https://issues.apache.org/jira/browse/HIVE-22568 > > > Repository: hive-git > > > Description > --- > > `checkForCompaction` includes many file metadata checks and may be expensive. > Therefore, make sense using a thread pool here and running > `checkForCompactions` in parallel. > > > Diffs > - > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 4393a2825e > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java > 7a0e32463d > ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestInitiator.java > 564839324f > > > Diff: https://reviews.apache.org/r/71888/diff/1/ > > > Testing > --- > > unit test > > > Thanks, > > Denys Kuzmenko > >
Re: Review Request 71888: HIVE-22568: Process compaction candidates in parallel by the Initiator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71888/#review219239 --- Ship it! +1 (non-binding) - Laszlo Pinter On Dec. 6, 2019, 12:54 p.m., Denys Kuzmenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71888/ > --- > > (Updated Dec. 6, 2019, 12:54 p.m.) > > > Review request for hive, Laszlo Pinter and Peter Vary. > > > Bugs: HIVE-22568 > https://issues.apache.org/jira/browse/HIVE-22568 > > > Repository: hive-git > > > Description > --- > > `checkForCompaction` includes many file metadata checks and may be expensive. > Therefore, make sense using a thread pool here and running > `checkForCompactions` in parallel. > > > Diffs > - > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 4393a2825e > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java > 7a0e32463d > ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestInitiator.java > 564839324f > > > Diff: https://reviews.apache.org/r/71888/diff/1/ > > > Testing > --- > > unit test > > > Thanks, > > Denys Kuzmenko > >
Review Request 71888: HIVE-22568: Process compaction candidates in parallel by the Initiator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71888/ --- Review request for hive, Laszlo Pinter and Peter Vary. Bugs: HIVE-22568 https://issues.apache.org/jira/browse/HIVE-22568 Repository: hive-git Description --- `checkForCompaction` includes many file metadata checks and may be expensive. Therefore, make sense using a thread pool here and running `checkForCompactions` in parallel. Diffs - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 4393a2825e ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java 7a0e32463d ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestInitiator.java 564839324f Diff: https://reviews.apache.org/r/71888/diff/1/ Testing --- unit test Thanks, Denys Kuzmenko
