Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestRun.pm
[EMAIL PROTECTED] wrote:
randyk 2004/01/10 14:07:17
Modified:perl-framework/Apache-Test/lib/Apache TestConfig.pm
TestRun.pm
Log:
On Win32, multiple options for Apache.exe can be returned which differ
only by the case of the .exe extension or by the directory separator.
These changes bring things into line with what is returned from which().
[...]
1.136 +2 -2 httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm
Index: TestRun.pm
===
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v
retrieving revision 1.135
retrieving revision 1.136
diff -u -r1.135 -r1.136
--- TestRun.pm 8 Jan 2004 04:54:06 - 1.135
+++ TestRun.pm 10 Jan 2004 22:07:17 - 1.136
@@ -1346,8 +1346,8 @@
for (grep defined $_,
map({ catfile $vars-{$_}, $vars-{target} } qw(sbindir bindir)),
$test_config-default_httpd, which($vars-{target}),
- $ENV{APACHE}, which('apache'), which('httpd'),
- $ENV{APACHE2}, which('apache2'), which('httpd2')) {
+ $ENV{APACHE}, which('Apache'), which('httpd'),
+ $ENV{APACHE2}, which('Apache2'), which('httpd2')) {
$choices{$_}++ if -e $_ -x _;
}
my $optional = 0;
yes, but we need which('apache') too for unix. so please:
- $ENV{APACHE}, which('apache'), which('httpd'),
- $ENV{APACHE2}, which('apache2'), which('httpd2')) {
+ $ENV{APACHE}, which('apache'), which('Apache'),
which('httpd'),
+ $ENV{APACHE2}, which('apache2'), which('Apache2'),
which('httpd2')) {
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: rerunning original_command
Randy Kobes wrote:
Hi,
With the current Apache-Test cvs, after the initial
dialogue asking which Apache binary you want is completed,
the original command is rerun with the desired configuration
options. However, this original command is reproduced as
't/TEST ', and on Win32 't/TEST' isn't recognized as a
command. This diff
===
Index: lib/Apache/TestRun.pm
===
RCS file:
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v
retrieving revision 1.136
diff -u -r1.136 TestRun.pm
--- lib/Apache/TestRun.pm 10 Jan 2004 22:07:17 - 1.136
+++ lib/Apache/TestRun.pm 10 Jan 2004 22:26:57 -
@@ -630,7 +630,7 @@
# reconstruct argv, preserve multiwords args, eg 'PerlTrace all'
my $argv = join , map { /^-/ ? $_ : qq['$_'] } @ARGV;
-$original_command = $0 $argv;
+$original_command = $^X $0 $argv;
$orig_cwd = Cwd::cwd();
$self-set_ulimit;
$self-set_env; #make sure these are always set
=
prepends the Perl binary to this command, which can then
be run.
I'm wondering, though - might there be circumstances where
$original_command contains the Perl binary already?
I think it's pretty safe:
% perl -le 'print $0'
-e
'perl' is not in $0. Is it different on windows?
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: win32_fetch_apxs in Apache-Test?
Randy Kobes wrote: Hi, The current Apache-Test cvs, as well as looking for an Apache binary, will also search for apxs, which doesn't come with Apache-2 on Win32. Within the mod_perl 2 distribution Makefile.PL will offer to run a script on Win32 to fetch and install an apxs - might it be an idea to do the same for Apache-Test, or perhaps within the perl-framework Makefile.PL? But that works only for mp2. How does A-T knows whether a user wants mp2 and not mp1? I think if they have mp2, they have had a chance to get apxs2 alredy, no? __ Stas BekmanJAm_pH -- Just Another mod_perl Hacker http://stason.org/ mod_perl Guide --- http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestRun.pm
On Sat, 10 Jan 2004, Stas Bekman wrote:
[EMAIL PROTECTED] wrote:
randyk 2004/01/10 14:07:17
Modified:perl-framework/Apache-Test/lib/Apache TestConfig.pm
TestRun.pm
Log:
On Win32, multiple options for Apache.exe can be returned which differ
only by the case of the .exe extension or by the directory separator.
These changes bring things into line with what is returned from which().
[...]
1.136 +2 -2
httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm
Index: TestRun.pm
===
RCS file:
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v
retrieving revision 1.135
retrieving revision 1.136
diff -u -r1.135 -r1.136
--- TestRun.pm8 Jan 2004 04:54:06 - 1.135
+++ TestRun.pm10 Jan 2004 22:07:17 - 1.136
@@ -1346,8 +1346,8 @@
for (grep defined $_,
map({ catfile $vars-{$_}, $vars-{target} } qw(sbindir
bindir)),
$test_config-default_httpd, which($vars-{target}),
- $ENV{APACHE}, which('apache'), which('httpd'),
- $ENV{APACHE2}, which('apache2'), which('httpd2')) {
+ $ENV{APACHE}, which('Apache'), which('httpd'),
+ $ENV{APACHE2}, which('Apache2'), which('httpd2')) {
$choices{$_}++ if -e $_ -x _;
}
my $optional = 0;
yes, but we need which('apache') too for unix. so please:
- $ENV{APACHE}, which('apache'), which('httpd'),
- $ENV{APACHE2}, which('apache2'), which('httpd2')) {
+ $ENV{APACHE}, which('apache'), which('Apache'),
which('httpd'),
+ $ENV{APACHE2}, which('apache2'), which('Apache2'),
which('httpd2')) {
Sorry about that - I'll revert that change (I just tried,
but got an error message about insufficient space left on a
device). Actually, looking for both 'apache' and 'Apache'
leads back to the same problem on Win32 that, when the list
of Apache binaries is reported, both 'apache' and 'Apache'
are listed (with the same paths), so a different approach is
needed.
--
best regards,
randy
Re: rerunning original_command
On Sat, 10 Jan 2004, Stas Bekman wrote:
Randy Kobes wrote:
Hi,
With the current Apache-Test cvs, after the initial
dialogue asking which Apache binary you want is completed,
the original command is rerun with the desired configuration
options. However, this original command is reproduced as
't/TEST ', and on Win32 't/TEST' isn't recognized as a
command. This diff
===
Index: lib/Apache/TestRun.pm
===
RCS file:
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v
retrieving revision 1.136
diff -u -r1.136 TestRun.pm
--- lib/Apache/TestRun.pm 10 Jan 2004 22:07:17 - 1.136
+++ lib/Apache/TestRun.pm 10 Jan 2004 22:26:57 -
@@ -630,7 +630,7 @@
# reconstruct argv, preserve multiwords args, eg 'PerlTrace all'
my $argv = join , map { /^-/ ? $_ : qq['$_'] } @ARGV;
-$original_command = $0 $argv;
+$original_command = $^X $0 $argv;
$orig_cwd = Cwd::cwd();
$self-set_ulimit;
$self-set_env; #make sure these are always set
=
prepends the Perl binary to this command, which can then
be run.
I'm wondering, though - might there be circumstances where
$original_command contains the Perl binary already?
I think it's pretty safe:
% perl -le 'print $0'
-e
'perl' is not in $0. Is it different on windows?
No, it's the same - I just wanted to be sure that the
Perl binary didn't creep in from somewhere else. Thanks.
--
best regards,
randy
Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestRun.pm
Randy Kobes wrote:
On Sat, 10 Jan 2004, Stas Bekman wrote:
[EMAIL PROTECTED] wrote:
randyk 2004/01/10 14:07:17
Modified:perl-framework/Apache-Test/lib/Apache TestConfig.pm
TestRun.pm
Log:
On Win32, multiple options for Apache.exe can be returned which differ
only by the case of the .exe extension or by the directory separator.
These changes bring things into line with what is returned from which().
[...]
1.136 +2 -2
httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm
Index: TestRun.pm
===
RCS file:
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v
retrieving revision 1.135
retrieving revision 1.136
diff -u -r1.135 -r1.136
--- TestRun.pm 8 Jan 2004 04:54:06 - 1.135
+++ TestRun.pm 10 Jan 2004 22:07:17 - 1.136
@@ -1346,8 +1346,8 @@
for (grep defined $_,
map({ catfile $vars-{$_}, $vars-{target} } qw(sbindir bindir)),
$test_config-default_httpd, which($vars-{target}),
- $ENV{APACHE}, which('apache'), which('httpd'),
- $ENV{APACHE2}, which('apache2'), which('httpd2')) {
+ $ENV{APACHE}, which('Apache'), which('httpd'),
+ $ENV{APACHE2}, which('Apache2'), which('httpd2')) {
$choices{$_}++ if -e $_ -x _;
}
my $optional = 0;
yes, but we need which('apache') too for unix. so please:
- $ENV{APACHE}, which('apache'), which('httpd'),
- $ENV{APACHE2}, which('apache2'), which('httpd2')) {
+ $ENV{APACHE}, which('apache'), which('Apache'),
which('httpd'),
+ $ENV{APACHE2}, which('apache2'), which('Apache2'),
which('httpd2')) {
Sorry about that - I'll revert that change (I just tried,
but got an error message about insufficient space left on a
device). Actually, looking for both 'apache' and 'Apache'
leads back to the same problem on Win32 that, when the list
of Apache binaries is reported, both 'apache' and 'Apache'
are listed (with the same paths), so a different approach is
needed.
So check that the path and lowercased filename match and exclude those on
win32?
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: win32_fetch_apxs in Apache-Test?
Randy Kobes wrote: On Sat, 10 Jan 2004, Stas Bekman wrote: Randy Kobes wrote: Hi, The current Apache-Test cvs, as well as looking for an Apache binary, will also search for apxs, which doesn't come with Apache-2 on Win32. Within the mod_perl 2 distribution Makefile.PL will offer to run a script on Win32 to fetch and install an apxs - might it be an idea to do the same for Apache-Test, or perhaps within the perl-framework Makefile.PL? But that works only for mp2. How does A-T knows whether a user wants mp2 and not mp1? I think if they have mp2, they have had a chance to get apxs2 alredy, no? That's true about a user already getting the chance to get a development apxs with mp2 - I was wondering though about doing the same for Apache2 within the perl-framework (the apxs that is offered with mp2 will work outside of mp2, as it just requires Apache2 - for example, it builds and runs the c-modules tests under httpd-test/perl-framework/). So here we would just have to check for Apache2. Yes, yes, what I was saying is that how the interactive config should know whether it's Apache 1 or Apache 2 that the user is after? or did you want to suggest it after user has specified the value for httpd and then if you figure out that it's for Apache2 and there is no apxs, you'd suggest to install it? I think that sounds like a working solution. __ Stas BekmanJAm_pH -- Just Another mod_perl Hacker http://stason.org/ mod_perl Guide --- http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestRun.pm
On Sun, 11 Jan 2004, Stas Bekman wrote: Randy Kobes wrote: [ .. ] Sorry about that - I'll revert that change (I just tried, but got an error message about insufficient space left on a device). Actually, looking for both 'apache' and 'Apache' leads back to the same problem on Win32 that, when the list of Apache binaries is reported, both 'apache' and 'Apache' are listed (with the same paths), so a different approach is needed. So check that the path and lowercased filename match and exclude those on win32? Yes, that would work, but it looks a bit funny - for example, my Apache is D:\Apache2\bin\Apache.exe, which would get reported as d:\apache2\bin\apache.exe. If there isn't an easy way to preserve the case yet still remove such duplicates, I'll do that - it's not a big deal. -- best regards, randy
Re: win32_fetch_apxs in Apache-Test?
On Sun, 11 Jan 2004, Stas Bekman wrote: Yes, yes, what I was saying is that how the interactive config should know whether it's Apache 1 or Apache 2 that the user is after? or did you want to suggest it after user has specified the value for httpd and then if you figure out that it's for Apache2 and there is no apxs, you'd suggest to install it? I think that sounds like a working solution. Yes, the latter is what I was thinking - I'll make up something for that and pass it along. Thanks. -- best regards, randy
Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestRun.pm
Randy Kobes wrote: On Sun, 11 Jan 2004, Stas Bekman wrote: Randy Kobes wrote: [ .. ] Sorry about that - I'll revert that change (I just tried, but got an error message about insufficient space left on a device). Actually, looking for both 'apache' and 'Apache' leads back to the same problem on Win32 that, when the list of Apache binaries is reported, both 'apache' and 'Apache' are listed (with the same paths), so a different approach is needed. So check that the path and lowercased filename match and exclude those on win32? Yes, that would work, but it looks a bit funny - for example, my Apache is D:\Apache2\bin\Apache.exe, which would get reported as d:\apache2\bin\apache.exe. If there isn't an easy way to preserve the case yet still remove such duplicates, I'll do that - it's not a big deal. Randy, you are the expert on win32 ;) I have no idea what method to use to get a consistent case on case-insenstive file systems. Really I think it's time to extend File::Spec to handle that and not solve this problem every time we need to read a filename. __ Stas BekmanJAm_pH -- Just Another mod_perl Hacker http://stason.org/ mod_perl Guide --- http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestRun.pm
On 12/01/2004, at 8:56 AM, Stas Bekman wrote: Randy Kobes wrote: On Sun, 11 Jan 2004, Stas Bekman wrote: Randy Kobes wrote: [ .. ] Sorry about that - I'll revert that change (I just tried, but got an error message about insufficient space left on a device). Actually, looking for both 'apache' and 'Apache' leads back to the same problem on Win32 that, when the list of Apache binaries is reported, both 'apache' and 'Apache' are listed (with the same paths), so a different approach is needed. So check that the path and lowercased filename match and exclude those on win32? Yes, that would work, but it looks a bit funny - for example, my Apache is D:\Apache2\bin\Apache.exe, which would get reported as d:\apache2\bin\apache.exe. If there isn't an easy way to preserve the case yet still remove such duplicates, I'll do that - it's not a big deal. Randy, you are the expert on win32 ;) I have no idea what method to use to get a consistent case on case-insenstive file systems. Really I think it's time to extend File::Spec to handle that and not solve this problem every time we need to read a filename. Likely to be a problem on (at least some versions of) Darwin as well, isn't it? Which probably means that you *really* don't want to be handling it all every time you come across it... Cheers, Nick
Bug report for Apache httpd-1.3 [2004/01/11]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 7741|New|Nor|2002-04-04|some directives may be placed outside of proper co| | 7982|New|Maj|2002-04-11|mod_rewrite URL string empty when passed unicoded | | 8311|Opn|Nor|2002-04-19|error in PUT directive gives confusing error messa| | 8329|New|Nor|2002-04-20|mime_magic gives 500 and no error_log on Microsoft| | 8372|Ass|Nor|2002-04-22|Threadsaftey issue in Rewrite's cache [Win32/OS2/N| | 8849|New|Nor|2002-05-07|make install errors as root on NFS shares | | 8882|New|Enh|2002-05-07|[PATCH] mod_rewrite communicates with external rew| | 9037|New|Min|2002-05-13|Slow performance when acessing an unresolved IP ad| | 9126|New|Blk|2002-05-15|68k-next-openstep v. 4.0 | | 9201|New|Maj|2002-05-17|Wrong REQUEST_URI with malformed HTTP queries | | 9726|New|Min|2002-06-09|Double quotes should be flagged as T_HTTP_TOKEN_ST| | 9894|New|Maj|2002-06-16|getline sub in support progs collides with existin| | |New|Nor|2002-06-19|Incorrect default manualdir value with layout.| |10038|New|Min|2002-06-20|ab benchmaker hangs on 10K https URLs with keepali| |10073|New|Maj|2002-06-20|upgrade from 1.3.24 to 1.3.26 breaks include direc| |10169|New|Nor|2002-06-24|Apache seg faults due to attempt to access out of | |10178|New|Maj|2002-06-24|Proxy server cuts off begining of buffer when spec| |10182|New|Nor|2002-06-24|Apache 1.3.26 and MOD_SO on OpenBSD 3.0 | |10195|New|Nor|2002-06-24|Configure script erroneously detects system Expat | |10199|New|Nor|2002-06-24|Configure can't handle directory names with unders| |10243|New|Maj|2002-06-26|CGI scripts not getting POST data | |10354|New|Nor|2002-06-30|ErrorDocument(.htaccess) fails when passed URL wit| |10470|New|Cri|2002-07-04|proxy module will not correctly serve mixed case f| |10666|New|Enh|2002-07-10|line-end comment error message missing file name | |10744|New|Nor|2002-07-12|suexec might fail to open log file| |10747|New|Maj|2002-07-12|ftp SIZE command and 'smart' ftp servers results i| |10760|New|Maj|2002-07-12|empty ftp directory listings from cached ftp direc| |10890|New|Cri|2002-07-17|if et locale is used, configure fails | |10939|New|Maj|2002-07-18|directory listing errors | |11020|New|Maj|2002-07-21|APXS only recognise tests made by ./configure | |11236|New|Min|2002-07-27|Possible Log exhaustion bug? | |11265|New|Blk|2002-07-29|mod_rewrite fails to encode special characters| |11765|New|Nor|2002-08-16|.apaci.install.tmp installs in existing httpd.conf| |11986|New|Nor|2002-08-23|Restart hangs when piping logs on rotation log pro| |11993|Opn|Cri|2002-08-23|PDFs served through ProxyPass show up blank | |12074|New|Nor|2002-08-27|Compilation fails due to a _Isinf not found | |12096|New|Nor|2002-08-27|apxs does not handle binary dists installed at non| |12391|New|Maj|2002-09-07|DBM_LIB should be blank for OS X 10.2 | |12551|New|Nor|2002-09-11|mod_proxy fails to shutdown when client cancels | |12574|New|Nor|2002-09-12|Broken images comes from mod_proxy when caching ww| |12583|New|Nor|2002-09-12|First piped log process do not handle SIGTERM | |12598|New|Maj|2002-09-12|Apache hanging in Keepalive State | |13120|New|Cri|2002-09-29|CGI procs defunctioning | |13188|New|Nor|2002-10-02|does not configure correctly for hppa64-hp-hpux11.| |13274|Ass|Nor|2002-10-04|Subsequent requests are destroyed by the request e| |13486|New|Nor|2002-10-10|multiple slashes in DocumentRoot are not handled p| |13577|New|Nor|2002-10-13|mod_proxy mangles query string| |13607|Opn|Enh|2002-10-14|Catch-all enhancement for vhost_alias?| |13687|New|Min|2002-10-16|Leave Debug symbol on Darwin | |13822|New|Maj|2002-10-21|Problem while running Perl modules accessing CGI::| |14031|New|Nor|2002-10-29|POST handling for multi part forms incorrect |
