[STATUS] (httpd-2.1) Wed Aug 18 23:45:15 EDT 2004
APACHE 2.1 STATUS: -*-text-*- Last modified at [$Date: 2004/04/27 22:09:17 $] Release [NOTE that only Alpha/Beta releases occur in 2.1 development]: 2.1.0 : in development Please consult the following STATUS files for information on related projects: * srclib/apr/STATUS * srclib/apr-util/STATUS * docs/STATUS Contributors looking for a mission: * Just do an egrep on "TODO" or "XXX" in the source. * Review the "PatchAvailable" bugs in the bug database. Append a comment saying "Reviewed and tested". * Open bugs in the bug database. CURRENT RELEASE NOTES: * When the CVS->SVN is done, there's a bogus avendor branch that should be removed from most files. The branch was created 4/27/2004. It's safest (and easiest) for now just to leave it in there; the MAIN branch and the APACHE_2_0_BRANCH are untouched and unharmed. --jwoolley RELEASE SHOWSTOPPERS: * Handling of non-trailing / config by non-default handler is broken http://marc.theaimsgroup.com/?l=apache-httpd-dev&m=105451701628081&w=2 * the edge connection filter cannot be removed http://marc.theaimsgroup.com/?l=apache-httpd-dev&m=105366252619530&w=2 CURRENT VOTES: * Promote mod_cache from experimental to non-experimental status (keep issues noted below in EXPERIMENTAL MODULES as items to be addressed as a supported module). +1: jim, bnicholes -0: jerenkrantz -1: stoddard There are a couple of problems that need to be resolved before this module is moved out of experimental. 1) We need to at least review and comment on the RFC violations 2) Resolve issue of how to cache page fragements (or perhaps -if- we want to cache page fragements). Today, mod_cache/mod_mem_cache will cache #include 'virtual' requests (but not #include 'file' requests). This was accomplished by making CACHE_IN a CONTENT_SET-1 filter to force it to run before the SUBREQ_CORE filter. But now responses cannot be cached that include the effects of having been run through CONTENT_SET filters (mod_deflate, mod_expires, etc). We could rerun all the CONTENT_SET filters on the cached response, but this will not work in all cases. For example, mod_expires relies on installing the EXPIRATION filter during fixups. Contents served out of mod_cache (out of the quick_handler) bypass -all- the request line server hooks (Ryan really hated this. It is great for performance, but bad because of the complications listed above). jerenkrantz: There are a slew of RFC compliance bugs filed in Bugzilla for mod_cache (see 'RFC 2616 violations' below). I think fixing them is a pre-requisite before it isn't experimental. * httpd-std.conf and friends a) httpd-std.conf should be tailored by install (from src or binbuild) even if user has existing httpd.conf +1: trawick, slive, gregames, ianh, Ken, wrowe, jwoolley, jim, nd, erikabele wrowe - prefer httpd.default.conf to avoid ambiguity with cvs b) tailored httpd-std.conf should be copied by install to sysconfdir/examples -0: striker c) tailored httpd-std.conf should be installed to sysconfdir/examples or manualdir/exampleconf/ +1: slive, trawick, Ken, nd (prefer the latter), erikabele d) Installing a set of default config files when upgrading a server doesn't make ANY sense at all. +1: ianh - medium/big sites don't use 'standard config' anyway, as it usually needs major customizations -1: Ken, wrowe, jwoolley, jim, nd, erikabele wrowe - diff is wonderful when comparing old/new default configs, even for customized sites that ianh mentions jim - ... assuming that the default configs have been updated with the required inline docs to explain the changes * If the parent process dies, should the remaining child processes "gracefully" self-terminate. Or maybe we should make it a runtime option, or have a concept of 2 parent processes (one being a "hot spare"). See: Message-ID: <[EMAIL PROTECTED]> Self-destruct: Ken, Martin, Lars Not self-destruct: BrianP, Ian, Cliff, BillS Make it runtime configurable: Aaron, jim, Justin, wrowe, rederpj, nd /* The below was a concept on *how* to handle the problem */ Have 2 parents: +1: jim -1: Justin, wrowe, rederpj, nd +0: Lars, Martin (while standing by, could it do something useful?) * Make the worker MPM the default MPM for threaded Unix boxes. +1: Justin, Ian, Cliff, BillS, striker, wrowe, nd +0:
[STATUS] (httpd-2.0) Wed Aug 18 23:45:11 EDT 2004
APACHE 2.0 STATUS: -*-text-*- Last modified at [$Date: 2004/08/18 14:46:02 $] Release: 2.0.51 : in development 2.0.50 : released June 30, 2004 as GA. 2.0.49 : released March 19, 2004 as GA. 2.0.48 : released October 29, 2003 as GA. 2.0.47 : released July 09, 2003 as GA. 2.0.46 : released May 28, 2003 as GA. 2.0.45 : released April 1, 2003 as GA. 2.0.44 : released January 20, 2003 as GA. 2.0.43 : released October 3, 2002 as GA. 2.0.42 : released September 24, 2002 as GA. 2.0.41 : rolled September 16, 2002. not released. 2.0.40 : released August 9, 2002 as GA. 2.0.39 : released June 17, 2002 as GA. 2.0.38 : rolled June 16, 2002. not released. 2.0.37 : rolled June 11, 2002. not released. 2.0.36 : released May 6, 2002 as GA. 2.0.35 : released April 5, 2002 as GA. 2.0.34 : tagged March 26, 2002. 2.0.33 : tagged March 6, 2002. not released. 2.0.32 : released Feburary 16, 2002 as beta. 2.0.31 : rolled Feburary 1, 2002. not released. 2.0.30 : tagged January 8, 2002. not rolled. 2.0.29 : tagged November 27, 2001. not rolled. 2.0.28 : released November 13, 2001 as beta. 2.0.27 : rolled November 6, 2001 2.0.26 : tagged October 16, 2001. not rolled. 2.0.25 : rolled August 29, 2001 2.0.24 : rolled August 18, 2001 2.0.23 : rolled August 9, 2001 2.0.22 : rolled July 29, 2001 2.0.21 : rolled July 20, 2001 2.0.20 : rolled July 8, 2001 2.0.19 : rolled June 27, 2001 2.0.18 : rolled May 18, 2001 2.0.17 : rolled April 17, 2001 2.0.16 : rolled April 4, 2001 2.0.15 : rolled March 21, 2001 2.0.14 : rolled March 7, 2001 2.0a9 : released December 12, 2000 2.0a8 : released November 20, 2000 2.0a7 : released October 8, 2000 2.0a6 : released August 18, 2000 2.0a5 : released August 4, 2000 2.0a4 : released June 7, 2000 2.0a3 : released April 28, 2000 2.0a2 : released March 31, 2000 2.0a1 : released March 10, 2000 Please consult the following STATUS files for information on related projects: * srclib/apr/STATUS * srclib/apr-util/STATUS * docs/STATUS Contributors looking for a mission: * Just do an egrep on "TODO" or "XXX" in the source. * Review the "PatchAvailable" bugs in the bug database. Append a comment saying "Reviewed and tested". * Open bugs in the bug database. RELEASE SHOWSTOPPERS: PATCHES TO BACKPORT FROM 2.1 [ please place file names and revisions from HEAD here, so it is easy to identify exactly what the proposed changes are! ] *) Fix mod_userdir vs mod_suexec identity hook ordering. http://cvs.apache.org/viewcvs.cgi/httpd-2.0/modules/mappers/mod_userdir.c?r1=1.58&r2=1.59 PR: 18156 +1: jorton, slive *) [SECURITY] mod_ssl: Fix potential input filter segfaults in SPECULATIVE mode. http://cvs.apache.org/viewcvs.cgi/httpd-2.0/modules/ssl/ssl_engine_io.c?r1=1.125&r2=1.126 PR: 30134 +1: jorton *) [SECURITY] mod_ssl: Fix potential infinite loop. http://cvs.apache.org/viewcvs.cgi/httpd-2.0/modules/ssl/ssl_engine_io.c?r1=1.124&r2=1.125 PR: 29964 +1: jorton, nd, jerenkrantz *) mod_ssl: Use anon shm in shmcb by default. http://cvs.apache.org/viewcvs.cgi/httpd-2.0/modules/ssl/ssl_scache_shmcb.c?r1=1.23&r2=1.24 PR: 21335 +1: jorton, minfrin, nd *) apachectl: Fix a problem finding envvars if sbindir != bindir. PR 30723. [Friedrich Haubensak ] http://cvs.apache.org/viewcvs.cgi/httpd-2.0/support/apachectl.in?r1=1.22&r2=1.23 +1: trawick, jorton *) suexec: Pass the SERVER_SIGNATURE envvar through to CGIs. http://cvs.apache.org/viewcvs.cgi/httpd-2.0/support/suexec.c?r1=1.32&r2=1.33 +1: trawick, jorton, slive *) Proposal: Several folks want to aggressively backport changes from mod_cache, mod_mem_cache and mod_file_cache from Apache 2.1 back into the 2.0 tree. Proposal is this: Lets drop the '3 vote' backport rule for mod_cache, mod_mem_cache and mod_file cache (for xx days?). This is a very tightly scoped easing of a rule that has served us well and we can even put an expiration date on it if we like. I intentionally did not include all exerimental modules out of respect for folks working on ldap. stoddard: +1 jwoolley: +0.5 (if we're going to backport, I don't mind us doing so aggressively since these are experimental. but i'm also of the opinion that these should not be backported at all, but rather be the 'key feature' motivating a 2.2 release.) jerenkrantz: +0.5. What Cliff said. Plus, the changes aren't just scoped to mod_cache - there's a number of ot
[STATUS] (apache-1.3) Wed Aug 18 23:45:06 EDT 2004
APACHE 1.3 STATUS: -*-text-*- Last modified at [$Date: 2004/05/20 15:16:42 $] Release: 1.3.32-dev: In development 1.3.31: Tagged May 7, 2004. Announced May 11, 2004. 1.3.30: Tagged April 9, 2004. Not released. 1.3.29: Tagged October 24, 2003. Announced Oct 29, 2003. 1.3.28: Tagged July 16, 2003. Announced ?? 1.3.27: Tagged September 30, 2002. Announced Oct 3, 2002. 1.3.26: Tagged June 18, 2002. 1.3.25: Tagged June 17, 2002. Not released. 1.3.24: Tagged Mar 21, 2002. Announced Mar 22, 2002. 1.3.23: Tagged Jan 21, 2002. 1.3.22: Tagged Oct 8, 2001. Announced Oct 12, 2001. 1.3.21: Not released. (Pulled for htdocs/manual config mismatch. t/r Oct 5, 2001) 1.3.20: Tagged and rolled May 15, 2001. Announced May 21, 2001. 1.3.19: Tagged and rolled Feb 26, 2001. Announced Mar 01, 2001. 1.3.18: Tagged and rolled Not released. (Pulled because of an incorrect unescaping fix. t/r Feb 19, 2001) 1.3.17: Tagged and rolled Jan 26, 2001. Announced Jan 29, 2001. 1.3.16: Not released. (Pulled because of vhosting bug. t/r Jan 20, 2001) 1.3.15: Not released. (Pulled due to CVS dumping core during the tagging when it reached src/os/win32/) 1.3.14: Tagged and Rolled Oct 10, 2000. Released/announced on the 13th. 1.3.13: Not released. (Pulled in the "first minutes" due to a Netware build bug) 1.3.12: Tagged and rolled Feb. 23, 2000. Released/announced on the 25th. 1.3.11: Tagged and rolled Jan. 19, 2000. Released/announced on the 21st. 1.3.10: Not released. (Pulled at "last minute" due to a build bug in the MPE port) 1.3.9: Tagged and rolled on Aug. 16, 1999. Released and announced on 19th. 1.3.8: Not released. 1.3.7: Not released. 1.3.6: Tagged and rolled on Mar. 22, 1999. Released and announced on 24th. 1.3.5: Not released. 1.3.4: Tagged and rolled on Jan. 9, 1999. Released on 11th, announced on 12th. 1.3.3: Tagged and rolled on Oct. 7, 1998. Released on 9th, announced on 10th. 1.3.2: Tagged and rolled on Sep. 21, 1998. Announced and released on 23rd. 1.3.1: Tagged and rolled on July 19, 1998. Announced and released. 1.3.0: Tagged and rolled on June 1, 1998. Announced and released on the 6th. 2.0 : Available for general use, see httpd-2.0 repository RELEASE SHOWSTOPPERS: RELEASE NON-SHOWSTOPPERS BUT WOULD BE REAL NICE TO WRAP THESE UP: * PR: 27023 Cookie could not delivered if the cookie made before proxy module. * isn't ap_die() broken with recognizing recursive errors Message-Id: <[EMAIL PROTECTED]> +1: jeff, jim * Current vote on 3 PRs for inclusion: Bugz #17877 (passing chunked encoding thru proxy) (still checking if RFC compliant... vote is on the correctness of the patch code only). +1: jim, chuck, minfrin Bugz #9181 (Unable to set headers on non-2XX responses) +1: Martin, Jim Gnats #10246 (Add ProxyConnAllow directive) +0: Martin (or rather -.5, see dev@ Message <[EMAIL PROTECTED]>) * htpasswd.c and htdigest.c use tmpnam()... consider using mkstemp() when available. Message-ID: <[EMAIL PROTECTED]> Status: * Dean's "unescaping hell" (unescaping the various URI components at the right time and place, esp. unescaping the host name). Message-ID: <[EMAIL PROTECTED]> Status: * Martin observed a core dump because a ipaddr_chain struct contains a NULL-"server" pointer when being dereferenced by invoking "httpd -S". Message-ID: <[EMAIL PROTECTED]> Status: Workaround enabled. Clean solution can come after 1.3.19 * long pathnames with many components and no AllowOverride None Workaround is to define with AllowOverride None, which is something all sites should do in any case. Status: Marc was looking at it. (Will asks 'wasn't this patched?') * Ronald Tschalär's patch to mod_proxy to allow other modules to set headers too (needed by mod_auth_digest) Message-ID: <[EMAIL PROTECTED]> Status: Available Patches (Most likely, will be ported to 2.0 as appropriate): * A rewrite of ap_unparse_uri_components() by Jeffrey W. Baker <[EMAIL PROTECTED]> to more fully close some segfault potential. Message-ID: <[EMAIL PROTECTED]> Status: Jim +1 (for 1.3.19), Martin +0 * Andrew Ford's patch (1999/12/05) to add absolute times to mod_expires Message-ID: <[EMAIL PROTECTED]> Status: Martin +1, Jim +1, Ken +1 (on concept) * Raymond S Brand's path to mod_autoindex to fix the header/readme include processing so the envariables are correct for the included documents. (Actually, there are two variants in the patch message, for two different ways of doing it.) Mes
Re: mod_deflate and no-gzip
* Nick Kew <[EMAIL PROTECTED]> wrote:
> On Wed, 18 Aug 2004, Brian Akins wrote:
>
> > Shouldn't we still set "Vary: Accept-Encoding" if no-gzip is set?
>
> Hmmm, makes sense. +1
Nope. mod_deflate doesn't know whether it depends on the request (more than
the URL).
SetEnv no-gzip
Possible solutions would be either a special value (like "vary") or another
variable ("no-gzip-but-vary" or the like) or just to use mod_headers.
nd
--
$_=q?tvc!uif)%*|#Bopuifs!A`#~tvc!Xibu)%*|qsjou#Kvtu!A`#~tvc!KBQI!)*|~
tvc!ifmm)%*|#Qfsm!A`#~tvc!jt)%*|(Ibdlfs(~ # What the hell is JAPH? ;
@_=split/\s\s+#/;$_=(join''=>map{chr(ord( # André Malo ;
$_)-1)}split//=>$_[0]).$_[1];s s.*s$_see; # http://www.perlig.de/ ;
Re: Windows 2003 IA64 builds?
I posted a companion patch to the apr list last night.
This patch against HEAD along with the apr patch get
the three core dlls cross compiling with Visual Studio 6
+ IA64 SDK. It addresses most /W2 warnings and fixes a
couple of bugs. I haven't looked at many of the modules
yet.
As I mentioned in the other note there are a lot more
warnings that are thrown with /W3 that need to be
investigated furher.
In addition to fixing compiler warnings there is the
question of the build process. I'm currently running
"setenv /SRV64 /RETAIL" from the SDK to set the IA64
environment, then running msdev with the /USEENV option.
This requires a separate set of .dsp files that have
been munged to specify /machine:IA64 among other things.
Keeping the .dsp's separate rather than folding into
the existing ones if for convenience and maintainability
at least in the short term, maybe the long term too.
One problem that comes up is that there are 3 executables
built that are used to generate tables at compile time, but
since everything is cross compiled IA64 that doesn't work.
I'll have to hack around that somehow, maybe store the prebuilt
files in CVS and copy to the appropriate locations.
I'm open to suggestions if anyone has a better idea.
If this sounds reasonable I'll proceed along this path.
Allan
--
Index: os/win32/ap_regkey.c
===
RCS file: /home/cvs/httpd-2.0/os/win32/ap_regkey.c,v
retrieving revision 1.11
diff -U3 -r1.11 ap_regkey.c
--- os/win32/ap_regkey.c9 Feb 2004 20:40:49 - 1.11
+++ os/win32/ap_regkey.c17 Aug 2004 21:02:48 -
@@ -236,7 +236,7 @@
*/
valuelen = (size - 1) * 3 + 1;
*result = apr_palloc(pool, valuelen);
-rv = apr_conv_ucs2_to_utf8(wvalue, &size, *result, &valuelen);
+rv = apr_conv_ucs2_to_utf8(wvalue, (apr_size_t *)&size, *result, &valuelen);
if (rv != APR_SUCCESS)
return rv;
else if (size)
@@ -309,7 +309,7 @@
wvallen = alloclen = size;
wvalue = apr_palloc(pool, alloclen * 2);
-rv = apr_conv_utf8_to_ucs2(value, &size, wvalue, &wvallen);
+rv = apr_conv_utf8_to_ucs2(value, (apr_size_t *)&size, wvalue, &wvallen);
if (rv != APR_SUCCESS)
return rv;
else if (size)
@@ -363,7 +363,7 @@
return APR_ENAMETOOLONG;
/* Read to NULL buffer to determine value size */
rc = RegQueryValueExW(key->hkey, wvalname, 0, resulttype,
- NULL, resultsize);
+ NULL, (LPDWORD)resultsize);
if (rc != ERROR_SUCCESS) {
return APR_FROM_OS_ERROR(rc);
}
@@ -371,7 +371,7 @@
/* Read value based on size query above */
*result = apr_palloc(pool, *resultsize);
rc = RegQueryValueExW(key->hkey, wvalname, 0, resulttype,
- (LPBYTE)*result, resultsize);
+ (LPBYTE)*result, (LPDWORD)resultsize);
}
#endif /* APR_HAS_UNICODE_FS */
#if APR_HAS_ANSI_FS
@@ -379,14 +379,14 @@
{
/* Read to NULL buffer to determine value size */
rc = RegQueryValueEx(key->hkey, valuename, 0, resulttype,
- NULL, resultsize);
+ NULL, (LPDWORD)resultsize);
if (rc != ERROR_SUCCESS)
return APR_FROM_OS_ERROR(rc);
/* Read value based on size query above */
*result = apr_palloc(pool, *resultsize);
rc = RegQueryValueEx(key->hkey, valuename, 0, resulttype,
- (LPBYTE)*result, resultsize);
+ (LPBYTE)*result, (LPDWORD)resultsize);
if (rc != ERROR_SUCCESS)
return APR_FROM_OS_ERROR(rc);
}
@@ -452,7 +452,7 @@
char *buf;
char *tmp;
DWORD type;
-DWORD size = 0;
+apr_size_t size = 0;
rv = ap_regkey_value_raw_get(&value, &size, &type, key, valuename, pool);
if (rv != APR_SUCCESS) {
Index: server/mpm/winnt/child.c
===
RCS file: /home/cvs/httpd-2.0/server/mpm/winnt/child.c,v
retrieving revision 1.37
diff -U3 -r1.37 child.c
--- server/mpm/winnt/child.c14 Aug 2004 10:57:13 - 1.37
+++ server/mpm/winnt/child.c17 Aug 2004 21:02:48 -
@@ -684,7 +684,7 @@
{
int rc;
DWORD BytesRead;
-DWORD CompKey;
+apr_size_t CompKey;
LPOVERLAPPED pol;
mpm_recycle_completion_context(context);
Index: server/mpm/winnt/mpm_winnt.c
===
RCS file: /home/cvs/httpd-2.0/server/mpm/winnt/mpm_winnt.c,v
retrieving revision 1.311
diff -U3 -r1.311 mpm_winnt.c
--- server/mpm/winnt/mpm_winnt.c24 Apr 2004 11:23:14 - 1.311
+++ server/mpm/winnt/mpm_winnt.c17 Aug 2004 21:02:49 -
@@ -416,7 +416,7 @@
HANDLE hDup
vacation
Hi, I'll be on vacation til 7th september. I will (try to) go on the new proxy implementation but I will only read my apache.org mail, so if you find something wrong in the new code (and want a "quick" fix) mail me there. Cheers Jean-Frederic
AJP lib files added to httpd-2.0 repos
Hi, I have added to the httpd-2.0/modules/proxy the following files: ajp.h ajp_header.c ajp_header.h ajp_link.c ajp_msg.c They are also in jakarta-tomcat-connectors/ajp/ajplib/test. They have to be kept up to date (synchronized) please remember to mail the diff to the other repos dev-list when something is changed. Cheers Jean-Frederic
Re: Where is the AJP code...
William A. Rowe, Jr. wrote: At 01:56 AM 8/17/2004, jean-frederic clere wrote: William A. Rowe, Jr. wrote: At 03:58 PM 8/16/2004, Brad Nicholes wrote: The addition of the proxy_ajp module to the httpd project presents a build problem. The AJP module code exists in httpd/modules/proxy in the httpd project but the AJP lib code still sits in the jakarta-tomcat-connectors\ajp\ajplib\test in the jakarta project. Is the AJPLIB code going to be migrated to the httpd project? Why is the AJPLIB code in a test directory? I'm +1 for placing it in modules/proxy/ ... iff it will be maintained and kept up to date. +1 Then let's go ahead, would you please commit the current flavor of the ajp sources to modules/proxy/ (not modules/proxy/ajp/) with a commit message to their official source location within jakarta-tomcat-connectors/ (the real location, not the temporary ajp/test/ajplib). The real location has not been decided in jakarta-tomcat-connectors... For the moment the ajplib files are in jakarta-tomcat-connectors/ajp/test/ajplib. Just in case another maintainer wants to look aside at their development. Then just a few tweaks so we don't delve the ./ajp/ directory. Bill
Re: mod_deflate and no-gzip
On Wed, 18 Aug 2004, Brian Akins wrote: Shouldn't we still set "Vary: Accept-Encoding" if no-gzip is set? Example, if I use SetEnvIf to disallow gzip for some browsers, shouldn't we still tell proxies to vary on "Accept-Encoding"? mod_deflate will send the Vary if the client does not have a proper Accept-Encoding header, but not if we set no-gzip. THis seems broken. If mod_deflate is called, if should send a Vary. What about SetEnvIf Request_URI file[0-9]+\.html no-gzip This doesn't require a Vary-header. And in fact, the example you site requires a "Vary: User-Agent", not "Vary: Accept-Encoding". This is a rather difficult problem, and I don't have a good solution to propose. Currently, it is the responsibility of the admin to deal with Vary if they use no-gzip. For an example, see http://httpd.apache.org/docs-2.0/mod/mod_deflate.html#recommended and for a discussion: http://httpd.apache.org/docs-2.0/mod/mod_deflate.html#proxies Joshua.
Re: cvs commit: httpd-2.0/modules/aaa NWGNUauthnzldap mod_authnz_ldap.c NWGNUmakefile
If you have time to move it before I do, by all mean, go for it. I probably won't get around to it until this afternoon anyway. Thanks for taking care of the build scripts. I'm pretty sure that I can handle the util_ldap netware build files once it is moved :) Experimental/Mod_auth_ldap should probably be thrown into the attic so we can at least preserve the history. Brad Brad Nicholes Senior Software Engineer Novell, Inc., the leading provider of Net business solutions http://www.novell.com >>> [EMAIL PROTECTED] Wednesday, August 18, 2004 7:24:13 AM >>> Brad Nicholes wrote: >BTW, since I am not a Linux makefile guru, the new authnz_ldap module > has not been added to the Linux build scripts. Can somebody make the > appropriate changes to the makefiles? Done. Are you going to move util_ldap to the ldap directory, or should I do it? I am not a netware guru, so you would have to do the build scripts :) Can we cvs rm mod_auth_ldap from it's old location? Regards, Graham --
Re: cvs commit: httpd-2.0/modules/aaa NWGNUauthnzldap mod_authnz_ldap.c NWGNUmakefile
Brad Nicholes wrote: BTW, since I am not a Linux makefile guru, the new authnz_ldap module has not been added to the Linux build scripts. Can somebody make the appropriate changes to the makefiles? Done. Are you going to move util_ldap to the ldap directory, or should I do it? I am not a netware guru, so you would have to do the build scripts :) Can we cvs rm mod_auth_ldap from it's old location? Regards, Graham -- smime.p7s Description: S/MIME Cryptographic Signature
Re: proxy compile warnings
> Adding it to mod_proxy.h is right the thing.
> The idea is to have a ap_proxy_pre_request and ap_proxy_post_request:
> one called before "processing" the request and one after.
ok, cool. attached is a new patch that addresses this.
sorry for the excess dialogue - this would have been obvious if I had
followed the code a bit :)
--Geoff
Index: modules/proxy/mod_proxy.h
===
RCS file: /home/cvs/httpd-2.0/modules/proxy/mod_proxy.h,v
retrieving revision 1.120
diff -u -r1.120 mod_proxy.h
--- modules/proxy/mod_proxy.h 11 Aug 2004 23:30:17 - 1.120
+++ modules/proxy/mod_proxy.h 18 Aug 2004 13:11:26 -
@@ -388,6 +388,7 @@
PROXY_DECLARE(const char *) ap_proxy_add_balancer(proxy_balancer **balancer, apr_pool_t *p, proxy_server_conf *conf, const char *url);
PROXY_DECLARE(void) ap_proxy_add_worker_to_balancer(apr_pool_t *pool, proxy_balancer *balancer, proxy_worker *worker);
PROXY_DECLARE(int) ap_proxy_pre_request(proxy_worker **worker, proxy_balancer **balancer, request_rec *r, proxy_server_conf *conf, char **url);
+PROXY_DECLARE(int) ap_proxy_post_request(proxy_worker *worker, proxy_balancer *balancer, request_rec *r, proxy_server_conf *conf);
PROXY_DECLARE(int) ap_proxy_determine_connection(apr_pool_t *p, request_rec *r, proxy_server_conf *conf, proxy_worker *worker, proxy_conn_rec *conn,
apr_pool_t *ppool, apr_uri_t *uri, char **url, const char *proxyname, apr_port_t proxyport,
char *server_portstr, int server_portstr_size);
Index: modules/proxy/proxy_ftp.c
===
RCS file: /home/cvs/httpd-2.0/modules/proxy/proxy_ftp.c,v
retrieving revision 1.145
diff -u -r1.145 proxy_ftp.c
--- modules/proxy/proxy_ftp.c 11 Aug 2004 23:28:58 - 1.145
+++ modules/proxy/proxy_ftp.c 18 Aug 2004 13:11:30 -
@@ -745,7 +745,8 @@
return OK;
}
-static ftp_proxyerror(request_rec *r, proxy_conn_rec *conn, int statuscode, const char *message)
+static
+int ftp_proxyerror(request_rec *r, proxy_conn_rec *conn, int statuscode, const char *message)
{
proxy_ftp_cleanup(r, conn);
return ap_proxyerror(r, statuscode, message);
@@ -782,7 +783,6 @@
int len, rc;
int one = 1;
char *size = NULL;
-apr_socket_t *origin_sock = NULL;
char xfer_type = 'A'; /* after ftp login, the default is ASCII */
int dirlisting = 0;
#if defined(USE_MDTM) && (defined(HAVE_TIMEGM) || defined(HAVE_GMTOFF))
Index: modules/proxy/proxy_util.c
===
RCS file: /home/cvs/httpd-2.0/modules/proxy/proxy_util.c,v
retrieving revision 1.135
diff -u -r1.135 proxy_util.c
--- modules/proxy/proxy_util.c 13 Aug 2004 12:20:53 - 1.135
+++ modules/proxy/proxy_util.c 18 Aug 2004 13:11:34 -
@@ -19,6 +19,10 @@
#include "scoreboard.h"
#include "apr_version.h"
+#if APR_HAVE_UNISTD_H
+#include /* for getpid() */
+#endif
+
#if (APR_MAJOR_VERSION < 1)
#undef apr_socket_create
#define apr_socket_create apr_socket_create_ex
Re: mod_deflate and no-gzip
On Wed, 18 Aug 2004, Brian Akins wrote: > Shouldn't we still set "Vary: Accept-Encoding" if no-gzip is set? Hmmm, makes sense. +1 Should we be looking at a wholesale backport from 2.1-head? There are a number of minor bugfixes, as well as the inflate output filter. -- Nick Kew
mod_deflate and no-gzip
Shouldn't we still set "Vary: Accept-Encoding" if no-gzip is set? Example, if I use SetEnvIf to disallow gzip for some browsers, shouldn't we still tell proxies to vary on "Accept-Encoding"? mod_deflate will send the Vary if the client does not have a proper Accept-Encoding header, but not if we set no-gzip. THis seems broken. If mod_deflate is called, if should send a Vary. -- Brian Akins Senior Systems Engineer CNN Internet Technologies
Re: missing variable in suexec safe list
On Wed, 18 Aug 2004 09:56:53 +0300, Zvi Har'El <[EMAIL PROTECTED]> wrote: > Hi, > > I just noticed that the safe_env_list in suexec.c has one variable name > missing: SERVER_SIGNATURE. Here is a tivial patch to add it: thanks! patch committed to 2.1-dev and proposed for merging into 2.0.next
