Re: svn commit: r332958 - /httpd/httpd/branches/2.2.x/docs/manual/style/build.properties

2005-11-13 Thread Justin Erenkrantz
On Sun, Nov 13, 2005 at 10:37:47AM -, [EMAIL PROTECTED] wrote:
>  # (pending) httpd version
> -httpd.version=2.1.9
> +httpd.version=2.2.0

So, what exactly does this do?

It'd be really nice to have just one place to change the version number.
But, even after chasing this property for a while, I couldn't see how
this would be it.  $httpd_version or  or something in
each .xml file that gets substituted for some string value at build-time
would be beautiful.

Thanks for the prop fixes.  I didn't get any error about the empty tags
being invalid - I wonder why you did.  -- justin


Re: svn commit: r332958 - /httpd/httpd/branches/2.2.x/docs/manual/style/build.properties

2005-11-13 Thread André Malo
* Justin Erenkrantz wrote:

> On Sun, Nov 13, 2005 at 10:37:47AM -, [EMAIL PROTECTED] wrote:
> >  # (pending) httpd version
> > -httpd.version=2.1.9
> > +httpd.version=2.2.0
>
> So, what exactly does this do?

This is more or less informal. It's taken to create the file names for 
offline packages (dist/httpd/docs). It's nice to have it in sync with the 
release, but not a strict requirement.

> It'd be really nice to have just one place to change the version number.
> But, even after chasing this property for a while, I couldn't see how
> this would be it.  $httpd_version or  or something in
> each .xml file that gets substituted for some string value at build-time
> would be beautiful.

Good point. I haven't figured out yet a way to unify the code and docs trees 
in this regard (docco folks typically have only the docs tree checked out).

> Thanks for the prop fixes.  I didn't get any error about the empty tags
> being invalid - I wonder why you did.  -- justin

`build validate-xml` :-) [1]
It might be questionable to reject empty lists, though. We can change the 
DTDs if we want to.

nd

[1] `build -projecthelp` shows all possible targets
-- 
Winnetous Erbe: 


Re: svn commit: r332958 - /httpd/httpd/branches/2.2.x/docs/manual/style/build.properties

2005-11-13 Thread Justin Erenkrantz
On Sun, Nov 13, 2005 at 11:58:09AM +0100, Andr Malo wrote:
> Good point. I haven't figured out yet a way to unify the code and docs trees 
> in this regard (docco folks typically have only the docs tree checked out).

I honestly don't care if it is unified.  A single value to change in the
docs tree would be sufficient.  If we can unify that lone value at a
later date with the code tree, cool, but not as important as getting a
single value in the docs directory, IMHO.

> > Thanks for the prop fixes.  I didn't get any error about the empty tags
> > being invalid - I wonder why you did.  -- justin
> 
> `build validate-xml` :-) [1]
> It might be questionable to reject empty lists, though. We can change the 
> DTDs if we want to.

*nod*

> [1] `build -projecthelp` shows all possible targets

FWIW, I tried 'build help' and it didn't do anything.  So, I gave up
trying to get help.  =(  -- justin


Re: ap_get_server_port differences

2005-11-13 Thread Ruediger Pluem


On 11/12/2005 06:46 PM, Sander Temme wrote:

[..cut..]

> 
> What bit you is probably the change in default value for 
> UseCanonicalName? Used to be On by default, now it's Off. Try  flicking
> that switch.

I saw that it is now set to off in the default configuration files, but the
behaviour of the code confuses me if it is not set at all in the configuration.
In this case use_canonical_name is set to USE_CANONICAL_NAME_UNSET, but:

In ap_get_server_name the behaviour in this case is like OFF and

if (d->use_canonical_name == USE_CANONICAL_NAME_ON) {
return r->server->server_hostname;
}

if (d->use_canonical_name == USE_CANONICAL_NAME_DNS) {
if (conn->local_host == NULL) {
if (apr_getnameinfo(&conn->local_host,
conn->local_addr, 0) != APR_SUCCESS)
conn->local_host = apr_pstrdup(conn->pool,
   r->server->server_hostname);
else {
ap_str_tolower(conn->local_host);
}
}

return conn->local_host;
}

in ap_get_server_port it is like ON:


   if (d->use_canonical_name == USE_CANONICAL_NAME_OFF
|| d->use_canonical_name == USE_CANONICAL_NAME_DNS) {

/* With UseCanonicalName off Apache will form self-referential
 * URLs using the hostname and port supplied by the client if
 * any are supplied (otherwise it will use the canonical name).
 */
port = r->parsed_uri.port_str ? r->parsed_uri.port :
   r->connection->local_addr->port ? 
r->connection->local_addr->port :
   r->server->port ? r->server->port :
   ap_default_port(r);
}
else { /* d->use_canonical_name == USE_CANONICAL_NAME_ON */

Is this correct?


Regards

Rüdiger

[..cut..]


Re: svn commit: r332958 - /httpd/httpd/branches/2.2.x/docs/manual/style/build.properties

2005-11-13 Thread André Malo
* Justin Erenkrantz wrote:

> On Sun, Nov 13, 2005 at 11:58:09AM +0100, Andr Malo wrote:
> > Good point. I haven't figured out yet a way to unify the code and docs
> > trees in this regard (docco folks typically have only the docs tree
> > checked out).
>
> I honestly don't care if it is unified.  A single value to change in the
> docs tree would be sufficient.  If we can unify that lone value at a
> later date with the code tree, cool, but not as important as getting a
> single value in the docs directory, IMHO.

Well. I think, that should be possible. I'm gonna create something.

> > > Thanks for the prop fixes.  I didn't get any error about the empty
> > > tags being invalid - I wonder why you did.  -- justin
> >
> > `build validate-xml` :-) [1]
> > It might be questionable to reject empty lists, though. We can change
> > the DTDs if we want to.
>
> *nod*
>
> > [1] `build -projecthelp` shows all possible targets
>
> FWIW, I tried 'build help' and it didn't do anything.  So, I gave up
> trying to get help.  =(  -- justin

Ok, we need a help target ;)
The problem here is, that -projecthelp is an ant option instead of a real 
target, so I'm going to add a help target which just points to 
-projecthelp.

nd
-- 
>kann mir jemand sagen, was genau @-Domains sind?
Ein Mythos. Ein Werbetrick. Verarsche. Nenn es wie du willst...

 -- Alexandra Buss und Björn Höhrmann in dciwam


APR_FIND_APR and minimum version

2005-11-13 Thread Colm MacCarthaigh

The APR_FIND_APR (and _APU) macro hunts for an installed apr with the
specified major version number, but then later we use APACHE_CHECK_APxVER 
to insist on a minor version too.

Wouldn't it make more sense for the APR_FIND_APR macro to only return
aprs of the minimum version we will use anyway?

The current behaviour can lead to problems; If a user has apr 1.0 or 1.1
installed in any of the places the macro looks, httpd will be
unbuildable, and the only way to fix it is to manually install apr >=
1.2. 

-- 
Colm MacCárthaighPublic Key: [EMAIL PROTECTED]


apr_wait_for_io_or_timeout() decl in apr_support.h which is in public include directory

2005-11-13 Thread Jeff Trawick
On 11/12/05, Brian Pane <[EMAIL PROTECTED]> wrote:
> On Nov 11, 2005, at 6:21 PM, Jeff Trawick wrote:
>
> > On 11/11/05, Brad Nicholes <[EMAIL PROTECTED]> wrote:
> >>
> > On 11/11/2005 at 1:40:32 pm, in message
> >> <[EMAIL PROTECTED]>, Jeff
> >> Trawick
> >> <[EMAIL PROTECTED]> wrote:
> >>> On 11/11/05, Brad Nicholes <[EMAIL PROTECTED]> wrote:
>    Reposting to the APR list with a new subject line.  Does this
>  need
> >> to
>  be taken care of in APR 1.2.x before httpd 2.2 ships?
> >>>
> >>> apr_wait_for_io_or_timeout() is private APR function (not API).  Is
> >>> the caller outside of APR?
> >>
> >> Yes, HTTPD.  trunk/server/core_filters.c
> >
> > Simply shocking ;)  That code needs to be fixed to call a real API :(
>
> I just double-checked the declaration, and apr_wait_for_io_or_timeout()
> currently is implemented as part of the public API.  I don't have any
> strong
> objection to making it private, though (e.g., by wrapping the
> declaration in
> an "#ifdef APR_PRIVATE" or moving apr_support.h to apr/include/arch/
> unix).

apr_support.h has these comments...

/**
 * @defgroup apr_support Internal APR support functions
 * @ingroup APR
 * @{
 */

It must be for pragmatic reasons that apr_support.h is in the apr
include directory instead of include/arch.  Perhaps
include/arch/apr_private_common.h is more appropriate?


Re: ap_get_server_port differences

2005-11-13 Thread Jim Jagielski
Ruediger Pluem wrote:
> 
>if (d->use_canonical_name == USE_CANONICAL_NAME_OFF
> || d->use_canonical_name == USE_CANONICAL_NAME_DNS) {
> 
> /* With UseCanonicalName off Apache will form self-referential
>  * URLs using the hostname and port supplied by the client if
>  * any are supplied (otherwise it will use the canonical name).
>  */
> port = r->parsed_uri.port_str ? r->parsed_uri.port :
>r->connection->local_addr->port ? 
> r->connection->local_addr->port :
>r->server->port ? r->server->port :
>ap_default_port(r);
> }
> else { /* d->use_canonical_name == USE_CANONICAL_NAME_ON */
> 
> Is this correct?
> 

This is something that is documented as a change in 2.0 -> 2.1/2.2
as well as something that was discussed when the change was
made. I suggested, iirc, some other UCN option which emulated
the 2.0 behavior... This is, I believe, still the right way
to go, esp now since it requires an API change for 2.1/2.2/2.3.
In fact, I think I still have the patch around here for that.

-- 
===
 Jim Jagielski   [|]   [EMAIL PROTECTED]   [|]   http://www.jaguNET.com/
   "If you can dodge a wrench, you can dodge a ball."


Re: ap_get_server_port differences

2005-11-13 Thread Jim Jagielski
Sander Temme wrote:
> 
> In the other case, UseCanonicalName On which was default in the 2.0  
> branch, we look first in the server_rec and then in the connection.  
> You could possibly make a case for having the search order in the top  
> of the if clause match the one in the bottom. This against trunk:
> 

There was a specific reason for the change in the 2.1/2.2 branch,
having to do with SSL I believe. In any case, IMO we should allow
for BOTH behaviors via an addition UCN option, like On2.0
or something. This was discussed awhile ago... I think
change the behavior right now for 2.1/2.2 will affect those
who are already using it... instead, we should provide
both elements of functionality.
-- 
===
 Jim Jagielski   [|]   [EMAIL PROTECTED]   [|]   http://www.jaguNET.com/
   "If you can dodge a wrench, you can dodge a ball."


Re: ap_get_server_port differences

2005-11-13 Thread Ruediger Pluem


On 11/13/2005 05:16 PM, Jim Jagielski wrote:

> 
> This is something that is documented as a change in 2.0 -> 2.1/2.2
> as well as something that was discussed when the change was
> made. I suggested, iirc, some other UCN option which emulated
> the 2.0 behavior... This is, I believe, still the right way
> to go, esp now since it requires an API change for 2.1/2.2/2.3.

Ok, but what is still confusing me is the fact that you have *three* possible 
settings
for UCN (On/Off/DNS) but you have *four* different behaviours (The fourth comes 
when you do not
have an UNC setting at all in your config). To my memory every directive in the
conf has a default value, but this default value can also be reached by setting 
it
explicitly. This does not seem to be the case for UNC.

Regards

Rüdiger


Re: Can't compile trunk on Win

2005-11-13 Thread Brian Pane

On Nov 12, 2005, at 2:21 PM, Vadim Chekan wrote:

On 11/12/05, Jeff Trawick <[EMAIL PROTECTED]> wrote:

On 11/12/05, Vadim Chekan <[EMAIL PROTECTED]> wrote:

Hi all,

I've tryed to compile httpd/trunk and got an error:
core_filters.obj : error LNK2019: unresolved external symbol
_apr_wait_for_io_or_timeout referenced in function
_send_brigade_blocking



I have apr from apr/branches/1.2.x and looks like it doesn't contain
apr_wait_for_io_or_timeout for windows, unix only.


wasn't supposed to be used

Try this??

Index: server/core_filters.c
===

[...]

Thanks, now it compiles!


+1 on Unix, too.

Brian



Bug report for Apache httpd-1.3 [2005/11/13]

2005-11-13 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=CriticalMAJ=Major |
| |   |   MIN=Minor   NOR=Normal  ENH=Enhancement   |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
| 8329|New|Nor|2002-04-20|mime_magic gives 500 and no error_log on Microsoft|
| 8372|Ass|Nor|2002-04-22|Threadsaftey issue in Rewrite's cache [Win32/OS2/N|
| 8849|New|Nor|2002-05-07|make install errors as root on NFS shares |
| 8882|New|Enh|2002-05-07|[PATCH] mod_rewrite communicates with external rew|
| 9037|New|Min|2002-05-13|Slow performance when acessing an unresolved IP ad|
| 9126|New|Blk|2002-05-15|68k-next-openstep v. 4.0  |
| 9726|New|Min|2002-06-09|Double quotes should be flagged as T_HTTP_TOKEN_ST|
| 9894|New|Maj|2002-06-16|getline sub in support progs collides with existin|
| |New|Nor|2002-06-19|Incorrect default manualdir value with layout.|
|10038|New|Min|2002-06-20|ab benchmaker hangs on 10K https URLs with keepali|
|10073|New|Maj|2002-06-20|upgrade from 1.3.24 to 1.3.26 breaks include direc|
|10169|New|Nor|2002-06-24|Apache seg faults due to attempt to access out of |
|10178|New|Maj|2002-06-24|Proxy server cuts off begining of buffer when spec|
|10195|New|Nor|2002-06-24|Configure script erroneously detects system Expat |
|10199|New|Nor|2002-06-24|Configure can't handle directory names with unders|
|10243|New|Maj|2002-06-26|CGI scripts not getting POST data |
|10354|New|Nor|2002-06-30|ErrorDocument(.htaccess) fails when passed URL wit|
|10446|Opn|Blk|2002-07-03|spaces in link to http server seen as foreign char|
|10666|New|Enh|2002-07-10|line-end comment error message missing file name  |
|10744|New|Nor|2002-07-12|suexec might fail to open log file|
|10747|New|Maj|2002-07-12|ftp SIZE command and 'smart' ftp servers results i|
|10760|New|Maj|2002-07-12|empty ftp directory listings from cached ftp direc|
|10939|New|Maj|2002-07-18|directory listing errors  |
|11020|New|Maj|2002-07-21|APXS only recognise tests made by ./configure |
|11236|New|Min|2002-07-27|Possible Log exhaustion bug?  |
|11265|New|Blk|2002-07-29|mod_rewrite fails to encode special characters|
|11765|New|Nor|2002-08-16|.apaci.install.tmp installs in existing httpd.conf|
|11986|New|Nor|2002-08-23|Restart hangs when piping logs on rotation log pro|
|12096|New|Nor|2002-08-27|apxs does not handle binary dists installed at non|
|12574|New|Nor|2002-09-12|Broken images comes from mod_proxy when caching ww|
|12583|New|Nor|2002-09-12|First piped log process do not handle SIGTERM |
|12598|Opn|Maj|2002-09-12|Apache hanging in Keepalive State |
|12770|Opn|Nor|2002-09-18|ErrorDocument fail redirecting error 400  |
|13188|New|Nor|2002-10-02|does not configure correctly for hppa64-hp-hpux11.|
|13274|Ass|Nor|2002-10-04|Subsequent requests are destroyed by the request e|
|13607|Opn|Enh|2002-10-14|Catch-all enhancement for vhost_alias?|
|13687|New|Min|2002-10-16|Leave Debug symbol on Darwin  |
|13822|New|Maj|2002-10-21|Problem while running Perl modules accessing CGI::|
|14095|Opn|Nor|2002-10-30|Change default Content-Type (DefaultType) in defau|
|14250|New|Maj|2002-11-05|Alternate UserDirs don't work intermittantly  |
|14443|New|Maj|2002-11-11|Keep-Alive randomly causes TCP RSTs   |
|14448|Opn|Cri|2002-11-11|Apache WebServer not starting if installed on Comp|
|14518|Opn|Nor|2002-11-13|QUERY_STRING parts not incorporated by mod_rewrite|
|14670|New|Cri|2002-11-19|Apache didn't deallocate unused memory|
|14748|New|Nor|2002-11-21|Configure Can't find DBM on Mac OS X  |
|15011|New|Nor|2002-12-03|Apache processes not timing out on Solaris 8  |
|15028|New|Maj|2002-12-03|RedirectMatch does not escape properly|
|16236|New|Maj|2003-01-18|Include directive in Apache is not parsed within c|
|16241|New|Maj|2003-01-19|Apache processes takes 100% CPU until killed manua|
|16492|New|Maj|2003-01-28|mod_proxy doesn't correctly retrieve values from C|
|16493|New|Nor|2003-01-28|Incorrect handling of several Cache-Control direct|
|16556|

Bug report for Apache httpd-2.0 [2005/11/13]

2005-11-13 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=CriticalMAJ=Major |
| |   |   MIN=Minor   NOR=Normal  ENH=Enhancement   |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
| 7483|Ass|Enh|2002-03-26|Add FileAction directive to assign a cgi interpret|
| 7741|Ass|Nor|2002-04-04|some directives may be placed outside of proper co|
| 7862|New|Enh|2002-04-09|suexec never log a group name.|
| 8483|Inf|Min|2002-04-24|apache_2.0 .msi installer breaks .log and .conf fi|
| 8713|New|Min|2002-05-01|No Errorlog on PROPFIND/Depth:Infinity|
| 8925|New|Cri|2002-05-09|Service Install (win32 .msi/.exe) fails for port i|
| 9727|New|Min|2002-06-09|Double quotes should be flagged as T_HTTP_TOKEN_ST|
| 9903|Opn|Maj|2002-06-16|mod_disk_cache does not remove temporary files|
| 9945|New|Enh|2002-06-18|[PATCH] new funtionality for apache bench |
|10114|Ass|Enh|2002-06-21|Negotiation gives no weight to order, only q value|
|10154|Ass|Nor|2002-06-23|ApacheMonitor interferes with service uninstall/re|
|10722|Opn|Nor|2002-07-12|ProxyPassReverse doesn't change cookie paths  |
|10775|Ass|Cri|2002-07-13|SCRIPT_NAME wrong value   |
|10932|Opn|Enh|2002-07-18|Allow Negative regex in LocationMatch |
|11035|New|Min|2002-07-22|Apache adds double entries to headers generated by|
|11294|New|Enh|2002-07-30|desired vhost_alias option|
|11427|Opn|Maj|2002-08-02|Possible Memory Leak in CGI script invocation |
|11540|Opn|Nor|2002-08-07|ProxyTimeout ignored  |
|11580|Opn|Enh|2002-08-09|generate Content-Location headers |
|11971|Opn|Nor|2002-08-23|HTTP proxy header "Via" with wrong hostname if Ser|
|11997|Opn|Maj|2002-08-23|Strange critical errors possibly related to mpm_wi|
|12033|Opn|Nor|2002-08-26|Graceful restart immidiately result in [warn] long|
|12340|Opn|Nor|2002-09-05|WindowsXP proxy, child process exited with status |
|12680|New|Enh|2002-09-16|Digest authentication with integrity protection   |
|12885|New|Enh|2002-09-20|windows 2000 build information: mod_ssl, bison, et|
|13029|New|Nor|2002-09-26|Win32 mod_cgi failure with non-ASCII characters in|
|13101|Inf|Cri|2002-09-27|Using mod_ext_filter with mod_proxy and http/1.1 c|
|13507|New|Enh|2002-10-10|capturing stderr from mod_cgi |
|13599|Ass|Nor|2002-10-14|autoindex formating broken for multibyte sequences|
|13603|New|Nor|2002-10-14|incorrect DOCUMENT_URI in mod_autoindex with Heade|
|13661|Ass|Enh|2002-10-15|Apache cannot not handle dynamic IP reallocation  |
|13946|Inf|Nor|2002-10-24|reverse proxy errors when a document expires from |
|13986|Ass|Enh|2002-10-26|remove default MIME-type  |
|14016|Inf|Nor|2002-10-28|Problem when using mod_ext_filter with ActivePerl |
|14090|New|Maj|2002-10-30|mod_cgid always writes to main server error log   |
|14206|New|Nor|2002-11-04|DirectoryIndex circumvents -FollowSymLinks option |
|14227|Ass|Nor|2002-11-04|Error handling script is not started (error 500) o|
|14496|New|Enh|2002-11-13|Cannot upgrade 2.0.39 -> 2.0.43. Must uninstall fi|
|14556|Inf|Nor|2002-11-14|mod_cache with mod_mem_cache enabled doesnt cash m|
|14858|New|Enh|2002-11-26|mod_cache never caches responses for requests requ|
|14922|Ass|Enh|2002-11-28| is currently hardcoded to 'apache2'  |
|15045|Ass|Nor|2002-12-04|addoutputfilterbytype doesn't work for defaulted t|
|15221|New|Nor|2002-12-10|reference to old script: sign.sh  |
|15233|Opn|Nor|2002-12-10|move AddType application/x-x509-ca-cert from ssl.c|
|15235|New|Nor|2002-12-10|add application/x-x509-email-cert, application/x-x|
|15625|New|Nor|2002-12-23|mention mod_ssl in http://nagoya.apache.org/dist/h|
|15626|New|Nor|2002-12-23|mention which modules are part of the (binary) dis|
|15631|New|Nor|2002-12-23|mention in httpd.conf that mod_ssl is not included|
|15719|Inf|Nor|2002-12-30|WebDAV MOVE to destination URI which is content-ne|
|15757|Opn|Nor|2003-01-02|Assumption of sizeof (void*)/int begin equal (64-b|
|15857|Opn|Nor|2003-01-07|MUST handle "chunked" response with a 16385Byte-lo|
|15859|Opn|Nor|

Re: Can't compile trunk on Win

2005-11-13 Thread Jeff Trawick
On 11/13/05, Brian Pane <[EMAIL PROTECTED]> wrote:
> On Nov 12, 2005, at 2:21 PM, Vadim Chekan wrote:
> > On 11/12/05, Jeff Trawick <[EMAIL PROTECTED]> wrote:
> >> On 11/12/05, Vadim Chekan <[EMAIL PROTECTED]> wrote:
> >>> Hi all,
> >>>
> >>> I've tryed to compile httpd/trunk and got an error:
> >>> core_filters.obj : error LNK2019: unresolved external symbol
> >>> _apr_wait_for_io_or_timeout referenced in function
> >>> _send_brigade_blocking
> >>
> >> Try this??
> >>
> >> Index: server/core_filters.c
> >> ===
> [...]
> > Thanks, now it compiles!
>
> +1 on Unix, too.

now committed


Re: Console _commit() fails on Win

2005-11-13 Thread William A. Rowe, Jr.

Vadim Chekan wrote:

Hi all,

I'm having assertion failed at
server/mpm/winnt/nt_eventlog.c: mpm_nt_eventlog_stderr_open()
...
/* Flush stderr and unset its buffer, then commit and replace stderr.
 * This is typically a noop for Win2K/XP since services with NULL std
 * handles [but valid FILE *'s, oddly enough], but is required
 * for NT 4.0 and to use this code outside of services.
 */
fflush(stderr);
setvbuf(stderr, NULL, _IONBF, 0);
_commit(2 /* stderr */);


1. FlushFileBuffers which is called from _commit() returns ERROR_INVALID_HANDLE.

2. 
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/fileio/fs/flushfilebuffers.asp
states that:
"The function fails if hFile is a handle to the console output. That
is because the console output is not buffered. The function returns
FALSE, and GetLastError returns ERROR_INVALID_HANDLE.

Windows Me/98/95:  The function does nothing if hFile is a handle
to the console output. That is because console output is not buffered.
The function returns TRUE, but it does nothing."

3. fflush does _commit() if appropriate flags are set:
/* lowio commit to ensure data is written to disk */
if (str->_flag & _IOCOMMIT) {
return (_commit(_fileno(str)) ? EOF : 0);


I think we can remove safely _commit() call.

Note: I have Win XP Pro(sp2) & Visual Studio 2005.


Yes, that's possibly true in VS2005, but not in MSVC 5 or 6, so it stays.
Note that httpd.exe really isn't 'meant' to be a console app.  But we can do
more to mop up any error emits.  You presume _IOCOMMIT is set, but that isn't
neccessarily so.

Perhaps we should slowly start backing it out from VS2005 first, then VS2003
and earlier as someone can confirm it's not needed.

The only way to validate your proposed patch is to go forward from NT 4.0 (we
can safely assume a baseline of SP6), NT 5.0 and NT 5.1, using the MSVCRT as
well as the new clibs.

So please provide the exact, complete assert message you receive (hate it when
that trivial detail is not reported) and we can look at a way to safely ignore
it for now.

Bill