[PATCH] log path to config file during startup
Patch below logs the path to the config file just before ap_mpm_run() Can help clear up some mysteries when posthumously analyzing an ErrorLog Index: server/main.c === --- server/main.c (revision 464572) +++ server/main.c (working copy) @@ -742,6 +742,9 @@ destroy_and_exit_process(process, 1); } +ap_log_error(APLOG_MARK, APLOG_NOTICE, 0, NULL, + "Using config file %s", ap_server_root_relative(ptemp, confname)); + apr_pool_destroy(ptemp); apr_pool_lock(pconf, 1); -- Eric Covener [EMAIL PROTECTED] Index: server/main.c === --- server/main.c (revision 464572) +++ server/main.c (working copy) @@ -742,6 +742,9 @@ destroy_and_exit_process(process, 1); } +ap_log_error(APLOG_MARK, APLOG_NOTICE, 0, NULL, + "Using config file %s", ap_server_root_relative(ptemp, confname)); + apr_pool_destroy(ptemp); apr_pool_lock(pconf, 1);
Re: [PATCH] htcacheclean requires
Martin Kraemer wrote: At the moment, htcacheclean.c does not compile because it includes mod_disk_cache.h (which in turn needs apr_buckets.h included for the typedef of apr_bucket_refcount), but apr_buckets.h is not included anywhere. The attached patch fixes the problem, but: is it okay to include apr_buckets.h from htcacheclean.c, or should it better be included from mod_disk_cache.h ? Seems ok - mod_disk_cache.h doesn't seem to include any #includes anyway. Regards, Graham -- smime.p7s Description: S/MIME Cryptographic Signature
Re: svn commit: r464141 - in /httpd/httpd/trunk/srclib/pcre: dftables.c dftables.dsp
William A. Rowe, Jr. wrote: Mladen Turk wrote: William A. Rowe, Jr. wrote: why not s#/wd:4996#/D "_CRT_SECURE_NO_DEPRECATE"# /wd with colon like (/wd:4966) gives: Command line error D8021 : invalid numeric argument '/wd:4996'cl when converted to VS2005. BTW according to the MSDN the proper format is /wd not /wd: Yes - I understood that from your first commit message, thank you for this catch! Also the _CRT_SECURE_NO_DEPRECATE is not required. Since you proposed that define as the alternative to /wd4996, I was curious why you preferred to disable the warning over defining out the warning? That's all - either way thank you for the fix. It was a simple copy/paste from apr.hw, so that's why _CRT_SECURE_NO_DEPRECATE get into focus :) VS2005 compiles the converted dftables.vcproj without warnings. Regards, Mladen.
Re: svn commit: r464141 - in /httpd/httpd/trunk/srclib/pcre: dftables.c dftables.dsp
Mladen Turk wrote: > William A. Rowe, Jr. wrote: >> >> why not s#/wd:4996#/D "_CRT_SECURE_NO_DEPRECATE"# >> > > /wd with colon like (/wd:4966) gives: > Command line error D8021 : invalid numeric argument '/wd:4996'cl > when converted to VS2005. > BTW according to the MSDN the proper format is /wd not /wd: Yes - I understood that from your first commit message, thank you for this catch! > Also the _CRT_SECURE_NO_DEPRECATE is not required. Since you proposed that define as the alternative to /wd4996, I was curious why you preferred to disable the warning over defining out the warning? That's all - either way thank you for the fix.
[PATCH] htcacheclean requires
At the moment, htcacheclean.c does not compile because it includes mod_disk_cache.h (which in turn needs apr_buckets.h included for the typedef of apr_bucket_refcount), but apr_buckets.h is not included anywhere. The attached patch fixes the problem, but: is it okay to include apr_buckets.h from htcacheclean.c, or should it better be included from mod_disk_cache.h ? Martin -- <[EMAIL PROTECTED]> | Fujitsu Siemens Fon: +49-89-636-46021, FAX: +49-89-636-48332 | 81730 Munich, Germany Index: support/htcacheclean.c === --- support/htcacheclean.c (Revision 464498) +++ support/htcacheclean.c (Arbeitskopie) @@ -34,6 +34,7 @@ #include "apr_getopt.h" #include "apr_ring.h" #include "apr_date.h" +#include "apr_buckets.h" #include "../modules/cache/mod_disk_cache.h" #if APR_HAVE_UNISTD_H
