Re: [PATCH] Some windows build enhancements
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mladen Turk wrote: | Hi, | | libapreq is missing .rc file, so here is a standard ASF one. | Also, added APREQ_DECLARE_EXPORT/APREQ_DECLARE_STATIC | in the same way as APR declares so that dllexport/dllimport | get correctly handled. Hi Mladen, Thanks for your work on this. In the future, please submit patches piece wise. Committed to trunk: 651366, 651374, 651381, 651385, 651388 backported to v2_10 branch: 651399. - -- - Philip M. Gollucci ([EMAIL PROTECTED]) o:703.549.2050x206 Senior System Admin - Riderway, Inc. http://riderway.com / http://ridecharge.com 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.8 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIEO3fdbiP+9ubjBwRAnNVAJ0SQj0/AH0uKv2i2uqs7pjoWyE5zACdE2sl Q5zb1EHDh1GuAetL/YNkg2k= =0wpi -END PGP SIGNATURE-
Re: [PATCH] Some windows build enhancements
Philip M. Gollucci wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mladen Turk wrote: | Hi, | | libapreq is missing .rc file, so here is a standard ASF one. | Also, added APREQ_DECLARE_EXPORT/APREQ_DECLARE_STATIC | in the same way as APR declares so that dllexport/dllimport | get correctly handled. Hi Mladen, Thanks for your work on this. In the future, please submit patches piece wise. Committed to trunk: 651366, 651374, 651381, 651385, 651388 backported to v2_10 branch: 651399. ACK. There was one small typo and it seems I have the karma for commits, so I've fixed it directly. I suppose the fix has to go to the 2.10 branch as well. Regards -- (TM)
Re: [PATCH] Some windows build enhancements
Mladen Turk wrote: ACK. There was one small typo and it seems I have the karma for commits, so I've fixed it directly. I suppose the fix has to go to the 2.10 branch as well. I haven't seen the svn commit mail on apreq-cvs yet ? Yes, please fix it on branches/v2.10 as well. -- Philip M. Gollucci ([EMAIL PROTECTED]) c:703.336.9354 Consultant / http://p6m7g8.net/Resume/resume.txt http://riderway.com / http://ridecharge.com 1024D/EC88A0BF 0DE5 C55C 6BF3 B235 2DAB B89E 1324 9B4F EC88 A0BF Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching.
Re: [PATCH] mod_log_config : 2.2 extended port logging backport from trunk
On Wed, Apr 16, 2008 at 6:00 PM, Vincent Deffontaines
[EMAIL PROTECTED] wrote:
Greetings,
Trunk can log connection source port by using in Logformat : %{remote}p.
2.2 currently does not support that (only logs the destination port of the
connection).
Included is a very simple (trivial) backport of that functionnality from
trunk to 2.2.
Tested, works for me.
proposed for backport to 2.2.x
your patch was missing one of the comment changes; I proposed the
original patch, which applies to 2.2.x
Re: Any work on SNMP?
Hi, did you try http://mod-apache-snmp.sourceforge.net ?? it's for apache 2.x Regards, Esteban On Wed, Apr 23, 2008 at 3:23 PM, Jeff McAdams [EMAIL PROTECTED] wrote: Along about September of last year, I started a thread here about SNMP support in Apache, and trying to find what was coming down the pipe and even suggesting that the company that I might work for might be able to contribute a small sack of cash to someone to make it work well. At the time, I think I remember Covalent was talking about open sourcing some of their work along those lines? (apologies if I mis-remember) In any case, I figured my best bet at the time was to sit tight and see what developed. So, what has developed? :) I try to keep up with the pulse of Apache httpd development a bit, but I haven't seen anything happening as far as SNMP support goes. This is a huge whole in our ability to manage our system, so we'd really love to see someone implement a halfway decent SNMP capability in Apache (and work towards getting it supported in the mainstream). What can I do to try to help bring this capability about? I'm not a programmer myself, so I really can't bring much code to the table myself. Any insight? Thoughts? -- Jeff McAdams They that can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety. -- Benjamin Franklin --enig615A1613E703436181C69112 Content-Type: application/pgp-signature; name=signature.asc Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFID3f2XkUmzpmSrfwRAtXsAKDIzZREsLJqzHLuckyM7mVLGjGylwCeLih9 45RZyWF5lfkrXSkObuoZRO0= =fSpk -END PGP SIGNATURE- --enig615A1613E703436181C69112-- -- Jeff McAdams They that can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety. -- Benjamin Franklin -- -- Esteban Pizzini (http://mod-apache-snmp.sourceforge.net)
Re: Solaris sed based apache filtering module (mod_sed)
I fixed one sed labels related bug. Sed labels were not been handled properly.
Code has been updated and can be obtained by mercurial as :
$ hg clone ssh://[EMAIL PROTECTED]/hg/webstack/mod_sed
Regards,
Basant.
diff -r 6dedc621b00d libsed.h
--- a/libsed.h Thu Apr 17 15:15:01 2008 -0700
+++ b/libsed.h Thu Apr 24 17:23:06 2008 -0700
@@ -104,6 +104,7 @@ struct sed_commands_s {
sed_reptr_t *rep;
int nrep;
apr_pool_t *pool;
+int canbefinal;
};
typedef struct sed_eval_s sed_eval_t;
@@ -157,7 +158,8 @@ apr_status_t sed_init_commands(sed_comma
apr_pool_t *p);
apr_status_t sed_compile_string(sed_commands_t *commands, const char *s);
apr_status_t sed_compile_file(sed_commands_t *commands, apr_file_t *fin);
-apr_status_t sed_finalize_commands(sed_commands_t *commands);
+char* sed_get_finalize_error(const sed_commands_t *commands, apr_pool_t* pool);
+int sed_canbe_finalized(const sed_commands_t *commands);
void sed_destroy_commands(sed_commands_t *commands);
apr_status_t sed_init_eval(sed_eval_t *eval, sed_commands_t *commands,
diff -r 6dedc621b00d regexp.h
--- a/regexp.h Thu Apr 17 15:15:01 2008 -0700
+++ b/regexp.h Thu Apr 24 17:23:06 2008 -0700
@@ -102,6 +102,7 @@ extern void command_errf(sed_commands_t
#define SEDERR_TSNTSS transform strings not the same size: %s
#define SEDERR_OLTL output line too long.
#define SEDERR_HSOVERFLOW hold space overflowed.
+#define SEDERR_INTERNAL internal sed error
#ifdef __cplusplus
}
diff -r 6dedc621b00d sed0.c
--- a/sed0.cThu Apr 17 15:15:01 2008 -0700
+++ b/sed0.cThu Apr 24 17:23:06 2008 -0700
@@ -39,6 +39,7 @@ static char *comple(sed_commands_t *comm
static char *comple(sed_commands_t *commands, sed_comp_args *compargs,
char *x1, char *ep, char *x3, char x4);
static sed_reptr_t *alloc_reptr(sed_commands_t *commands);
+static int check_finalized(const sed_commands_t *commands);
void command_errf(sed_commands_t *commands, const char *fmt, ...)
{
@@ -80,6 +81,7 @@ apr_status_t sed_init_commands(sed_comma
commands-rep-ad1 = commands-respace;
commands-reend = commands-respace[RESIZE - 1];
commands-labend = commands-labtab[SED_LABSIZE];
+commands-canbefinal = 1;
return APR_SUCCESS;
}
@@ -102,6 +104,8 @@ apr_status_t sed_compile_string(sed_comm
commands-eflag = 1;
rv = fcomp(commands, NULL);
+if (rv == APR_SUCCESS)
+commands-canbefinal = check_finalized(commands);
commands-eflag = 0;
@@ -118,40 +122,75 @@ apr_status_t sed_compile_file(sed_comman
}
/*
- * sed_finalize_commands
- */
-apr_status_t sed_finalize_commands(sed_commands_t *commands)
-{
-sed_label_t *lab;
-
+ * sed_get_finalize_error
+ */
+char* sed_get_finalize_error(const sed_commands_t *commands, apr_pool_t* pool)
+{
+const sed_label_t *lab;
if (commands-depth) {
-command_errf(commands, SEDERR_TMOMES);
-return APR_EGENERAL;
-}
-
-for (lab = commands-labtab; lab commands-lab; lab++) {
+return SEDERR_TMOMES;
+}
+
+/* Empty branch chain is not a issue */
+for (lab = commands-labtab + 1; lab commands-lab; lab++) {
+char *error;
if (lab-address == 0) {
-command_errf(commands, SEDERR_ULMES, lab-asc);
-return APR_EGENERAL;
+error = apr_psprintf(pool, SEDERR_ULMES, lab-asc);
+return error;
}
if (lab-chain) {
-sed_reptr_t *rep;
-
-rep = lab-chain;
-while (rep-lb1) {
-sed_reptr_t *next;
-
-next = rep-lb1;
-rep-lb1 = lab-address;
-rep = next;
-}
-
-rep-lb1 = lab-address;
-}
-}
-
-return APR_SUCCESS;
+return SEDERR_INTERNAL;
+}
+}
+return NULL;
+}
+
+/*
+ * sed_canbe_finalized
+ */
+int sed_canbe_finalized(const sed_commands_t *commands)
+{
+return commands-canbefinal;
+}
+
+/*
+ * check_finalized
+ */
+static int check_finalized(const sed_commands_t *commands)
+{
+const sed_label_t *lab;
+if (commands-depth) {
+return 0;
+}
+
+/* Empty branch chain is not a issue */
+for (lab = commands-labtab + 1; lab commands-lab; lab++) {
+if (lab-address == 0 || (lab-chain)) {
+return 0;
+}
+}
+return 1;
+}
+
+/*
+ * dechain
+ */
+static void dechain(sed_label_t *lpt, sed_reptr_t *address)
+{
+sed_reptr_t *rep;
+if ((lpt == NULL) || (lpt-chain == NULL) || (address == NULL))
+return;
+rep = lpt-chain;
+while (rep-lb1) {
+sed_reptr_t *next;
+
+next = rep-lb1;
+rep-lb1 = address;
+rep = next;
+}
+rep-lb1 = address;
+lpt-chain = NULL;
}
/*
@@ -309,6 +348,7 @@ swit:
command_errf(commands, SEDERR_DLMES, commands-linebuf);
return -1;
}
+dechain(lpt,
