dynamic module versioning
Hi, How I can accomplish the dynami9c module versioning? For example I want to deliver mod_x.so.1.0.1. Where do I need to specify the version 10.0.1? Thanks, Alin
Re: [Survey] Maintained builds - was Re: httpd trunk, apr/apu 1.4 branches and Linux
On 25.04.2010 18:07, William A. Rowe Jr. wrote: On 4/23/2010 8:03 AM, William A. Rowe Jr. wrote: On 4/23/2010 7:58 AM, Jim Jagielski wrote: For those who are working on httpd trunk and Linux, what are you using? You raise interesting questions about what the httpd folks actually test on a day to day basis, given the dozen combinations of build approaches. Maintainers, which of the below do you *frequently* use during development against trunk (as opposed to occasional/infrequent testing)? [X] ./configure and build entirely in-tree (httpd/srclib/* etc) [ ] ../httpd/configure into a single seperate vpath tree [X] configure for separately built or OS-provisioned expat [X] configure for separately built or OS-provisioned pcre [ ] configure for separately built or OS-provisioned apr[-util] Please check off all-of-the-above that apply, thanks! Regards Rüdiger
Re: svn commit: r937858 - in /httpd/httpd/trunk: CHANGES modules/http/http_filters.c
I am confused. Why is this a good idea? Why is it unexpected to
encounter a 413 response after a timeout due to a read of chunked
body, and how does changing it to a 400 somehow prevent a double
errordoc? Why not just fix the double errordoc bug instead of
the case that triggers it?
Roy
On Apr 25, 2010, at 12:10 PM, cove...@apache.org wrote:
Author: covener
Date: Sun Apr 25 19:10:45 2010
New Revision: 937858
URL: http://svn.apache.org/viewvc?rev=937858view=rev
Log:
PR49167, unexpected 413 and double-errordoc during a timeout reading a
chunk-size.
Modified:
httpd/httpd/trunk/CHANGES
httpd/httpd/trunk/modules/http/http_filters.c
Modified: httpd/httpd/trunk/CHANGES
URL:
http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=937858r1=937857r2=937858view=diff
==
--- httpd/httpd/trunk/CHANGES [utf-8] (original)
+++ httpd/httpd/trunk/CHANGES [utf-8] Sun Apr 25 19:10:45 2010
@@ -28,6 +28,11 @@ Changes with Apache 2.3.7
processing is completed, avoiding orphaned callback pointers.
[Brett Gervasoni brettg senseofsecurity.com, Jeff Trawick]
+ *) Log an error for failures to read a chunk-size, and return 400 instead
+ 413 when this is due to a read timeout. This change also fixes some
cases
+ of two error documents being sent in the response for the same
scenario.
+ [Eric Covener] PR49167
+
*) mod_proxy_balancer: Add new directive BalancerNonce to allow admin
to control/set the nonce used in the balancer-manager application.
[Jim Jagielski]
Modified: httpd/httpd/trunk/modules/http/http_filters.c
URL:
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_filters.c?rev=937858r1=937857r2=937858view=diff
==
--- httpd/httpd/trunk/modules/http/http_filters.c (original)
+++ httpd/httpd/trunk/modules/http/http_filters.c Sun Apr 25 19:10:45 2010
@@ -383,8 +383,13 @@ apr_status_t ap_http_filter(ap_filter_t
/* Detect chunksize error (such as overflow) */
if (rv != APR_SUCCESS || ctx-remaining 0) {
+ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, f-r, Error
reading first chunk %s ,
+ (ctx-remaining 0) ? (overflow) : );
ctx-remaining = 0; /* Reset it in case we have to
* come back here later */
+if (APR_STATUS_IS_TIMEUP(rv)) {
+http_error = HTTP_BAD_REQUEST;
+}
return bail_out_on_error(ctx, f, http_error);
}
@@ -484,10 +489,14 @@ apr_status_t ap_http_filter(ap_filter_t
/* Detect chunksize error (such as overflow) */
if (rv != APR_SUCCESS || ctx-remaining 0) {
+ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, f-r, Error
reading chunk %s ,
+ (ctx-remaining 0) ? (overflow) : );
ctx-remaining = 0; /* Reset it in case we have to
* come back here later */
-bail_out_on_error(ctx, f, http_error);
-return rv;
+if (APR_STATUS_IS_TIMEUP(rv)) {
+http_error = HTTP_BAD_REQUEST;
+}
+return bail_out_on_error(ctx, f, http_error);
}
if (!ctx-remaining) {
Re: svn commit: r937858 - in /httpd/httpd/trunk: CHANGES modules/http/http_filters.c
On 26.04.2010 08:04, Roy T. Fielding wrote:
I am confused. Why is this a good idea? Why is it unexpected to
encounter a 413 response after a timeout due to a read of chunked
body, and how does changing it to a 400 somehow prevent a double
errordoc? Why not just fix the double errordoc bug instead of
the case that triggers it?
Changing to 400 does not fix the double error message problem.
In fact this patch addresses two things in one and it might
have been worth doing two commits for it. I am partly to blame
for this as I encouraged Eric in a Bugzilla entry to commit this
patch.
The part that fixes the double error messages is:
-bail_out_on_error(ctx, f, http_error);
-return rv;
+return bail_out_on_error(ctx, f, http_error);
Regards
Rüdiger
Roy
On Apr 25, 2010, at 12:10 PM, cove...@apache.org wrote:
Author: covener
Date: Sun Apr 25 19:10:45 2010
New Revision: 937858
URL: http://svn.apache.org/viewvc?rev=937858view=rev
Log:
PR49167, unexpected 413 and double-errordoc during a timeout reading a
chunk-size.
Modified:
httpd/httpd/trunk/CHANGES
httpd/httpd/trunk/modules/http/http_filters.c
Modified: httpd/httpd/trunk/CHANGES
URL:
http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=937858r1=937857r2=937858view=diff
==
--- httpd/httpd/trunk/CHANGES [utf-8] (original)
+++ httpd/httpd/trunk/CHANGES [utf-8] Sun Apr 25 19:10:45 2010
@@ -28,6 +28,11 @@ Changes with Apache 2.3.7
processing is completed, avoiding orphaned callback pointers.
[Brett Gervasoni brettg senseofsecurity.com, Jeff Trawick]
+ *) Log an error for failures to read a chunk-size, and return 400 instead
+ 413 when this is due to a read timeout. This change also fixes some
cases
+ of two error documents being sent in the response for the same
scenario.
+ [Eric Covener] PR49167
+
*) mod_proxy_balancer: Add new directive BalancerNonce to allow admin
to control/set the nonce used in the balancer-manager application.
[Jim Jagielski]
Modified: httpd/httpd/trunk/modules/http/http_filters.c
URL:
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_filters.c?rev=937858r1=937857r2=937858view=diff
==
--- httpd/httpd/trunk/modules/http/http_filters.c (original)
+++ httpd/httpd/trunk/modules/http/http_filters.c Sun Apr 25 19:10:45 2010
@@ -383,8 +383,13 @@ apr_status_t ap_http_filter(ap_filter_t
/* Detect chunksize error (such as overflow) */
if (rv != APR_SUCCESS || ctx-remaining 0) {
+ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, f-r, Error
reading first chunk %s ,
+ (ctx-remaining 0) ? (overflow) : );
ctx-remaining = 0; /* Reset it in case we have to
* come back here later */
+if (APR_STATUS_IS_TIMEUP(rv)) {
+http_error = HTTP_BAD_REQUEST;
+}
return bail_out_on_error(ctx, f, http_error);
}
@@ -484,10 +489,14 @@ apr_status_t ap_http_filter(ap_filter_t
/* Detect chunksize error (such as overflow) */
if (rv != APR_SUCCESS || ctx-remaining 0) {
+ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, f-r, Error
reading chunk %s ,
+ (ctx-remaining 0) ? (overflow) : );
ctx-remaining = 0; /* Reset it in case we have to
* come back here later */
-bail_out_on_error(ctx, f, http_error);
-return rv;
+if (APR_STATUS_IS_TIMEUP(rv)) {
+http_error = HTTP_BAD_REQUEST;
+}
+return bail_out_on_error(ctx, f, http_error);
}
if (!ctx-remaining) {
Re: [Survey] Maintained builds - was Re: httpd trunk, apr/apu 1.4 branches and Linux
On 25.04.2010 18:07, William A. Rowe Jr. wrote: On 4/23/2010 8:03 AM, William A. Rowe Jr. wrote: On 4/23/2010 7:58 AM, Jim Jagielski wrote: For those who are working on httpd trunk and Linux, what are you using? You raise interesting questions about what the httpd folks actually test on a day to day basis, given the dozen combinations of build approaches. Maintainers, which of the below do you *frequently* use during development against trunk (as opposed to occasional/infrequent testing)? [X] ./configure and build entirely in-tree (httpd/srclib/* etc) [ ] ../httpd/configure into a single seperate vpath tree [ ] configure for separately built or OS-provisioned expat [X] configure for separately built or OS-provisioned pcre [ ] configure for separately built or OS-provisioned apr[-util] Please check off all-of-the-above that apply, thanks! Regards, Rainer
Re: svn commit: r937858 - in /httpd/httpd/trunk: CHANGES modules/http/http_filters.c
On Mon, Apr 26, 2010 at 2:04 AM, Roy T. Fielding field...@gbiv.com wrote: I am confused. Why is this a good idea? Why is it unexpected to encounter a 413 response after a timeout due to a read of chunked body, The body is not too large, and the server is not rejecting the body due to size. Isn't 413 a very misleading status? and how does changing it to a 400 somehow prevent a double errordoc? Why not just fix the double errordoc bug instead of the case that triggers it? This was the secondary part to me, but I'll open a bug with an example (IIUC, filter that adds an error bucket but then also returns a (non-http) error). -- Eric Covener cove...@gmail.com
Re: mod_fcgid: process PID graceful kill fail, sending SIGKILL
Can the SIGTERM be logged? Just to see how long it takes? On Fri, Apr 23, 2010 at 3:39 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Apr 23, 2010 at 3:33 PM, Jeff Trawick traw...@gmail.com wrote: Keeping zombies cleaned up requires a small scan interval, but that can keep some scripts from having adequate time to terminate before getting KILL-ed. whoops, ignore that; I'm getting scans confused :) (FcgidZombieScanInterval controls zombie cleanup)
Re: [Survey] Maintained builds - was Re: httpd trunk, apr/apu 1.4 branches and Linux
On Sun, Apr 25, 2010 at 12:07 PM, William A. Rowe Jr. wr...@rowe-clan.net wrote: On 4/23/2010 8:03 AM, William A. Rowe Jr. wrote: On 4/23/2010 7:58 AM, Jim Jagielski wrote: For those who are working on httpd trunk and Linux, what are you using? You raise interesting questions about what the httpd folks actually test on a day to day basis, given the dozen combinations of build approaches. Maintainers, which of the below do you *frequently* use during development against trunk (as opposed to occasional/infrequent testing)? [ ] ./configure and build entirely in-tree (httpd/srclib/* etc) [ ] ../httpd/configure into a single seperate vpath tree [ ] configure for separately built or OS-provisioned expat [X] configure for separately built or OS-provisioned pcre [X] configure for separately built or OS-provisioned apr[-util]
Re: [Survey] Maintained builds - was Re: httpd trunk, apr/apu 1.4 branches and Linux
On Apr 25, 2010, at 12:07 PM, William A. Rowe Jr. wrote: On 4/23/2010 8:03 AM, William A. Rowe Jr. wrote: On 4/23/2010 7:58 AM, Jim Jagielski wrote: For those who are working on httpd trunk and Linux, what are you using? You raise interesting questions about what the httpd folks actually test on a day to day basis, given the dozen combinations of build approaches. Maintainers, which of the below do you *frequently* use during development against trunk (as opposed to occasional/infrequent testing)? [X] ./configure and build entirely in-tree (httpd/srclib/* etc) [ ] ../httpd/configure into a single seperate vpath tree [X] configure for separately built or OS-provisioned expat [X] configure for separately built or OS-provisioned pcre [ ] configure for separately built or OS-provisioned apr[-util] The latter seems impossible for OS-provisioned apr, does it not?
Re: dynamic module versioning
On Apr 26, 2010, at 7:33 AM, alin vasile wrote: Hi, How I can accomplish the dynami9c module versioning? For example I want to deliver mod_x.so.1.0.1. Where do I need to specify the version 10.0.1? Thanks, Alin So, create a tar ball entitled mod_x-10.0.1.tgz or something similar. Apache isn't going to care one way or another. The only cares for versioning are what you've compiled the module against, and any visual cues (e.g. the filename, or just defining a version string and using that. e.g. : #define MOD_X_VERSION 10.0.1 Then, wherever you want to attach the version string, just add the MOD_X_VERSION. Remember, apache doesn't care. If you want a resulting mod_x.so.10.0.1, just rename the .so file. apxs is just going to build the .so. Doing this will be the rare case, though. Do at your own risk. Joe
Re: mod_fcgid: process PID graceful kill fail, sending SIGKILL
On Mon, Apr 26, 2010 at 11:02 AM, Weedy weedy2...@gmail.com wrote:
Can the SIGTERM be logged? Just to see how long it takes?
The patches attached add extra logging to the error scan.
1. report_graceful_terminations.txt
It logs the number of processes receiving SIGTERM every time the error
scan runs, as long as there is at least one process. This could
probably be committed permanently.
It requires LogLevel debug.
2. noisily_report_graceful_terminations.txt
This logs the pid of every process that is sent SIGTERM. It is too
noisy to be committed permanently.
It requires LogLevel debug.
Index: modules/fcgid/fcgid_pm_main.c
===
--- modules/fcgid/fcgid_pm_main.c (revision 938085)
+++ modules/fcgid/fcgid_pm_main.c (working copy)
@@ -282,6 +282,7 @@
fcgid_server_conf *sconf =
ap_get_module_config(main_server-module_config,
fcgid_module);
+int graceful_terminations = 0;
/* Should I check the busy list? */
if (procmgr_must_exit()
@@ -326,6 +327,7 @@
current_node-proc_pool);
if (!dummy) {
proc_kill_gracefully(current_node, main_server);
+++graceful_terminations;
apr_pool_userdata_set(set, HAS_GRACEFUL_KILL,
apr_pool_cleanup_null,
current_node-proc_pool);
@@ -350,6 +352,12 @@
}
previous_node-next_index = temp_error_header.next_index;
proctable_pm_unlock(main_server);
+
+if (graceful_terminations) {
+ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, main_server,
+ mod_fcgid: gracefully terminated %d processes,
+ graceful_terminations);
+}
}
static void kill_all_subprocess(server_rec * main_server)
Index: modules/fcgid/fcgid_pm_main.c
===
--- modules/fcgid/fcgid_pm_main.c (revision 938091)
+++ modules/fcgid/fcgid_pm_main.c (working copy)
@@ -326,6 +326,9 @@
current_node-proc_pool);
if (!dummy) {
proc_kill_gracefully(current_node, main_server);
+ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, main_server,
+ mod_fcgid: gracefully killing process %
APR_PID_T_FMT,
+ current_node-proc_id.pid);
apr_pool_userdata_set(set, HAS_GRACEFUL_KILL,
apr_pool_cleanup_null,
current_node-proc_pool);
Re: [Survey] Maintained builds - was Re: httpd trunk, apr/apu 1.4 branches and Linux
On 4/26/2010 10:27 AM, Jim Jagielski wrote: On Apr 25, 2010, at 12:07 PM, William A. Rowe Jr. wrote: On 4/23/2010 8:03 AM, William A. Rowe Jr. wrote: On 4/23/2010 7:58 AM, Jim Jagielski wrote: For those who are working on httpd trunk and Linux, what are you using? You raise interesting questions about what the httpd folks actually test on a day to day basis, given the dozen combinations of build approaches. Maintainers, which of the below do you *frequently* use during development against trunk (as opposed to occasional/infrequent testing)? [X] ./configure and build entirely in-tree (httpd/srclib/* etc) [ ] ../httpd/configure into a single seperate vpath tree [X] configure for separately built or OS-provisioned expat [X] configure for separately built or OS-provisioned pcre [ ] configure for separately built or OS-provisioned apr[-util] The latter seems impossible for OS-provisioned apr, does it not? You mean, that apr 1.4 (not apr-util 1.4) is a prerequisite? Its true that few vendors are likely to be shipping apr 1.4.2 yet.
Re: [Survey] Maintained builds - was Re: httpd trunk, apr/apu 1.4 branches and Linux
On Sunday 25 April 2010, William A. Rowe Jr. wrote: [X] ./configure and build entirely in-tree (httpd/srclib/* etc) [ ] ../httpd/configure into a single seperate vpath tree [X] configure for separately built or OS-provisioned expat [X] configure for separately built or OS-provisioned pcre [ ] configure for separately built or OS-provisioned apr[-util] Cheers, Stefan
Re: [Survey] Maintained builds - was Re: httpd trunk, apr/apu 1.4 branches and Linux
On 2010-04-25 at 12:07, William A. Rowe Jr. wr...@rowe-clan.net wrote: You raise interesting questions about what the httpd folks actually test on a day to day basis, given the dozen combinations of build approaches. Maintainers, which of the below do you *frequently* use during development against trunk (as opposed to occasional/infrequent testing)? [ ] ./configure and build entirely in-tree (httpd/srclib/* etc) [ ] ../httpd/configure into a single seperate vpath tree [x] configure for separately built or OS-provisioned expat [x] configure for separately built or OS-provisioned pcre [x] configure for separately built or OS-provisioned apr[-util] Please check off all-of-the-above that apply, thanks!
Re: svn commit: r937858 - in /httpd/httpd/trunk: CHANGES modules/http/http_filters.c
On Apr 26, 2010, at 2:55 AM, Eric Covener wrote: On Mon, Apr 26, 2010 at 2:04 AM, Roy T. Fielding field...@gbiv.com wrote: I am confused. Why is this a good idea? Why is it unexpected to encounter a 413 response after a timeout due to a read of chunked body, The body is not too large, and the server is not rejecting the body due to size. Isn't 413 a very misleading status? Er, yeah, 413 is wrong -- I should have looked it up. It should be a 408 (Request Timeout). and how does changing it to a 400 somehow prevent a double errordoc? Why not just fix the double errordoc bug instead of the case that triggers it? This was the secondary part to me, but I'll open a bug with an example (IIUC, filter that adds an error bucket but then also returns a (non-http) error). Well, if it is fixed as Ruediger explained, then I am fine with it. I just couldn't see the fix in that patch. Roy
Re: Oxygen icons for Apache
On Saturday 24 April 2010 16:07:54 Guenter Knauf wrote: Hi Javier. Javier Llorente schrieb: I have just talked with Pinheiro and he told me that the Oxygen icons are no longer dual-licensed. They're under the LGPL only, so they cannot be part of Apache. However, distributions can still make them the default icons. That's good enough :) maybe you can also add an alternate icon for the [back] link? I would prefer something like this: http://people.apache.org/~fuankg/.dirup.gif instead of the usual: http://people.apache.org/icons/back.gif or yours (which is already nicer, agreed): http://www.javierllorente.com/icons/up.png not as replacement, just as alternate back icon You want me to create a back icon of that style? There's a similar icon, however it's used for the symlinks (folder+arrow). what I miss with your icons is one for .zip; and some for .md5, .sha?, and .asc would also be nice ... I have icons for zip and asc already. Not for md5 and sha. I can try creating those. then it would also be helpful if you could provide an icon sheet with all icons, just as what we ship with httpd: http://people.apache.org/icons/icon.sheet.png OK, I will do so. oh, and do you also offer an archive with all icons packed together? It's available on the Build Service: https://build.opensuse.org/package/show?package=apache2-icons- oxygenproject=Apache (requires BS account) I have also uploaded it to http://www.javierllorente.com/tmp/ Greetings, -- Javier Llorente signature.asc Description: This is a digitally signed message part.
Re: svn commit: r937858 - in /httpd/httpd/trunk: CHANGES modules/http/http_filters.c
On Mon, Apr 26, 2010 at 6:15 PM, Roy T. Fielding field...@gbiv.com wrote: On Apr 26, 2010, at 2:55 AM, Eric Covener wrote: On Mon, Apr 26, 2010 at 2:04 AM, Roy T. Fielding field...@gbiv.com wrote: I am confused. Why is this a good idea? Why is it unexpected to encounter a 413 response after a timeout due to a read of chunked body, The body is not too large, and the server is not rejecting the body due to size. Isn't 413 a very misleading status? Er, yeah, 413 is wrong -- I should have looked it up. It should be a 408 (Request Timeout). 400-408 in r938265. -- Eric Covener cove...@gmail.com
