Re: [RELEASE CANDIDATE] libapreq2 2.13 RC

2010-12-02 Thread Jim Jagielski
Confirmed here as well... Good on OSX.

On Dec 2, 2010, at 12:19 PM, Sander Temme wrote:

 
 On Nov 25, 2010, at 11:34 AM, Issac Goldstand wrote:
 
 After a year and a half, the apreq team would like to release version
 2.13 of libapreq.
 
 Good PGP signature; good md5.  
 
 Built and tested on an x64 Meerkat box, against bundled Apache2.  
 
 Build against httpd and apr trunk fails: configure looks for apr-util which 
 does not exist.  I don't see this as a blocker. 
 
 +1
 
 S.
 
 -- 
 Sander Temme
 scte...@apache.org
 PGP FP: FC5A 6FC6 2E25 2DFD 8007  EE23 9BB8 63B0 F51B B88A
 
 View my availability: http://tungle.me/sctemme
 
 
 



Re: svn commit: r1040177 - /httpd/httpd/trunk/modules/http/http_protocol.c

2010-12-02 Thread Joe Orton
On Mon, Nov 29, 2010 at 04:37:49PM -, fua...@apache.org wrote:
 URL: http://svn.apache.org/viewvc?rev=1040177view=rev
 Log:
 Supress compiler warning.
...
 ==
 --- httpd/httpd/trunk/modules/http/http_protocol.c (original)
 +++ httpd/httpd/trunk/modules/http/http_protocol.c Mon Nov 29 16:37:49 2010
 @@ -204,7 +204,12 @@ AP_DECLARE(int) ap_set_keepalive(request
   *   THEN we can be persistent, which requires more headers be output.
   *
   * Note that the condition evaluation order is extremely important.
 + *
 + * Silent compiler warnings for (r-chunked = 1) with #pragma 
   */
 +#ifdef __WATCOMC__
 +#pragma disable_message(105)
 +#endif

Eww.  Do you really need to litter the source code with this stuff?  Can 
you not flip compiler switches in the Makefiles?  Regards, Joe


Re: disk cache file rename errors on Windows

2010-12-02 Thread Dan Poirier
Is anyone successfully using mod_disk_cache on Windows?

Thanks,
Dan


Re: [RELEASE CANDIDATE] libapreq2 2.13 RC

2010-12-02 Thread Sander Temme

On Nov 25, 2010, at 11:34 AM, Issac Goldstand wrote:

 After a year and a half, the apreq team would like to release version
 2.13 of libapreq.

Good PGP signature; good md5.  

Built and tested on an x64 Meerkat box, against bundled Apache2.  

Build against httpd and apr trunk fails: configure looks for apr-util which 
does not exist.  I don't see this as a blocker. 

+1

S.

-- 
Sander Temme
scte...@apache.org
PGP FP: FC5A 6FC6 2E25 2DFD 8007  EE23 9BB8 63B0 F51B B88A

View my availability: http://tungle.me/sctemme





Re: disk cache file rename errors on Windows

2010-12-02 Thread Graham Leggett

On 23 Nov 2010, at 8:21 PM, Dan Poirier wrote:


We're seeing errors like this from mod_disk_cache on Windows only:

(OS 5)Access is denied.  : disk_cache: rename tempfile to datafile
failed: c:/temp/HTTPServer7/aptmpV0JKJ8 -
c:/temp/HTTPServer7/wHY/FhW/b...@muvttlk@V4w.data

under moderate to heavy load, resulting in requests failing.


Looking at the code, the error message is thrown when  
apr_file_rename() fails, specifically when a temporary file is swung  
into place in the cache.


Looking at the APR code, there is a forest of ifdefs that seem to  
choose one of MoveFileEx(), MoveFileW(), MoveFileExW() or MoveFile().  
Ideally, the Microsoft API documentation should explain under what  
conditions the error Access is denied is thrown.


Does Windows allow you to move a file into place while the replaced  
file is still open for read?


Regards,
Graham
--



Re: [RELEASE CANDIDATE] libapreq2 2.13 RC

2010-12-02 Thread Jim Jagielski
Confirmed here as well... Good on OSX.

On Dec 2, 2010, at 12:19 PM, Sander Temme wrote:

 
 On Nov 25, 2010, at 11:34 AM, Issac Goldstand wrote:
 
 After a year and a half, the apreq team would like to release version
 2.13 of libapreq.
 
 Good PGP signature; good md5.  
 
 Built and tested on an x64 Meerkat box, against bundled Apache2.  
 
 Build against httpd and apr trunk fails: configure looks for apr-util which 
 does not exist.  I don't see this as a blocker. 
 
 +1
 
 S.
 
 -- 
 Sander Temme
 scte...@apache.org
 PGP FP: FC5A 6FC6 2E25 2DFD 8007  EE23 9BB8 63B0 F51B B88A
 
 View my availability: http://tungle.me/sctemme
 
 
 



Re: disk cache file rename errors on Windows

2010-12-02 Thread Dan Poirier
On Thu, Dec 2, 2010 at 12:23 PM, Graham Leggett minf...@sharp.fm wrote:
 On 23 Nov 2010, at 8:21 PM, Dan Poirier wrote:

 We're seeing errors like this from mod_disk_cache on Windows only:

 (OS 5)Access is denied.  : disk_cache: rename tempfile to datafile
 failed: c:/temp/HTTPServer7/aptmpV0JKJ8 -
 c:/temp/HTTPServer7/wHY/FhW/b...@muvttlk@V4w.data

 under moderate to heavy load, resulting in requests failing.

 Looking at the code, the error message is thrown when apr_file_rename()
 fails, specifically when a temporary file is swung into place in the cache.

 Looking at the APR code, there is a forest of ifdefs that seem to choose one
 of MoveFileEx(), MoveFileW(), MoveFileExW() or MoveFile(). Ideally, the
 Microsoft API documentation should explain under what conditions the error
 Access is denied is thrown.

 Does Windows allow you to move a file into place while the replaced file is
 still open for read?

Disclaimer: My last real Windows programming was on WfW 3.11, so
please, someone with up-to-date Windows programming experience correct
me as needed.

From the doc for MoveFileEx
(http://msdn.microsoft.com/en-us/library/aa365240%28VS.85%29.aspx),
you can pass a flag telling Windows to do the move on the next reboot
(also see http://support.microsoft.com/kb/140570) , apparently to work
around an inability to rename another file over a file in use.  So I
think the answer to your question is no.

The doc for error 0x05 at
http://msdn.microsoft.com/en-us/library/ms681382%28v=VS.85%29.aspx
consists, in its entirety, of Access is denied..  Maybe there's more
explanation elsewhere.

-- 
Dan Poirier
poir...@pobox.com


Re: disk cache file rename errors on Windows

2010-12-02 Thread William A. Rowe Jr.
On 12/2/2010 11:23 AM, Graham Leggett wrote:
 
 Does Windows allow you to move a file into place while the replaced file is 
 still open for
 read?

This is illustrative of Win32 limitations;

The DeleteFile function fails if an application attempts to delete a file that 
is open
for normal I/O or as a memory-mapped file.

The DeleteFile function marks a file for deletion on close. Therefore, the file 
deletion
does not occur until the last handle to the file is closed. Subsequent calls to 
CreateFile
to open the file fail with ERROR_ACCESS_DENIED.

Which is to say, unlink/rename or rename-over-existing would have the same net 
behavior,
and the same failure case.


Re: disk cache file rename errors on Windows

2010-12-02 Thread Gregg L. Smith
I'd say I am. Even though it is not a high traffic server, the last time I got 
one of those errors was October 8th. looking further back, it is always 
following one specific custom error doc that oops, didn't exist till now cause 
I forgot to generate a new on when I changed the look of the site.

IfModule cache_module

  CacheIgnoreHeaders Set-Cookie

  IfModule disk_cache_module
 CacheEnable disk /
 CacheDirLevels 5
 CacheDirLength 4
 CacheRoot /path/to/cache
  /IfModule
/IfModule


Original Message ---
Is anyone successfully using mod_disk_cache on Windows?